- 27 Apr, 2020 40 commits
-
-
Filip Gorski authored
Patch 1 for OmniboxSuggestionsList RecyclerView update. * Creates OmniboxSuggestionsDropdown interface (will be shared with a RecyclerView implementation) * Moves SuggestionListObserver from SLProperties to OmniboxSuggestionsDropdown (as a nested interface) * Moves OmniboxSuggestionListEmbedder to OmniboxSuggetsionsDropdown as an internal interface -- handles naming inconsistencies * Updates test utils that access suggestions dropdown. Change-Id: Ib44f41fbb43d57a4c43c09835d127836f5e782d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163152 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#762833}
-
Mohammed Abdon authored
Introduces ChromeOS.SAML.Provider metrics which will record SAML Provider every time SAML online flow is used. Bug: 1065080 Change-Id: I3646df19bc42a6c1d7c661bd69c6d249f66aaa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111174 Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762832}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a67630cdfebc..821726de7bad git log a67630cdfebc..821726de7bad --date=short --first-parent --format='%ad %ae %s' 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 4fb0e0374a39..3336e65e8801 (1 commits) 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 7d65f09b8311..bcf6a2430e99 (3 commits) 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bb0380e3932a..1512acdf047f (2 commits) Created with: gclient setdep -r src/third_party/angle@821726de7bad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5e05d6d8d8cb0e1408aadc9180369d314cb77ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762831}
-
Xida Chen authored
This CL doesn't change behavior, it deletes some dead code. Bug: None Change-Id: Ic917e76b8dc5545cc7bfc7b39887c4ea859009bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167107 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762830}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I9ca0ff68f4f9633b7a98043cba0d9def392ec4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166415Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762829}
-
Alexander Hendrich authored
This reverts commit 7c281002. Reason for revert: blink_web_tests failure on webkit linux asan bot (see crbug.com/1075517) Original change's description: > [LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item. > > As part of the descendants walk that we perform when adding a box > fragment that establishes an inline formatting context, update the > first/last-for-node bits directly. > > Many thanks to kojii@ for suggesting and helping out with this solution! > > Once we add the last box fragment for a node, finalize the inline items. > In addition to associating with the LayoutObjects, also set the > first/last-for-node bits, if fragment traversal is enabled. > > Since we now require the layout results to be available for anything > that establishes an inline formatting context (to set the first/last > bits), we also need to store the layout results for the column > fragments. Columns are not really associated with a LayoutObject, but > we'll use the legacy LayoutFlowThread for this. Another option would be > to create an anonymous block child of a multicol container that > establishes an inline formatting context, but I decided against that for > now. > > Expanded some NGFragmentItemTest unit tests, and added a new one, to > make sure that we behave in RTL situations. > > This allows for supporting these bits in culled inlines as well. > Enabled fragment traversal in NGFragmentItemTest, so that we can test > it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The > culled inlines test there also expects FragmentsVisualRectBoundingBox() > to return something sensible, so remove the skipping we had in PrePaint > for culled inlines, to just make this work. > > Will follow-up with cleaning up the first/last for node stuff added as > part of CL:2111158. This will no longer be needed, but doing it in a > separate CL is probably cleaner. > > Bug: 1043787 > Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762758} TBR=kojii@chromium.org,mstensho@chromium.org Bug: 1043787, 1075517 Change-Id: I18342be3d4a42d2170f46df73cec7f9250be840e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165736Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#762828}
-
Miyoung Shin authored
This CL converts ViewHostMsg_ResolveProxy to RendererHost mojom interface and drops |Msg| from the name of ResolveProxyMsgHelper. Bug: 1071625 Change-Id: I8fa8c6c8a502e0bace9bba7dd36ed687c1a86047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164137 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#762827}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74fc574cbc14..62a0d647d9e8 git log 74fc574cbc14..62a0d647d9e8 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 mbonadei@webrtc.org Remove deprecated constant. Created with: gclient setdep -r src/third_party/webrtc@62a0d647d9e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I77e0b1b96d00bb49ec672c30d1335057df468e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167932Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I67e80ea4485f22b8a0fd8f974b9fa1a1c6edec41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167931Reviewed-by:
-
Vadym Doroshenko authored
This CL is a part of moving PasswordForm class to components/password_manager/core/browser. Bug: 1067347 Change-Id: Iebc89045547a3ea9293e794e7ee8ae43f36b6684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164611 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#762824}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I960875650dacb7ec78f04666bbbf22147e649461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164811 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762823}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51980699f7e4..992295e37d43 git log 51980699f7e4..992295e37d43 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 jacktfranklin@chromium.org Move `UIString` into `Platform` 2020-04-27 mathias@chromium.org Revert "Roll deps" 2020-04-27 mathias@chromium.org Roll deps 2020-04-27 tvanderlippe@chromium.org Add extensions for implicit imports in named export declarations 2020-04-27 tvanderlippe@chromium.org Run Karma unittests on the Ninja output directory Created with: gclient setdep -r src/third_party/devtools-frontend/src@992295e37d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125,chromium:1075437 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4770e154e20d39364ac824f6ef522d7558126947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167789Reviewed-by:
-
arthursonzogni authored
[Android sheriff] Disable the flaky test: testAdvancedSyncFlowPreferencesAndBottomBarShown The test has recently been added by: https://chromium-review.googlesource.com/c/chromium/src/+/2137440 TBR=bsazonov@chromium.org Bug: 1075530 Change-Id: I06aa061853dfb346a750f1913e9d4bec1f12084e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167277Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762821}
-
Mathias Carlen authored
This patch introduces a repeated field of domains to be used as a browse mode whitelist when a user browses the web. In particular, subdomains should be whitelisted if they should be accessible by a user without AA shutting down. Bug: b/154305037 Change-Id: Id3a1ce078b8ece833513beacedf3c529a9cd77d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164807 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#762820}
-
Boris Sazonov authored
This CL adds IdentityManager.getPrimaryAccountInfo(consentLevel) and deprecates the old version without parameters. It also migrates all callers to the new method. Bug: 1046746 Change-Id: I6a1d9de35361fc81420eda7fc6a8b73ceb0db20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162737Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#762819}
-
Milica Selakovic authored
This CL intorduces presaving of generated password. Bug: 1064264 Change-Id: I7fd18722a2eecb883c0f62bbc7d0aaed764e37b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153109 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#762818}
-
Boris Sazonov authored
The call to SigninHelper.updateAccountRenameData() in AccountsChangedReceiver is redundant, as SigninHelper would call updateAccountRenameData in validateAccountsInternal anyway. Bug: 1074306 Change-Id: Ib02d364ee06364582816b0896e3ec96d4c3295c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164826Reviewed-by:
-
Sebastien Lalancette authored
I realized no code-path will ever trigger the error alert pop-up in the activity service component. I think it actually makes sense given that our activities are in fact commands - the command should handle reporting its failing state. Cleaned-up that scenario. Bug: 1068606 Change-Id: I677746f7216cbc975a0382d2fc98cec05a75a7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165849Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#762816}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b26111815641..74fc574cbc14 git log b26111815641..74fc574cbc14 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 tommi@webrtc.org Fork a few VideoReceiveStream related classes. Created with: gclient setdep -r src/third_party/webrtc@74fc574cbc14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3067f5472db64c2f25bc8539703fd5a0d381d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167788Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Id6e45887e66060a275b14489290e5aedd0379868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164511Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762814}
-
Antonio Sartori authored
According to https://w3c.github.io/webappsec-csp/#directive-report-to, the Content-Security-Policy directive "report-to" should only accept one token (endpint). However, our previous implementation allowed several endpoints to be specified. Bug: 916265 Change-Id: Ie11ee736f577d015921a5291824dcedcbc790177 Fixed: 916265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162826Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#762813}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d2d6cca..c23316f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60d1a25eaf45aa091df396ce81db3c0dd690c099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165914Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762812}
-
Harald Alvestrand authored
Bug: none Change-Id: Id2858339f46c14ee6b007c5e3b0aa4b2d7c90c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153160 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#762811}
-
Ulan Degenbaev authored
Change-Id: I2b28e30f7d4f64e53d0c95ac4224df639967afd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156413Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762810}
-
Yuki Shiino authored
{Readable,Writable,Transform}StreamDefaultConstroller expect their prototype object to have 'constructor' property, however, [NoInterfaceObject] is an extended attribute that removes 'constructor' property on the prototype object (although the current bindings generator doesn't do so). Remove the misusage of [NoInterfaceObject]. Bug: 839389 Change-Id: I12057b0a4283c9247933e7f6085f855df581e3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167743Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762809}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b59ed7ed88a3..51980699f7e4 git log b59ed7ed88a3..51980699f7e4 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 mathias@chromium.org Avoid unnecessary use of `Object.entries` Created with: gclient setdep -r src/third_party/devtools-frontend/src@51980699f7e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039620,chromium:1075437 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibeec76be4537878f65deec9f9b854727fcb018c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167783Reviewed-by:
-
Anastasiia Nikolaienko authored
If we receive mirror header for another profile (when using multiprofile mode) - don't show the dialog. If Show method was called when lock screen is open, ignore the call. Bug: 1073050 Change-Id: I5b6575bf8ef6c833c34c3de4117018818ba957c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161030Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#762807}
-
Stephan Hartmann authored
Use of std::all_of requires STL compliant iterator. However, NGPhysicalContainerFragment::ConstIterator does not define iterator_tag and therefore is no STL iterator. To make it compliant derive NGPhysicalContainerFragment::ConstIterator from std::iterator. Bug: 957519 Change-Id: Id042f987ca093ece6cd1cd10f601eb1909700d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153148Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#762806}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bcf6a2430e99..ea50f6d77ef5 git log bcf6a2430e99..ea50f6d77ef5 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 63069047+pmistryNV@users.noreply.github.com Add support for extension GL_ARB_shading_language_packing (#2192) Created with: gclient setdep -r src/third_party/glslang/src@ea50f6d77ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I6c1db3e0b2915a658cf22b1752c9e74ae4dca7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167785Reviewed-by:
-
Anastasiia Nikolaienko authored
Change-Id: If45fe9bcf7029eaeba5443129d3f2b905dce7a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166187Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This reverts commit 6df2ca04. Reason for revert: suspecting this revert caused a compile error -> build tree red Original change's description: > Revert "[LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item." > > This reverts commit 7c281002. > > Reason for revert: consistent failures on "webkti linux asan" bot > > Original change's description: > > [LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item. > > > > As part of the descendants walk that we perform when adding a box > > fragment that establishes an inline formatting context, update the > > first/last-for-node bits directly. > > > > Many thanks to kojii@ for suggesting and helping out with this solution! > > > > Once we add the last box fragment for a node, finalize the inline items. > > In addition to associating with the LayoutObjects, also set the > > first/last-for-node bits, if fragment traversal is enabled. > > > > Since we now require the layout results to be available for anything > > that establishes an inline formatting context (to set the first/last > > bits), we also need to store the layout results for the column > > fragments. Columns are not really associated with a LayoutObject, but > > we'll use the legacy LayoutFlowThread for this. Another option would be > > to create an anonymous block child of a multicol container that > > establishes an inline formatting context, but I decided against that for > > now. > > > > Expanded some NGFragmentItemTest unit tests, and added a new one, to > > make sure that we behave in RTL situations. > > > > This allows for supporting these bits in culled inlines as well. > > Enabled fragment traversal in NGFragmentItemTest, so that we can test > > it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The > > culled inlines test there also expects FragmentsVisualRectBoundingBox() > > to return something sensible, so remove the skipping we had in PrePaint > > for culled inlines, to just make this work. > > > > Will follow-up with cleaning up the first/last for node stuff added as > > part of CL:2111158. This will no longer be needed, but doing it in a > > separate CL is probably cleaner. > > > > Bug: 1043787 > > Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824 > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#762758} > > TBR=kojii@chromium.org,mstensho@chromium.org > > Change-Id: I9c2d4764baa7b3d714221fad9d281529b0195a3a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1043787, 1075517 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166188 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762797} TBR=kojii@chromium.org,mstensho@chromium.org,hendrich@chromium.org Change-Id: I5f15504387b23ca4720e6befdc114e691203a123 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043787, 1075517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167275Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit c714a458. Reason for revert: https://crbug.com/1075519 The bot: android-internal-chromium-tot can't compile anymore. Original change's description: > [Signin][Android] Move AccountManagerFacade.java and dependants to ../../../public/android > > This CL is a second step towards reorganizing //components/signin java files, this one moves the files from core/browser/android to public/android when relevant. > > Bug: 934688 > Change-Id: I0ac30a3d94fa0a09f645b70c1ddc6c5345b94441 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814826 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762795} TBR=blundell@chromium.org,bsazonov@chromium.org,pmeuleman@chromium.org Change-Id: I635f58cd59d9604514fa1aba02eb74464355f291 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167274Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7f7cc93aa44..b26111815641 git log f7f7cc93aa44..b26111815641 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 chunbo.hua@intel.com Fix a typo for decoder naming Created with: gclient setdep -r src/third_party/webrtc@b26111815641 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id56659fe8a59cf2423071795e98b9c0a0ca38ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167784Reviewed-by:
-
Marc Grimme authored
Currently no unit tests are covering the logic behind ManagementUIHandler::AddDeviceReportingInfo(). This CL adds the missing unit tests and does some basic refactoring in the test class itself. R=marcgrimme Bug: 1044954 Change-Id: I1767deec4d6754e9bb55ad544fb6f0a59ca697cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016640 Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#762800}
-
Alexander Hendrich authored
TBR=jityao@google.com Bug: 1075511 Change-Id: I6882a9f268492919903bceacd5bcdf78a2bb08e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167853Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/65301cad4d44..b0ad61f6ec5d git log 65301cad4d44..b0ad61f6ec5d --date=short --first-parent --format='%ad %ae %s' 2020-04-27 dberris@chromium.org Dashboard: Add timestamps to anomaly metadata Created with: gclient setdep -r src/third_party/catapult@b0ad61f6ec5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955 Tbr: oysteine@google.com Change-Id: Ia00889896e1df58ad29e9f5b9468a591d39c0300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167782Reviewed-by:
-
Alexander Hendrich authored
This reverts commit 7c281002. Reason for revert: consistent failures on "webkti linux asan" bot Original change's description: > [LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item. > > As part of the descendants walk that we perform when adding a box > fragment that establishes an inline formatting context, update the > first/last-for-node bits directly. > > Many thanks to kojii@ for suggesting and helping out with this solution! > > Once we add the last box fragment for a node, finalize the inline items. > In addition to associating with the LayoutObjects, also set the > first/last-for-node bits, if fragment traversal is enabled. > > Since we now require the layout results to be available for anything > that establishes an inline formatting context (to set the first/last > bits), we also need to store the layout results for the column > fragments. Columns are not really associated with a LayoutObject, but > we'll use the legacy LayoutFlowThread for this. Another option would be > to create an anonymous block child of a multicol container that > establishes an inline formatting context, but I decided against that for > now. > > Expanded some NGFragmentItemTest unit tests, and added a new one, to > make sure that we behave in RTL situations. > > This allows for supporting these bits in culled inlines as well. > Enabled fragment traversal in NGFragmentItemTest, so that we can test > it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The > culled inlines test there also expects FragmentsVisualRectBoundingBox() > to return something sensible, so remove the skipping we had in PrePaint > for culled inlines, to just make this work. > > Will follow-up with cleaning up the first/last for node stuff added as > part of CL:2111158. This will no longer be needed, but doing it in a > separate CL is probably cleaner. > > Bug: 1043787 > Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762758} TBR=kojii@chromium.org,mstensho@chromium.org Change-Id: I9c2d4764baa7b3d714221fad9d281529b0195a3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043787, 1075517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166188Reviewed-by:
-
Omar Morsi authored
This CL extends PlatformKeysService by introducing the following new functions: - RemoveKey This function will be used to remove the key pair corresponding to a given DER-encoded SubjectPublicKeyInfo. - GetAttributeForKey This function retrieves the value of an attribute for a private key corresponding to a provided DER-encoded public key. - SetAttributeForKey This function sets the value of an attribute for a private key corresponding to a provided DER-encoded public key. This is not planned to be exposed as an actual extension API. Instead, the functions are implemented mainly to be used by another component (built-in cert_provisioning). Bug: 1045895 Test: browser_tests --gtest_filter= *PlatformKeys* Change-Id: I8797e690487b866c80377aafce615546afd8f54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151868Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#762796}
-
Pâris Meuleman authored
This CL is a second step towards reorganizing //components/signin java files, this one moves the files from core/browser/android to public/android when relevant. Bug: 934688 Change-Id: I0ac30a3d94fa0a09f645b70c1ddc6c5345b94441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814826Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762795}
-
My Nguyen authored
These fields are added as requested by ChromeVox's team to tell ChromeVox user the true number of candidates and the current selection's index. Bug: 1074158 Change-Id: I697f96fe955fd5dc151543d47b26c605060f0a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162501 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#762794}
-
