- 19 Jan, 2021 40 commits
-
-
Christopher Cameron authored
Bug: 1162496 Change-Id: Ie8d986ae88b4f909380b527855eb3c84b3a0a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634016 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#844884}
-
Tommy Li authored
Two weeks ago we added a CHECK to verify in production our assumption that the default search provider was never Remove()-ed. This turned out to be violated in SearchEngineTabHelper. This CL fixes that violation. We don't need to call Remove() from that tab helper anyways, since a call to Add() will remove duplicates if possible, and will preserve the DSE. Bug: 1166372 Change-Id: Ia3d145ddc457d901fbb81c94487cee28b2792cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637957Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#844883}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611057528-6f03f3ff553c2040abb87e84fc5d258c023feaa2.profdata to chrome-mac-master-1611078768-634fb3ae1c67578f99ad9e12394867d392a20265.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I360531555dc70aaae63149e128697c47c045b528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844882}
-
Joshua Berenhaus authored
Changing the client id backup logic so that it does not try to get the id from the registry if there was a cloned install. This avoids the race condition specified in crbug/1160366 Bug: 1160366 Change-Id: Iee04a5173ed7713392d15fec42ded18f2b65bc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612110 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844881}
-
Nancy Wang authored
In ~AppWindowLauncherItemController, AppWindowBase::SetController could remove the window from windows_, so the for loop for windows_ might cause crash. Modify the for loop to use the reverse iterator to resolve the crash issue. BUG=1164188 Change-Id: Ifa561df71d3be1daf0c3505e8836d1cb60fa9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633483Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844880}
-
Ryan Sturm authored
Bug: 1135715 Change-Id: I8363e7434c24bf6d6b52b150e9b7747fe3d421e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636215Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844879}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611057528-c042fc837e99141efabc34633cbdaeed88679432.profdata to chrome-win32-master-1611068186-6acea0a5e8e4dcb5129946657add72ff4aa0a2a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e990922a2061af56be2cbb6cbc754131d7ce792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638235Reviewed-by:
-
Evan Stade authored
This reverts commit 4e7cf905. Reason for revert: no longer necessary after crrev.com/f6658bc4 Original change's description: > [omnibox] Fix Views clipboard access issues on Linux. > > Includes one behavioral change, no longer disabling the ability to paste > via keyboard shortcuts when the clipboard is empty. This change > simplifies the code, reducing the number of points of access to the > clipboard and removing the need for an auto-reset bool to control > whether the user is notified of restricted clipboard access. The removal > of the auto-reset bool is especially important as the scope-exiting > reset will always cause a memory access even if the view has been > deleted. > > Bug: 1161149 > Change-Id: I7a494c534e0efbf5d762a58fe6f7f39591cebb80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619204 > Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843159} TBR=estade@chromium.org,jdonnelly@chromium.org,manukh@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161149 Change-Id: I9bca7d74069f69f84addf96f2c9019b80ad0dacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637259Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#844877}
-
Michael Checo authored
Screenshot: http://shortn/_EzVSDUHswl Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#db1415fc-6806-4059-958e-459d8da17580 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I910d41a48c036b4a9067355faff4592c80b88aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530902Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#844876}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a8b2b4a5eb39..baf149636bd5 2021-01-19 morlovich@chromium.org UA-ch editting: let enter on (i) button actually work. 2021-01-19 morlovich@chromium.org UA-CH editing: fix focus indicator for (i) overlapping leading text 2021-01-19 andoli@chromium.org [module.json extensions] Adds getLazilyComputedLocalizedString to 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate snippets 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate node_debugger 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate protocol_monitor 2021-01-19 andoli@chromium.org [module.json extensions] lighthouse 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate performance_monitor 2021-01-19 tvanderlippe@chromium.org Fix localization of developer-resources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1158760,chromium:1167652,chromium:1168075 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic45b6b30337c6db775c86f1030d576208159d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637723Reviewed-by:
-
Rainhard Findling authored
This is a temporary workaround for crbug.com/1159942 Bug: 1152336 Change-Id: I58a55101e7344e756e694d8b8d213d33f8b1a88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627394 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844874}
-
Peter Wen authored
D8 provides a list of dependent/dependency relationships for desugaring. When a file changes (whether within the target or on the classpath), the classes within the target that implement it will need to be re-desugared even though those classes did not change. Previously we would re-desugar all classes within the target. Now we can just re-desugar (i.e. re-dex) only the necessary ones. This provides a build speed boost primarily due to avoiding the need to run any desugaring (either bazel desugar or D8 desugar) when a change does not require it. A follow-up CL will deal with the DexSplitter issue for monochrome and trichrome bundle builds. The stats below are timed with android_fast_local_dev=true. Before: chrome_java_nosig: 34.5s avg (34.1s, 35.2s, 34.2s, 34.4s) chrome_java_sig: 36.2s avg (35.0s, 37.0s, 36.4s, 36.4s) chrome_java_res: 39.8s avg (39.8s, 39.9s, 39.6s, 40.0s) base_java_nosig: 46.0s avg (46.9s, 46.0s, 45.0s, 46.1s) base_java_sig: 107.2s avg (106.8s, 106.9s, 107.7s, 107.3s) After: chrome_java_nosig: 31.6s avg (32.5s, 31.1s, 31.7s, 31.2s) chrome_java_sig: 34.0s avg (34.2s, 34.0s, 33.8s, 34.1s) chrome_java_res: 39.8s avg (39.8s, 39.6s, 39.9s, 39.8s) base_java_nosig: 22.7s avg (22.5s, 23.1s, 22.3s, 22.8s) base_java_sig: 101.3s avg (102.0s, 101.2s, 100.9s, 101.2s) Bug: 1015559 Change-Id: Idf4e05bf41583b2ea7d4f1d3855b508be56eea94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633323 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844873}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4b02fe1d0f5625a1c1562339f08f792a63b622e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616741Reviewed-by:
Joon Ahn <joonbug@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#844872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b69f54069cbf..e670fc72a5ae 2021-01-19 jmadill@chromium.org Implement shader compiler changes for Tessellation. 2021-01-19 cnorthrop@google.com Capture/Replay: Fixes for compressed texture cache 2021-01-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2bb77d70cc64 to dd50a3bce3ca (3 revisions) 2021-01-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: Aztec Ruins MEC Change-Id: I89e85dd24b00447e7be03115212767b2b1695a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638078Reviewed-by:
-
Daniel Hosseinian authored
Currently, both the plugin and the UI track the state of two-up-view. Additionally, the state tracked by the plugin is consistently sent to the UI. While two-up-view can only be invoked on through the UI, the feature actually occurs asynchronously. It would be better to update the UI state with that of the plugin. Change-Id: Id0b40c2fa0d7d4eb029bbb06d8eb162871938385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631360 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 1103604 Change-Id: I69d1d4d62de530c6ad0aaa83a5e1c09fd4ae2a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637597 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844869}
-
Erik Språng authored
This method replaces the ImplementationName() and adds support for the explicit is_hardware_accelerated flag. Bug: webrtc:12271 Change-Id: I22c6956077b7494b74016382f9ba304017bffc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599087 Auto-Submit: Erik Språng <sprang@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844868}
-
Eric Seckler authored
Adds a power_scheduler component and the foundational framework to vote on and determine a process-wide PowerMode, which will later be used as input to the yet-to-be-implemented power scheduler. We will instrument different Chromium components to provide inputs to power mode detection. Each instrumentation site will instantiate a PowerModeVoter, which votes on the process's power mode. The votes are collected by a PowerModeArbiter, which decides the overall mode for the process based on a prioritization mechanism. Internal design doc: http://go/chromium-process-power-scheduler (sorry, no public docs yet.) Bug: 1166695 Change-Id: Idc70c8c5202d45ba44cddffa3fba9a5da41257fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628958Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#844867}
-
Mohamed Amir Yosef authored
This CL introduces a method in Autofill client that opens the Save Address bubble. No implementation is added in this CL. The method is currently empty. Follow up CLs will add implementation for this on various platforms. Bug: 1135178 Change-Id: I8d67a4a097013785eddc28a0981da71e3fc10ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632587Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#844866}
-
Caitlin Fischer authored
These experiments appear to have launched. Bug: 1126640 Change-Id: I42c346088f392de93d8ca77e0d1988025b52bc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631926Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844865}
-
Ahmed Mehfooz authored
Bug: 1160929 Change-Id: I1dbcf67108e7e07c2a746610b237870db1b1c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633724Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
-
Danila Kuzmin authored
Bug: 1159889 Change-Id: I54ea83b1599f6a732e910f2034c67ccfd038c426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616350Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#844863}
-
Victor Costan authored
The method currently follows an unfortunate maybe-async pattern established in //net whereby operations may either report an outcome synchronously by returning a net::Error other than net::ERR_IO_PENDING, or report the outcome asynchronously by invoking a callback. This CL changes the method to unconditionally run the callback with the operation outcome. This is intended to simplify the mental model and control flow around the method. Change-Id: Iedf252bae4f6dc82c5570ccc5f1d70f8b2e11c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635679 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6ed1382f51..0d1002c96edb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidvc@google.com,adithyas@google.com Change-Id: I8d0e834957551181c7ed04fcd92890b7c2ba87fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630572Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844861}
-
Jarryd authored
* Quota.GlobalTemporaryPoolSize * Quota.QuotaForOrigin * Quota.PercentUsedByOrigin Bug: 1165268 Change-Id: I9303197804caa996c9f44845d60f932705c51a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633939 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Domenic Denicola authored
The feature's name has changed, so it's ideal for places like https://www.chromestatus.com/metrics/feature/timeline/popularity/3286 to reflect the new name. Bug: 1158853 Change-Id: I17c83d8be38c97e4748b4299f81861ce411bbb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633374Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844859}
-
Adam Langley authored
BUG=1002262 Change-Id: I46732a4570ebbfc896e23c86f6689b29e82f0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636382 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844858}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b28c3b8f..870bd0b9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6419cf6f263ff4c49c47e102323aded0fcfa7d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637328Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844857}
-
Tim Volodine authored
Add kWebViewJavaJsBridgeMojo feature for Android WebView, to enable/disable the new Java/JS bridge code path using mojo. The feature is currently disabled by default. When the feature is enabled the mojo interface for the addJavascriptInterface() API in Android WebView is used. This CL also adds the feature to the ProductionSupportedFlagList and removes the 1-arg version of JavascriptInjector.fromWebContents(). BUG=1164434 Change-Id: Ic4ecdbb78ca18e5455ddbac3367ddbe301bdb67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630905Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844856}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0bc32f23f69e..f8dfc3b51883 2021-01-19 johnstiles@google.com Generate valid Metal code when globals reference one another. 2021-01-19 adlai@google.com Optimize task clustering, part 1 2021-01-19 fmalita@chromium.org [svg] Cleanup: drop the presentation attribute SkPaint cache 2021-01-19 bungeman@google.com Avoid division by zero when shaping. 2021-01-19 bsalomon@google.com Revert "Test all YUVA image factories with different encoded origins." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I069d44c5d3de7225aa974fc1c682f2a12c62f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638012Reviewed-by:
-
Victor Costan authored
The member is kept up to date in code, but only read in tests. Change-Id: I2a1fb25e9ac51e2e26d2b38365df55b502d3c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634861 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Xida Chen authored
This reverts commit 85f5cc53. Reason for revert: Test fails here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tester%20(Ozone%20Wayland)/4513/overview Original change's description: > Handle sync paste deep scanning crash > > This fixes the crash observed in crbug.com/1166233 and adds tests for > it. See the comments in that bug for more details. > > This fix also removes the dialog for unauthorized users for pasting > after the initial scan that does authentication, so crbug.com/1028133 > is affected. > > Bug: 1166233, 1028133 > Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701 > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844787} TBR=anthonyvd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,domfc@chromium.org Change-Id: Ie52bf5a7b9aeaf3871795e0c480cf86d6be8fc0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166233 Bug: 1028133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637406Reviewed-by:
Xida Chen <xidachen@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844853}
-
Sherry Hu authored
Chrome uses ArcAdbdMonitorBridge to control arcvm-adbd. Android notify Chrome over Mojo to make sure arcvm-adbd job start/stop when guest's adbd startup/shutdown. The change is paired with https://crrev.com/c/2600256 and https://crrev.com/c/2600476 TEST=Toggle ADB debugging on Android developer setting, start/stop arcvm-adbd job successfully. TEST=component_unittests --gtest_filter="ArcVmClientAdapterTest.*" TEST=unit_tests --gtest_filter="ArcAdbdMonitorBridgeTest.*" Change-Id: Ib3742fba4854dc20e71ebe09d7a145ea45047101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600436 Commit-Queue: Sherry Hu <shuanghu@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844852}
-
manukh authored
We're unlikely to further pursue kRichAutocompletionTwoLineOmniboxParam. Bug: 1062446 Change-Id: Ia10ccf122faf94c86c912e0c618d4039bf8da84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617514Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#844851}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2517afd133f3..0489cc12af57 2021-01-19 ehmaldonado@google.com Reland "presubmit: Use new API to check for owners approval" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ieff0ff0a2f88a220f562d59d968d357111186b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638234Reviewed-by:
-
cfredric authored
Change-Id: Id88e7004eb6bb85fcbb8352ee0ff522d88702350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637397 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
-
Patrick Noland authored
Bug: 1147581 Change-Id: If11ef6233939f1c58ffba34b4ab391f7665134d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596115 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#844848}
-
Eugene But authored
Bug: None Change-Id: I637c90a7eec18a18d60b1727fa51e71b5e115832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633969 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#844847}
-
Scott Violet authored
Specifically, if the box has non visible overflow and an overflow-clip-margin. Without this the overflow from contain:paint doesn't take into the account the overflow-clip-margin, and we may end up not painting when we should. BUG=1157843 TEST=third_party/blink/web_tests/external/wpt/css/css-overflow/overflow-clip-margin-007.html Change-Id: Iba11a683f8cc1eb595ef26984c0dce38133fc760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626027Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844846}
-
Victor Costan authored
The majority of the storage code uses incognito instead of off_the_record. This CL gets WebSQL in line, to reduce cognitive overhead for readers. Change-Id: I8fcce58f82da24e22aa7b14b201dc7ed935b1114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634551 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
