- 14 Feb, 2019 9 commits
-
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature Bug: 925652 Change-Id: Iac0bef29d129c3e48c24d6bff14605f1a116fdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1471372 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#631985}
-
Kent Tamura authored
The new behavior matches to the standard, Firefox, and Safari. Bug: 927626 Change-Id: Ifc6687992c10fbca13faaaeb4a56e59f5469f594 Reviewed-on: https://chromium-review.googlesource.com/c/1469843Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#631984}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da5e03954dd3..5105d68f93e9 git log da5e03954dd3..5105d68f93e9 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 brianosman@google.com Use half-floats for out-of-gamut color in GrAAFillRRectOp 2019-02-13 nigeltao@google.com Keep scaledHeight calculation across oID calls 2019-02-13 reed@google.com work to fix bookmaker 2019-02-13 jvanverth@google.com Fix drag events in Mac viewer. 2019-02-13 herb@google.com Use SkStrikeSpec to consolidate SkDescriptor, Effects and Typeface. 2019-02-13 mtklein@google.com rewrite SkMasks::CreateMasks to work in bytesPerPixel 2019-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d3fac74a236e..6fc22a13d45d (7 commits) Created with: gclient setdep -r src/third_party/skia@5105d68f93e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I5dba42616bfa9b108289ee470d58573c5282a927 Reviewed-on: https://chromium-review.googlesource.com/c/1471192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631983}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6fc22a13d45d..3805122b0297 git log 6fc22a13d45d..3805122b0297 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 syoussefi@chromium.org Revert "Roll Vulkan repos" Created with: gclient setdep -r src/third_party/angle@3805122b0297 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie5bb05a2da1b44ad303b4692bb45957008d7f667 Reviewed-on: https://chromium-review.googlesource.com/c/1471270Reviewed-by:
-
John Lee authored
Bug: 924176 Change-Id: Icf2e64886ad574cfb43a60823e2ce9035d925857 Reviewed-on: https://chromium-review.googlesource.com/c/1471296Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#631981}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a594f8fdb4d7..1809ff74233d git log a594f8fdb4d7..1809ff74233d --date=short --no-merges --format='%ad %ae %s' 2019-02-13 jiawei.shao@intel.com Vulkan: Remove RenderPassDescriptorVk 2019-02-13 tikuta@chromium.org [dawn] small fix for BUILD.gn Created with: gclient setdep -r src/third_party/dawn@1809ff74233d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931596 TBR=cwallez@chromium.org Change-Id: I285f4a614d70d32449c0794542bff8655bed4ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1470954Reviewed-by:
-
Kevin McNee authored
This reverts commit ab746aa2. Reason for revert: Re-enabling this report revealed that this issue is still happening. We'll disable it again until we have another idea for a fix. Original change's description: > Re-enable the ReportBubblingScrollToSameView DumpWithoutCrashing > > We believe that this issue is now fixed, so we'll re-enable this > DumpWithoutCrashing to confirm that there are no more occurrences of > this. > > Bug: 828422 > Change-Id: I3ab2b9b949ee50bf15d883b86a938bde46eafa9c > Reviewed-on: https://chromium-review.googlesource.com/c/1456875 > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Auto-Submit: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629797} TBR=nasko@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 828422 Change-Id: I37d3b72aa6ea4f748fdd755883ec6926e698a128 Reviewed-on: https://chromium-review.googlesource.com/c/1471222Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#631979}
-
Melissa Zhang authored
This CL adds a permission field to the ArcPackageInfo struct so that ARC app permission data can be passed from ARC to Chrome OS through the AppHost function OnPackageAppListRefreshed. This data is then passed through to arc_apps in the App Service. BUG=916380 Change-Id: If1df4c4fd8b3d85df153fbb9d3355a2d5af1ea78 Reviewed-on: https://chromium-review.googlesource.com/c/1433339 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#631978}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae2acf7bf997..3b1e64245a0b git log ae2acf7bf997..3b1e64245a0b --date=short --no-merges --format='%ad %ae %s' 2019-02-13 jbudorick@chromium.org presubmit: use depot_tools.on_path rather than a handrolled equivalent. Created with: gclient setdep -r src/third_party/depot_tools@3b1e64245a0b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925774 TBR=agable@chromium.org Change-Id: I1f292a4a70e6a819a36c59642148f7c9ea7d495b Reviewed-on: https://chromium-review.googlesource.com/c/1471191Reviewed-by:
-
- 13 Feb, 2019 31 commits
-
-
Julie Jeongeun Kim authored
This CL removes ProfileOAuth2TokenService and ProfileOAuth2TokenServiceIOSDelegate from CWVSyncController and uses IdentityManager instead of them. Bug: 913927 Change-Id: I49970068e663c10af5472d083ef3621d83748db8 Reviewed-on: https://chromium-review.googlesource.com/c/1461203Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#631976}
-
Dan Zhang authored
No flag change Make QuicSpdyStream only reports ack on body, excluding headers bytes acked. Protected by version 99. Merge internal change: 233167078 https://chromium-review.googlesource.com/c/1471111/ Add |frame_len| argument to HttpDecoder::Visitor::OnHeadersFrameEnd(). This will be used in cr/231494986. That one is a quite large CL, so I'm trying to carve out pieces of it for easier review. Also, change HttpDecoder member and argument and return value and local variable types from size_t or uint64_t to QuicByteCount wherever it expresses number of bytes. n/a. Change types in class used in QUIC v99 only. Not flag protected. Merge internal change: 233149295 https://chromium-review.googlesource.com/c/1470999/ Create a QuartcEndpoint abstraction which creates sessions asynchronously. For now, this is just a wrapper around QuartcFactory. It creates sessions asynchronously by scheduling a callback on a QuicAlarm. The only point to this construct is to force users to wait for a callback. QuartcEndpoint will serve a greater purpose in the future: it will own session/dispatcher dependencies that the caller doesn't need, serve as a unified API for both client and server perspectives (useful because Quartc is peer-to-peer and application layer code is the same on both perspectives), and handle session establishment. We will start by migrating users from calling QuartcFactory directly to calling QuartcEndpoint instead, then replace QuartcFactory with an implementation of QuicDispatcher (for server-side version negotiation) or a version negotiation agent (for the client). QuartcFactory will eventually cease to exist. Creating QuartcEndpoint and migrating callers away from QuartcFactory first makes it significantly easier to cannibalize the parts of the factory that handle connection and session creation without breaking callers. These pieces need to be reorganized to allow use from the dispatcher. n/a (Quartc only) Merge internal change: 233082878 https://chromium-review.googlesource.com/c/1468263/ Remove unused ack_listener argument from QuicSpdyStream::WriteOrBufferBody. No functional change expected, not protected. Merge internal change: 233065023 https://chromium-review.googlesource.com/c/1468262/ Change a LOG(ERROR) to LOG(WARNING) in QuicPacketReader, and add a histogram for the size of dropped packets. Log & stats only, not protected. Merge internal change: 233055771 https://chromium-review.googlesource.com/c/1468023/ Add a new method to allow QuicClientBase to change local ports to simulate NAT rebinding and add a command line arg, --num_requests, to QuicClientBin to use it. n/a (Test only tools) Merge internal change: 233054987 https://chromium-review.googlesource.com/c/1468003/ Simplify the implementation of QuicFramer::BuildConnectivityProbingPacket(). Protected by FLAGS_quic_reloadable_flag_quic_simplify_build_connectivity_probing_packet Merge internal change: 232996256 https://chromium-review.googlesource.com/c/1467981/ Remove QuicFramer::BuildIetfDataPacket and make BuildDataPacket do the needful. Rename the guts of BuildIetfDataPacket to AddIetfFrame(). n/a - Moving code around. No functional change. Merge internal change: 232985714 https://chromium-review.googlesource.com/c/1467668/ Split QuicConnectionHelperInterface from QuartcFactory. Required for QuicDispatcher/QuartcEndpoint. When we adopt QuicDispatcher for server-side version negotiation, it needs to own its own instance of QuicConnectionHelperInterface. The factory will eventually go away, so it can no longer serve as the connection helper for Quartc. Instead, the factory will own a separate implementation of the connection helper interface, which can be used without the factory in the near future. n/a (Quartc only) Merge internal change: 232965722 https://chromium-review.googlesource.com/c/1467381/ Deprecate FLAGS_quic_reloadable_flag_quic_fix_last_packet_is_ietf_quic. Remove unused last_header_form_ from QuicFramer. Merge internal change: 232921237 https://chromium-review.googlesource.com/c/1465982/ Deprecate FLAGS_quic_reloadable_flag_quic_fix_mark_for_loss_retransmission. Merge internal change: 232913254 https://chromium-review.googlesource.com/c/1466864/ In QUIC, move ack_listener_ from QuicStream to QuicSpdyStream. No functional change expected. Not protected. Merge internal change: 232900726 https://chromium-review.googlesource.com/c/1464114/ Deprecate FLAGS_quic_reloadable_flag_quic_disallow_peer_ack_0. Merge internal change: 232899487 https://chromium-review.googlesource.com/c/1464452/ Initialize server address in QUIC tests. Previously, GetProof would sometimes get called with an uninitialized server address. n/a (test only code) Merge internal change: 232559024 https://chromium-review.googlesource.com/c/1464356/ In QUIC, fix a potential BUILD error because of trying to get min of different types. Merge internal change: 232551850 https://chromium-review.googlesource.com/c/1464133/ Disable QUIC v39. Protected by BLOCKED FLAGS_quic_reloadable_flag_quic_disable_version_39. Merge internal change: 232527607 https://chromium-review.googlesource.com/c/1464447/ Rename QuicSimpleServerStreamPeer to TestStream and make it not a peer. n/a (test-only change) QuicSimpleServerStreamPeer is kind of a regular peer class: it is friend of QuicSimpleServerStream, and has static methods taking a QuicSimpleServerStream* argument. At the same time, it is also a subclass of QuicSimpleServerStream, and has non-static methods that operate on base class members. I find this confusing. This CL turns QuicSimpleServerStreamPeer into a regular derived class: no static methods, no friendship. It also renames it accordingly. Merge internal change: 232526479 https://chromium-review.googlesource.com/c/1464350/ Add serializer/deserializer for IETF MAX_STREAMS and STREAMS_BLOCKED frames These replace the MAX_STREAM_ID and STREAM_ID_BLOCKED frames. The serializer/deserializer converts between the internal QuicMaxStreamIdFrame and QuicStreamIdBlockedFrame objects, which use absolute stream IDs, and the wire form of the new frames, which uses stream ID counts. The translation between the two is simple and straight forward. A number of tests have been changed to accomodate the new formats and logic -- in particular, dealing with the stream ID formats for uni- & bi-directional streams and server- & client- initiated streams. A follow on CL will replace teh Quic..Frame objects with new ones for the new frames, with associated logic changes. N/A all code is V99 only and protected by the V99 flag. Merge internal change: 232523736 https://chromium-review.googlesource.com/c/1464132/ Change QuicDispatcher to take a pointer to QuicConfig. The constructor currently binds the config to a reference member. This means the caller is required to keep the referred-to object alive for the lifetime of the QuicDispatcher. This behavior tripped me up when trying to adopt QuicDispatcher in Quartc, as I assumed QuicDispatcher would create a copy of the config. Changing this to a pointer conforms with advice from go/totw/116. It makes it clearer that the caller is responsible for ensuring that the config outlives the dispatcher. Merge internal change: 232516491 https://chromium-review.googlesource.com/c/1464446/ (n/a) Deprecate FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2. Merge internal change: 232511987 https://chromium-review.googlesource.com/c/1464107/ R=rch@chromium.org Change-Id: I7f982c27514d17bc6947f420d42a0ed7b569002f Reviewed-on: https://chromium-review.googlesource.com/c/1471234Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#631975}
-
Alexey Baskakov authored
Incognito windows (WebContents) are backed by OffTheRecord profiles. Make BMO behavior match the legacy behavior. This is tested in HostedAppPWAOnlyTest.PopOutDisabledInIncognito (I've found that prototyping unified BMO install). Bug: 915043 Change-Id: I5b3e7491989fb690538ea5892a5463ecec35770c Reviewed-on: https://chromium-review.googlesource.com/c/1469755Reviewed-by:
-
Brian White authored
There may be a follow-up CL that changes the class to have only RandInt() accessed through a virtual method and thus remove the non-deterministic part of the test. However, in order to merge easily, this meat of this change is only the fix from "!=" to "==" and a test to verify the correction. Bug: 931710 Change-Id: Idfe0cef847148aa99b19974f29b53388d0141e2f Reviewed-on: https://chromium-review.googlesource.com/c/1470943 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#631973}
-
Bo Liu authored
Broken case is WebContents::WasHidden is called before the first load then page visibility remains visible because nothing handles PageMsg_WasHidden, and nothing rechecks the state after first load. Note RenderView is invisible due to EnsureRenderFrameHostVisibilityConsistent. A related bug is that in this case RenderView is created to be visible and then marked visible after. Turns out fixing this will also correctly set page visibility, so this CL fixes this bug instead. Bug: 929860 Change-Id: I30e5e7d9488eb68299fbb524363d01a9b5b4e558 Reviewed-on: https://chromium-review.googlesource.com/c/1467641 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#631972}
-
Pavel Feldman authored
Bug: 930212 Change-Id: I99100d4fd6fd952f29763de8b33ce277a85ffb58 Reviewed-on: https://chromium-review.googlesource.com/c/1471258Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#631971}
-
Nico Weber authored
This CL was uploaded by git cl split. R=mgiuca@chromium.org Bug: 926235 Change-Id: Idcdbb010ed84fa6a679af7d20b889a3f272e41e5 Reviewed-on: https://chromium-review.googlesource.com/c/1464341 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#631970}
-
Erik Anderson authored
Microsoft runs tests in a Hyper-V VM. The test external/wpt/resource-timing/resource-timing-level1.sub.html leverages wptserve's SyntheticResponse.py to request that each step of a response is delayed by 250ms. In our environment, even with the extra 15ms "padding" in sleep.py, we're seeing the timer return 5ms early which in turn causes the test to fail. This change updates the sleep_at_least function to, in a loop, explicitly check that it slept long enough and, if not, sleep again for a short interval. Change-Id: I2dbd8e6bd586dc661b45f94454d3b6b4613db1a5 Reviewed-on: https://chromium-review.googlesource.com/c/1469655Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Erik Anderson <Erik.Anderson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#631969}
-
Natalie Chouinard authored
Now that the binary size is less significantly impacted by introducing additional ProtoDatabase instances (crrev.com/c/1419199), switch to using a unique ProtoDatabase for each proto message type. Bug: 921133 Change-Id: Ieae1fc5ba98c574c8e4f9a2587bffa4333fa80df Reviewed-on: https://chromium-review.googlesource.com/c/1471266 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#631968}
-
Mattias Nissler authored
This adds a flag and the corresponding boilerplate to let the user configure the flag via chrome://flags. BUG=chromium:927840 TEST=Manual Change-Id: I5e1e292a9f7b81283149dbb4673cf7e7ed26c553 Reviewed-on: https://chromium-review.googlesource.com/c/1456069 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#631967}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: If5f1ff20dc836ecd394236ed3d6d21ed363a12d5 Reviewed-on: https://chromium-review.googlesource.com/c/1470695 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is followup of https://chromium-review.googlesource.com/c/1461680 Change-Id: I52bdce131b2979f695863230225c78c6801cf3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1470284 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#631965}
-
Nasko Oskov authored
In order to make debugging easier, instead of serializing url::Origin logging code should call the newly added GetDebugString method. It adds more information, such as the nonce and precursor origin for opaque origins, which can be useful in investigating bugs. Bug: 918565, 919144, 931895 Change-Id: I1155a4c1f2df0adccd34b890feba8ab4164ec14d Reviewed-on: https://chromium-review.googlesource.com/c/1470727 Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#631964}
-
Tatiana Buldina authored
Change-Id: Ic1d9541d6404f3259cbf47a68fd0f3d0660de482 Reviewed-on: https://chromium-review.googlesource.com/c/1471260Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#631963}
-
Raphael Kubo da Costa authored
This fixes the GCC build: ../../chrome/browser/media/router/providers/cast/cast_activity_manager.cc:806:1: error: function ‘media_router::CastActivityManager::DoLaunchSessionParams::DoLaunchSessionParams(media_router::CastActivityManager::DoLaunchSessionParams&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ CastActivityManager::DoLaunchSessionParams::DoLaunchSessionParams( ^~~~~~~~~~~~~~~~~~~ With GCC, having that noexcept marker requires all members to be marked with noexcept themselves, and MediaRoute, CastMediaSource and url::Origin need the right annotations. Just making DoLaunchSessionParams not noexcept is the least intrusive solution for now. clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). Bug: 819294 Change-Id: Ia3a5fb60b5e74e68bd35cfa50e2fcc728b64e5eb Reviewed-on: https://chromium-review.googlesource.com/c/1469942 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#631962}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: I030910542a3adad311c9d5ffa11e904004b4b712 Reviewed-on: https://chromium-review.googlesource.com/c/1470757 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#631961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0187c190b58c..0167a20b0af8 git log 0187c190b58c..0167a20b0af8 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 zoddicus@users.noreply.github.com Move usage detection to after all instructions are registered (#2378) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0167a20b0af8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ief88f00f9f6d5ddbfef4cb9fe9df0fcfb97f8375 Reviewed-on: https://chromium-review.googlesource.com/c/1471273Reviewed-by:
-
Antonio Gomes authored
What theses tests really want is to supply their own URLLoaderFactory instance, so that GCMS uses it. In c/b/sync: The CL does this without need to instantiate or reference GCMSFactory directly. Basically, it adds a ChromeSigninClient factory method and injects the URLLoaderFactory instance ChromeSigninClient instance. GaiaCookieManagerService fetches the URLLoaderFactory instance from ChromeSigninClient for its cookie-related operations. In c/b/metrics: UkmBrowserTestBase::CreateNonSyncProfile calls SyncTest::SetupMockGaiaResponsesForProfile which injects the URLLoaderFactory to the ChromeSigninClient instance. Hence, the existing mechanism to add tests own URLLoaderFactory to GCMS is not needed, and can simply be removed. BUG=930745 Change-Id: Ie5d8074e6eb47181ef719b13daed1f9f8276c40b Reviewed-on: https://chromium-review.googlesource.com/c/1466606Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Wez authored
Bug: 931860 Change-Id: I8c7beaf359bf192d299ba730ae40971ad66c5932 Reviewed-on: https://chromium-review.googlesource.com/c/1471262 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#631958}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e77f5b943781..52ea556bdd54 Created with: gclient setdep -r src-internal@52ea556bdd54 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I70df488e5f83e66c40290395461ff815b9e07e02 Reviewed-on: https://chromium-review.googlesource.com/c/1471271Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631957}
-
Nico Weber authored
Bug: 926235 Change-Id: I14f82448d1c618f9b2bd1b3bfe883f3933c7ca9b Reviewed-on: https://chromium-review.googlesource.com/c/1471005 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#631956}
-
David Lu authored
This is due to the deprecation of the url shortener domains in favor of Firebase Durable Link (go/us-to-fdl) for creating 1P shortlinks at Google. Bug: 896461 Change-Id: I38379161ed513518b7b9871eef7fa44e7ef0ccf2 Reviewed-on: https://chromium-review.googlesource.com/c/1460063 Commit-Queue: David Lu <davidluphd@google.com> Reviewed-by:
-
Kyle Spiers authored
Change-Id: I3198507a82e15e8c4bcb51a3a3c5966b4184d6f5 Bug: 929943 Change-Id: I3198507a82e15e8c4bcb51a3a3c5966b4184d6f5 Reviewed-on: https://chromium-review.googlesource.com/c/1413396Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Kyle Spiers <ksspiers@google.com> Cr-Commit-Position: refs/heads/master@{#631954}
-
Aga Wronska authored
Bug: 911326 Test: ParentAccessViewTest Change-Id: I953afbcc8ba6df559c468cbb4c1537dbbe07a6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1455740Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Tommy C. Li authored
This puts the newly added-back vertical margin experiment into about:flags as well. Bug: 931332 Change-Id: I8ea314e3ffdefeb434f724b4ef8eb6948737f267 Reviewed-on: https://chromium-review.googlesource.com/c/1470741Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#631952}
-
Kevin McNee authored
The test performs a synthetic click from an OOPIF over the OOPIF. Synthetic mouse clicks over OOPIFs are broken in web_tests due to issue 895001, however this test happens to pass due to the incorrect behaviour described in issue 923497. Once 923497 is fixed, this test will no longer pass, so we have the test run without site isolation. Bug: 895001 Change-Id: I73d8eca31953dab6e19a21e31af130bcbff2c1b9 Reviewed-on: https://chromium-review.googlesource.com/c/1457120Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#631951}
-
Kyle Milka authored
Add last feature to UseGoogleLocalNtp experiment. Bug: None Change-Id: I06e3ef9caded7fc19735ca0dbf44bc2ea97098a7 Reviewed-on: https://chromium-review.googlesource.com/c/1470975 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Bug: 924160 Change-Id: I0f7471c8222f21d9707586cb67d54ae243f756ea Reviewed-on: https://chromium-review.googlesource.com/c/1471012 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#631949}
-
Jay Harris authored
Bug: 719176 Change-Id: I294c4b9b4dd51e9e507e790e901519a882a0ced6 Reviewed-on: https://chromium-review.googlesource.com/c/1462379Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#631948}
-
Dan Harrington authored
When setting state=FAILED, we need to assign a fail_state. Bug: 908991 Change-Id: Id6694bf1e0a5d071a14e1e884b8b319d8f685988 Reviewed-on: https://chromium-review.googlesource.com/c/1470747Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#631947}
-
Devlin authored
This reverts commit 53c99aa1. Reason for revert: New tests fail on Webkit Win10: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/45950 Original change's description: > Add vp9-alpha + canvas layout test. > > Apparently we don't have any vpx-alpha layout tests, hence macOS has > had broken support here for some time. > > BUG=919015 > TEST=fails without the macOS alpha fix. > > Change-Id: I1103f3fd747ca62eff938824bdc0e52899495f64 > Reviewed-on: https://chromium-review.googlesource.com/c/1468597 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631877} TBR=dalecurtis@chromium.org,dcastagna@chromium.org Change-Id: Ie0b6c6262b6456813c3fab097f8862989885a48e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919015 Reviewed-on: https://chromium-review.googlesource.com/c/1471350Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#631946}
-
