GitLab

Ports the ash version change from crrev.com/580666

Bug: 869921, internal b/112073644
Test: manual
Change-Id: I85e68b53f13ff190d1f90f39f96f85f43699f20a
Reviewed-on: https://chromium-review.googlesource.com/1167651
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582119}

This reverts commit 68947d74.

Reason for revert: this may break interactive_ui_tests (CrSettingsSyncPageTest.All) on multiple builders.

Original change's description:
> Reland "[Settings] UserEvents depends on history and passphrase"
> 
> This is a reland of 13143b64ae10001dd25dcb8b2d8e707b9e439382
> 
> Original change's description:
> > [Settings] UserEvents depends on history and passphrase
> >
> > The user events UI toggle should be grayed out and turned off
> > when there is a passphrase or when history sync is disabled.
> > Note that this is purely a UI change: the internal sync datatype
> > is not really turned off in that case, and we assume that the Sync
> > engines will correctly stop syncing user events in these cases,
> > even if the preference is still ON.
> >
> > Bug: 865522, 865537
> > Change-Id: I04844e2ab9c631300e88f02bbedd712f7618bc32
> > Reviewed-on: https://chromium-review.googlesource.com/1160658
> > Reviewed-by: Scott Chen <scottchen@chromium.org>
> 
> TBR=droger
> 
> Bug: 865522, 865537
> Change-Id: Ifae79eaf00a42c3b536bc54fa5d23cbcbcabd18a
> Reviewed-on: https://chromium-review.googlesource.com/1170202
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582078}

TBR=droger@chromium.org,scottchen@chromium.org

Change-Id: I2187610fb6ebbeaefff001b858b3585b786ed181
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865522, 865537, 873110
Reviewed-on: https://chromium-review.googlesource.com/1170782Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582118}

PSA: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9YCeDToqDU8

Bug: chromium:757440
Change-Id: Ie53f3a5f68ace78bc47828cfb441d5d0a53fd9aa
Reviewed-on: https://chromium-review.googlesource.com/1170692Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582117}

Edge-passthrough was necessary in the past when the touch exploration
event rewriter preceded the cast system gesture event rewriter. Now
the touch exploration runs last, so this code is unused.

Bug: internal b/112073644
Test: manual
Change-Id: I3372a3ac15b31ac68b7d2a8603182f1e19a4934a
Reviewed-on: https://chromium-review.googlesource.com/1167545
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582116}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3e655b0ac271..fa55f08ba456


git log 3e655b0ac271..fa55f08ba456 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 dgarrett@google.com cros tryjob: Improve --cbuildbot.


Created with:
  gclient setdep -r src/third_party/chromite@fa55f08ba456

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I51dd94886296b224033b61a2e745842d6d2add15
Reviewed-on: https://chromium-review.googlesource.com/1170571Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582115}

This was approved in the following blink-dev thread:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/PNTQCliD2oA/discussion

Bug: 599859, 834580
Change-Id: I5419f4b804d864f7837487ec881fb5542d9304df
Reviewed-on: https://chromium-review.googlesource.com/1169477Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582114}

This reverts commit a92b95bb.

Reason for revert: suspect this causes dashboard internal error. 
BUG:chromium:873102

Original change's description:
> Maximize the number of parallel processes for processing & uploading perf data
> 
> A big portion of perf data uploading latency is due to I/O operation (uploading),
> hence maximize the number of parallel processes to improve the wall-time.
> 
> Bug:857283
> Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0
> 
> TBR=simonhatch@chromium.org
> 
> Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0
> 
> NOTRY=true  # android_arm64_dbg_recipe flake
> 
> Change-Id: I0c3246849676a56801fe99846ade7265d13d94c0
> Reviewed-on: https://chromium-review.googlesource.com/1170083
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581991}

TBR=simonhatch@chromium.org,eakuefner@chromium.org,nednguyen@google.com

Change-Id: I02d1e84a065bd9c315ec2242fc6a8a0bbd6593a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857283
Reviewed-on: https://chromium-review.googlesource.com/1169800Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#582113}

These tests don't exist.

TBR=kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8040cb301de29f54ad047184f540b2ca31de5ef6
Reviewed-on: https://chromium-review.googlesource.com/1170697
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582112}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I0da28cbce779f0b1e859f8c3d88932046730448e
Reviewed-on: https://chromium-review.googlesource.com/1170579
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582111}

The LongTaskObserver API enables applications to detect presence of
“long tasks” that monopolize the UI thread for extended periods of
time and block other critical tasks from being executed.
https://codereview.chromium.org/2685183002
https://www.chromestatus.com/feature/5738471184400384

BUG=688439

Change-Id: Ibfa8745abd6ff4a670fa94859b7d211d10ab489c
Reviewed-on: https://chromium-review.googlesource.com/1166621Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582110}

Without jumbo, password_manager takes around 3.6 CPU
minutes to build. With jumbo and chunk size 50,
password_manager takes around 11 seconds to build,
a decrease by around 94 %.

This commit enables jumbo support in
components/password_manager.

Bug: 869381
Change-Id: Icce9d9800a01d452d63ba137c52c2a0495359da8
Reviewed-on: https://chromium-review.googlesource.com/1166963
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582109}

This CL introduced blink::mojom::WebUsbService implemented
by WebUsbServiceImpl in chrome/browser/usb which used to be
WebDeviceManager.
Paralleling with device::mojom::UsbDeviceManager, the new interface
aims to simplify the interactions with Blink, and a meaningless
argument of GetDevices() method has been reduced in this CL.
device::mojom::UsbChooserService will be merged to this interface in
subsequent CLs.

BUG=699790

Change-Id: I891c56460425c20d2e8d067f9335091f6945ae7d
Reviewed-on: https://chromium-review.googlesource.com/1151065
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582108}

device_orientation/motion/detached-frame.html

TBR=rmcelrath@chromium.org
NOTRY=true


Bug: 873078
Change-Id: I58d98a331c8d56937313d8f2db27652355c1a4f7
Reviewed-on: https://chromium-review.googlesource.com/1170696Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582107}

Bug: 862461
Change-Id: If75e6c2b4a608c94c4d12dedb88d23ccee8e3847
Reviewed-on: https://chromium-review.googlesource.com/1166769
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582106}

//components/autofill takes 6.6 CPU minutes to compile.
With jumbo and chunk size = 50 the build time is reduced
by around 54 %.

This commit enables jumbo support in components/autofill.

Bug: 869381
Change-Id: Iba405b8c2199f68c11a13ee0872bfaae87943d7f
Reviewed-on: https://chromium-review.googlesource.com/1170689Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#582105}

This CL changes the system of callback registration to slot-based as with references.
Anytime HeapLinkedHashSet rehashes and impl_.table_ changes while incremental marking is in progress, is when the callback won't be called.
So as preparing for HeapCompaction with IncrementalMarking, we change the key of the registration on HashMap from references(buffer address) to slots.

Bug: 864425
Change-Id: I5af93f1c56d0a76952e3347c4f3f1ba4f271047b
Reviewed-on: https://chromium-review.googlesource.com/1164881
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582104}

This CL improves a few functions related to symbol search
and relocation. This prepares for a major change that will
considerably change the way symbols are resolved during
relocations and dlsym(), to better match default ELF
semantics and help fix the component build as well.

- Use a SearchResult result when looking for symbols,
  in order to allow symbols with a null address to be
  supported (this can happen for weak symbol exports).

  See SystemLinker::SearchResult and the related
  LibraryView::SearchResult struct definitions.

- Ensure that SharedLibraryResolver properly releases
  its global scope handle on destruction. Since these
  correspond to a reference-counted global object, that
  will never be destroyed by the system linker, this
  was not a real resource leak, but is still the
  correct way to deal with this.

- Add a comment to SharedLibraryResolver::Lookup()
  explaining why the code is written and will need to
  be refactored in a future CL.

- Make LibraryView::LookupSymbol() const (finally!)

- Use a few const references, instead of raw pointers
  when calling SharedLibrary::Relocate().

BUG=843987,802068
R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org

android: crazy_linker: Minor cleanups.

Minor cleanups to the code base. Preparing for future changes.

BUG=NONE
R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org

Change-Id: I91c955c7be24e3738b118832c9ae8775934bc572
Reviewed-on: https://chromium-review.googlesource.com/1169603
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582103}

This CL modifies collected traced_slot_ in HeapCompaction.
In atomic pause GC world, slots that has nullptr references and only has an inline buffer are not collected by traced_slot_ because such HeapCollections are ealy returned in Trace method.
However, In incremental GC, we want to collect such slots because they might have references to OutOfLineBuffer after tracing.
So, we modified to collect all slots.

Bug: 864425
Change-Id: I08d94ae86eb33973addcd2f535a003d29c9eeb3b
Reviewed-on: https://chromium-review.googlesource.com/1156112
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582102}

BUG=none

Change-Id: I175181a2cdcfc0e2a04e40e7901343cd003e1ae7
Reviewed-on: https://chromium-review.googlesource.com/1164948Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582101}

The current approach to externs in file_manager js code requires
js_type_check in various modules to re-list all the externs used by
their dependencies, even if none of them are used in that module.

This CL kills the js_library("closure_compile_externs") in the Gallery
image_editor and puts externs named there where they belong.

To help audit this, the js_unit_tests() template is modified to generate
a js_type_check target for each unit test. This ensures that each unit
test has a complete dependency chain, including externs attached properly
to any of its dependencies.

The changes do not attempt to do full IWYU: if an extern is picked up
transitively in a js_type_check target, it is not listed more than once.
Eventually, breaking out more unit tests will ensure we have dependencies
better described, since each unit test has its own js_type_check.

Bug: 867700
Change-Id: I06fc0359627728046408493088a5bc407e54484b
Reviewed-on: https://chromium-review.googlesource.com/1166610Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582100}

This CL updates the ONC Validator to not only log detailed
errors/warning messages, but also collect them for later use (e.g.,
reporting to policy server or displaying in chrome://policy).

DesignDoc: go/chromeos-robust-onc-policy

Bug: 794848, 855057
Change-Id: Ie22ed887b3b298a8b7e92b175376f98d5f492dc3
Reviewed-on: https://chromium-review.googlesource.com/1116787
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582099}

When the LabelLink is displaying a text containing an unbreakable space,
the unbreakable space is preventing two words from being broken at the
end of a line. However, the ManualTextFramer used to get the position of
the link isn't respecting the unbreakable spaces.
So the displayed text isn't breaking the words at the end of the line
but the link is positioned as if the words were broken. So the position
of the link is wrong.

Bug: 872290
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9b2bae32a47e19b14c397e230aade87b3cb88157
Reviewed-on: https://chromium-review.googlesource.com/1169014
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582098}

Using wpt-import in Chromium 836ab12f.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22581

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams
mkwst@chromium.org:
  external/wpt/secure-contexts

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I9b98ffb1a68c9d79a96ce45414872cb43d7e0ccb
Reviewed-on: https://chromium-review.googlesource.com/1170563
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582097}

This CL relands "Don't show camera icon in guest mode", which was
reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1165962

Original description:

This CL hides camera icon of internal camera app in guest mode. Since
extensions are not allowed in guest mode, users can't perform any
actions after clicking on the camera icon.

TBR=stevenjb@chromium.org,melandory@chromium.org

Bug: 866412
Test: Tested on eve that there's no camera icon in guest mode.
Change-Id: Ia033c0899c5d23005c1c4779d20aff72f9a91501
Reviewed-on: https://chromium-review.googlesource.com/1167147
Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582096}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/aba1649cfb98..3e655b0ac271


git log aba1649cfb98..3e655b0ac271 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 saklein@chromium.org Update expected users/groups to reflect freon values.


Created with:
  gclient setdep -r src/third_party/chromite@3e655b0ac271

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I74de16d64ff43b28da7921d5446cf4d133166724
Reviewed-on: https://chromium-review.googlesource.com/1170287Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582095}

TracingControllerTest.DoubleStopTracing
TracingControllerTest.EnableAndStopTracingWithEmptyFile

TBR=oysteine@chromium.org

Bug: 873073
Change-Id: I1455984cf656abb30f700cdf30c5a9f770971b16
Reviewed-on: https://chromium-review.googlesource.com/1170683Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582094}

Move the functions to translate back and forth between the account id
used by the OAuth service chain and the account representation used by
Chrome OS Account Manager, to a util class.

This function was previously being performed internally in
|ChromeOSOAuth2TokenServiceDelegate|. Move it to a common util class
because other usages (ARC++) have cropped up that should not depend on
|ChromeOSOAuth2TokenServiceDelegate| for this use case.

Bug: 820046, 871690
Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"
Change-Id: Ie5d9fe672c521c0ddf3d6e376649d3a3fb9d33cb
Reviewed-on: https://chromium-review.googlesource.com/1165352
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582093}

Add a timeout parameter for ImageFetchTabHelper::GetImageData in case the
JavaScript does not response.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibee9284d937f020ae8deed55eab9eb3aabdba5c1
Reviewed-on: https://chromium-review.googlesource.com/1169168
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582092}

Current implemtation for chrome.windows.create cannot handle
following combination, but throw an error message instead.
- minimized with 'focused'.
- maximized, fullscreen with 'not-focused'

This change slightly improve documentation about it

Bug: 459841
Change-Id: Id925904c2e8c1b319041a455970252bc4f59750e
Reviewed-on: https://chromium-review.googlesource.com/1169039Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sungguk Lim <limasdf@gmail.com>
Cr-Commit-Position: refs/heads/master@{#582091}

This patch changes |CorrectedSelectionAfterCommand()| to use |Position::
IsValidFor()| to make it to check |Position| offset and return valid
selection.

Bug: 873037
Change-Id: I70c7d6f514a39414a4c3245b59969d19beb13f45
Reviewed-on: https://chromium-review.googlesource.com/1170458Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582090}

Whenever HostGpuMemoryBufferManager tries to get the GpuService instance
using GpuServiceProvider callback, it also sends a callback to be used
as the connection error handler for the GpuService. The code is also
updated such that the provider callback is called only when GpuService
has changed and the return value is cached.

BUG=733482

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7f30dc4fd63fe079a02f6c2484ac14c75da3c36a
Reviewed-on: https://chromium-review.googlesource.com/1161211
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582089}

Minor cleanups to the code base. Preparing for future changes.

BUG=843987,802068
R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org

Change-Id: I65598259521b3e21b540cedadba99cfa58f13051
Reviewed-on: https://chromium-review.googlesource.com/1169480Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582088}

On chrome/x11, right-clicking on the window decoration bar toggles a
context menu whose one of the menu items allows switching between
builtin and system/native window decorations.

Today, chrome/ozone/wayland crashes when building the menu because it tried to
read a preference only registered in use_x11: kUseCustomChromeFrame.

So this CL does two things:

- registers the preference [1] based on PlatformProperties in case of USE_OZONE.

- checks whether using system title bar[2] is supported by underlying ozone platform.
By default, ozone platforms have this feature disabled.

[1] kUseCustomChromeFrame
[2] IDC_USE_SYSTEM_TITLE_BAR

Based on tonikitoo@igalia.com's patch.

Bug: 578890, 849596
Change-Id: Ib05d2057f1193a9e41580d0133e35dff4bc2ea77
Reviewed-on: https://chromium-review.googlesource.com/1167045
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582087}

When building with jumbo the compiler sees two
operator==, declared in the files:
content/common/media/media_devices.h
content/browser/indexed_db/scopes/scopes_lock_manager.cc

Therefore, it throws an error. This commit solves the
issue by replacing the operator with a lamdba doing
the same operation.

Change-Id: I285a95a77ac55d2502d146316da12339de277fc9
Reviewed-on: https://chromium-review.googlesource.com/1169468
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582086}

This is a reland of bd08401c92882ed1c69503217a67b17274439621
(Note that the original CL is no longer in the tree; it landed during yesterday's
Gerrit outage and was reset out of existence. So this is the first time it has
"officially" landed in the tree.)

Original change's description:
> Disable some LayerTreeHostBlendingPixelTest on Linux, because flaky.
>
> Disable on Linux
>
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL_TextureRect
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersColorMatrixAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskAA_GL
> LayerTreeHostBlendingPixelTest.BlendingWithRenderPassColorMatrixAA_GL
>
> because flaky.
>
> TBR=ajuma@chromium.org
>
> Bug:872733
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I61a0b1cc99172da0437eec8f10149f0c46c966eb
> Reviewed-on: https://chromium-review.googlesource.com/1169204
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Commit-Queue: vitaliii <vitaliii@chromium.org>

TBR=ajuma@chromium.org

Bug: 872733
Change-Id: I044022d2db22b1cccb20692cf7300c3784ba2859
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1170543Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582085}

Bug: 821926
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie1a0d74985a7fb689ff0d47ba9404fd15803f0f8
Reviewed-on: https://chromium-review.googlesource.com/1158315Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#582084}

This CL adds code to PaintPropertyTreeBuilder to create transform node
for CSS object-fit. Currently only LayoutImage is supported.

BUG=854195

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If9002cae344c4a27c2c45cd8a7d9b94dda236861
Reviewed-on: https://chromium-review.googlesource.com/1168471
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582083}

This reverts commit 826c708a.

Reason for revert: This was speculatively reverted but wasn't the culprit.

Original change's description:
> Revert "Remove unnecessary NetworkService flag check in ResourceDispatcher"
> 
> This reverts commit 3d493dc6.
> 
> Reason for revert: FindIt blamed this CL with 85% confidence.
> 
> Sorry. I don't see anything wrong with this CL, but I also don't see
> anything wrong with any other CL in the blamelist, so I'm starting
> here. See https://crbug.com/873015 for analysis.
> 
> Original change's description:
> > Remove unnecessary NetworkService flag check in ResourceDispatcher
> > 
> > blink::ServiceWorkerUtils::IsServicificationEnabled() checks
> > whether NetworkService is enabled, so we don't need the check
> > in ResourceDispatcher::StartAsync().
> > 
> > Bug: N/A
> > Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1
> > Reviewed-on: https://chromium-review.googlesource.com/1168707
> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581828}
> 
> TBR=yhirano@chromium.org,bashi@chromium.org,shimazu@chromium.org
> 
> Change-Id: Ia89cf9c0523395c7b331482f39e708f283cbc3ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: N/A
> Reviewed-on: https://chromium-review.googlesource.com/1170402
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582023}

TBR=yhirano@chromium.org,bashi@chromium.org,mgiuca@chromium.org,shimazu@chromium.org

Change-Id: Ia3b4db0a6d9586d4febc3a16c1d6f8c987b124fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/1170622Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582082}

AppWindow has its own ImmersiveFullscreenController therefore it has to
do this by itself. (similar to CustomFrameViewAshWindowStateDelegate).

Bug: 869945
Test: covered by unit tests.
Change-Id: Ibbbd71441138ff4f8cabaae6c98d30a1fc0c954d
Reviewed-on: https://chromium-review.googlesource.com/1166254
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582081}

Bug: 855465
Change-Id: I1736e5d83494341e068e4aeffeea535d624f3dd4
Reviewed-on: https://chromium-review.googlesource.com/1168944Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Xunran Ding <xunran.ding@samsung.com>
Cr-Commit-Position: refs/heads/master@{#582080}