GitLab

I created a group for this item in r254287, but forgot to add it in
render_view_context_menu.cc.

BUG=348379
Test=Select some <text> in webpage, right click to see context menu,
  "Search Google for <text>" should appear in the list now.

Review URL: https://codereview.chromium.org/187923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255267 0039d316-1c4b-4281-b951-d872f2087c98

Removes extra left border from wrench menu buttons. This seems to have been broken in https://codereview.chromium.org/82113004.

BUG=349063
TEST=Visual inspection - see screenshots in the bug. The buttons should have rounded corners.

Review URL: https://codereview.chromium.org/185233017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349416,64887
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/188453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/187963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255264 0039d316-1c4b-4281-b951-d872f2087c98

This flag used to cause a crash on startup. As of Xcode 5 this doesn't
appear to happen anymore.

BUG=341484
TEST=None

Review URL: https://codereview.chromium.org/187823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255263 0039d316-1c4b-4281-b951-d872f2087c98

Modified chrome.bluetooth API code to use the new discovery session API for
device discovery.

BUG=346982
TEST=1. unit_tests, browser_tests
     2. Use multiple running extension instances with the bluetooth permission and check for the following behavior:
        - Only one session per extension. Calling chrome.bluetooth.stopDiscovery from one running app should fail if that app never called chrome.bluetooth.startDiscovery.
        - An app's discovery sessions should get cleaned up if that app crashes or unloads.
        - Use bt_console and run "power off". This should cause all discovery sessions that have been assigned to apps to get marked as inactive. Verify by requesting a new discovery session from apps, which should succeed.

Review URL: https://codereview.chromium.org/179123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346862

Review URL: https://codereview.chromium.org/181063036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348137
NOTRY=true

Review URL: https://codereview.chromium.org/186843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255258 0039d316-1c4b-4281-b951-d872f2087c98

The changes from login_unittest.py include:
* Removed testOobeLocalization since it's very specialized.
* Apply test.Enabled('chromeos')
* browser.Start() is no longer necessary.


BUG=NONE
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/183923029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/182283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332239, 338501
R=navabi@google.com

Review URL: https://codereview.chromium.org/184873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255230 0039d316-1c4b-4281-b951-d872f2087c98

This is upstreaming a Gentoo Linux patch.

BUG=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/184293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349628
TEST=gpu_unittests
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/183883026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349463

Review URL: https://codereview.chromium.org/187443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255227 0039d316-1c4b-4281-b951-d872f2087c98

The Blink-side change is here: https://codereview.chromium.org/180273020/

BUG=345839
NOTRY=true

Review URL: https://codereview.chromium.org/183743016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344589,341231
TEST=none
NOTRY=True

Review URL: https://codereview.chromium.org/181063034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255224 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/183793009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255223 0039d316-1c4b-4281-b951-d872f2087c98

This allows applications to draw to multiple render targets at the same time.

BUG=318019

Review URL: https://codereview.chromium.org/182213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349634
TBR=phoglund@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/180183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255219 0039d316-1c4b-4281-b951-d872f2087c98

Test is failing because FileManagerFileTasksComplexTest.FindFileHandlerTasks
doesn't initialize URL system request context. But URL fetch was started due
to misprint.

BUG=343589
TEST=unit_tests
NOTRY=true

Review URL: https://codereview.chromium.org/187603009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255218 0039d316-1c4b-4281-b951-d872f2087c98

What's removed:
 - The idea of unique_id's (these were for the now-gone webUI taskmanager).
 - The GetResourceExtension() method, which the tests no longer need.
 - The IsBackground getter, which is not used.

BUG=348836

Review URL: https://codereview.chromium.org/186153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227247

Review URL: https://codereview.chromium.org/178883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345598

Review URL: https://codereview.chromium.org/187653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110119

Review URL: https://codereview.chromium.org/178473022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/187593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260879

Review URL: https://codereview.chromium.org/28183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255208 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [AudioPlayer] Add test for opening another file from Files.app (https://codereview.chromium.org/177443006/)

Reason for revert:
This CL seems to be making OpenSpecialTypes/FileManagerBrowserTest.Test/5 timeout. See:

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20(2)

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%282%29/builds/55/steps/browser_tests/logs/Test_5

Original issue's description:
> [AudioPlayer] Add test for opening another file from Files.app
> 
> BUG=none
> TEST=manually
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255003

TBR=hirono@chromium.org,yoshiki@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/188253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255205 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255203 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168504:168526&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/187603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255202 0039d316-1c4b-4281-b951-d872f2087c98

has a browser action which it starts reading from storage on startup, but then
it's updated to a new version with no browser action before the callback comes
back.

A better way to fix it would be to block the update until the extension is
"started", but we need better infrastructure to do that.

BUG=349371

Review URL: https://codereview.chromium.org/187323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337526

Review URL: https://codereview.chromium.org/145923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255200 0039d316-1c4b-4281-b951-d872f2087c98

This argument is just used for an early out. Instead don't call the
method at all when it is true.

Depends on: https://codereview.chromium.org/183563003/

R=enne
BUG=344962

Review URL: https://codereview.chromium.org/187043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255199 0039d316-1c4b-4281-b951-d872f2087c98

crbug/349398: Disabled Widevine test license server on precise 32 bit.
crbug/349526: Disabled two failing tests on precise 64 bit.

BUG=349526,349398

Review URL: https://codereview.chromium.org/180733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255198 0039d316-1c4b-4281-b951-d872f2087c98

This makes "adding" an I/O thread easier (and usable when you already
have a test base class).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/187383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255196 0039d316-1c4b-4281-b951-d872f2087c98

This is only used in !NDEBUG builds, and making the variable only available
there makes it harder to break -Wunused-const-variable builds with custom
traits. Follow-up to r255159.

BUG=349521,307668
R=fischman@chromium.org

Review URL: https://codereview.chromium.org/187903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255194 0039d316-1c4b-4281-b951-d872f2087c98

These are unit tests so they should be in the unit_tests target. A
TODO says this did not work before, but they appear to pass as unit
tests now, so this is just a code move.

R=sky
BUG=270918

Review URL: https://codereview.chromium.org/186063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual
TRYBOT=None

Review URL: https://codereview.chromium.org/180723017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255191 0039d316-1c4b-4281-b951-d872f2087c98

Move the ContentGestureProvider to ui/, allowing the filtering and gesture
batching code to be used outside of content/.  Also eliminate
TouchDispositionGestureFilter's dependency on a custom ack result type,
instead simply using a bool to indicate whether or not the ack'ed touch was
consumed.

BUG=348588

Review URL: https://codereview.chromium.org/182383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255190 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/188133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255189 0039d316-1c4b-4281-b951-d872f2087c98