- 16 Oct, 2019 40 commits
-
-
Hiroki Nakagawa authored
Bug: 1014812 Change-Id: Id1ce9a48778fa71e188a35bc24d6191cb583e19d Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864752Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#706334}
-
Gyuyoung Kim authored
OnMediaRemoterCreated has still been using old Mojo types. This CL applies pending_remote and pending_receiver to the function. Bug: 955171 Change-Id: Iefbf6465dfd43940f4f0a9c46c28a1f4f2012ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829633Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#706333}
-
Juan Antonio Navarro Pérez authored
This reverts commit 37d44dbb. Reason for revert: Catapult roller failing with: AttributeError: type object 'StoryFilterFactory' has no attribute '_expectations' https://chromium-swarm.appspot.com/task?id=47eb08c183837510 Original change's description: > [Benchmarks] Smoke tests lay groundwork for move to story_filter. > > This change > https://chromium-review.googlesource.com/c/catapult/+/1839176 > makes it so that expectations config is passed to story_filter.py > using the project config (sometimes referred to as the > "environment"). This change lays the groundwork for that future > change. Until that change is committed, this is a no-op change. > > This change first requires this catapult-side change > https://chromium-review.googlesource.com/c/catapult/+/1854882 > to make sure that we don't pass an invalid argument to > GetRunOptions(). > > > Bug: 985103 > Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706080} TBR=perezju@chromium.org,crouleau@chromium.org,rmhasan@google.com Change-Id: I9cdcf778d4feaa3ab4d1dd1bd5385b53e99e4f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864671Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706332}
-
Hiroki Nakagawa authored
Bug: 1014810 Change-Id: I1fb23439d996e8142353a05f6cc18c07ea3d0095 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863068Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I654114143b038a86cc813bd5ce57508260abed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706330}
-
Samuel Huang authored
Previously, DevUI DFM installation used BrowserURLHandler to modify DevUI URLs to chrome://dev-ui-loader, whose host performs DFM install flow by calling C++ API via JavaScript. On install success, the page forwards to the original DevUI URL. A flaw of the old flow was that it allows for URL "laundering", where a compromised chrome:// page may use chrome://dev-ui-loader's ?url= query param to access another chrome:// page, thereby bypassing potential restrictions (e.g., referrer or origin). Another problem is that BrowserURLHandler does not run when a webpage is restored on Chrome restart. This causes crbug.com/1013522, where DevUI pages fail to load because resource load was not triggered. This CL uses NavigationThrottle to re-implement the DevUI DFM install flow as DevUiNavigationThrottle. This solves the above problems, and is simpler. Additional changes: * Add i18n support to the install error page messages. * Add extensive unit tests for DevUiNavigationThrottle. Bug: 927131,987040,1013522 Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#706329}
-
Julie Jeongeun Kim authored
This CL converts Model from model.mojom to new Mojo types using PendingReceiver, ReceiverSet, and Remote. Bug: 955171 Change-Id: Ie0ac1f426d46d8efe22bdb52c99d6c8e43051efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851367Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#706328}
-
Julie Jeongeun Kim authored
This CL converts ProxyConfigPollerClient and ProxyErrorClient from proxy_config_with_annotation.mojom to new Mojo types using PendingRemote, PendingReceiver, and Receiver. Bug: 955171 Change-Id: I3a877c85a6b0f7ec64beee91d56062e6de42bad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851985 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#706327}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/634d15032d37..2b3a883db586 git log 634d15032d37..2b3a883db586 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a27dfcf868bf..9097eeb5359b (2 commits) Created with: gclient setdep -r src/third_party/skia@2b3a883db586 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None Change-Id: I8c09ebdd682d7b8eb5e3fdb91d28faa46e8e6ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864437Reviewed-by:
-
Alexey Baskakov authored
To avoid confusion with PendingAppManager's placeholder app. Bug: 860583 Change-Id: Ibd48d2114225b62b813e64aa2d563217929d9903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864494 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2615b7727cb..810ee9415435 git log c2615b7727cb..810ee9415435 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 cjmcdonald@chromium.org Return narrower & smarter paths for dependency service Created with: gclient setdep -r src/third_party/chromite@810ee9415435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic24937cfde274aa908def3db27fcfcd8d051455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864550Reviewed-by:
-
Yoshifumi Inoue authored
This patch change |LayoutText::CollectLineBoxRects()| to utilize |NGInlineCursor| instead of |NGInlineFragmentTraversal::SelfFragmentsOf()| as preparation of migrating to |NGFragmentItem|. This patch also makes |NGInlineCursor::MoveTo()| to work during layout to use previous layout result for scroll anchoring. Bug: 982194 Change-Id: I9f046540ab797f274b88072f26bb241e101175d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855152 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706323}
-
Daniel Rubery authored
These files should still be blocked, but the current UX only shows "Failed - Blocked". We would like to provide a little context to the user about the reason for the blocking. Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0 Screenshots: https://screenshot.googleplex.com/eQvXRqtcGOJ.png https://screenshot.googleplex.com/JM7yHFkcBnc.png Bug: 980777 Change-Id: Ib097d0137d39383f66299fe891c710de693c828a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859579 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706322}
-
Wanming Lin authored
Following Web NFC spec change at https://github.com/w3c/web-nfc/pull/383, this CL adds a test to check NFC scanning from top-level document will not be stopped when an iframe is focused Bug: 996250, 520391 Change-Id: If89079d7bf9d7dc58587abcd0c9a9a797420aa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862475Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#706321}
-
Austin Tankiang authored
Paper ripples need an ancestor with style `position: relative` in order for the ripple to not escape. Bug: 1014819 Change-Id: I1f07fb769a47c573bafebf96172d5e2cfe309b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863058 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706320}
-
Chase Phillips authored
* Update README.md with notes about where data model items are stored (db, disk/mem cache) * Update comment to point to HandleResourceFetchCompleted * Update section pointers for update spec items At some point, the AppCache spec gained a new section such that "6.9.4" became "7.9.4". This updates any "6.9.4" entries to "7.9.4". In at least one place, there were other spec changes so that the update steps within 7.9.4 also changed. I've tried to map them to the correct update step as best I could. * Update spec pointers for 6.9.5/6.9.6 to 7.9.5/7.9.6 Bug: 1014587 Change-Id: I0a787bd1eae6f5ffbc84dff225d863e8dc80ffc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862124 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706319}
-
Yoshifumi Inoue authored
This reverts commit ff8a70bd. Reason for revert: Causes use-after-free in issue 1013490 Original change's description: > Make hit test on culled inline faster > > This patch changes |LayoutInlineCollector| to use |IsDescendantOf()| instead of > using |HashSet<T>| to make |SelftFragmentsOf()|, which is used by hit testing > and others, faster. > > I found the slowness of |LayoutInlineCollector| by CPU profiling[1] where > |HashSet<T>::insert()| consumes most of time. > > So, it seems traversing fragment tree + LayoutObject::IsDescendnatOf()| is > faster than two times of traversing fragment tree + |HashSet<T>::insert()|. > > > [1] https://bit.ly/2pXQbcE > > Bug: 1008523 > Change-Id: I825197f2b85fd2ef573e8ff159ddf966489361be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847602 > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704102} TBR=yosin@chromium.org,eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008523, 1013490 Change-Id: Ie8b3757a3ce8ad5e2499195fef1f3cb48fbd8cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864491 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706318}
-
Manu Cornet authored
Rely on existing mechanisms to figure out the app list visibility, instead of maintaining a local boolean prone to get out of sync with the actual state. Remove extraneous test statements (they duplicate the calls to the "app list test helper" to check the same thing). Change-Id: If6385fae0ccec004a2afba9479abad452ecbdde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860838 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706317}
-
Jay Harris authored
Previously, hopping between threads had to be done manually at the call site of CreatePlatformShortcuts. This pushes this implementation detail down to the web_app_shortcuts layer, paving the way for shortcut creation from the AppShortcutManager. Bug: 860581 Change-Id: I6efca0f2f1fd08da1c27765ff82ff0b38f1b221d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862877 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f91a46b0230..25741699ee0e Created with: gclient setdep -r src-internal@25741699ee0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I03483f962d5cd45a0b0d261100cdc32733cb318e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864509Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706315}
-
Miyoung Shin authored
This CL converts CameraAppDeviceProviderRequest and CameraAppHelperRequest in media to the new Mojo type. Bug: 955171 Change-Id: Ifdd02ad052b50879ca54556b0f3cf1a7e8596f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862446Reviewed-by:
-
Miyoung Shin authored
This CL converts WiFiDisplaySessionService{Ptr, Request} in extensions to the new Mojo type. Bug: 955171 Change-Id: I5eba79faacfb08a099feeca4d003270f21c5364a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862456Reviewed-by: -
Wei Lee authored
Bug: 1004482, 1004483, 1004484 Test: None Change-Id: If0e1b037ab542e211ea5b9d2db37d9867a03779c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860857Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706312}
-
Nicolas Arciniega authored
When running the traffic annotation auditor with the python extractor and either the --all-files option or --no-filtering option turned on, the auditor ignores any path filters when running the extractor since the python extractor is quite fast. Later, if there are any path filters the auditor will attempt to fill in any missing, un-audited annotations from the annotations.xml so that we don't report that those annotations have been removed. In the case of the python extractor, we'd be adding multiple copies of the same annotations into our list of extracted annotations. The result is that the auditor will complain about duplicate annotations. This change fixes the issue by keeping track of whether or not we decided to ignore existing |path_filters| in favor of following the --all-files or --no-filtering flags. Bug: 1005537 Change-Id: Icda9bb469bf4a8f90d099a53c79d3154f68b12fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853853Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#706311}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8cde4063d097..9097eeb5359b git log 8cde4063d097..9097eeb5359b --date=short --no-merges --format='%ad %ae %s' 2019-10-16 sugoi@google.com Workaround a compiler issue Created with: gclient setdep -r src/third_party/swiftshader@9097eeb5359b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1013375 Change-Id: I444959f7d1b8be0e4a5dacb523a4ec1c86b7a9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864449Reviewed-by:
-
Takashi Toyoshima authored
services/network/public/cpp/cors/cors.cc contains several test parsing code. These all are in an inner anonymous namespace, but can be accessible via IsCorsSafelistedHeader interface with some specific arguments. This patch adds fuzzing tests for the interface and call it with several header names so that it covers all parsing functions. Bug: 1007883 Change-Id: I9440a34d57aedb265a4f09a3445d9edc55270d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855627 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706309}
-
Alex Danilo authored
Bug: 980452 Change-Id: I5a60f59b64f290513bb2dfc2aa7d9e2a34471495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864489 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#706308}
-
Kent Tamura authored
DOM mutation doesn't affect DocumentLifecycle. If it was kLayoutClean before UpdateType(), it's still kLayoutClean in Document::UpdateFocusAppearanceAfterLayout(). What we'd like to ensure in UpdateType() is no synchronous style recalc or layout. So this CL adds |DocumentLifecycle:: DisallowTransitionScope()|. Bug: 1009806 Change-Id: I0ad30908e76a9084ba8d685285e613a7194c02fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861436Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1007760, 1007685 Change-Id: Iba9be2981b042593327e9ca5bf862c263f4f6ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849531 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706306}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34c175bd. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." e547ca2c "[CSS] Add test to to ensure that ::part overrides inline-style." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Id2314b6fc5d2092ad2533ebb5eb84e057c6fc932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863441Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706305}
-
Marina Sakai authored
Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty. So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter. This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties. Bug: 715418 Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac6afeb999e9..c2615b7727cb git log ac6afeb999e9..c2615b7727cb --date=short --no-merges --format='%ad %ae %s' 2019-10-16 mmortensen@google.com Add determine_chrome_version to GetTargetVersions. Created with: gclient setdep -r src/third_party/chromite@c2615b7727cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I046ec654cc15fcee3959822de87338d9bc5ea888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864329Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ecd11dd1..480cfc4a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I050a170d087667721d661f9a02243de8482f426f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863440Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706302}
-
Takashi Toyoshima authored
This patch introduces two enterprise policies, one is kCorsLegacyModeEnabled, and the other is kCorsMitigationList. kCorsLegacyModeEnabled disbles OOR-CORS feature completely, and uses the legacy Blink CORS instead. The policy can not be dynamically modified, and a consistent value is managed by per-profile instance in the browser process. Call sites in the browser process checks the OOR-CORS mode via BrowserContext, and if the actual instance inherits Profile class, it counts in the policy. If call sites do not have a corresponding BrowserContext, it directly checks base::FeatureList. Call sites in the renderer processes are managed via a command line flag. The browser process properly sets the flag based on the OOR-CORS mode that is checked by the steps described above. Call sites in the network process should ask the relevant NetworkContext. Each NetworkContext should initialize the OOR-CORS mode based on the NetworkContextParams that should be properly set by the browser process. If the constructor that does not have the NetworkContextParams argument is called, base::FeatureList is directly checked to initialize the mode. Thus, all components for chromium can use a consistent CORS mode during each profile session. kCorsMitigationList still activate the OOR-CORS as long as the feature is not disabled for other reasons. But it adopts compatibility mitigation to mimic the legacy behavior. E.g., it enforces all Extensions to call webRequest API with "extraHeaders" option, and specified header names are assumed as CORS-safelisted so that it does not trigger CORS preflights. Bug: 1000977, 1000984, 1000982 Change-Id: I4166e26405482e479c895db639bb73a4388fc0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830253Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Daniel Rubery authored
Per the documentation, these should only apply to files selected for deep scanning. The current implementation, however, applies these restrictions to all downloads. Bug: 980777 Change-Id: I62e80d590def15e19d2ba1740356390a757ae628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849415 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#706300}
-
Charles Zhao authored
FileOpening and UrlVisiting is observed inside SearchResultRanker as a quick fix. Since the CrOSActionRecorder is disabled by default, and it's constructor is relatively trivial. This will not be a problem. Bug: 1012936 Change-Id: I42c32b2b622881ddaa802dc31e9afcae8f1c2e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862881 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706299}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/120275e84dca..8f91a46b0230 Created with: gclient setdep -r src-internal@8f91a46b0230 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iabdcad8844a8b57f8905b2cc9777fe77c93a79fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864270Reviewed-by:
-
Alexandre Courbot authored
This is a reland of 61ae3ddf. Changes: check that backend_ is not nullptr before using it in places where this can happen. Original change's description: > There are two V4L2 decode APIs: stateless and stateful. In the VDA era > these were implemented as two completely separate classes > (V4L2VideoDecodeAccelerator and V4L2SliceVideoDecodeAccelerator), which > resulted in a lot of duplicated code and bugs due to fixes not being > replicated on both classes. > > For the VD-based decoder, we want to avoid doing the same error and > use a single V4L2 decoder, supported by different backends depending on > which V4L2 API we are using. > > This CL is the first step towards that direction: it splits the > V4L2SliceVideoDecoder into its general V4L2 part and the one that is > specific to the stateless API. > > Bug: 1003223 > Test: video_decode_accelerator_tests passing on Kevin. > > Change-Id: I373f3ea739b6799ecad009d053ca7e415b8484bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840034 > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705894} Bug: 1014756 Test: video_decode_accelerator_tests passing on Kevin. Change-Id: I5ec23f64faf0e309f26f973ce7fa3f81eb05d60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863053Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706297}
-
Manu Cornet authored
Bug: 1012353, 1006013, 1009716 Change-Id: Ib056dc7c7dcf38e54b83cb3e0ffcd3461e4c1b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863672 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Renjie Tang authored
Change-Id: I8ffb26d392a312e18a7b5982b02337a1120fd7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859639 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706295}
-
