- 18 Jul, 2017 28 commits
-
-
John Abd-El-Malek authored
I missed this in r486111 BUG=736375 Change-Id: I26b4381945063f7216bab29412bfe0df1c3d95a9 Reviewed-on: https://chromium-review.googlesource.com/575393 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487321}
-
Dmitry Gozman authored
BUG=734762 Change-Id: I679f42eec506a033b9ab53799db4043f57a52293 Reviewed-on: https://chromium-review.googlesource.com/572328 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487320}
-
xdai authored
It's a regression caused by https://codereview.chromium.org/2979903003/. We need to make sure newPrinter is not a null object when automatically switch from auto-discovery dialog to manual-add-printer dialog. Bug: 744551 Change-Id: If535c64aa2bb716e3f8e813852b556f6f6f8f796 Reviewed-on: https://chromium-review.googlesource.com/575381Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#487319}
-
Justin Schuh authored
Creates a fast runtime path for checked and clamped absolute value. Change-Id: Ibabc3cd8d4eda0a44703d3197d03bba7c746ba11 Reviewed-on: https://chromium-review.googlesource.com/573529Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#487318}
-
Alexei Filippov authored
This reverts commit cb4af30e. Reason for revert: Broke ChromeOS build. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/61952 Original change's description: > cros: Eliminate the ash::test namespace > > We are inconsistent in our usage of this namespace. We mostly use it > for test support code, but not always. We sometimes wrap tests in it, > but not always. > > After discussion with top-level ash OWNERS we're going to eliminate > the namespace entirely. This is more consistent with unittest.cc > files in the rest of Chrome. > > TBR=reveman@chromium.org > > Bug: none > Test: compiles, ash_unittests, chrome unit_tests > Change-Id: I5afb42abcd06acab673ac1b459cfe071018f4400 > Reviewed-on: https://chromium-review.googlesource.com/573324 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487299} TBR=derat@chromium.org,jamescook@chromium.org,sky@chromium.org Change-Id: Iffa518b0f95c9f889af59fe94ccf98063b3aac71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/574698Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487317}
-
ananta authored
This patch changes the insets and control spacing and the match count text We space the controls in the find bar using margins to ensure that the distances are computed to the vector image glyphs and not to the border. Next steps would be to tackle the rest of the items in this dialog for harmony BUG=651643 TBR=blundell Review-Url: https://codereview.chromium.org/2968713003 Cr-Commit-Position: refs/heads/master@{#487316}
-
Robert Kroeger authored
Add struct_traits for OverlaySurfaceCandidate to enable mojo IPC in ozone. BUG=620927 Change-Id: I16a6058f6ef411ab7acfeedc8ba35d080baed674 Reviewed-on: https://chromium-review.googlesource.com/571980 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487315}
-
Wez authored
The Fuchsia FileDescriptorWatcher attempted to cancel the wait operation on deletion, failing if the pump was already deleted because the underlying wait port was no longer valid. FileDescriptorWatcher now access the wait port handle via a WeakPtr to the associated MessagePumpFuchsia, allowing it to skip cancelling the operation in this case. Bug: 738275 Change-Id: Icd2a8811219de182c9c9a3208224e46a9ce1d186 Reviewed-on: https://chromium-review.googlesource.com/575291 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487314}
-
xdai authored
Bug: 725999 Change-Id: I78948e0d82f88a4303877788ddf7db7df60e3654 Reviewed-on: https://chromium-review.googlesource.com/570808 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487313}
-
Kyle Horimoto authored
[CrOS Tether] Show the "connection to host failed" notification when a Tether connection attempt fails. The notification is removed when it is clicked or when a new connection attempt is started. Bug: 672263, 734241 Change-Id: I985554345796b953c166024e4bcddf141703591f Reviewed-on: https://chromium-review.googlesource.com/575526Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487312}
-
Scott Haseley authored
This CL creates a separate class that is in charge of recording UMAs on behalf of TabManager for tab and system-related properties and events during session restore and background tab loading. The RecordSwitchTo metric method has been moved out of TabManager and into TabManagerStatsCollector. In this implementation, the TabManagerStatsCollector is scoped to the lifetime and owned by the TabManager, and the TabManagerStatsCollector holds a pointer to the TabManager. Bug: 740625 Change-Id: Ic3c77d5d99563ceefedab3d417721a7624d02ffe Reviewed-on: https://chromium-review.googlesource.com/565353Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#487311}
-
Ashley Enstad authored
This change enables perf_data_generator to upload results from a list of benchmarks to the flakiness dashboard. BUG=chromium:717394 Change-Id: I3952887c527c40fb5d061e9ee8aa4875794075c7 Reviewed-on: https://chromium-review.googlesource.com/574687 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#487310}
-
erikchen authored
Due to a clang bug, adding the API_AVAILABLE annotation also changes the visibility to be "default". This causes an unintentional leak of global-visibility symbols. Explicitly re-specify "hidden" visibility to work around this. https://bugs.llvm.org/show_bug.cgi?id=33796 Bug: 669240 Change-Id: I1118de5ddb6035402f8b787cece33e0bb040ff15 TBR: reillyg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/574683 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487309}
-
Scott Nichols authored
+ adds a wrapper around defaults and makes this a singleton. + Creates a new settings object to save settings in. + Serializes the settings to and from defaults. Change-Id: I8e4aaed4c38fd02ca8a71b410c6d441e17da72b6 Reviewed-on: https://chromium-review.googlesource.com/574888 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#487308}
-
Chris Harrelson authored
Bug: 744204 Change-Id: I3a0bea65287c1b724ac0576dd7d03486789c2f96 Reviewed-on: https://chromium-review.googlesource.com/575205 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487307}
-
Sergey Volk authored
We had a bug where FFmpegDemuxer usage was too high due to excessive buffering caused by not taking into account enabled/disabled stream status. This unit test should provide test coverage for that. BUG=740138 Change-Id: Ia29175a8c90be4465aeffe189d7d8e48e738ef68 Reviewed-on: https://chromium-review.googlesource.com/575390Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#487306}
-
Nate Fischer authored
This adds three hardcoded URLs as part of the chrome://safe-browsing/ domain: * chrome://safe-browsing/match?type=malware * chrome://safe-browsing/match?type=phishing * chrome://safe-browsing/match?type=unwanted These URLs will be needed by WebView for CTS testing the various Safe Browsing APIs. Bug: 709626 Test: browser_tests --gtest_filter=SafeBrowsingBlockingPage*HardcodedUrls* Change-Id: I56d6557e6474feda6b036f04aa39a8ad92dcc4d1 Reviewed-on: https://chromium-review.googlesource.com/572765Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487305}
-
Jeff Carpenter authored
When .any.js and .worker.js files are seen during MANIFEST generation they are mapped to .any.html, .any.worker.html, and .worker.html files as appropriate which WPTServe will generate on-the-fly. This allows for easy testing of [Exposed=(Window,Worker)] APIs and tests that are simply script with no boilerplate HTML. These are now supported in run-webkit-tests. When specifying tests to run, the source name should be specified, for example: $ run-webkit-test external/wpt/storage/interfaces.worker.js But expectations will use the generated name, e.g.: external/wpt/storage/interfaces.worker-expected.txt And failures will be reported under the generated name: external/wpt/storage/interfaces.worker.html This change is based on jsbell's crrev.com/2767673002. Bug: 703837 Change-Id: I063b18f44e0460932c3fe8114420a327f1b1e088 Reviewed-on: https://chromium-review.googlesource.com/574645 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#487304}
-
Mounir Lamouri authored
Bug: None Change-Id: I783dd4dca9928874fbfa97481404595b7dc6253a Reviewed-on: https://chromium-review.googlesource.com/571749 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#487303}
-
Alexei Svitkine authored
The previous CL https://chromium-review.googlesource.com/570458 added a CHECK, but the messages are not preserved in production builds. This adds the same info to a crash key, so we can get info from the wild. BUG=736675,744734 Change-Id: I97106eec9a6f4a4f2ab00d2a28e23f891ebe5e50 Reviewed-on: https://chromium-review.googlesource.com/575188 Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487302}
-
Andrew Grieve authored
It was forgetting to pass in dex_files. Also adds in explicit calls to pFinish(), which according to the docs should be necessary (although they don't seem to be). BUG=674250 Change-Id: Iefab37b1ef77413f54d2b6e036700cdbb8bf361d Reviewed-on: https://chromium-review.googlesource.com/575329Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487301}
-
Jared Saul authored
Bug: Change-Id: Ib144cc6e0e13329aa346bf9bef4e272c06d2a06e Reviewed-on: https://chromium-review.googlesource.com/569076 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487300}
-
James Cook authored
We are inconsistent in our usage of this namespace. We mostly use it for test support code, but not always. We sometimes wrap tests in it, but not always. After discussion with top-level ash OWNERS we're going to eliminate the namespace entirely. This is more consistent with unittest.cc files in the rest of Chrome. TBR=reveman@chromium.org Bug: none Test: compiles, ash_unittests, chrome unit_tests Change-Id: I5afb42abcd06acab673ac1b459cfe071018f4400 Reviewed-on: https://chromium-review.googlesource.com/573324Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#487299}
-
Daniel Erat authored
Let the user remap the Caps Lock key when --has-chromeos-keyboard isn't provided (i.e. the internal keyboard has a Caps Lock key in place of Search). Formerly, the setting was only shown when an external keyboard was connected. Also add unit tests for KeyboardHandler and delete some unused variables. Unrelatedly, drop an accidentally-repeated call in PowerHandlerTest. BUG=742613 Change-Id: I56d7ccb0bd5e054b9e815fb4d8d457c0729ada0c Reviewed-on: https://chromium-review.googlesource.com/572209Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#487298}
-
Scott Violet authored
At the time I wrote SetMousePointerDisplayLocation() it was assumed SetMousePointerDisplayLocation() was called right after Reset(), which meant pointer_targets_ was empty. Now that SetMousePointerDisplayLocation() may be called by client code, that assumption is no longer valid and the DCHECK is out date. BUG=744923 TEST=none Change-Id: I19af55eab935bc05aa025839bd0a297ad585ea32 Reviewed-on: https://chromium-review.googlesource.com/574677Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487297}
-
Darren Shen authored
Currently, when we wish to combine several strings together to form the name for a class or data member for example, we have to use join_name, which would combine the strings correctly in a space separated format, followed by something like class_member_name that formats the result into the correct style. This patch allows things like class_member_name to take a list of names, and join_name internally. This does not change behaviour. Bug: 628043 Change-Id: Iae966e45b9dc80a14bb57cf477af580fb64c85fc Reviewed-on: https://chromium-review.googlesource.com/532676Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#487296}
-
Fady Samuel authored
FrameSinkManager is responsible for creating and updating the FrameSink hierarchy to allow propagation of BeginFrames across CompositorFrameSink. This CL removes some publicly exposed methods on FrameSinkManager that simply forward operations along to SurfaceManager. This takes us one step closer toward merging mojom::FrameSinkManager and viz::FrameSinkManager together. Bug: 722935 Change-Id: Ibb4b5b174a56e138add1ba44b32919ff9ad4ec52 Reviewed-on: https://chromium-review.googlesource.com/574878 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487295}
-
Kent Tamura authored
Bug: 742692 Change-Id: I3a64ed5870d6a1769bfccab353ad261ce24de17d Reviewed-on: https://chromium-review.googlesource.com/571521Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#487294}
-
- 17 Jul, 2017 12 commits
-
-
Lei Zhang authored
Many cases are else after returns. A few are converted to early returns. Change-Id: If6c8df0f182113c0d1d5710bd8369209ed477a1f Reviewed-on: https://chromium-review.googlesource.com/571162Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#487293}
-
Justin Carlson authored
Also rename factory class. This is in preparation for subsuming some of this functionality into a higher level printers manager. BUG=742487 Change-Id: I4929a4faa6bbdade248c9bdb710a3b53d8ebb262 Reviewed-on: https://chromium-review.googlesource.com/569849Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487292}
-
Devlin Cronin authored
Move ownership of the ICPMessageSender to the bindings system. This internalizes a bit more of the logic into the ExtensionBindingsSystem, and moves a bit more out of the overly-busy Dispatcher classes. Bug: 653596 Change-Id: I321afadb64c8351ca95cb0953a0148c71ad7f005 Reviewed-on: https://chromium-review.googlesource.com/570932 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487291}
-
Marijn Kruisselbrink authored
Also turn on the BlobStorageBrowserTest for the new mojo implementation now that transportation mostly works. This required a couple of minor other changes: - Adding BlobRegistry to the browser process' manifest - Turning off some BlobDispatcherHost IsInUseInProcess checks. These checks don't really make sense anyway when it will become possible to transfer blobs between renderers directly, and this never was a security boundary anyway, so removing the check shouldn't hurt. Bug: 611935 Change-Id: If8bfc2d8351aecc72a3818d0cbb013a55efc6175 Reviewed-on: https://chromium-review.googlesource.com/558192Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#487290}
-
Scott Chen authored
This allows WebUI sections outside of settings/ to reuse the same styles. Bug: 740758 Change-Id: Iefbdff0b219a3ced28b02098a0f05bbe25f83357 Reviewed-on: https://chromium-review.googlesource.com/571189 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487289}
-
Joshua Bell authored
The 'replacement' encoding originated as a spec concept to prevent security attacks via problematic encodings by recognizing the label but not decoding the stream. It was initially specified as the only encoding where the name wasn't one of the labels, requiring special cases in all implementations. Based on more implementer feedback we'd like to remove the special case. Delete the special case code in Blink too. See also: https://github.com/whatwg/encoding/issues/70 Bug: 744405 Change-Id: Ia15ccef1a9d7f35c23af4509a5a9758cbefc2087 Reviewed-on: https://chromium-review.googlesource.com/559973Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#487288}
-
scroggo authored
This method actually returns whether the encoded data for the frame at |index| has been fully received. (Prior to crrev.com/2879123003, the behavior was different for single-frame images versus multi-frame images. Now both return whether the frame is received.) Rename the method to better reflect its use, and avoid confusion in the future. No change in behavior, no new tests. Bug: 722168 Review-Url: https://codereview.chromium.org/2982083002 Cr-Commit-Position: refs/heads/master@{#487287}
-
Findit authored
This reverts commit 7ae6f9f5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 487250 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdhZTZmOWY1MGYyM2VlOGY1MDA3YTg1MGNkY2NiNmYwODNlYzY0MTgM Sample Build: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/89626 Original change's description: > Adjust the bounds in opened search box > > Changes: > 1. Adjust the height of SearchResultTileItemView based on spec: > https://screenshot.googleplex.com/AFQ5HnrMYch > 2. Adjust the height of SearchBoxView based on spec: > https://screenshot.googleplex.com/bGiXTCBUhdX > 3. Adjust the width and height of SearchResultPageView based on spec: > https://screenshot.googleplex.com/ykfwoEeMPTr > > Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ > > BUG=742699 > > Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1 > Reviewed-on: https://chromium-review.googlesource.com/572365 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487250} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=742699 Change-Id: Id9ba9992566802461da8d3c055b6f052d0f69056 Reviewed-on: https://chromium-review.googlesource.com/575358Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487286}
-
Alexei Filippov authored
Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-006a.html as flaky NOTRY=true Bug: 736319 Change-Id: Ic6cd1b422ceb23774bbd65083919560795ce4799 TBR: rogerta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/575384Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487285}
-
Anna Maria authored
Bug: 721802 Change-Id: I592898445b73c36ed4744f7025e4613843b0c586 Reviewed-on: https://chromium-review.googlesource.com/570490 Commit-Queue: Anna Maria <paezagon@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487284}
-
Luke Zielinski authored
Change-Id: I42739f8f13a24efc48268b503bae8f167167d603 Reviewed-on: https://chromium-review.googlesource.com/571419 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#487283}
-
Kyle Horimoto authored
Previously, if a Tether connection was active and the browser crashed, the UI would start back up and show the device connected to the raw Wi-Fi network instead of the special Tether network; furthermore, all host scan results were gone and the device would not continue to send KeepAliveTickle messages to the active host, resulting in the phone's hotspot shutting down automatically. This CL creates a class which is run at the end of initialization of the Tether module, before a host scan begins. If it detects that there was saved active host data in persistent storage, it knows that the last session ended due to a crash since persistent active host data is cleared under the normal shutdown flow. If this is the case, CrashRecoveryManager restores the connection. Bug: 672263, 737273 Change-Id: Id51967e20855edb086285f5bfdb92c4677bee77c Reviewed-on: https://chromium-review.googlesource.com/572840 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487282}
-