- 07 May, 2020 40 commits
-
-
James Cook authored
I'm trying to disable SplitSettingsSync on trunk and hitting a test failure. The CL below accidentally changed the pre-SplitSettingsSync sync consent screen to say "Chrome browser sync" instead of just "Chrome sync". https://chromium-review.googlesource.com/c/chromium/src/+/2154601 Change the original string back to "Chrome sync", introduce a new string "Chrome browser sync", and update the browser test expectations so the tests pass both with and without SplitSettingsSync enabled. Bug: 1013466 Change-Id: I146c7a1c783146e11207aa6a80c011a42bde4e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186459 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#766432}
-
Philipp Hancke authored
merges the simulcast getStats test into a single test. Waiting for simulcast ramp-up twice takes too long and is flaky BUG=chromium:1077194 Change-Id: I42c11ccc76c5cf52fc3a7596a5a13cdaf3817623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187374 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#766431}
-
Benoit Lize authored
We are seeing more DetachedResourceRequest errors in M81. This is assumed to be due to some NETWORK_CHANGED errors now being reported as NAME_NOT_RESOLVED. To mitigate that, retry for NAME_NOT_RESOLVED errors as well. Bug: 1078350 Change-Id: Ib3cc36270f580b7679bdcc49379022213a4fd746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187315Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#766430}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1058fc52fff1..8ce113cb322d git log 1058fc52fff1..8ce113cb322d --date=short --first-parent --format='%ad %ae %s' 2020-05-07 morlovich@chromium.org Emulate UA client hints for bundled emulation configs. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8ce113cb322d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1031511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5432c063b0042e8a37e824caf57bfd2d107333f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766429}
-
Daniel Rubery authored
This CL imports the portion of OpenCV needed to use its EMD implementation. This API will be fuzzed (see https://crrev.com/c/2166582), and is intended to run only in the renderer process. Bug: 1068616 Change-Id: I16cd87b493290dc83f85c6b78a1c02b89ae53b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163432Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#766428}
-
Stephan Hartmann authored
This is required for gcc-10. Change-Id: I6659a14f885011941887702171f6e49b8740f049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174486Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#766427}
-
Jeff Yoon authored
As part of the PGO effort, migrating isolate_coverage_data to isolate_profile_data. part 2 of the migration: * migrating all definitions of isolate_coverage_data to isolate_profile_data Bug: 1075823 Change-Id: I346e031f90b1f94e260629e0d1fcac93cf6df214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185417 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#766426}
-
Juanmi Huertas authored
It is not needed to try and use the SharedImageProvider as currently the CanvasResourceProvider::Create method will instantly fall into the SharedBitmapProvider fallback or BitmapProvider fallback. This CL removes the SoftwareCompositedUsage and replaces it with both fallbacks. This CL also adds the CreateSharedBitmapProvider. Bug: 1035589 Change-Id: I2cc0b23c1a40c15285ccdbba06840a0f98ff1b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118573Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#766425}
-
Ioana Pandele authored
This ensures that data is refetched from the store so that cloning the form manager doesn't result in stale data overwriting recent data in the CredentialCache. Bug: 1044930 Change-Id: I9e03b0c6732439d47cceccf55a317ee6921fbdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187710 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766424}
-
Clemens Arbesser authored
This change ensures that values that derive from client_side_only values are also client_side_only, such that neither the value itself nor values derived from it can be sent to the backend. Since the only way to derive values is via a ComputeValue interaction, the additional complexity seems to be manageable. We may have to consider refactoring in the future if there are other ways of deriving values. This CL also removes some unused code in value_util. Bug: b/145043394 Change-Id: Ida9642903b3ef5bd938930163dd422250eb657bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184270 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#766423}
-
Marc Treib authored
On desktop, the Wallet account storage uses a special "in-memory" path to avoid writing the database to disk. On mobile (where this isn't launched yet), it should instead write to a file normally. So this CL introduces a new filename "Account Web Data" (in addition to the existing "Web Data"), to be used for the account-scoped storage on mobile only. Bug: 1078809 Change-Id: Iea12afdb2e51d8e14313b631e94a5e8966ac2644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030770 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#766422}
-
Patrick Noland authored
With this CL, these suppliers are created at the ChromeActivity level and injected where they're needed, i.e. RootUICoordinator and AppMenuPropertiesDelegate. This lets us remove getBookmarkBridge and getBookmarkBridgeSupplier as well as simplify setCurrentProfile. Bug: 865801 Change-Id: Id8ccdac76c14e29582aaf6d54b023bac739f174f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171321 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#766421}
-
Mikel Astiz authored
This removes function StartAssociating() which is a no-op for all existing controllers (based on ModelTypeController), and the corresponding state, ASSOCIATING. Controllers now become RUNNING when RegisterWithBackend() is called, which is earlier than prior to this patch (via ActivateDataType()), when there was a barrier barrier for type prioritization. This is expected to have no noticeable behavioral impact other than debugging, since callers to DataTypeController::state() or the dependent APIs like SyncService::GetActiveDataTypes() shouldn't distinguish whether or not the initial download has been kicked off via SyncEngine::Configure(). The change surfaces more semi-dead or obsolete codepaths that need further cleanup, annotated with TODOs. Change-Id: Ie9372473547e56d571e2f109fd24b72388bbdc8d Bug: 647505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176773 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#766420}
-
Xianzhu Wang authored
Bug: 1076503 Change-Id: I2ebfa1eb7926cf760ff7ffbe9b4c3a98997339dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186741Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766419}
-
edchin authored
iOS 13.4 introduces new APIs for mouse cursor support on iPad. This CL enables the hover effect on table view cells with a single button. Test: iPad only. Enable pointer support flag. Test on cell catalog in debug builds. Test on translate infobar. Bug: 1073961 Change-Id: I3f95a67ea6ae07dbd01672fba22f0785674cd5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186079Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766418}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e83d34fc1fd..b63331bb8f7f git log 1e83d34fc1fd..b63331bb8f7f --date=short --first-parent --format='%ad %ae %s' 2020-05-07 danilchap@webrtc.org Cleanup mocks for Video (en|de)coder factories Created with: gclient setdep -r src/third_party/webrtc@b63331bb8f7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icdd69a90c9d18728d55f1eebd439d2930cee3155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187891Reviewed-by:
-
Abhijeet Kandalkar authored
This CL defines frame-widget-specific methods that will be invoked from the browser process to toggle render throttling for an out-of-process iframe. Bug: 1071586 Change-Id: Iaedb484cd16268c6ca7fc8d479915797b9396225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162430 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#766416}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e7d27705e160..21d330b76d4e git log e7d27705e160..21d330b76d4e --date=short --first-parent --format='%ad %ae %s' 2020-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader baa10d7b1dee..08afdde7726c (4 commits) 2020-05-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src d2b486219495..c8590c18bd0c (1 commits) Created with: gclient setdep -r src/third_party/angle@21d330b76d4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I99bfd2c5e2c896a62ccc07131b13e6d2cb949e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187525Reviewed-by:
-
Colin Blundell authored
Change-Id: Ib3b92b7bd6879e391433d308a563f67c566d9539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187317 Commit-Queue: Colin Blundell <blundell@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Stephen Nusko authored
We switched from json to proto, which changed the location of certain args and names. This updates and also takes advantage of the new gestureScrollId to better group scrolls together. Bug: internal b/154684017 Change-Id: I88bedf8f17ecdeaf0ca5a0c07c8bf3a572f4b41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185074Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#766413}
-
arthursonzogni authored
The test was checking no post-redirect information was leaked. Unfortunately, there was a bug in the test. The same data was present in both the final URL and the post-redirect URL. This patch make the post-redirect URL no to have the data. BUG=1074317 Change-Id: I40a698b8edf6ff651dda5d0e82b803a60ccaac7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187711Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#766412}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2871ab0727bf..d7a27532bc38 git log 2871ab0727bf..d7a27532bc38 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 fmalita@chromium.org [skottie] Include ExternalLayer.h explicitly Created with: gclient setdep -r src/third_party/skia@d7a27532bc38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Ic4cc0bf043ba5c550a401c90d6fc97f7638a66e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187890Reviewed-by:
-
Daniel Rubery authored
Currently there is no way for the client to tell which scans are causing a timeout. This CL adds some information to VLOG(1) about which scans are complete and which are still blocking. Change-Id: I6054bcd3690e8145e00b0f71efc3d755881fbb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186457 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#766410}
-
Leonard Grey authored
This reverts commit 130b6251. Reason for revert: Fixed in patchset 2 Original change's description: > Revert "Mac: exit browser fullscreen on Esc" > > This reverts commit a9f47ca0. > > Reason for revert: https://crbug.com/1077651 > > Original change's description: > > Mac: exit browser fullscreen on Esc > > > > Every (non-Chrome) Mac app I've tried supports this, and nobody seems to > > know of a good reason for why we don't do it, so let's do it. > > > > Bug: 1074609 > > Change-Id: I43e9b5137faf347e17e737e2e3f2cbdba4e6c470 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174345 > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#764644} > > TBR=ellyjones@chromium.org,lgrey@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1074609 > Change-Id: I9825e3f24975563333e35263b22316b3c25a6a88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179663 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#765065} TBR=ellyjones@chromium.org,lgrey@chromium.org Change-Id: I60a112cc2521a286736cb0186202e79d09567dff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1074609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179765Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#766409}
-
Caitlin Fischer authored
Hopefully crrev/c/2181510 will have fixed the flakiness on Android CI builds. Bug: 1071110 Change-Id: I86c99100ef5ca014a9760079d925a1c3e514f1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186111 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#766408}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cd09f8e96a3a..2dd864470e31 git log cd09f8e96a3a..2dd864470e31 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 nicolascapens@google.com Revert "Produce MSVC error when virtual class misses virtual destructor" 2020-05-07 capn@google.com Remove typeinfo from Vulkan exported symbols Created with: gclient setdep -r src/third_party/swiftshader@2dd864470e31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibde7ecdd3a1d26f574779122fc2e4c0c871e9b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186086Reviewed-by:
-
Ben Schwartz authored
This simplifies functions that acquire the state, improves type safety, and allows neater organization of the relevant constants. Change-Id: Iff6af9f531ed27e7f1e4fcce7972b2959d60bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179926Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#766406}
-
Johann authored
Change-Id: I7083d45c533a98319114d4b3ae4817806d8f10fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186900 Auto-Submit: Johann Koenig <johannkoenig@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#766405}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c2654255f78..38dda5a415a4 Created with: gclient setdep -r src-internal@38dda5a415a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sinhak@google.com Change-Id: If5a77e0250b1682fc609827fd7cb25f358cb271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766404}
-
Bo Liu authored
Bug: 1035837 Change-Id: I3efc1b56b0e64ddac0ebb0924446cdc14b0c745b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187850Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766403}
-
Ella Ge authored
This CL makes TWAPermissionManager check the delegated app's packageInfo to get its geolocation permission states. 1. If client app did not request geolocation permission (does not have ACCESS_COARSE_LOCATION in the manifest), treat it as "did not enable location delegation. 2. If no stored permission exist, this site is requesting location for the first time, return ContentSettingValues.ASK. --In this case we will connect to the client app to show the permission prompt (implement in the following CL (crrev.com/c/2149530) 3. If stored permission exist, use the permission state from packageInfo and update stored result. Note that this CL does not handle the "one-time permission" case for R. Bug: 1069506 Change-Id: I4b32f8a0b184ed9067e93de259bde2b448cbc39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144630Reviewed-by:
-
arthursonzogni authored
This fixes bug https://crbug.com/1070117 This happened in the following context: 1) The document loads some JS framework. It uses a stale resource. 2) The document prevents itself from issuing more requests by defining a new CSP using a <meta> header. 3) The stale revalidation of (1) is triggered. It was blocked by (2) and some CSP reports were sent. This patch inhibits CSP reporting for stale revalidation requests. Ideally, we should bypass every checks for them (not only CSP). However, this can have several security implications. I am not really attracted into breaking things now. This could potentially be done in a follow-up if needed. What is important here is to stop spamming websites with wrong CSP reports. Blocking stale revalidations because of the race condition happening in (1,2,3) is a rare event anyway. Bug: 1070117, 1079188 Change-Id: I4fb0c23fbb6ee0f7aca16b492af3b44d38e43776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185190 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Matthias Körber authored
Currently, autofill assumes that the language of country names found in a form that is imported to an address profile machtes the app_locale. With this change, autofill also tries to use the page language to understand localized country name in forms to import addresses into new profiles. Change-Id: I409c08633d82e340bd9cc4a776aae0d571264c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165895 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#766400}
-
Henrique Ferreiro authored
//ui/base/cursor is its own component under //ui/base, so it makes sense that its Mojo code lives there instead of in //ui/base/mojom. Also update cursor_mojom_traits.* includes and move accessors to the .h file. Change-Id: Ib98548bfb944521ed02e221619cf9e31124548bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172874Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6f1c4463..ed8b50dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieb5c878579c74b5fe54190e465734a64d5cf9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187532Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766398}
-
Matt Jones authored
This patch allows the bottom sheet to restore the state that it was in prior to suppression. If the content remains the same when the sheet is unsuppressed, it will return to what it was rather than only peeking. Bug: 1078986 Change-Id: Ie48afc1a2c8f108e41813ecdde5597ec727985b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182811 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#766397}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/40875028ce6c..1058fc52fff1 git log 40875028ce6c..1058fc52fff1 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 szuend@chromium.org [issues] Update texts for COEP issues 2020-05-07 pfaffe@chromium.org Show contents of wasm variables for C+DWARF 2020-05-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-07 pfaffe@chromium.org Merge the source scope view back into the scope view Created with: gclient setdep -r src/third_party/devtools-frontend/src@1058fc52fff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1020120,chromium:1042636,chromium:1068570,chromium:1077702 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I286a6bab25b735dbbaf310acf11f8f5a49093979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186085Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0f6cd95f999d..ee416ab2ae31 git log 0f6cd95f999d..ee416ab2ae31 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 fancl@chromium.org dashboard: fixing grouping across test suites Created with: gclient setdep -r src/third_party/catapult@ee416ab2ae31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079179 Tbr: wenbinzhang@google.com Change-Id: I55ea933368561d9ee1b445e069062a4795fce412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187527Reviewed-by:
-
Harald Alvestrand authored
The histogram has expired long ago (July 2019). Bug: chromium:975747 Change-Id: I5e4e8eb03ea9df2fc96f84e0e6468b4a5d4ed8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187772Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#766394}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6b10943c754..1e83d34fc1fd git log d6b10943c754..1e83d34fc1fd --date=short --first-parent --format='%ad %ae %s' 2020-05-07 landrey@webrtc.org Remove pc level test framework redundant code. Created with: gclient setdep -r src/third_party/webrtc@1e83d34fc1fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba4f21660b74ba7962fd18901916058917bc2b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186082Reviewed-by:
-
