GitLab

This CL adds the options of customizing external display's device
scale factor from the options page. There are two TODOs though:
- the configured device scale factor should be stored
- not possible to specify device scale factor and resolution at the
  same time; from 1600x900, it can't enter to 1920x1080(2x). Instead
  it enters to 3840x2160, then the user needs to select 2x again.

Actually the former would solve the latter; this CL sets the new
resolution and the DSF at the same time but resolution change is
asynchronous, so changed DSF will be overwritten by the resolution
change.

I will address these issues in further CL(s).

BUG=396704
R=oshima@chromium.org, stevenjb@chromium.org
TBR=asvitkine@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/417113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393235

Review URL: https://codereview.chromium.org/396293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287676 0039d316-1c4b-4281-b951-d872f2087c98

Makes a window that has been resized to maximized bounds, then maximized and then restored shrink. This allows it to be resized easier after this sequence.

BUG=392599
TEST=ash_unittests --gtest_filter="WindowStateTest.RestoredWindowBoundsShrink"
TEST=unit_tests --gtest_filter="WindowSizerAshTest.DefaultStateBecomesMaximized"
TEST=unit_tests --gtest_filter="WindowSizerAshTest*"

Review URL: https://codereview.chromium.org/424463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287675 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287669 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix and reenable checkbox in Polymer page set. (https://codereview.chromium.org/437353002/)

Reason for revert:
Fails on N5 (at least).

Unhandled exception while running http://www.polymer-project.org/components/paper-elements/demo.html#paper-checkbox

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:232
    self._RunMethod(page, self._action_name_to_run, action_runner)
  _RunMethod at tools/telemetry/telemetry/page/page_test.py:241
    run_method(action_runner)
  RunSmoothness at tools/perf/page_sets/polymer.py:124
    self.TouchEverything(action_runner)
  TouchEverything at tools/perf/page_sets/polymer.py:154
    self.DoActionOnWidgetType(action_runner, tappable_type, self.TapWidget)
  DoActionOnWidgetType at tools/perf/page_sets/polymer.py:169
    element_query + '.offsetParent != null'):
  EvaluateJavaScript at tools/telemetry/telemetry/page/actions/action_runner.py:148
    return self._tab.EvaluateJavaScript(expression)
  EvaluateJavaScript at tools/telemetry/telemetry/core/web_contents.py:108
    expr, context_id=None, timeout=timeout)
  EvaluateJavaScriptInContext at tools/telemetry/telemetry/core/web_contents.py:124
    expr, context_id=context_id, timeout=timeout)
  EvaluateJavaScript at tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py:176
    return self._runtime.Evaluate(expr, context_id, timeout)
  Evaluate at tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:46
    raise exceptions.EvaluateException(res['result']['result']['description'])
EvaluateException: TypeError: Cannot read property 'offsetParent' of undefined

Locals:
  context_id : None
  expr       : 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'
  request    : {'params': {'returnByValue': True, 'expression': 'document.querySelector("sampler-scaffold").$.frame.contentDocument.querySelectorAll("body paper-checkbox:not([disabled]):not([active]):not([checked])")[2].offsetParent != null'}, 'method': 'Runtime.evaluate', 'id': 173}
  res        : {u'id': 173, u'result': {u'wasThrown': True, u'exceptionDetails': {u'url': u'', u'text': u"Uncaught TypeError: Cannot read property 'offsetParent' of undefined", u'line': 1, u'column': 68}, u'result': {u'className': u'TypeError', u'type': u'object', u'description': u"TypeError: Cannot read property 'offsetParent' of undefined", u'objectId': u'{"injectedScriptId":4,"id":1}'}}}
  timeout    : 90

http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1213/steps/smoothness.polymer/logs/stdio

Original issue's description:
> Fix and reenable checkbox in Polymer page set.
> 
> BUG=394756
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596

TBR=dtu@chromium.org,nduca@chromium.org,wiltzius@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394756

Review URL: https://codereview.chromium.org/443793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287667 0039d316-1c4b-4281-b951-d872f2087c98

This isn't right from a UI perspective. Needs to be reimplemented and put
through UI review.

> Make chrome app colored frames available on ChromeOS.
> 
> This feature has been available on Windows and Mac for some time, but
> was never made available on ChromeOS.
> 
> BUG=371642
> 
> Review URL: https://codereview.chromium.org/407073002

TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/442853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287661 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287655 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287654 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (ht… (https://codereview.chromium.org/444453002/)

Reason for revert:
Macbots are getting stuck here:
[       OK ] page_runner_unittest.PageRunnerTests.testDiscardFirstResult (10464 ms)
[ RUN      ] page_runner_unittest.PageRunnerTests.testHandlingOfCrashedTab
[ RUN      ] chrome://crash

http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(3)
http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(3)

Original issue's description:
> Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)"
> 
> This reverts https://codereview.chromium.org/320693002/
> 
> The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall.
> 
> TBR=tonyg,dtu
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287612

TBR=tonyg@chromium.org,dtu@chromium.org,oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/446743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298788
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/446643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287647 0039d316-1c4b-4281-b951-d872f2087c98

This test times out on Windows.

BUG=400922
TBR=tonyg@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/441153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287646 0039d316-1c4b-4281-b951-d872f2087c98

This gives an idea how long it took a connection to complete as well
as the arrival of data messages.

Also records received GCM data burst size and intervals in UMA, and
added previously left-out xml description for another UMA metric.

jar: please review histograms.xml

BUG=386273

Review URL: https://codereview.chromium.org/409653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287645 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287644 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179500:179514&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/438393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287643 0039d316-1c4b-4281-b951-d872f2087c98

This will allow true 720p/60fps tab/desktop capture, if configured
through the constraints (and the system hardware performance supports
it).  In addition, this will enable tab capture perf tests to run at
higher frame rates so that more-subtle regressions are caught.

A new hard upper-bound of 120 FPS is enforced with this change.

BUG=400631
TBR=yzshen@chromium.org

Review URL: https://codereview.chromium.org/442643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287642 0039d316-1c4b-4281-b951-d872f2087c98

will use gfx::FrameTime::Now().

Start frame time ticks at 1 millisecond so that LTHI does not use gfx::FrameTime::Now().

BUG=

Review URL: https://codereview.chromium.org/438373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287641 0039d316-1c4b-4281-b951-d872f2087c98

I will send a PSA to chromium-dev shortly explaining the issue.

BUG=338338, 400860
NOTRY=true

Review URL: https://codereview.chromium.org/441133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399806

Review URL: https://codereview.chromium.org/434183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287636 0039d316-1c4b-4281-b951-d872f2087c98

When doing name-based comparison, use the displayed name.

BUG=400633

Review URL: https://codereview.chromium.org/442843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287635 0039d316-1c4b-4281-b951-d872f2087c98

AddressSanitizer: global-buffer-overflow
READ of size 8 at 0x0000155dfc10 thread T0 (browser_tests)
    #0 0xda3a92 in policy::DeviceLocalAccountTest::SetRecommendedLocales(char const**, unsigned long) chrome/browser/chromeos/policy/device_local_account_browsertest.cc:583:7
    #1 0xdaa280 in policy::DeviceLocalAccountTest_MultipleRecommendedLocales_Test::RunTestOnMainThread() chrome/browser/chromeos/policy/device_local_account_browsertest.cc:1671:3
    #2 0x38ea263 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:428:5

> Allow recommended locales to be set for public sessions
> 
> This CL introduces the |SessionLocales| policy that can be used to
> recommend one or more UI locales for a public session. If the policy is
> set, the first recommended locale is pre-selected when starting a public
> session. If more than one locale is recommended, the public session pod
> is shown in its advanced form, highlighting the availability of language
> and keyboard layout pickers.
> 
> The keyboard layout is automatically set to the most popular layout
> matching the UI locale.
> 
> BUG=214904,241790
> TEST=Extensive browser test coverage, including picker UI
> R=asvitkine@chromium.org, nkostylev@chromium.org, pneubeck@chromium.org
> 
> Review URL: https://codereview.chromium.org/426063005

TBR=bartfab@chromium.org

Review URL: https://codereview.chromium.org/441143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287634 0039d316-1c4b-4281-b951-d872f2087c98

I needed to change the behaviour of Future.Then() to implement this.

BUG=306341
R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/438403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400561
TEST=Add a Sleep(1000) before this section of the test: fails before this CL, succeeds now.

Review URL: https://codereview.chromium.org/442853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/445513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287631 0039d316-1c4b-4281-b951-d872f2087c98

The Poly1305 NEON code became live again with the BoringSSL switch. This
change disables it again in Chromium because of some broken phones.

We should really read /proc/cpuinfo and selectively disable, but this
change is simple and keeps the status-quo for now.

BUG=341598

Review URL: https://codereview.chromium.org/443523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287630 0039d316-1c4b-4281-b951-d872f2087c98

These product IDs have been assigned under the Google vendor ID for
this project.

BUG=396682

Review URL: https://codereview.chromium.org/436213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287629 0039d316-1c4b-4281-b951-d872f2087c98

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/418093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287628 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix flakiness of DesktopDragDropClientAuraX11Tests (https://codereview.chromium.org/431973006/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/11578/steps/compile/logs/stdio#error1

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/views/widget/desktop_aura/views.desktop_drag_drop_client_aurax11.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DVIEWS_IMPLEMENTATION -DGL_GLEXT_PROTOTYPES -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../../third_party/wtl/include -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Igen/ui/resources -Igen/ui/strings '-I../../third_party/libc++/trunk/include' '-I../../third_party/libc++abi/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c ../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc -o obj/ui/views/widget/desktop_aura/views.desktop_drag_drop_client_aurax11.o
In file included from ../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:5:
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:166:8:error: no type named 'vector' in namespace 'std'
  std::vector< ::Atom> GetOfferedDragOperations();
  ~~~~~^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:166:14:error: expected member name or ';' after declaration specifiers
  std::vector< ::Atom> GetOfferedDragOperations();
  ~~~~~~~~~~~^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:316:32:error: no member named 'GetOfferedDragOperations' in 'views::DesktopDragDropClientAuraX11'
    actions_ = source_client_->GetOfferedDragOperations();
               ~~~~~~~~~~~~~~  ^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:614:34:error: use of undeclared identifier 'GetOfferedDragOperations'
  std::vector< ::Atom> actions = GetOfferedDragOperations();
                                 ^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:924:52:error: out-of-line definition of 'GetOfferedDragOperations' does not match any declaration in 'views::DesktopDragDropClientAuraX11'
std::vector< ::Atom> DesktopDragDropClientAuraX11::GetOfferedDragOperations() {
                                                   ^~~~~~~~~~~~~~~~~~~~~~~~


Original issue's description:
> Fix flakiness of DesktopDragDropClientAuraX11Tests
> 
> I suspect that the flakiness was caused by X11WholeScreenMoveLoop::RunMoveLoop()
> sometimes failing. This CL fixes this potential source of flakiness by using
> a stub move loop in tests.
> 
> BUG=396468
> TEST=None
> TBR=erg
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287622

TBR=erg@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396468

Review URL: https://codereview.chromium.org/443773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287627 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Moving coordinate conversion methods from ash/wm to ui/wm. (https://codereview.chromium.org/425363002/)

Reason for revert:
Build break.

../../ash/display/mouse_cursor_event_filter_ozone.cc:21:7:error: no member named 'ConvertPointToScreen' in namespace 'ash::wm'
  wm::ConvertPointToScreen(target, &point_in_screen);
  ~~~~^
../../ash/display/mouse_cursor_event_filter_ozone.cc:45:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm'
  wm::ConvertPointFromScreen(root_at_point, &point_in_root);
  ~~~~^
../../ash/display/mouse_cursor_event_filter_ozone.cc:86:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm'
  wm::ConvertPointFromScreen(dst_root, &point_in_dst_screen);
  ~~~~^


Original issue's description:
> Moving coordinate conversion methods from ash/wm to ui/wm.
> 
> Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into
> aura::Window. The suggestion to do this was made here:
> https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h
> 
> BUG=NONE
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287609

TBR=oshima@chromium.org,ben@chromium.org,sky@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/445703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387879
TEST=MaximizeModeController.CloseLidWhileInMaximizeMode
TEST=MaximizeModeController.WasLidOpenedRecently
TEST=MaximizeModeController.HingeAnglesWithLidClosed
TEST=MaximizeModeController.StableHingeAnglesWithLidOpened
TEST=MaximizeModeController.UnstableHingeAnglesWhenLidRecentlyOpened
TEST=MaximizeModeController.UnstableHingAnglesWithLidOpened

Review URL: https://codereview.chromium.org/412013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287625 0039d316-1c4b-4281-b951-d872f2087c98

Experiment is no longer running and is in many ways obsolete. Removing the code.

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/437803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287624 0039d316-1c4b-4281-b951-d872f2087c98

This change moves all non-API classes to
sync/internal_api/public/attachments/ so that the various sync
sub-components may depend on sync/api/attachments without risking a
cyclic dependency.

Remove unused variables and includes from
attachment_service_proxy_unittest.cc.

Remove an unnecessary forward declaration from
attachment_service_proxy.h.

TBR=nkostylev@chromium.org,pam@chromium.org,bengr@chromium.org,brettw@chromium.org,miket@chromium.org,pkotwicz@chromium.org,msw@chromium.org

Review URL: https://codereview.chromium.org/436373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287623 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that the flakiness was caused by X11WholeScreenMoveLoop::RunMoveLoop()
sometimes failing. This CL fixes this potential source of flakiness by using
a stub move loop in tests.

BUG=396468
TEST=None
TBR=erg

Review URL: https://codereview.chromium.org/431973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50968,51153,58561,58574,370210
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/447623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287621 0039d316-1c4b-4281-b951-d872f2087c98

Now that hit-testing for views (crbug.com/388838) and
event-targeting for views (crbug.com/391845) use
ViewTargeterDelegate to define custom behaviour for
these operations (instead of the now-obsolete
approach of subclassing ViewTargeter itself), we
should not be calling into EventTargeter for this
purpose. Changes in this CL:

* Finding the target of a scroll event is now
  performed correctly by using the logic in
  ViewTargeterDelegate and its overrides.

* The dead code
  ViewTargeter::SubtreeCanAcceptEvent(),
  ViewTargeter::EventLocationInsideBounds(),
  and ViewTargeter::BoundsForEvent() have been
  removed along with their corresponding tests.

* The class-level documentation for ViewTargeter
  and ViewTargeterDelegate has been updated
  to clarify the purpose of these classes.

BUG=395387,370579
TEST=ViewTargeterTest.*

Review URL: https://codereview.chromium.org/426443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400892
R=robliao@chromium.org
TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/442983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385396
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/446693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/445723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399835

Review URL: https://codereview.chromium.org/427713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/429693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287613 0039d316-1c4b-4281-b951-d872f2087c98