GitLab

This CL updates the video_decoder_(perf_)tests usage documentation with
the additional "--use_vd_vda" parameter that was added recently.

BUG=None
TEST=checked doc in gitiles

Change-Id: I175ba21fe3563d092409a3202c7257dae90d520a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215394Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772116}

We were depending on view_->GetWidget() to see if the view is
removed from a widget or not. But in ViewObserver::OnViewRemovedFromWidget(),
GetWidget() may return valud widget. It's because View's parent pointer
is still valid at this point. Please see GetWidget() implementation.

So explicitly clear animation runner without checking GetWidget().

note: tried invalidating parent pointer before the propagation, but caused crash.
it seems some classes are using GetWidget() in the OnViewRemovedFromWidget().

Bug: 1082633
Change-Id: I607f1845002398fa24311dcf697f52f19f25aa8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212109
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772115}

Change-Id: I63a9b2f8fc276dfc6ad8e605f952aeafa96fd75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213521
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772114}

Bug: 1086675
Change-Id: I80f71de863c3a6db40d9c7459356d5ef0184c4d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213899Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772113}

Profile::IsIncognitoProfile() currently returns true for incognito
profiles and also other non-Guest OTR profiles.

This behavior is updated so that it only returns true for incognito
profiles.

Bug: 1033903, 1074201
Change-Id: Ic2ce57b85a92534f0f6582c5c718b2947a899ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124249Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772112}

It's not actually being used anywhere.

Bug: None
Change-Id: Id11dddbbc99d78de841a2faafe2473adbbee197d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216284Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772111}

They used to be separate because Base acted as a base class for all
platforms, but we've since removed support for the other platforms [1].

Also remove some non-ChromeOS code from the class since it's dead code.

Follow up CLs will combine InputMethodEngineBase with InputMethodEngine.

[1] https://crrev.com/c/2198861

Bug: 1083803
Change-Id: Ia49ac04c161df37a42ed5e9bd5ac41b052b453b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212194Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772110}

Refactoring crostini port forwarding tests to be more readable and more
easily editable in the futre. Also adding new tests to cover interface
switching.

Tests: Running the implemented tests
Bug: 848127
Change-Id: I26fdbb65c92c2e9ea161fe20738644e12965fd5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214804Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Daniel Ng <danielng@google.com>
Cr-Commit-Position: refs/heads/master@{#772109}

The NativeFileSystem API currently only supports "real" files, backed
by inodes. Attempting to open a non-native file results it it not being
found because there are no attempts to "uncrack" virtual file paths.

This CL causes file_manager::file_tasks::FindWebTasks() to early-exit
if any entries in the file selection are non-native files.

A testing chrome app is included that uses the file system provider
API as a basis for providing files that can be used for end-to-end
testing.

Bug: 1079065
Change-Id: I5ed5649eb85dcfb25cdfd4965770ae39c3c56dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213652
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772108}

This relands http://crrev.com/771122 with compile fixes.

It's safe for the Widget to own the underlying View via
SetContentsView().  This was not immediately obvious; much of this CL is
adjacent refactoring and cleanup that simplifies the ownership/lifetime.

Bug: 1044687
Change-Id: I49820e70df1387cfde6998de6ab67e119b5a451a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213227
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772107}

Bug: 1084325
Change-Id: I151b5ca66e420dae91feaff8e47f56aaffe4d03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207923Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772106}

This a rerun of the same script as in
https://chromium-review.googlesource.com/c/chromium/src/+/2026350
on r771943 this time.

TBR=fdoray@chromium.org

Bug: 1026641
Change-Id: I9d32d1262b0f0e1eaa771358cb77d837c3d3467f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217115Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772105}

https://chromium.googlesource.com/angle/angle.git/+log/9dac86c9c458..5b4c627389a6

2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 6ff146b0bfce to 424cdd54fe80 (12 revisions)
2020-05-27 geofflang@chromium.org Don't allow glReadPixels of depth buffers with ES3.1.
2020-05-26 sunnyps@chromium.org Use surface texture offset for clears and blits

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: I5790febf21cb162059162fbf219852057a2c9dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217076Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772104}

Prior to http://crrev.com/c/2138156, the outline-offset was ignored
when drawing the focus ring.

Unlike normal outlines (whole width is outside of the offset), focus
rings are drawn with the center of the path aligned with the offset, so
only a part of the ouline is outside of the offset.

This CL updates the behavior of NeedsDecorationOutlineLayer to consider
the part of the outline drawn inside.

Added textarea-with-scrollbar.html to validate the change.

Bug: 1084997
Change-Id: I50949194c0a2f413d7a3c508509339dac63cfbb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216705Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772103}

This reverts commit 7a8d0e7d.

Reason for revert: DT tree CL landed and we don't need this now.

Original change's description:
> arcvm: Add /factory as /dev/vdc
> 
> BUG=b:155128030
> TEST=try
> 
> Change-Id: Ic03e43b2ba8af5453f376417e5312b76c14274e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203274
> Commit-Queue: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Long Cheng <lgcheng@google.com>
> Cr-Commit-Position: refs/heads/master@{#769632}

TBR=yusukes@chromium.org,lgcheng@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:155128030
Change-Id: If4555182a1e1fdb21801d05435ebbec7df9b3c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213898Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Lepton Wu <lepton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772102}

[Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders.

The builders are linux-chromeos-dbg, Mac ASan 64 Tests (1), Linux ChromiumOS MSan Tests,
Win7 Tests (dbg)(1), Linux Tests (dbg)(1), and Linux CFI.

Bug: 1086794
Change-Id: If0b9d37b3d4662880916f26b8acfc5612200e075
Tbr: beccahughes@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216098
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#772101}

This patch changes "modify-up-on-rtl-wrapping-text.html" to utilize
|selection_test()| for ease of maintenance and help to implementing EditingNG.

Bug: 707656, 679977
Change-Id: I0306f6f80da87804a739398f3e9201d3ced1c2ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215542
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772100}

This patch changes "extend-to-line-boundary.html" to utilize |selection_test()|
for ease of maintenance and help to implementing EditingNG.

Bug: 707656, 679977
Change-Id: I3c31e572b3f4ba3e2eb5a72e62857c054b4a56b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214738
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772099}

Bug: 1083585
Change-Id: I5660fbc7cf8ce917013eabd6c2c8d66385baa7f5
Tbr: danakj@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216137Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#772098}

For M84.

Launch bug: http://crbug.com/1062024

Bug: b/150951008

Change-Id: I9943a5295282f028ec19886a0d758cba37a7a879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214653Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772097}

A surface can be submitted to the compositor without a corresponding
call to its commit method if it is a subsurface and some other surface
in the hierarchy changes. When this happens, the surface hasn't changed
since the last frame, so there is no damage on the surface. To prevent
sending stale damage rects when this happens, clear surface damage when
sending each frame.

TEST=SurfaceTest.SubsurfaceDamageAggregation
TEST=Run ARC++ YouTube app, observe no graphics corruption
BUG=b:155369189, 1082084

Change-Id: Iea935e0252674b112d1a1e511aab71a530266874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198527
Commit-Queue: David Stevens <stevensd@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772096}

https://skia.googlesource.com/skia.git/+log/64391c4a55c7..fd9745eee98f

2020-05-27 reed@google.com SkDrawLooper has not been supported by Skia for a while. Update dox and remove examples

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: I7076d63fb828b39989e9e4308e2a82a39311de35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217078Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772095}

This is a follow-up to crrev.com/c/2086360, which added a custom version
of launcher file icons for use in the suggestion chips. That CL only
added 2x PNGs. This CL updates the icons to GM2, and adds 1x versions
also.

We're expecting to move these to SVG next.

Bug: 1081586
Change-Id: Ic6e6fbce6fb0b32c47b36d79781e70ae9cddbade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216830Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772094}

Bug: b/156333981
Change-Id: Ieec9421a98119684f3ad901b16c1ad8dbe8998ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196082Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772093}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aef138255c4c..94b3d7589061

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC tasak@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1069072,chromium:1073232,chromium:1085525
Tbr: tasak@google.com
Change-Id: Id06ca384c77a125f4f1ee1c1adca6e7e7f20c6a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217077Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772092}

Bug: 1077160
Bug: 1049453
Change-Id: I231edda50a25fbc5b5ae4c9238e07a10d8a41548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206868Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#772091}

Change the blink runtime flag to be fully controlled by the finch flag
so that we can still use finch as a kill switch if necessary. (With the
old kEnableOnly, "stable" in runtime enabled features json would
override the finch server's value.)

Bug: 845235
Change-Id: I7610b078a52674b3e8fa06d87d33f82e96761d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216595Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772090}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I654dbb9790d9e8a928eef03dc35d4437795c257d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217116Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772089}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c3f19085..c1f72606

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I23bf017113c7c09efc8e88eb5f7cb7f4e4931053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216688Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772088}

Call SetEmbeddedColorProfile() before SetSize() in MaybeCreateDemuxer().
Create the ColorProfile from either an ICC profile (preferred) or the
CICP color description (always present, from either the nclx colr box in
the container or the AV1 sequence header for the frames). This requires
always decoding the first frame (because we need to decode the AV1
sequence header) when we are asked to decode metadata such as size and
frame count.

Add ColorCorrectImage(), which calls skcms_Transform() if
ColorTransform() returns a non-null transform.

Change DecodeFrameCount() to return frame_buffer_cache_.size() if the
image decoder has already failed, as some other image decoders do. This
causes FrameCount() to return 0 if the decoding of the first frame
fails.

Use the GetAsFullRangeRGB() version of the src color space as the dst
color space of the gfx::ColorTransform for YUV-to-RGB color conversion.

This allows us to enable the AVIF image tests guarded by
FIXME_CRASH_IF_COLOR_TRANSFORMATION_IS_ENABLED and
FIXME_CRASH_IF_COLOR_BEHAVIOR_IS_IGNORE.

Since we now always decode the first frame when we are asked to decode
metadata, the notion of "error phase" for the invalid static image tests
no longer applies. Invalid static images now always fail in the "parse"
phase.

TODO:
1. Improve the tests for the color spaces that libyuv supports. Since
libyuv's numerical accuracy is not as good as gfx::ColorTransform, this
will require relaxing the thresholds for pixel value differences for
some AVIF image tests.

Bug: 1076555
Change-Id: I2a312da1f917fe2cef7ef2f342a3aa52bda6445d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209638
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772087}

There were inconsistent usages of node.state.type,
and node.state[State.type].

Also fix closure_compiler errors.

AX-Relnotes: n/a.
Bug: None (refactoring).
Test: webui_closure_compile, shows no errors
Change-Id: I78483d79336c8e71df34309f2ba306e7ac07d031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210604Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Auto-Submit: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772086}

https://dawn.googlesource.com/dawn.git/+log/e370ec6de4fa..6a029fc9d84e

2020-05-27 jiajie.hu@intel.com Only download binutils in standalone build
2020-05-27 yunchao.he@intel.com Implement texture subresource on Vulkan
2020-05-26 natlee@microsoft.com Fire map callback if map async operation fails
2020-05-26 rharrison@chromium.org Rolling 9 dependencies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I9029990bc62a7210832b08bcbf4af4f11e3febc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217074Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772085}

This patch ensures ensures that ARC++ gets updated with the layer 3 IP
configurations of all active networks, including host VPN networks.

To do so this patch changes two parts in ArcNetHostImpl:

1) First, shill properties are now always asynchronously retrieved and
cached for active networks. Asynchronous network properties requests
are now sent to shill when chromeos::NetworkStateHandlerObserver's
NetworkPropertiesUpdated() or NetworkListChanged() callbacks are
triggered, only for currently active networks. When the properties are
received, a call to net.mojom ActiveNetworkChanged is triggered. This
replaces the previous net.mojom ActiveNetworksChanged triggers on every
callback invocation of chromeos::NetworkStateHandlerObserver's
ActiveNetworksChanged and DefaultNetworkChanged.

2) When net.mojom NetworkConfiguration objects are created, on top of
device properties (not available for VPNs) and ONC properties obtained
from the cached chromeos::NetworkState, cached shill properties are also
used for populating the IP configuration. This allows to obtain the
layer 3 IP configuration for VPNs, which have neither an associated
Device nor any cached layer 3 information in chromeos::NetworkState.

This change makes the retrieval of IP configurations from ONC properties
mostly obsolete. A follow-up patch will remove that code.

BUG=b:145960788
BUG=b:143258259
BUG=b:155129178
BUG=crbug:991189
TEST=Flashed chrome, tested various connectivity setup with multiple
networks, including L2TP connections and Chrome 3p VPN connections.

Change-Id: If3e511212f491a5ec6533c8fb259c49eab29295b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210335
Commit-Queue: Hugo Benichi <hugobenichi@google.com>
Auto-Submit: Hugo Benichi <hugobenichi@google.com>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772084}

This reverts commit 8603f25b.

Reason for revert: metrics recorder is missing some resources in Polymer2 settings, causing some breakage

Original change's description:
> [CrOS settings] Port os_reset_page/ and localized_link/ to Polymer3
> 
> - Forks TestLifetimeBrowserProxy into test_os_lifetime_browser_proxy.js
> - create new os_settings_v3_browsertest.js
> 
> Bug: 1045266
> Change-Id: I4500646fda8e8208d7bc63b405594592f9a7fce2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190976
> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Reviewed-by: Regan Hsu <hsuregan@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771716}

TBR=khorimoto@chromium.org,dpapad@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com

Change-Id: I99a42fac621b3fd5dab766f1dbe476ba52aa58b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216914Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772083}

Some of the core interfaces (URLLoader, URLLoaderClient and
URLLoaderFactory) are good to have a diagram for overall of them since
they are complicated.

This CL just add the URL for the diagram about URLLoader.

Change-Id: I0e4c662aa6446eae43ac661b09ff870015786425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209778Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772082}

Re-enable HotseatShelfAppBrowserTest.TappingAppIconsHidesHotseat. Fix
one things: In ShelfWidget, contextual nudge related function should
not be called when the contextual nudge feature is disabled.

Verify this CL with MSAN test.

Bug: 1021011
Change-Id: Iff1755001e41e28cfe0490e014502ad711e0b90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207613
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772081}

This CL fixes
1 - If we get redundant calls to the TileSuggestionProcessor, ignore them
and don't update the underlying widget. This will prevent the previous
suggestion from flashing up momementarily before new tile set is loaded.
2 - Default ItemAnimator is removed to prevent the jank
3 - Only reload the tile if NTP is reloaded via home button. For regular
page load, don't animate query tiles (fixes submit query flow jank)
4 - Fix for international languages - ASCII comparison is not enough
for non-english languages. string16 is used for comparison purposes,
which fixes the omnibox flow for query tiles (Bug 1086672)

Bug : 1086672, 1081557

Change-Id: I8536759fb3f7a9c9c00ddb56f5c12f40df26a114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211661
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772080}

Using RasterInterface's CopySubTexture() proved costly. Reverting to
replaceBackendTexture in non OOP-R mode to regain lost perf. OOP-R mode
will continue to use RasterInterface for copy-on-write.

Bug: 1082399, 1082403
Change-Id: I80e1b285e4d7c4336a706d1e5f006afd676f0b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216591Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772079}

Before this patch, the C++ payment_app.h interface exposed a
gfx::ImageSkia type icon, which is difficult to pass to Java.

This patch changes payment_app.h interface from gfx::ImageSkia to
SkBitmap.

After this patch, the C++ payment_app.h interface exposes an SkBitmap
type icon, which is easier to pass to Java.

Design: https://bit.ly/cross-platform-pay-app-factory

Bug: 1022512
Change-Id: I506bec37b1bb298452e1ebe51cc4bd1731d8d032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212495
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772078}

The hash function originally picked was SuperFastHash(), but we are running into a few limitations.

Justification for the new function is explained in identifiability_metrics.cc.

Bug: 973801
Change-Id: I6743d72c5b18dc86cf9fe3d4a8d98ef49fbcd7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213403Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772077}