GitLab

http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.

At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.

BUG=94334
TEST=browser_tests

Review URL: http://codereview.chromium.org/8008012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106845
TBR=thestig
Review URL: http://codereview.chromium.org/8951010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none
TBR=jam
Review URL: http://codereview.chromium.org/8951008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114611 0039d316-1c4b-4281-b951-d872f2087c98

Also, this CL moves chrome/browser/ui/webui/sync_promo_* to
chrome/browser/ui/webui/sync_promo/sync_promo_*.

BUG=107223
R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org
TEST=The sync promo responds to brand code and records results of the field
trial correctly.

Review URL: http://codereview.chromium.org/8933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114608 0039d316-1c4b-4281-b951-d872f2087c98

schema_generated_bindings.js.


BUG=80310
TEST=browser_tests --gtest_filter=*Extensions*


Review URL: http://codereview.chromium.org/8916019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114606 0039d316-1c4b-4281-b951-d872f2087c98

Print preview: A quick hack to support printing to the default printer without user confirmation in kiosk mode.

BUG=31395
TEST=none

Review URL: http://codereview.chromium.org/8915027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114605 0039d316-1c4b-4281-b951-d872f2087c98

- Add RUN_TEST_WITH_REFERENCE_CHECK macro which run a test then check leaked
 pepper objects.
- Use that macro to run all WebSocket related PPAPI unit tests
- Fix some object leak in tests found by the macro

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114389

Review URL: http://codereview.chromium.org/8934003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23640,106862,106850
TEST=run unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113601

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=113624

Review URL: http://codereview.chromium.org/8833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114603 0039d316-1c4b-4281-b951-d872f2087c98

GLES2Implemetation::FreeEverything now fress everything it can.
the transfer buffer, the command buffer and any unused mapped
buffer (glMapSubXXX).

BUG=103989
TEST=unit tests


Review URL: http://codereview.chromium.org/8953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114602 0039d316-1c4b-4281-b951-d872f2087c98

aura-x11: Make sure the list of devices to track are updated when device hierarchy changes, and turn XInput2 back on.

If a device gets initialized after chrome boots up, then it is necessary to
update the list of devices chrome accepts input-events from.

BUG=106516
TEST=manually


Review URL: http://codereview.chromium.org/8892005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114601 0039d316-1c4b-4281-b951-d872f2087c98

Split out pointer, touchpad and mouse settings.

BUG=chromium-os:22305
TEST=chrome://settings/system should have separate pointer, touchpad and mouse settings.

Review URL: http://codereview.chromium.org/8905025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114600 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8958001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114599 0039d316-1c4b-4281-b951-d872f2087c98

Merge these redundant classes and their unit tests.
Do not try_mirroring_arrow with dummy anchor rects.
Deprecate unused allow_bubble_offscreen bubble flag.
Replace GetArrowLocation virtual with simple setter/getter pair.
Return anchor view bounds in BubbleDelegateView::GetAnchorRect.
Other refactoring and simplification.

BUG=106050
TEST=Bubbles are anchored correctly with their arrows in the right location.

Review URL: http://codereview.chromium.org/8870003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114598 0039d316-1c4b-4281-b951-d872f2087c98

This removes a lot of boilerplate with checking host_ (which was never
[locally] thread-safe, anyway).

Make as many things in SyncBackendHost private as possible.

BUG=103410,107279
TEST=


Review URL: http://codereview.chromium.org/8938013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17585
TEST=browser_tests --gtest_filter=SystemPrivateChromeOsApiTest.GetUpdateStatus

Review URL: http://codereview.chromium.org/8747003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114596 0039d316-1c4b-4281-b951-d872f2087c98

Move D&D client stuff into client namespace.
Provide some convenient getters/setters.

BUG=none
TEST=existing automation
TBR=sky
Review URL: http://codereview.chromium.org/8949010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114595 0039d316-1c4b-4281-b951-d872f2087c98

When VarTracker remove PP_Var from VarMap, it release its Var object
if needed, but never reset var_id stored in Var object. Then, if Var's
reference count is not 1, Var continue to exist with invalid var_id until
the last reference is released.

BUG=87310
TEST=ui_tests, browser_tests, nacl_integration

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114384

Review URL: http://codereview.chromium.org/8872065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8952002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=new tests


Review URL: http://codereview.chromium.org/8872044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114590 0039d316-1c4b-4281-b951-d872f2087c98

Add loop to _VerifySearchInPDFURL to try FindInPage 10 times and re-raise
the exception on the final loop. This is required because
_GetResultFromJSONRequest appears to timeout if called before the PDF has
loaded.

Add timeout parameter to pyauto.FindInPage to be passed to
_GetResultFromJSONRequest to speed up the loop in _VerifySearchInPDFURL
from the default of 45 seconds to 1 second.

Re-enable test on Mac.

BUG=107448, 70927, 93956

Review URL: http://codereview.chromium.org/8913012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114589 0039d316-1c4b-4281-b951-d872f2087c98

This change has been made at the parent class level, where the rendering
of the BookmarkButtonCell is implemented. It aligns the favicon with
NSImageLeft if there is no title.

A test has also been added to check for the differences in image positioning between these two classes.

BUG=105276


Review URL: http://codereview.chromium.org/8792001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none

Review URL: http://codereview.chromium.org/8926001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114586 0039d316-1c4b-4281-b951-d872f2087c98

Some NaClLog invocations were left with detail level 0, which gets
printed by default.  This CL just increases some of these, so that
NACLVERBOSITY environment variable would have to be set to see events
such as NaCl module crash log messages that occur while generating the
'crashed' event.

BUG= None
TEST= None


Review URL: http://codereview.chromium.org/8929022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114585 0039d316-1c4b-4281-b951-d872f2087c98

Add a component installer for Portable NaCl. Registration of installer is hidden behind a commandline flag '--enable-pnacl'.

Still some of TODOs: finalize the metadata associated with the CRX, figure out what to do when a NaCl plugin needs Pnacl, but it's not there yet.


BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365
TEST= none yet, only manually test:

(1) put a pnacl omaha config in the omaha sandbox, pointing at a crx.

(2) run out/Debug/chrome --user-data-dir=/tmp/temp_profile/ --enable-pnacl --component-updater-debug=fast-update --apps-gallery-update-url=http://omaha.sandbox.google.com/service/update2/crx

check /tmp/temp_profile/PNaCl/0.1.0.X is installed after a few seconds.

restart chrome, check that PathService registers /tmp/temp_profile/PNaCl/0.1.0.X soonish.


Review URL: http://codereview.chromium.org/8348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8907052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114583 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8490001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/8680040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=trybots

Review URL: http://codereview.chromium.org/8954001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24259
TEST=None
Review URL: http://codereview.chromium.org/8957002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24265
TEST=None
Review URL: http://codereview.chromium.org/8951003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114575 0039d316-1c4b-4281-b951-d872f2087c98

RendererAccessibility::PostAccessibilityNotification function while processing the WebAccessibilityNotificationLayoutComplete 
notification from webkit. This function recursively calls itself with the WebAccessibilityNotificationLayoutComplete
notification leading to infinite recursion.

Fix is to check whether the incoming notification is WebAccessibilityNotificationLayoutComplete before the recursive
call.

BUG=none
TEST=chrome frame tests should pass on the IE6 builder.
Review URL: http://codereview.chromium.org/8952005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114573 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily used by the sync typed URL performance tests.  This
method helps stabilize the perf numbers since there's only a single
notification that is emitted (instead of one per URL).

BUG=107040
TEST=


Review URL: http://codereview.chromium.org/8910024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114572 0039d316-1c4b-4281-b951-d872f2087c98

This time, we allow the StackingClient to be optional. If not specified, unparented windows will just be added to the RootWindow.

BUG=none
TEST=existing automation

Review URL: http://codereview.chromium.org/8916020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8898036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98

Set aura window focus in NativeWidgetAura::ClearNativeFocus only if the focus is owned by child window.

 This was causing a focus to be stolen when non active window calls ClearNativeFocus.

BUG=114477
TEST=OmniboxViewTest.PopupAccelerators passes with this change


Review URL: http://codereview.chromium.org/8931022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114561 0039d316-1c4b-4281-b951-d872f2087c98

1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
   as there is an Atlmodule instance instantiated by the content code.

2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
   test instances to control whether an AtExitManager instance is created for the duration of the
   test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435

BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8907054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98

Resubmitting reverted CL with fix
BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8909012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114557 0039d316-1c4b-4281-b951-d872f2087c98

Requiring developers to update their extensions to manifest_version 2 when
loading them as unpacked extensions was more disruptive than we anticipated.
We want to make sure our documentation is in better shape and that folks have a
chance to move to manifest_version 2 on their own schedule before flipping this
switch.

Review URL: http://codereview.chromium.org/8907056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114556 0039d316-1c4b-4281-b951-d872f2087c98