GitLab

BUG=None

Review-Url: https://codereview.chromium.org/2339323002
Cr-Commit-Position: refs/heads/master@{#419241}

At times, we receive multiple focus events. This is technically fine, but it can cause lots of queued up chatter.

In the linke to bug, we are reading a focus event from a previous tab. Ideally the focus event shouldn't be fired (as it once was not), but ChromeVox should be robust enough to not over speak in this case.

Note that in braille, this results in a "shuffling" effect where one focus event flashes briefly before the expected event comes through.

BUG=646126

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2331253002
Cr-Commit-Position: refs/heads/master@{#419240}

BUG=617204
TEST=This enables existing test on more bots

Review-Url: https://codereview.chromium.org/2338023005
Cr-Commit-Position: refs/heads/master@{#419239}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/be85e5fd4bf5..b22608753f37

$ git log be85e5fd4..b22608753 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 washingtonp Replace profile_chromes atrace agent with Systrace's.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343223002
Cr-Commit-Position: refs/heads/master@{#419238}

This CL uses margins rather than max-width to determine when the avatar
icon grid layout should wrap.

BUG=646253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338003004
Cr-Commit-Position: refs/heads/master@{#419237}

This CL lands server change 129028211 by birenroy.

BUG=488484

Review-Url: https://codereview.chromium.org/2237113005
Cr-Commit-Position: refs/heads/master@{#419236}

This CL lands server change 133042402 by yasong@.

BUG=488484

Review-Url: https://codereview.chromium.org/2348603003
Cr-Commit-Position: refs/heads/master@{#419235}

This CL is aimed at solving the bug described in comment 7 in crbug.com/468969. The original method only considered the system tray alone.

After the fix:

On signin screen, tabing focus order is:
three dots -> system tray -> (virtual keyboard) -> user login
shift-tabing focus order is:
user login -> (virtual keyboard) -> system tray -> three dots

On locked screen, tabing focus order is:
signout -> system tray -> notification tray -> (virtual keyboard) -> user login
reverse tabing focus order is:
user login -> (virtual keyboard) -> notification tray -> system tray -> signout

BUG=468969
TEST=device test, works good on the above description.

Review-Url: https://codereview.chromium.org/2295843006
Cr-Commit-Position: refs/heads/master@{#419234}

In short, an LTO optimization pass might recognize
naive implementations of builtins (such as memset)
and replace them with references to the real builtins,
which, in the case of -nostdlib, might cause the binary
to get undefined references to those symbols.

See more details:
https://llvm.org/bugs/show_bug.cgi?id=30403

BUG=645295

Review-Url: https://codereview.chromium.org/2343063002
Cr-Commit-Position: refs/heads/master@{#419233}

It uses a flood fill ripple that remains active while the overflow shelf
is active. InkDropHostView and CustomButton are updated to handle active
case:
 - CustomButton does not hide the ripple if it is not a pending ripple;
 - InkDropHostView does not show or hide a pending ripple if it is
   showing an active ripple.

BUG=612579
TEST=OverflowButtonInkDropTest.* in ash_unittests, manual

Review-Url: https://codereview.chromium.org/2178163002
Cr-Commit-Position: refs/heads/master@{#419232}

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=629116

Review-Url: https://codereview.chromium.org/2343453002
Cr-Commit-Position: refs/heads/master@{#419231}

https://chromium.googlesource.com/skia.git/+log/43d665111137..046cb56c6c1b

$ git log 43d665111..046cb56c6 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 mtklein GN: build get_images_from_skps.
2016-09-16 cblume Keeping asserts in release.
2016-09-16 bsalomon Allow GrCaps access from GrDrawContext GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348923002

BUG=643845

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2342213003
Cr-Commit-Position: refs/heads/master@{#419230}

BUG=647679

Review-Url: https://codereview.chromium.org/2346913003
Cr-Commit-Position: refs/heads/master@{#419229}

Make EasyUnlockGetKeysOperation wait for the cryptohome
D-Bus service to be available before making a GetKeyDataEx
method call to it. Otherwise, we get repeated log spam at
boot:

  [1912:1912:0916/102203:ERROR:object_proxy.cc(583)] Failed to call method: org.chromium.CryptohomeInterface.GetKeyDataEx: object_path= /org/chromium/Cryptohome: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.Cryptohome was not provided by any .service files
  [1912:1912:0916/102203:ERROR:easy_unlock_get_keys_operation.cc(61)] Easy unlock failed to get key data, code=1

BUG=636554

Review-Url: https://codereview.chromium.org/2343213002
Cr-Commit-Position: refs/heads/master@{#419228}

ViewportControl's _selectedText currently does this:
1 - get a selection+range with native window/shadowRoot.getSelection()
2 - calculate first and last viewport items that are part of the selection
3 - get the deepTextContent() of all those items
4 - trim out text based on the offsets provided by the selection

Step 4 is done by _textOffsetInNode(), which takes an itemElement, container,
and offset. Beforethis CL, it would start at the item and traverse all text
nodes until it stops at the container (node !== container). In this logic, it
assumes that the container is a text node itself so that (node !== container)
will be false and we will stop before counting the container's text length. In
reality, a user can drag to create a selection where the
range.start/endContainer can be an element that is not a text node (e.g. <span>
containing a text node). Then, _textOffsetInNode() would continue to traverse
and node.traverseNextTextNode() will never return a node that is === container.
This results in extra text length being counted which breaks the offset logic.

This CL makes sure that in those cases where the range.start/endContainer is not
a text node, such as a <span> containing the boundary text, we will stop
traversing when we hit a text node that is the end or is a descendant.

BUG=647287

Review-Url: https://codereview.chromium.org/2340223002
Cr-Commit-Position: refs/heads/master@{#419227}

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473

Review-Url: https://codereview.chromium.org/2151093003
Cr-Commit-Position: refs/heads/master@{#419226}

This makes the test interface almost exactly like any other origin trial, and
means that we don't have to do any special handling at internals construction
time to support it. Because it lives on window.internals.originTrialTest() now,
I renamed the various test methods and attributes to be more descriptive of what
they are actually testing, rather than prefixing them with 'frobulate' to avoid
polluting the internals namespace.

BUG=647273

Review-Url: https://codereview.chromium.org/2340323002
Cr-Commit-Position: refs/heads/master@{#419225}

BUG=647112

Review-Url: https://codereview.chromium.org/2340923004
Cr-Commit-Position: refs/heads/master@{#419224}

This CL adds it because it's in [1] but not in [2]

[1] https://cs.chromium.org/chromium/src/media/base/video_codecs.h?q=kCodecHEVC&sq=package:chromium&l=27&dr=CSs
[2] https://cs.chromium.org/chromium/src/tools/metrics/histograms/histograms.xml?q=histograms.xml+kCodecVP9&sq=package:chromium&dr=C&l=98435

Review-Url: https://codereview.chromium.org/2347793002
Cr-Commit-Position: refs/heads/master@{#419223}

- Disabling and enabling the type, which revealed a bug in the DTC.
- Conflict resolution, which revealed a bug in the worker.

BUG=643269

Review-Url: https://codereview.chromium.org/2339403004
Cr-Commit-Position: refs/heads/master@{#419222}

BUG=None

Review-Url: https://codereview.chromium.org/2347053002
Cr-Commit-Position: refs/heads/master@{#419221}

Revert of Temporarily remove chrome_app_unittests from the Dr. Memory builder (patchset #1 id:1 of https://codereview.chromium.org/2278113002/ )

Reason for revert:
Reverting, because Dr. Memory test bots need that executable. It didn't break until a clobber landed and deleted the executable generated in the past.

Also glider@ reports that chrome_app_unittests was probably innocent (in the bug report) anyways.

First breaking build: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/130

Original issue's description:
> Temporarily remove chrome_app_unittests from the Dr. Memory builder
>
> BUG=640185
> TBR=dpranke@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/ad1aac65be3a92db6e76bf62336569ee65246666
> Cr-Commit-Position: refs/heads/master@{#414420}

TBR=dpranke@chromium.org,glider@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=640185

Review-Url: https://codereview.chromium.org/2347223002
Cr-Commit-Position: refs/heads/master@{#419220}

Revert of Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target (patchset #1 id:1 of https://codereview.chromium.org/2286623002/ )

Reason for revert:
Reverting, because Dr. Memory test bots need that executable. It didn't break until a clobber landed and deleted the executable generated in the past.

Also glider@ reports that chrome_app_unittests was probably innocent (in the bug report) anyways.

First breaking build: https://build.chromium.org/p/chromium.memory.full/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/130

Original issue's description:
> Remove chrome_app_unittests from chromium_builder_dbg_drmemory_win target
>
> This should probably fix the compile step on the Dr. Memory builder.
>
> BUG=640185
> TBR=dpranke@chromium.org,cpu@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/48586ee56e601e60095f30723060d4bd888ce6fe
> Cr-Commit-Position: refs/heads/master@{#414670}

TBR=cpu@chromium.org,dpranke@chromium.org,glider@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=640185

Review-Url: https://codereview.chromium.org/2341353002
Cr-Commit-Position: refs/heads/master@{#419219}

This CL modifies the export behavior when clicking 'Save as...' from the context menu in the
console. Exported logs now include the entire formatted message, including the anchor location
(source file : line number) and contents of stack traces.

Screenshot: http://imgur.com/a/DVKkW

BUG=505190, 505177

Review-Url: https://codereview.chromium.org/2270033003
Cr-Commit-Position: refs/heads/master@{#419218}

BUG=632930

Review-Url: https://codereview.chromium.org/2340533003
Cr-Commit-Position: refs/heads/master@{#419217}

This CL moves some code from site_lists.js to site_settings_behavior.js
so that it can be used from site_details.js. As a result, we can
complete the initialization of the SiteException received in
site_details.js and show the URL in that UI.

BUG=635874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338133008
Cr-Commit-Position: refs/heads/master@{#419216}

In this CL:
 - Make test methods in update_w3c_test_expectations have more realistic examples.
 - Change some lines in write_to_test_expectations to make that method shorter.

This is a refactoring CL (no behavior changes).

BUG=647395

Review-Url: https://codereview.chromium.org/2349543002
Cr-Commit-Position: refs/heads/master@{#419215}

s.t. cc_perftests can find the device .isolate file we now generate.

BUG=647016

Review-Url: https://codereview.chromium.org/2342253002
Cr-Commit-Position: refs/heads/master@{#419214}

The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors.

BUG=615373
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2345773002
Cr-Commit-Position: refs/heads/master@{#419213}

rollforward cr/2296923004 with fix: updated unittest to prevent issue with unreachable code (win_chromium)

BUG=635596

Review-Url: https://codereview.chromium.org/2345693004
Cr-Commit-Position: refs/heads/master@{#419212}

This is needed to allow the UiAccess enabled binary to work.  Otherwise the
binary will crash on launch which is an undesirable behavior.

BUG=617185

Review-Url: https://codereview.chromium.org/2349583002
Cr-Commit-Position: refs/heads/master@{#419211}

R=stevenjb@chromium.org, phajdan.jr@chromium.org
BUG=643238

Review-Url: https://codereview.chromium.org/2344093002
Cr-Commit-Position: refs/heads/master@{#419210}

Reverted in
https://codereview.chromium.org/2342243003/

Reason for reland:
Actually fixed gn gen failure.

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org,yutak@chromium.org
BUG=641032

Review-Url: https://codereview.chromium.org/2342023004
Cr-Commit-Position: refs/heads/master@{#419209}

Previously the field trial testing was incorrect. The key was the
feature name instead of the Finch experiment name.

BUG=608886

Review-Url: https://codereview.chromium.org/2342893003
Cr-Commit-Position: refs/heads/master@{#419208}

https://chromium.googlesource.com/skia.git/+log/3d5541dc3d0f..43d665111137

$ git log 3d5541dc3..43d665111 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 msarett Support Float32 output from SkColorSpaceXform
2016-09-16 jvanverth Remove old SkGaussianEdgeShader code

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2348603004
Cr-Commit-Position: refs/heads/master@{#419207}

https://chromium.googlesource.com/chromium/src/+/e34a6457a

BUG=601247
TBR=kdsilva@google.com

Review URL: https://codereview.chromium.org/2343203002 .

Cr-Commit-Position: refs/heads/master@{#419206}

We ended up not using it, and there are no plans to use it in
the future. It adds some unnecessary complexity to
SyncMessageFilter which I don't want to have to maintain as
I add some extra support for associated interfaces.

BUG=612500
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2343033002
Cr-Commit-Position: refs/heads/master@{#419205}

The source event type information will be used in a follow up patch to compute scroll latency metrics for touch and wheel, separately.

BUG=622827
TEST=RenderWidgetHostViewAuraTest.SourceEventTypeExistsInLatencyInfo, RenderWidgetHostViewMacTest.SourceEventTypeExistsInLatencyInfo, EventTest.PointerEventSourceEventTypeExistsInLatencyInfo

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2317253005
Cr-Commit-Position: refs/heads/master@{#419204}

Uses drawing commands rather than raster assets.

This CL tries to retain/reuse the same positioning logic that already exists, but I didn't attempt to correct any bugs in positioning that might be introduced. That's up next.

BUG=635170

Review-Url: https://codereview.chromium.org/2343913003
Cr-Commit-Position: refs/heads/master@{#419203}

This reduces the number of compilation units that depend on files like
LayoutBlock.h by more than 200 (from around 500 to around 280).

Review-Url: https://codereview.chromium.org/2348853003
Cr-Commit-Position: refs/heads/master@{#419202}