- 11 Jun, 2020 40 commits
-
-
Evan Stade authored
This is the first refactor that prepares the code for componentization. After further refacrtoring, the next step will be to relocate the relevant code and resources to //components/browser_ui/media_session/. This patch splits MediaSessionTabHelper into two classes, separated by what is componentizable and what is Chrome specific. Most of this class is moved into a new class MediaSessionHelper, which operates on a WebContents rather than a (Chrome) Tab. MediaSessionTabHelper remains as a thin wrapper and implementor of MediaSessionHelper.Delegate. The most substantive change is moving functionality from TabObserver (in MediaSessionTabHelper) to WebContentsObserver (in MediaSessionHelper). Bug: 1066263 Change-Id: I9259a082686c0e0f6b9788bc15a19e887c0e95e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204964 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#777374}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ea07c860154..25ab22e43971 2020-06-11 fmayer@google.com Merge "Do not depend on elf.h for symbolization." 2020-06-11 rslawik@google.com Merge "Hide time_in_state thread counter tracks" 2020-06-11 lalitm@google.com Merge "CTS: mark activities as android:exported="true"" 2020-06-11 fmayer@google.com Merge "Do not explicitly start heapprofd in heap_profile." 2020-06-11 fmayer@google.com Merge "Make assertion explicit." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I261ac37798262ee282850c273199e2baff9a818d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777373}
-
Chris Lu authored
InfobarSaveCardModalConsumer will be used to help SaveCard overlay migration which will need a consumer for the modal mediator to push information to the TableViewController UI. This change refactors the existing Messages implementation using InfobarSaveCardModalConsumer. Bug: 1071914 Change-Id: I537055a9e83d04902430748983dddf38e49c4db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238754 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#777372}
-
Koji Ishii authored
This lets us control FragmentItem rollout via Finch. Tested either of following commands enables FragmentItem: % content_shell --enable-features=FragmentItem % content_shell --enable-blink-features=LayoutNGFragmentItem Bug: 982194 Change-Id: Ib3836b59f2cdeafebb961d2ca3df8109f9e0ced8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239773 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#777371}
-
Emily Stark authored
This logic is meant to hide the path by default when reveal-on-hover is enabled and hide-on-interaction is disabled, but instead we were hiding the path whenever hide-on-interaction is disabled (including when the user doesn't have any flags flipped). Bug: 1093748 Change-Id: Ia42434906e64366374dc78a7681ce7e74951711b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241339Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#777370}
-
Raphael Kubo da Costa authored
This header defines max and min as macros, which can break the subsequent <algorithm> include with at least libstdc++. Bug: 957519 Change-Id: Ib2b3fa3a61ce98874a2c4c1e2ffd2cd3d855ccaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240861 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#777369}
-
Owen Min authored
Remove all places that mention the reporting extension which has been deprecated, mostly for policy group. Make policy description consistency for all reporting policies even for policies that are currently not supported. Change-Id: I218077597d402483caf417649da211d039f17280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240062 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#777368}
-
Ken Rockot authored
Bug: 1082761 Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#777367}
-
Rouslan Solomakhin authored
Before this patch, deleting the singleton ServiceWorkerPaymentAppFinder at browser shutdown could result in a crash. This is a speculative patch that changes ServiceWorkerPaymentAppFinder to be owned by a render frame host and its internal helper SelfDeletingServiceWorkerPaymentAppFinder is changed from self-owned to be owned by WebContents. Tests now must navigate to the page that will invoke the PaymentRequest API before injecting the test-only downloader into ServiceWorkerPaymentAppFinder. The SelfDeletingServiceWorkerPaymentAppFinder helper cannot be owned by RenderFrameHost because RenderFrameHost implementation supports only one owned object per class, but there must be one instance of the helper per PaymentRequest object in JS, of which there can be many. The two_payment_requests_browsertests.cc is added to verify that multiple PaymentRequest objects work correctly when used simultaneously. After this patch, ServiceWorkerPaymentAppFinder is no longer a singleton, but is instead owned by the render frame host. Bug: 1092477 Change-Id: I48ac819de79641ed5c2a638c302b6a696a340250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236197Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#777366}
-
David Lechner authored
This fixes a compile error that was accidentally introduced in https://crrev.com/2191232. For unknown reasons this does not cause a compile error with libc++, which is normally used with chromium, but does cause an error with stdlibc++. The API for preparing write requests was not changed in https://crrev.com/2191232, so the change that introduced this error was incorrect anyway. This reverts the change that introduced the error and adds the kTypeRequest argument to the call to WriteValue() since that was the API that was actually changed in the prior CL. Bug: 1092470 Change-Id: I6f6fe90ab42aea3db8cac95b69aee5095ea33b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237388Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: David Lechner <david@pybricks.com> Cr-Commit-Position: refs/heads/master@{#777365}
-
Gauthier Ambard authored
Bug: 1080907 Change-Id: I5bbcc074197cddd4e1ec8afeeb715fd782f05e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235841 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#777364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6e7fe26ccc85176e47958590a27fe2ce7980647e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241726Reviewed-by:
-
David Black authored
Next CL will populate the grid w/ suggestions from the Assistant suggestions model. Note that this CL also corrects gfx::kGoogleRed050. Bug: b:157689497 Change-Id: I22d95bc2f8f3e9c944e6403c56a84536f8b67575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238757 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777362}
-
Bailey Berro authored
This change parameterizes the ResolutionNotificationController tests to run with the kListAllDisplayModes flag both on and off to prepare for enabling the flag by default. Bug: 1024113 Change-Id: I66222401a0b47341f65f2d6df0a82a7294b3c049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227373 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#777361}
-
Jamie Madill authored
This reverts commit 569d611c. Reason for revert: Suspected of causing failures on GPU bots. See issue for more details. Bug: 1093667 Original change's description: > Show Offline indicator if device has been offline for 2 seconds > > When the connection changes from online to offline, wait 2 seconds > before showing the offline indicator. In some cases, it may > take some time for the device to establish the connection. > In those cases, we do not want to unnecessarily show the offline > indicator. > > Bug: 1084740 > Change-Id: Ie83340342fa0c7b4778d3362174f9d04631c3bb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232801 > Reviewed-by: Jian Li <jianli@chromium.org> > Reviewed-by: Sinan Sahin <sinansahin@google.com> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777217} TBR=jianli@chromium.org,tbansal@chromium.org,sinansahin@google.com Change-Id: I27c4848f3220e896c1fb38884ee6c404394d01a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1084740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241177Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#777360}
-
Charlie Hu authored
|FeaturePolicyFeature::kDocumentCookie| is not used anywhere in the codebase and thus should be removed. Change-Id: I43cb989d94d824ac1f0f408da1110778b38360ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240034Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#777359}
-
Becca Hughes authored
Adds a copy of Google Closure Library to //third_party so we can use Protobuf JS. Eng-Review: https://groups.google.com/a/google.com/g/chrome-eng-review/c/qGhhrucgSo4/m/oYT5wPiIAgAJ BUG=1087037 Change-Id: I31011bb1ae3334ab2ce6bc7f0277aab052ad8a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226913Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#777358}
-
Joey Arhar authored
This gets us both the desired logic of having anchor navigations take precedence over form submissions and not canceling form submissions when the anchor doesn't actually navigate anywhere without lots of extra logic needed in HTMLAnchorElement. It essentially restores the logic in FrameLoader which used to cancel pending navigations through NavigationScheduler. This line in particular would cancel form submissions for anchor navigations: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/loader/frame_loader.cc?l=1590&rcl=8f4e07de2e8797821a9446eb66ceeb305d763cbf Bug: 1053679, 1092313 Change-Id: Ic304c2650181d0e18d0bebf488d9275c5cf5692b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090724Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#777357}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7d475b39170ffa60c31c998fd34b5ed6bc4f8183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241333Reviewed-by:
-
Ramin Halavati authored
The following 3 functions user IsOffTheRecord but their name indicate incognito only: - BrowserList::GetIncognitoSessionsActiveForProfile - BrowserList::IsIncognitoSessionInUse - BrowserList::IsIncognitoSessionActive |Incognito| is replaced with |OffTheRecord| in fix the function names, and also |Session| is replaced with |Browser| to resolve a TODO. This CL does not change any functionality and is just code clean up. Bug: 968028, 1014002 Change-Id: Ic232076ab55114bf79144b0b15d7a653d2f72f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241116Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#777355}
-
Alexandre Courbot authored
Narrow the scope of the dequeued buffer variable in the service task handler, to the dequeued buffers are made available faster. BUG=b:149663704 TEST=VDAtest --use_vd passes on Krane. Change-Id: I7f377de7ccf90e7f323215697fdd3073a518ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235583 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#777354}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/18992f7be95a..ba3c6becdfc5 2020-06-11 cwallez@chromium.org Fix compilation error of MemoryServiceDmaBuf on ChromeOS 2020-06-11 cwallez@chromium.org Vulkan: handle Instance extensions more programmatically 2020-06-11 xing.xu@intel.com Add storage texture case reading from read-only then writing into write-only 2020-06-11 cwallez@chromium.org Add CopyB2B tests including for 0-sized copies 2020-06-11 cwallez@chromium.org Add tests and fix (create) mapping zero-sized buffers 2020-06-11 hao.x.li@intel.com Query API: QuerySet 2020-06-10 jiawei.shao@intel.com Vulkan: Enable nonzero_clear_resources_on_creation_for_testing on buffer 2020-06-10 jiawei.shao@intel.com Enable CopyTests_T2T/CopyWithinSameTexture* tests on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2b7a9797c01471f76d813232b77b16ad9c30d13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241717Reviewed-by:
-
Hui Wang authored
This CLs ensures that same-document browser-initiated navigations on documents loaded from a data URL with a valid base URL will not modify the document URL. It will remain the base URL instead of reverting to the data URL. Bug: 1082141 Change-Id: I8347b5e82829fbbb3252bd4aa6393bbc353201fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198837 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777352}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I3868550e8717dfae6d2291b0f904522989c44dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237582Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#777351}
-
Nate Fischer authored
This adds info about work profile and Samsung Secure Folder and how to work around these when switching WebView provider. Fixed: 1092497 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Iac02758b9772962b7949c267c52919e43f415204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237048 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#777350}
-
Yann Dago authored
Bug: 958893 Change-Id: I689b960624c336f9b7a1963f51e5cf422d2758c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231755 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#777349}
-
Guillaume Jenkins authored
Move the reporting request namespace to components so it can eventually be reused by iOS code. Bug: 1091914 Change-Id: Ifd519dfc2d817f095265f652994a684b5436dc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240192Reviewed-by:
-
Alexei Svitkine authored
This should help debug more what's happening. Bug: 1090968 Change-Id: Iedc6d66f79cde93092587a22b5333f01a65ca0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240137Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#777347}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591847470-22394db4eae687d46ca49599d3bc16bb448d2db1.profdata to chrome-win32-master-1591876517-dd7faaeec22d918256a2af8afd22dfee486b79d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f61481c09eeda388c13cfc72edbca1b8169ac03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241713Reviewed-by:
-
Francois Doray authored
This CL adds a feature that limits to 20 the number of family names that can be accessed by a renderer. This feature will be enabled for a subset of users to assess the impact on input delay. It will not ship as-is, because it breaks some pages. Local experiments show that accessing >20 fonts is typically done by fingerprinting scripts. A few family names can be accessed even when the limit is reached, because Blink uses them as last resort. Bug: 1089390 Change-Id: I231bf1f1b192868174c22ad1152195f874231dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239684 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#777345}
-
Yann Dago authored
Bug: 1086955 Change-Id: Ifd20ded53728b7b24838a343b9dd9ab4bbe2d797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231295Reviewed-by:
-
chrome://flags#enable-launcher-app-pagingAna Salazar authored
This change adds a flag to enable the new launcher app drag redesign. Design doc: https://docs.google.com/document/d/1klNglz8LFuCoHQDHo43SQaBMxnvCRSDAl_BakCSpVto/edit Bug: 996822: Change-Id: I890a35a579b5ce83ef96d2027a0091c503391793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240030Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#777343}
-
Sebastien Lalancette authored
Bug: 1093302 Change-Id: I9132694a27c0d017bba585d4ed6c93e08c0e483a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238371 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#777342}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eb9f481af818..30fcc49adc0b 2020-06-11 fancl@chromium.org sheriff-config: Support exclude in Rule If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1055685 Tbr: sadrul@google.com Change-Id: Ia744be61f4d14c4c56c63bf2a9a8819f8efe942b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239663Reviewed-by:
-
Ben Kelly authored
Fixed: 1089978,1089977,1089976 Change-Id: Ib7dd184e26560b294d4558fa4540ad588d96a7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238559Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#777340}
-
Hitoshi Yoshida authored
If an IDL definition has a default null value for a nullable enumeration type, its initializer expression is expected to be "base::nullopt", but "nullptr" was generated. // IDL enum E {"a", "b"}; dictionary D { E? m = null; }; // Expect C++ class D : public bindings::DictionaryBase { ...(snip)... base::Optional<E> m_{base::nullopt}; }; // Actual C++ class D : public bindings::DictionaryBase { ...(snip)... base::Optional<E> m_{nullptr}; }; This CL fixes the issue. Bug: 839389 Change-Id: Iccd312fc7b6c2b048d41a970e140c9ae79a69490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241351Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#777339}
-
Dale Curtis authored
Fixed: 1088905 Change-Id: I2ac06cd576f72cbb3b3ea04987902c8d9e307093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240025 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
The stateful decoder requires the input queue to be streaming as we give it buffers, in order to us to get the first resolution change event, so start streaming the queue during Initialize(). The stateless decoder doesn't require this behavior, but won't be affected by it. BUG=b:149663704 TEST=VDAtest --use_vd passes on Krane. Change-Id: I783e20c57369bed8e9b8a9a6b9d05a82f14d8a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235582 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#777337}
-
Mohamed Heikal authored
The MobileStartup.ToolbarFirst*.* histograms are no longer useful. This cl removes the histogram recording code and also removes the OmniboxStartupMetrics class. Bug: 1053190 Change-Id: I239bfd9635d05a6269e362191996d03d44c4dfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238448Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#777336}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10d70555cd6f..0805f4a03309 2020-06-11 patrick.brosset@microsoft.com Shared goToResource e2e helper to simplify tests 2020-06-11 patrick.brosset@microsoft.com Re-enable the network e2e test 2020-06-11 mathias@chromium.org Add stylelint dependency 2020-06-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1091226,chromium:1093287 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a3710c77a5ae2e6193f7d4005207f6554ecf540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241286Reviewed-by:
-
