GitLab

BUG=None

Review URL: https://codereview.chromium.org/376133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282334 0039d316-1c4b-4281-b951-d872f2087c98

An earlier change to narrow the whitelisting behavior for the Compositor and
VideoDecode APIs enforced whitelisting, but removed the channel version check
which permits use of these API on dev and canary builds of Chrome.
https://codereview.chromium.org/346263006

This fixes that regression (and highlights the need for better testing for API
permissions).

BUG=

Review URL: https://codereview.chromium.org/378353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282333 0039d316-1c4b-4281-b951-d872f2087c98

Two recent flakes:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32469
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32479

(One before the clang switch, one after, so it's unrelated to that.)

BUG=367701
TBR=yutak@chromium.org

Review URL: https://codereview.chromium.org/384783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282332 0039d316-1c4b-4281-b951-d872f2087c98

> Map WebSocket URL schemes to HTTP URL schemes for auth purposes.
> 
> This permits WebSocket connections to inherit credentials from HTTP pages, and
> matches the behaviour of other browsers.
> 
> Design doc: https://docs.google.com/a/chromium.org/document/d/129rLtf5x3hvhP5rayLiSxnEjOXS8Z7EnLJgBL4CdwjI/edit
> 
> Also consider any 401 or 407 results that reach the WebSocketStream
> URLRequest::Delegate to be unrecoverable errors.
> 
> Also ensure that the response headers are reported back to the renderer
> when the developer tools are open and a 401 error happens.
> 
> BUG=123862
> 
> Review URL: https://codereview.chromium.org/336263005

Seems to cause WebSocket1 failure in WinXP

TBR=ricea@chromium.org

Review URL: https://codereview.chromium.org/388493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282331 0039d316-1c4b-4281-b951-d872f2087c98

The patch made the bubble unresponsive on Win (see crbug/392734).

> Password bubble: Don't focus by default.
> 
> BUG=383821
> 
> Review URL: https://codereview.chromium.org/373043003

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/381913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282325 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/376403002/ ,
looks like the 64bit bot just hadn't cycled yet.

BUG=360311
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/387513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282324 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282323 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177812:177816&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/382633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282322 0039d316-1c4b-4281-b951-d872f2087c98

Yak shaving to land https://codereview.chromium.org/380533003/

Before the patch, |MemoryObserver| called |GetMemoryUsageKB()| without
any check, which is only valid after webkit is initialized.
GetMemoryUsageKB queries |v8::Isolate::GetCurrent()| internally, but the
query fails on DCHECK on debug builds.

This patch moves the |MemoryObserver| instantiation inside |RenderThreadImpl::EnsureWebKitInitialized|.

BUG=None

Review URL: https://codereview.chromium.org/380603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/378823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282319 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/380123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282318 0039d316-1c4b-4281-b951-d872f2087c98

When vertical_density is 1,
the value of horizontal_density from do_clustering() should be equal to 1.
Thus, it skips the horizontal sort process in this case.

When I checked logs in google.com and www.naver.com, 
this condition (vertical_density equals to 1) is met 
for more than 70% of cases.

BUG=312861

Review URL: https://codereview.chromium.org/379823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282317 0039d316-1c4b-4281-b951-d872f2087c98

> Add function queryForNewLocalDevices to send query for new local devices,
> implement it for mDNS (WiFi devices forthcoming)
>
> BUG=383167
>
> Review URL: https://codereview.chromium.org/356613002

TBR=noamsml@chromium.org

Review URL: https://codereview.chromium.org/387453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282315 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282314 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177793:177811&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/379973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282313 0039d316-1c4b-4281-b951-d872f2087c98

Ephemeral apps should not be used to open files via the ChromeOS file
manager as they are not permanently installed.

BUG=391145
TEST=unit_tests

Review URL: https://codereview.chromium.org/381583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282312 0039d316-1c4b-4281-b951-d872f2087c98

These should be generated by the browser instead. I considered
verifying the generated credentials but I think that's better done in
a different test.

R=bemasc@chromium.org

Review URL: https://codereview.chromium.org/376863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282311 0039d316-1c4b-4281-b951-d872f2087c98

With the old approach (storing the current and old passwords for a form), we could not tell apart login forms from sign-up forms and change password forms that did not have a password confirmation field.

Furthermore, the new approach align more nicely with the new-password and current-password scheme we use for the autocomplete attributes.

BUG=375333

Review URL: https://codereview.chromium.org/356223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282310 0039d316-1c4b-4281-b951-d872f2087c98

These tests will be broken by the blink side change which removes HeaderMap and introduces Headers class.
https://codereview.chromium.org/373613004/

After the blink side change will land, I will re-enable the tests.

BUG=373120

Review URL: https://codereview.chromium.org/379323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282309 0039d316-1c4b-4281-b951-d872f2087c98

Currently, display offset for a gfx::RenderText is computed
automatically to ensure the cursor is always visible. This CL adds the
ability to set display offset explicitly which, as an example, can be
useful in adding touch scrolling to textfields. Display offset set this
way is not permanent and will be recalculated next time a property
(text, font, alignment, etc.) is changed.

BUG=388862

Review URL: https://codereview.chromium.org/378723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282308 0039d316-1c4b-4281-b951-d872f2087c98

This permits WebSocket connections to inherit credentials from HTTP pages, and
matches the behaviour of other browsers.

Design doc: https://docs.google.com/a/chromium.org/document/d/129rLtf5x3hvhP5rayLiSxnEjOXS8Z7EnLJgBL4CdwjI/edit

Also consider any 401 or 407 results that reach the WebSocketStream
URLRequest::Delegate to be unrecoverable errors.

Also ensure that the response headers are reported back to the renderer
when the developer tools are open and a 401 error happens.

BUG=123862

Review URL: https://codereview.chromium.org/336263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282307 0039d316-1c4b-4281-b951-d872f2087c98

    
RenderArena object is deprecated in WebCore.
And WebCore path has been changed from WebCore to core.

BUG=None

Review URL: https://codereview.chromium.org/352113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282306 0039d316-1c4b-4281-b951-d872f2087c98

Most methods simulate TrackerIDSet structure on LevelDB entries.
GetTrackerIDSetByPrefix() builds up a real TrackerIDSet to
get gathered information.



BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest*"

Review URL: https://codereview.chromium.org/371873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282305 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org
BUG=

Review URL: https://codereview.chromium.org/379403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769
TEST=unit_tests --gtest_filter="SyncProcessRunnerTest.*"

Review URL: https://codereview.chromium.org/373413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282303 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282302 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/57ad493789cb1a97574390b5ccf4fb9183ed3814..da03653f347e38a27e79b1dfb8c731bf9a184909

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=jcgregorio@google.com
BUG=

Review URL: https://codereview.chromium.org/383643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282301 0039d316-1c4b-4281-b951-d872f2087c98

Added GetPDFPageSizeByIndex to expose FPDF_GetPageSizeByIndex. The function outputs the width and height, in points, of a given PDF document page.

BUG=388517

Review URL: https://codereview.chromium.org/376083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282300 0039d316-1c4b-4281-b951-d872f2087c98

To add more result display types to the app list search results, we plan to
have a large pool of results which will be filtered by display type.

As a displayed result may retain its display index but have a different model
index, it is necessary to handle reordering of the items in an in-place way to
avoid icon flickering.

The current implementation only avoids flickering when the result is in the
same model index which is unsuitable for our purposes.

BUG=349727

Review URL: https://codereview.chromium.org/369693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282299 0039d316-1c4b-4281-b951-d872f2087c98

Rename local variable from 'p' to 'parcel.  Call parcel.setDataPosition(0)
between write and read.  Fix a log message for punctuation.

Fixes (from logcat):
  E/Bundle  ( 5115): readBundle: bad magic number
  E/Bundle  ( 5115): readBundle: trace = java.lang.RuntimeException
  E/Bundle  ( 5115):      at android.os.Bundle.readFromParcelInner(Bundle.java:1677)
  E/Bundle  ( 5115):      at android.os.Bundle.readFromParcel(Bundle.java:1670)
  E/Bundle  ( 5115):      at org.chromium.base.library_loader.Linker.useSharedRelros(Linker.java:494)
  E/Bundle  ( 5115):      at org.chromium.content.app.ChildProcessService$1.setupConnection(ChildProcessService.java:100)
  E/Bundle  ( 5115):      at org.chromium.content.common.IChildProcessService$Stub.onTransact(IChildProcessService.java:57)
  E/Bundle  ( 5115):      at android.os.Binder.execTransact(Binder.java:388)
  E/Bundle  ( 5115):      at dalvik.system.NativeStart.run(Native Method)

BUG=388356

Review URL: https://codereview.chromium.org/371943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282298 0039d316-1c4b-4281-b951-d872f2087c98

We're working on fixing these, but disable them to make the waterfall
green until they are working.

BUG=382573
TEST=none
NOTRY=true
NOTREECHECKS=true

depends on https://codereview.chromium.org/379933002/

Review URL: https://codereview.chromium.org/383473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282297 0039d316-1c4b-4281-b951-d872f2087c98

Tests on XP are failing. 

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34594 
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29

We should use LoadLibrary and GetProcAddress to call SetupDIGetDeviceProperty
because it is not available in WinXP.

> Retrieve "connected" property from BLE devices.
> 
> We have to use the SetupDIGetDeviceProperty API to retrieve this specific property, as the "connected" status is something common to many PnP devices.
> 
> BUG=388016
> 
> Review URL: https://codereview.chromium.org/379943003

TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/383693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282295 0039d316-1c4b-4281-b951-d872f2087c98

We need to revert r282212 which breaks XP tests.
> Expose "visible" and "authenticated" properties.
> 
> They are always "true" for now, due to the way BLE devices work under Windows 8.
> 
> BUG=388016
> 
> Review URL: https://codereview.chromium.org/378293007

TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/388453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282294 0039d316-1c4b-4281-b951-d872f2087c98

glQuery objects are not sharable, so managing IDs for each client
locally in GLES2Implementation.

BUG=

Review URL: https://codereview.chromium.org/371363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282292 0039d316-1c4b-4281-b951-d872f2087c98

Updating the history state has been a surprisingly rich source of performance
bugs. This minimal page exemplifies them.

BUG=391158

Review URL: https://codereview.chromium.org/378803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282291 0039d316-1c4b-4281-b951-d872f2087c98

Default chunk size is 32KB and it is too small for provided file systems, which
require IPC calls for each chunk. Such small chunks cause the IPC overhead to
slow down the reading process drastically.

Moreover, since there is no streaming support in XMLHttpRequest, returning
data in chunks in providing extensions, requires making separate HTTP requests
with appriopriate Range header. That introduces another overhead.

This patch introduces a wrapper on a FileStreamReader, which converts 32KB
chunk requests to 512KB chunk requests to the underlying file stream  reader.

As a result, the overhead of IPC and HTTP is decreased significantly.

TEST=unit_tests: *FileSystemProvider*BufferingFileStreamReader*
BUG=248427

Review URL: https://codereview.chromium.org/318563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390819

Review URL: https://codereview.chromium.org/377383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282288 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177731:177792&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/384503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282287 0039d316-1c4b-4281-b951-d872f2087c98

They are always "true" for now, due to the way BLE devices work under Windows 8.

BUG=388016

Review URL: https://codereview.chromium.org/378293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282286 0039d316-1c4b-4281-b951-d872f2087c98