- 07 Feb, 2018 19 commits
-
-
Nico Weber authored
No behavior change. Actually turning on the warning is blocked on an issue in protobuf (see crbug.com/809157), so this will happen in a future CL. Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If4a2e661257a77298bacf589b7bdf02e0e54374d Reviewed-on: https://chromium-review.googlesource.com/902066Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#534862}
-
Yuki Awano authored
- Enables new implementation of touch support for screen magnification by default. - Removes the old implementation of touch support for screen magnification. around with two fingers scroll without any flag. Pass ash_unittests:MagnificationControllerTest Bug: 670526 Test: Confirm that you can change zoom level with pinch gesture and pan Change-Id: Icf25edb2bceae28323075f857c3e74c2b4526dcc Reviewed-on: https://chromium-review.googlesource.com/903306Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#534861}
-
James Cook authored
--mash causes thousands of lines of UI code to behave differently, but in the best case there's no visual indication of what mode you're in. Add an indicator to the status area that shows if you're running --mash. This could be generalized later to a "flag warning", like we use in browser windows when running --no-sandbox. Bug: 808158 Test: ash_unittests Change-Id: I477158085bed9665c2fc9e7d2356c1f346083919 Reviewed-on: https://chromium-review.googlesource.com/905631 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534860}
-
Aga Wronska authored
Add new metrics for 'Browse as guest' and 'Add person' buttons, that are only shown on login screen shelf. Split existing click target metrics into separate histograms for login and lock screen. Use helper enumerations that are converted to histogram values to keep metrics deduction code enclosed in metrics recorders. Bug: 798848 Change-Id: I9a6ddbccfcd301dec770362916ceaa7ca9fa721e Reviewed-on: https://chromium-review.googlesource.com/894063 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#534859}
-
Stuart Langley authored
The mojo work for web clipboard has introduced a regression when copying images. Originally the code was in content and was using net::EscapeForHTML to escape the URL of the image and the title. When converted to mojo and moved inside of blink this was changed to EncodeWithURLEscapeSequences which is a different encoding scheme. This change reverts to using an escaping the same as net::EscapeForHTML, however as net::EscapeForHTML uses std::string and we are working with WTF::String we have had to copy the code rather than re-use it. Bug: 806076 Change-Id: Ic51835c555c071571a837018d74a27fd455362cf Reviewed-on: https://chromium-review.googlesource.com/896762 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#534858}
-
Jiaquan He authored
The AppList UI is being moved into Ash, we'll not be able get its window in Chrome any more. Bug: 733662 Change-Id: I132cba730516a5b1492d306fb99651543a0ef364 Reviewed-on: https://chromium-review.googlesource.com/897470Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#534857}
-
Benjamin Shaya authored
CHECK on user builds do not create logs for DEATH_TEST to match. Change-Id: I2df09257311579133701be0f1293f4107ce99f1e Bug: b/72821844 Test: cast_audio_backend_unittests on device w/ user build Reviewed-on: https://chromium-review.googlesource.com/903052Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#534856}
-
https://skia.googlesource.com/skia.git/+log/744160486520..5dd202dc9002 $ git log 744160486..5dd202dc9 --date=short --no-merges --format='%ad %ae %s' 2018-02-06 reed Revert "Revert "move GrColor.h to private, IWYU"" 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ceb7190bb..fbb1c7921 (3 commits) 2018-02-06 fmalita Fix picture shader handling of outer local matrix 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ca5c10598..ceb7190bb (1 commit) 2018-02-06 reed add maskfilter+localmatrix to fix savelayer 2018-02-06 jvanverth Revert "Cleanup of large text rendering." Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: If6c02f50485a9ee496f683bab52bb8a0441ac303 Reviewed-on: https://chromium-review.googlesource.com/905237Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534855}
-
Doug Arnett authored
Uses NoScript inflation_percent from optimization guide hints if not 0. Bug: 807662 Change-Id: I6478e751bc073c49159098eed37b702e9160641b Reviewed-on: https://chromium-review.googlesource.com/895286Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#534854}
-
Lukasz Anforowicz authored
Bug: 809735 Change-Id: I9e5376b7fcea6f4a96fdf831b13bae801753e962 Tbr: creis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/905748Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#534853}
-
Eugene But authored
This tests load rejection when ShouldAllowResponse returns false. Bug: 614168,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I91c1da903fdda7910aadc7ffdf74c23a72f79bde Reviewed-on: https://chromium-review.googlesource.com/900094Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534852}
-
Matthew Jones authored
BUG=803098 Change-Id: I18537d5a844368a694bbb292a98a94da735c6bfb Reviewed-on: https://chromium-review.googlesource.com/900100 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534851}
-
Mike Wasserman authored
These tests appear to pass as-is on ToT @ #534716. Bug: 695563, 698887, 775177 Test: Automated Change-Id: I6d3979aec6738e4d14c2119faa3488d0ee1c596e Reviewed-on: https://chromium-review.googlesource.com/905687Reviewed-by:
-
Mike Baxley authored
FullscreenTestCase.testShowHeaderWhenChildTabCloses results in an error when the child tab is closed, because the web view is invlaidated. this behavior is expected, and should be verified. Add a helper to tap on a web view element, which can return an NSError. Bug: 807789 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I401319a1c19af60cdfd71e4fc6a75f36153e954b Reviewed-on: https://chromium-review.googlesource.com/902792 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534849}
-
Xiaocheng Hu authored
Spellchecker has a heuristic that, if the bounding box of an editing host is not in viewport, don't check anything in the editing host. This is wrong as there might still be descendants of the editing host inside the viewport. Hence, this patch removes the heuristic. Bug: 768231 Change-Id: I22995b365c6a3e10eedb76a4868746f09261e733 Reviewed-on: https://chromium-review.googlesource.com/903265 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534848}
-
Thomas Anderson authored
This reverts commit 036ea24b. Reason for revert: Causing build failure on Cast Audio Linux: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/8575 Original change's description: > Introduce WebRtcRemoteEventLogManager > > WebRtcRemoteEventLogManager is a member of WebRtcEventLogManager, in > charge of managing remote-bound WebRTC event logs: > * Store remote-bound log files locally, persisting them between session > of Chrome. > * Uploading them when permissible (when no active peer connections are > present, with which the upload's increased bandwidth utilization might > interfere). > * Purge remote-bound log files from local disk once an upload attempt > was made, regardless of whether it was successful. (Otherwise, we might > end up attempting multiple times, wasting bandwidth on an upload that > always fails after a non-trivial amount of data was pushed upstream. > More refined retry behavior is to be added at a later stage.) > > Upcoming related work: > * Actual implementation of the uploader (this CL deals with managing the > files to be uploaded, and the timing of the upload). > * Implementation of the JS hooks. > > Bug: 775415 > Change-Id: Ib5ee6081ca13d85cb8a3f38d6462bbd61a99dcae > Reviewed-on: https://chromium-review.googlesource.com/891219 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534826} TBR=avi@chromium.org,guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org Change-Id: I2bc87f1002eac26f4c77bc5082be45db80b0449d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415 Reviewed-on: https://chromium-review.googlesource.com/905826Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534847}
-
Nate Chapin authored
We're shipping the kResourcesBeforeDCL in M65, so remove the other behaviors now that we've branched. Bug: 513459 Change-Id: Id5b5f0bac5c35c0e3a3f574a4695858916c40283 Reviewed-on: https://chromium-review.googlesource.com/875261Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#534846}
-
Andrey Kosyakov authored
This reverts commit 022ed8ae. Reason for revert: this broke Cast Audio bots, https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64%20Cast%20Audio/4367 Original change's description: > RenderProcessHost exiting is an implicit PeerConnection removal > > When a RenderProcessHost exits clearly or crashes, all of its > PeerConnections should be considered as removed. > > Bug: 775415, 805398, 808402 > Change-Id: I223e6e867758ef05d896608fbdcc3bc824238dd8 > Reviewed-on: https://chromium-review.googlesource.com/899348 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534840} TBR=guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org Change-Id: I6f33dded2bba23f471c73495518fdded3ccbc3dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415, 805398, 808402 Reviewed-on: https://chromium-review.googlesource.com/905638Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#534845}
-
https://webrtc.googlesource.com/src.git/+log/29f14322d13e..dffead8835d1 $ git log 29f14322d..dffead883 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I193181e14cd93321906bc4fde31c453a65439a5a Reviewed-on: https://chromium-review.googlesource.com/905628 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534844}
-
- 06 Feb, 2018 21 commits
-
-
Victor Costan authored
In component builds, SQLite's API methods are exported from the chromium_sqlite component, which means they are visible to the dynamic library loader. This opens up the following possibilities: 1) A system library calls into our SQLite instead of calling into the system's SQLite library which it was built against. The patches in our SQLite version lead to different behavior from the system's SQLite, which can cause subtle failures. This happens if the dynamic library loader resolves the system library's symbol imports with our SQLite's exported symbols. 2) A system library loads the system SQLite, and we end up calling into it, instead of calling into our version of SQLite. This happens if the dynamic library loader resolves our symbol imports with the system's SQLite library. Both possibilities above lead to the possibility that the component build will behave differently from the release build, in subtle and potentially non-deterministic ways. This is not a purely academic concern. https://crbug.com/807487 happened because we use NSS on Linux, and NSS invokes SQLite via a complex plugin system. On non-component builds, NSS (a system library) loads and uses the system version of SQLite. On component builds, NSS ends up using our SQLite. This CL fixes the problem by adding a chrome_ prefix to all the symbols exported from SQLite3. In C++ libraries, namespaces can make prefixing easy. Unfortunately, SQLite is a C library, so the prefixing is fairly heavy-handed. A high-level overview of the approach follows: * An extract_sqlite_api Python script reads SQLite's header, extracts the names of all exported symbols, and writes a header file consisting of renaming preprocessor macros, e.g. #define sqlite3_init chrome_sqlite3_init David Benjamin <davidben@chromium.org> designed the approach and wrote the original version of the script. * The script that we use to generate SQLite's amalgamation now also invokes the extract_sqlite_api script described above, and saves the output to amalgamation/rename_exports.h. * The SQLite component exposes an sqlite3.h header that must be used by all SQLite3 users in Chromium. This header now #includes rename_exports.h (containing the renaming preprocessor macros) before #including amalgamation/sqlite3.h. * sqlite3.c (the main output of the amalgamation process) does not #include "sqlite3.h". However, in order to facilitate autoconf builds, it does #include a "config.h", if a certain preprocessor define exists. We abuse that define to have sqlite.c always load config.h, and have config.h load our rename_exports.h. This CL also adds a PRESUBMIT.py that runs unit tests for the extract_sqlite_api Python script, which ensures that the script will not break accidentally. Both the unit tests and the PRESUBIMT script are inspired from //tools/vim. Bug: 807093, 807487 Change-Id: If3868ba119ffd4ccbb06d1a6fcd4cc2ecd9ef2ae Reviewed-on: https://chromium-review.googlesource.com/898549Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#534843}
-
Alexander Timin authored
Move deinitialisation of TaskQueue's OnTaskStartedHandler and OnTaskCompletedHandler to main thread and avoid race condition. R=skyostil@chromium.org BUG=809424 Change-Id: I1c67ceead20e9b8463de054ce3040314d4fee002 Reviewed-on: https://chromium-review.googlesource.com/904605Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534842}
-
Xiyuan Xia authored
Debugging code to track app terminiating while loading user profile is added in M63. Two milestones has passed and the problem no longer happens. Hence removing it. Bug: 717585 Change-Id: I7df6ea9c4ab9809e4a86b36136aa69e1b03a5ead Reviewed-on: https://chromium-review.googlesource.com/905063Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534841}
-
Elad Alon authored
When a RenderProcessHost exits clearly or crashes, all of its PeerConnections should be considered as removed. Bug: 775415, 805398, 808402 Change-Id: I223e6e867758ef05d896608fbdcc3bc824238dd8 Reviewed-on: https://chromium-review.googlesource.com/899348 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534840}
-
Matthew Jones authored
This change removes the use of transparency on the location bar when modern is enabled. This simplifies the logic required to run animations and fixes a flickering issue when entering and exiting the tab switcher. This change also changes the background color of the asset to white. This allows it to be easily tinted which will also be required for the composited version. BUG=803098,803091 Change-Id: Ia56660da21f615840f6ea2902a3252b8809d337f Reviewed-on: https://chromium-review.googlesource.com/899772 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
yiyix authored
In the current implementation, the copy request is handled by DelegatedFrameHost::RequestCopyOfOutput, which add copy request to the compositor frame of the browser. After this patch, the copy request will be handled by the CompositorFrameSinkSupport:RequestCopyOfSurface which adds the copy request to the surface where the copy request needs to be make. TEST: exiting test cases on copy requests should cover all the usage Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5c0b4572a7b8ed5fce0f5ee10f5d4dd982912e0a Reviewed-on: https://chromium-review.googlesource.com/881548Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#534838}
-
Ted Choc authored
BUG= Change-Id: I5372417f961594c3907ebde5f38a1512c83f189d Reviewed-on: https://chromium-review.googlesource.com/903182Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#534837}
-
Jacob Dufault authored
- keep_alive ensures we do not exit/shutdown. - drag'n'drop disables drag and drop. Bug: 784495 Change-Id: I65525cf5065db48bc14db93af3f3b6e86bc715c7 Reviewed-on: https://chromium-review.googlesource.com/871835 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Reporte crash can happen if |ContentViewCore.onRotationChanged| is called after CVC is destroyed, therefore mWebContents is set to null. Added null check against the variable to prevent crash. Bug: 808971 Change-Id: I7719d2d0c26b36b94eeff406d655512111e58c2d Reviewed-on: https://chromium-review.googlesource.com/903342Reviewed-by:
-
Allen Vicencio authored
Implements WriteFile in SmbFileSystem using TempFileManager. Bug: chromium:757625 Change-Id: I176079aca1bb752f628c86942f2ee89b46c19729 Reviewed-on: https://chromium-review.googlesource.com/894983Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#534834}
-
https://chromium.googlesource.com/catapult.git/+log/e6e84629dbe5..874bc7c4eabb $ git log e6e84629d..874bc7c4e --date=short --no-merges --format='%ad %ae %s' 2018-02-06 charliea Disable all CPU tracing agent integration tests on Windows Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8468b18bb72c450df3d79595fa2788204d52d857 Reviewed-on: https://chromium-review.googlesource.com/905460Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534833}
-
Dirk Pranke authored
This bumps the experimental builder to 50% and also marks it as "compile_only", which means that we don't include any debug symbols (this speeds up the build). R=jbudorick@chromium.org BUG=694033 Change-Id: I73713462395bcc360172883aa898af72c8a8ecd7 Reviewed-on: https://chromium-review.googlesource.com/898366Reviewed-by:
John Budorick <jbudorick@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534832}
-
Nico Weber authored
Fixes a bug where memory-infra tracing would count private_dirty memory also as shared_dirty memory in a certain detail view (but not in aggregates). Record a memory-infra trace as described on https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory-infra/ then click a memory dump, click e.g. "Browser" in the Analysis view, scroll down, and click the triangle toggle next to Total and then Native heap. Before this change, entries with "Private dirty" != 0 would always have the same value in the "Shared dirty" column (but not the other way round). After this change, at most one of the two columns is != 0. Actually turning on the warning is blocked on an issue in protobuf (see crbug.com/809157), so this will happen in a future CL. TBR=sky Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I663f225f817accd5ee7319e33e2779aafd9c85c6 Reviewed-on: https://chromium-review.googlesource.com/902065 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534831}
-
Nektarios Paisios authored
Paper-button-light doesn't support the alt property, so aria-label should be used instead. R=dmazzoni@chromium.org, fukumi@chromium.org Tested: Manually using Jaws Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8db2a1c399f41fafc577634062df37972a80a816 Reviewed-on: https://chromium-review.googlesource.com/890778Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#534830}
-
Jinsuk Kim authored
This CL replaces |getSelectPopupForTesting| with the one that simply returns its visibility (showing or hidden), which is enough for testing purposes. It helps CVC not return/expose non-public class when moved to content_public https://crrev.com/c/900884 Bug: 807155 Change-Id: I8dbdace17ace9068ee7807dfa1abf7ac85f4c357 Reviewed-on: https://chromium-review.googlesource.com/902982Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#534829}
-
https://skia.googlesource.com/skia.git/+log/2fb7c8aef57e..744160486520 $ git log 2fb7c8aef..744160486 --date=short --no-merges --format='%ad %ae %s' 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ bfeed4ddf..ca5c10598 (1 commit) 2018-02-06 reed Can't correctly call computeFastBounds on maskfilter w/ device geo 2018-02-05 halcanary SkQP: download_model complains when files.checksum is missing 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2d1c0a2b8..bfeed4ddf (1 commit) 2018-02-06 stephana Remove ConstraintLayout from skqp app 2018-02-06 bsalomon Revert "move GrColor.h to private, IWYU" 2018-02-06 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 6fd3bac65..2908ce856 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I58a89fe497e14f31153acb5f223423d8a4f9bd02 Reviewed-on: https://chromium-review.googlesource.com/905446 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 799074 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I06c20525b10187804949ed9bed7485e483802d15 Reviewed-on: https://chromium-review.googlesource.com/903047Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Elad Alon authored
WebRtcRemoteEventLogManager is a member of WebRtcEventLogManager, in charge of managing remote-bound WebRTC event logs: * Store remote-bound log files locally, persisting them between session of Chrome. * Uploading them when permissible (when no active peer connections are present, with which the upload's increased bandwidth utilization might interfere). * Purge remote-bound log files from local disk once an upload attempt was made, regardless of whether it was successful. (Otherwise, we might end up attempting multiple times, wasting bandwidth on an upload that always fails after a non-trivial amount of data was pushed upstream. More refined retry behavior is to be added at a later stage.) Upcoming related work: * Actual implementation of the uploader (this CL deals with managing the files to be uploaded, and the timing of the upload). * Implementation of the JS hooks. Bug: 775415 Change-Id: Ib5ee6081ca13d85cb8a3f38d6462bbd61a99dcae Reviewed-on: https://chromium-review.googlesource.com/891219 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Ehsan Chiniforooshan authored
Since most tracing agents only care about receiving start/stop tracing signals, a default implementation is provided for other methods to reduce boilerplate code. Bug: 808839 Change-Id: I4645add6e7e81a25d0e923c8afcdf8f5dc3a7a13 Reviewed-on: https://chromium-review.googlesource.com/868575 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#534825}
-
dpapad authored
It was missed in r533917. Bug: 809381,808182 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4b7d574e2a1f6b3522547def1b2c6615e974143a Reviewed-on: https://chromium-review.googlesource.com/904851 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Bence Béky authored
Use GetPromisedUrlFromHeaderBlock() instead of GetUrlFromHeaderBlock() for pushed HTTP/2 headers. Remove dangerous GetDefaultUrlWithPath() and inline pushed URLs instead in SpdyNetworkTransactionTests. Pass URL from SpdySession to SpdyStream so that GetUrlFromHeaderBlock() does not need to be called once more. Change-Id: Ibc51015d20d0f5a3cf1431ad668feff1662a178a Reviewed-on: https://chromium-review.googlesource.com/896808 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534823}
-
