GitLab

SearchProvider enforces that if the user is in keyword mode, the
only suggestions allowed to be the default match are keyword mode
suggestions, lest they break the user out of keyword mode.

Previously, this constraint was applied with an after-the-fact
correction to allowed_to_be_default_match.  This change sets
allowed_to_be_default_match correctly when the AutocompleteMatches
are created.

All tests pass.  (And yes, this constraint enforcement is tested.
Here you can see the tests that were added when the constraint was put
in place: https://codereview.chromium.org/67693004 .)

BUG=398135
R=msw@chromium.org

Review URL: https://codereview.chromium.org/476263002

Cr-Commit-Position: refs/heads/master@{#289981}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289981 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289980}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289980 0039d316-1c4b-4281-b951-d872f2087c98

This picks up:

3186999  Fix for incorrect builtin with clang 3.6

BUG=400849
R=fdegans@chromium.org, navabi@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/479623003

Cr-Commit-Position: refs/heads/master@{#289979}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289979 0039d316-1c4b-4281-b951-d872f2087c98

The "Resource-Freshness" header was temporarily named
"Chromium-Resource-Freshness" during development.

Since Chrome policy is to avoid using vendor prefixes, we should not
ship the browser to stable with this header name.

Rename the header to "Resource-Freshness".

TEST=net_unittests
BUG=348877

Review URL: https://codereview.chromium.org/469993008

Cr-Commit-Position: refs/heads/master@{#289978}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289978 0039d316-1c4b-4281-b951-d872f2087c98

The inner class needs to be exported in case any uses in inline methods
or vtable of the outer class causes it to potentially be referenced across
a shared library boundary.

On non-Windows, the visibility attribute is already inherited by nested
classes, but on Windows, they must be marked explicitly.

BUG=82385
R=thakis@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/476013002

Cr-Commit-Position: refs/heads/master@{#289977}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289977 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289976}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289976 0039d316-1c4b-4281-b951-d872f2087c98

Focus and activation are closely related. Focus could
perhaps be considered a view manager concept, but
activation is window-manager specific, and cannot. Event
dispatch is influenced by (among other things) focus. So,
move event dispatch to the window manager.

I still like the idea of the view manager client lib
providing a "flattened" API to users that allows
setting/querying focus state & observing changes, rather
than obliging everyone connect to the window manager
independently (though they may want to do so for other
reasons). So I'm having the view manager client connect
to the window manager & continue to provide the
SetFocus()/FocusChanged APIs. This causes a minor dilemma
in that we have two window managers but only one view
manager client. Right now I resolved this by defaulting
to the original window manager and allowing others to be
specified on the command line to the shell, but I think
we will eventually want a way to register a default
window manager.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/474883003

Cr-Commit-Position: refs/heads/master@{#289975}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289975 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13624: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13625: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13626: (dschuff) Update revision for PNaCl r13616->r13625

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/480473003

Cr-Commit-Position: refs/heads/master@{#289974}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289974 0039d316-1c4b-4281-b951-d872f2087c98

This makes the following changes to media.gyp to make it compile for iOS (for
the Chromoting iOS client):

- Don't use ffmpeg or libvpx in media (just like Android)
- Do use libyuv
- Add yasm flag to decorate functions correctly for iOS (just like in the Mac)

BUG=134226

Review URL: https://codereview.chromium.org/474693002

Cr-Commit-Position: refs/heads/master@{#289973}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/webrtc/issues/detail?id=3601

Review URL: https://codereview.chromium.org/466843002

Cr-Commit-Position: refs/heads/master@{#289972}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403515

Review URL: https://codereview.chromium.org/474573003

Cr-Commit-Position: refs/heads/master@{#289971}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289971 0039d316-1c4b-4281-b951-d872f2087c98

verifier_test_dll_1.dll.exp : warning LNK4070: /OUT:verifier_test_dll.dll directive in .EXP differs from output filename 'verifier_test_dll_1.dll'; ignoring directive
BUG=

Review URL: https://codereview.chromium.org/473693003

Cr-Commit-Position: refs/heads/master@{#289970}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377978

Review URL: https://codereview.chromium.org/420543002

Cr-Commit-Position: refs/heads/master@{#289969}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289969 0039d316-1c4b-4281-b951-d872f2087c98

The header include order checks were running on all
affected files, including third_party for example,
this causes issues when rolling harfbuzz-ng.

BUG=404105
NOTRY=true

Review URL: https://codereview.chromium.org/462323003

Cr-Commit-Position: refs/heads/master@{#289968}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98

CRX file code currently lives under extensions/. However, 
component_updater also uses them to package components. The 
CRX code should therefore live as its own component.

BUG=371463
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/474633005

Cr-Commit-Position: refs/heads/master@{#289966}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289966 0039d316-1c4b-4281-b951-d872f2087c98

Metrics to track how many times users open a distilled page or distilled page
preferences.

BUG=383630

Review URL: https://codereview.chromium.org/476953002

Cr-Commit-Position: refs/heads/master@{#289965}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404066

Review URL: https://codereview.chromium.org/476133002

Cr-Commit-Position: refs/heads/master@{#289964}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289964 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289962}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402113
TEST=none
NOTRY=true
R=jwd@chromium.org

Review URL: https://codereview.chromium.org/468433003

Cr-Commit-Position: refs/heads/master@{#289961}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/481513002

Cr-Commit-Position: refs/heads/master@{#289960}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289960 0039d316-1c4b-4281-b951-d872f2087c98

Verbatim queries do not see an answer. If the previous query had an
answer with a suggestion that matches the current verbatim text, reuse
that answer.

BUG=401486

Review URL: https://codereview.chromium.org/462963002

Cr-Commit-Position: refs/heads/master@{#289959}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289959 0039d316-1c4b-4281-b951-d872f2087c98

R=danakj

Review URL: https://codereview.chromium.org/471233002

Cr-Commit-Position: refs/heads/master@{#289958}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/470133005

Cr-Commit-Position: refs/heads/master@{#289957}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289957 0039d316-1c4b-4281-b951-d872f2087c98

Without this some telemetry tests and canary XP build fail to load.

BUG=404175

Review URL: https://codereview.chromium.org/477173002

Cr-Commit-Position: refs/heads/master@{#289956}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303883

Review URL: https://codereview.chromium.org/473213002

Cr-Commit-Position: refs/heads/master@{#289955}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289955 0039d316-1c4b-4281-b951-d872f2087c98

We need to copy these png images first because tryserver does not work
very well with binaries in patches. So in order to run the trybots in
the next CL, we need to copy them first.

BUG=338338
TEST=None
R=avi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/471343002

Cr-Commit-Position: refs/heads/master@{#289954}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289954 0039d316-1c4b-4281-b951-d872f2087c98

Add the ability to the audio API to activate more than one audio device at a
time. This is currently accomplished via a hack and when getting device info
via audio.getInfo, only one device will show up as active.

This will allow us to active multiple microphones and multiple speakers though.

I've also made couple of changes to OWNERS files so we don't need to keep
chasing rubberstamps for audio changes.

This is patched from rkc@'s original cl:
https://codereview.chromium.org/460113003/

BUG=397664

TBR=asargent

Review URL: https://codereview.chromium.org/478493002

Cr-Commit-Position: refs/heads/master@{#289951}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289951 0039d316-1c4b-4281-b951-d872f2087c98

If the shared libary being packed uses relocations with addends,
update DT_RELASZ and DT_RELACOUNT instead of DT_RELSZ and DT_RELCOUNT.
Check DT_RELAENT instead of DT_RELENT.

Update unit test data to match.

BUG=385553

Review URL: https://codereview.chromium.org/474283002

Cr-Commit-Position: refs/heads/master@{#289950}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289950 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/421223003

Cr-Commit-Position: refs/heads/master@{#289949}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289949 0039d316-1c4b-4281-b951-d872f2087c98

This adds Experience Sampling instrumentation to the Cocoa version of
the extension install dialog.

BUG=384635

Review URL: https://codereview.chromium.org/462853002

Cr-Commit-Position: refs/heads/master@{#289948}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289948 0039d316-1c4b-4281-b951-d872f2087c98

[MemSheriff] Disable WebRtcLocalAudioTrackTest.ConnectTracksToDifferentCapturers to get tsan bot green.

BUG=404133
TBR=ajm@chromium.org

Review URL: https://codereview.chromium.org/478693003

Cr-Commit-Position: refs/heads/master@{#289947}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289947 0039d316-1c4b-4281-b951-d872f2087c98

We currently use the same UMA metric to log the loading time of different kinds of NTP:
- The local NTP
- The Google app-cached NTP
- NTP from other providers

This CL separates these in three UMA metric using histogram suffixes.

In addition, this CL brings back the Tab.NewTab* UMA metrics to the public histograms.xml in accordance with the practice that metrics in the public chromium repository should be in the public histograms.xml.

Review URL: https://codereview.chromium.org/474053002

Cr-Commit-Position: refs/heads/master@{#289946}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289946 0039d316-1c4b-4281-b951-d872f2087c98

R=mef@chromium.org
BUG=374917

Review URL: https://codereview.chromium.org/471403002

Cr-Commit-Position: refs/heads/master@{#289945}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/399433003

Cr-Commit-Position: refs/heads/master@{#289944}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397754

Review URL: https://codereview.chromium.org/469023003

Cr-Commit-Position: refs/heads/master@{#289943}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289943 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289942}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289942 0039d316-1c4b-4281-b951-d872f2087c98

Rename the "linker_script_copy" target to "android_exports" and move the
link_settings clause to that target. This avoids the linker flag being
duplicated once for every target which includes jni_generator.gypi,
which causes problems on some linker versions.

BUG=402003

Review URL: https://codereview.chromium.org/473173004

Cr-Commit-Position: refs/heads/master@{#289941}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=jiayl@chromium.org

Review URL: https://codereview.chromium.org/469423003

Cr-Commit-Position: refs/heads/master@{#289940}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289940 0039d316-1c4b-4281-b951-d872f2087c98

The adapter is torn down when a session is ended (no more tracks connected to it), so we do the logging in the destructor.

BUG=399835

Review URL: https://codereview.chromium.org/466333005

Cr-Commit-Position: refs/heads/master@{#289939}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/470213002

Cr-Commit-Position: refs/heads/master@{#289938}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289938 0039d316-1c4b-4281-b951-d872f2087c98