GitLab

https://skia.googlesource.com/skia.git/+log/c7a8df8b1cdb..549325c87e9d

git log c7a8df8b1cdb..549325c87e9d --date=short --no-merges --format='%ad %ae %s'
2019-10-30 egdaniel@google.com Have GrTextureOp use GrSurfaceProxyViews instead of just proxys.
2019-10-30 herb@google.com Remove unused API
2019-10-30 brianosman@google.com Use SkYUVMath in asyncRescaleAndReadPixelsYUV420
2019-10-30 hop2deep@gmail.com build: fix compilation on macOS with 10.14 SDK
2019-10-30 brianosman@google.com Print out a warning if trying to use a cross context image on two contexts

Created with:
  gclient setdep -r src/third_party/skia@549325c87e9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:none
Change-Id: I267d238ed4fc2dd2183b36acca366a5429dc29d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891551Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711075}

Bug: None
Change-Id: I8b5163209c54a98f5807adb91df90f362cb4644c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890951
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711074}

Using wpt-import in Chromium 9bc823dd.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Id9bf6b8c596847d51a00a7d92179ffe8e8ab1b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891076Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711073}

Hit testing uses a 1x1 rect (i.e., "bounding box" )at the hit test
location to test intersection with boxes in the tree. The current
implementation always uses a 1x1 bounding box in the local coordinate
space of the box being tested, which is incorrect -- for example, if the
box is scaled by 100x, then using a 1x1 bounding box in the local space
is equivalent to using a 100x100 bounding box in the viewport, and as a
result we hit the transformed box even if the hit test location is still
100px away from it.

This patch fixes the issue by also transforming the bounding box, so
that it is always equivalent to a 1x1 rect in the viewport.

Bug: 1015801
Change-Id: Ia23e33d2d14bc51fcb2d4b0953ed48bc5738e20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891110Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711072}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/48823c28549d..c87ed60623e4

git log 48823c28549d..c87ed60623e4 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 ehmaldonado@chromium.org git-cl: Fix some python3 compatibility errors.
2019-10-30 ehmaldonado@chromium.org presubmit_support: Fix tests on Python 3.
2019-10-30 ehmaldonado@chromium.org depot_tools: Make owners tests run on Python 3
2019-10-30 ehmaldonado@chromium.org git-rebase-update: Make tests run on Python 3.
2019-10-30 ehmaldonado@chromium.org gerrit_util: Remove RemoveReviewers.
2019-10-30 ehmaldonado@chromium.org depot_tools: Don't use basestring in scm.CaptureStatus.
2019-10-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-30 hypan@google.com Revert "Fetch the input commit ref when both ref and id are specified."

Created with:
  gclient setdep -r src/third_party/depot_tools@c87ed60623e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1002209,chromium:1009814,chromium:1009814,chromium:1009809,chromium:1002209,chromium:1002209,chromium:922150
Change-Id: I4a5b8c4ab8e24c62d6d2e071fe3c504a299d8a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891780Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711071}

This reverts commit 18a95ec0.

Reason for revert: Breaks smart card PIN keyboard and quick unlock WebUI PIN keyboard (https://crbug.com/1012102).

Original change's description:
> Refactor the settings pin keyboard to fix touch ripples
> 
> -Now that pin_keyboard uses cr-button(used to be paper-button) there
> is no need for an additional paper-ripple.
> 
> -cr-button needs logic for being able to customize ripples since
> pin_keyboard uses a custom ripple. The same createRipple function
> exists in cr-toggle, cr-slider, etc.
> 
> Bug: 1007235
> Change-Id: Ib391bd45f87c65bf3ae5982dfccc4a61e5fd807d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829766
> Commit-Queue: Gavin Williams <gavinwill@chromium.org>
> Reviewed-by: Bailey Berro <baileyberro@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701742}

TBR=stevenjb@chromium.org,baileyberro@chromium.org,gavinwill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1007235, 1012102
Change-Id: I732b445aa8731fa6536c99794596e891b8c34a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891291Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711070}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e8fabd71826..a25f3386ca1a

git log 0e8fabd71826..a25f3386ca1a --date=short --no-merges --format='%ad %ae %s'
2019-10-30 cjmcdonald@chromium.org SDKTestStage: Disable revdep logic while building boards
2019-10-30 mmortensen@google.com Add additional error handling in determine_chrome_version.
2019-10-30 tzungbi@chromium.org lib/git: exact match first in MatchBranchName()
2019-10-30 lamontjones@chromium.org paygen: log output for gs downloads
2019-10-30 jrt@chromium.org Revert "chromeos_config: Mark littlejoe and viking as experimental"

Created with:
  gclient setdep -r src/third_party/chromite@a25f3386ca1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iaaa316ebcb94589fe40c80c8ddc7d72aa57161c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891449Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711069}

Fuchsia is removing RunTask and must remove all external references first.

Bug: 1019980
Change-Id: I95db4ae011e6dab6755af93a795f359b764ceacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890732Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Rich Kadel <richkadel@google.com>
Auto-Submit: Rich Kadel <richkadel@google.com>
Cr-Commit-Position: refs/heads/master@{#711068}

min-width and min-height were previously defined in
https://drafts.csswg.org/css-box-3/
They supported 'fit-content' as a keyword, not as a function.
`[ [<length> | <percentage>] && [border-box | content-box]? ] | available | min-content | max-content | fit-content`

Now min-width and min-height are exclusively defined in
https://drafts.csswg.org/css-sizing-3/
They support fit-width as a function, not as a keyword.
`auto | <length-percentage> | min-content | max-content | fit-content(<length-percentage>)`

Bug: 856648
Change-Id: I04230a5a530b1455fbd17bbf0aceeabacdd188d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885860
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711067}

The CL that added the flag accidentally made the app disabled by default

Bug: 1019959
Change-Id: Idc5b175767a4e77e70fb755af007f6fa00dce1f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891810Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711066}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a18fa927208..e6d7ff710e36


Created with:
  gclient setdep -r src-internal@e6d7ff710e36

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:1014539,chromium:1012928,chromium:None
Change-Id: I72fe31e144dc4c194ce0eebbb4b8cd07a73b110c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891773Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711065}

Removing the builder since it's not providing anything that
chromeos-betty-google-rel isn't.

Change-Id: I7841e41585cc5e814dde37141145834f94792431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884521Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711064}

Note: Excluded components/dom_distiller/core/images/dom_distiller_material_spinner.svg
since that file seems to hold a lot of documentation in the form of comments.

This is in preparation of turning on web-dev style related PRESBUMIT
checks for this folder.

Bug: 1019312
Change-Id: I1a03bf2f14b10d42235a357553f1ce7304da0e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887663Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711063}

We have an optimization to directly update compositor property node
values from blink and skip a PaintArtifactCompositor update. If a
blink::PaintPropertyNode is not known to be composited (does not have a
direct compositing reason) but does have a cc::PropertyNode, we cannot
simply do the direct update because we may need to issue invalidations
on the non-composited content that has changed.

For example:
<div id="a" style="transform, not-directly-composited">
  <div id="b" style="transform, composited"></div>
</div>
If a's transform changes, PaintArtifactCompositor::Update needs to run
to notice the change. Because b is composited, there is a compositor
property node for a, but we cannot just update it. This regressed in
https://crrev.com/692043 which stopped creating a composited layer for
some transform ancestors, and without this layer the underinvalidation
bug became visible.

This change has a few places where direct compositing reasons are now
set when they were not before (viewport nodes and scroll offset nodes)
to allow for direct updates.

Bug: 1017939
Change-Id: Ib8167e981d3d613af44ea40224c5e4328029607e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888374
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711062}

-Using aria-hidden will force the these text labels to be skipped over
 when navigating with the screen reader. The preference is to only
 navigate to the actionable button instead of its text label.

-Adding an aria-labelledby and a aria-describedby will make the screen
 reader read "{printerName}, Button, Save/Setup" when navigated to.

Bug: 1014145
Change-Id: I4cca27f8d48297d9de0c1409984b0344503e8bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859689Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711061}

We used to rotate the back button and hide apps when the VK was shown,
but nowadays we completely hide the shelf behind the VK so this logic
is not useful.

Race conditions resulted in users seeing the shelf in this state after
the vk is no longer visible, so just remove the logic to prevent this
behavior.

Bug: 1012425
Change-Id: I10dd761a4138373140e9d3c725d1eb4b945d66f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891017
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711060}

The platform_window target is used from multiple components and should
therefore be a component itself. This is needed to avoid ODR violations.

One ODR problem that currently can happen is the duplication of the
global boolean backing UseTestConfigForPlatformWindows().

Reland with fuchsia_dbg fixes.

Bug: 1019015

Change-Id: I6781667889b45ce178d5a5aaa95807d6b0eb94e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891457Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711059}

TBR=bsazonov@chromium.org

Bug: 1014790
Change-Id: I249b7e9f2b49f9ec1b1108a0236178625fc3ce8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891811Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711058}

Accelerometer values affect screen orientation and other visible behavior.
Thus it should use USER_VISIBLE priority.


Bug: 1004432,1000353
Change-Id: I717f7fb7ce2c4de0372b237f78c9d4493497c69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891576Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711057}

This CL fixes a regression that leads to inconsistent widths for the
items on the download shelf. This regression was introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/1864876

Fixed: 1017101, 1017921
Change-Id: Id0365810848dcdac59edec49eae1197c02130d00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887890Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711056}

Previously, the blue background of the blue-button was too light, and
didn't meet WCAG contrast ratio guidelines. This CL makes it darker.

Fixed: chromium:1005543

TEST=Take before/after screenshots, use color contrast checker.

Change-Id: I6052f9539bf9d506914e0affc56ddc6bdea704bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888726
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711055}

Skip WebGPU tests on Win7 as Win7 does not support D3D12.

Since WebGPU decoder tests require a GPU in order to run, they are
moved to gpu_tests from gpu_unittests. gpu_unittests.exe run on
"GPU less" machines. As a side effect of the move, the tests are
no longer skipped on Mac.

The change also disables the WebGPU tests on Linux since the shared
Vulkan shared image extension is not working or being initialized
properly on the bots.

Bug: 1017035
Change-Id: Ie5426bd0e1e0bb4b570a74b8a75c1f99c80d246d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879655
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711054}

BUG=b:143501658
BUG=b:143189411
TEST=Manually confirmed PIP dismiss animation works well on an external display

Change-Id: I931b18635ed99cfff9c230f69687497a43efb2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888859Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711053}

This CL introduces behavior to delay touches that would be flagged as
palm by heuristic, until inference occurs. This is all flagged by a
configuration flag.

We add a thorough unittest to test behavior: that delay is set, and
kept, until Inference. Test that delay is not set when flag is off.

Bug: 1009290
Change-Id: I060db0a2dda207537a5cc1f61690d0fafcc2f4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888618Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711052}

MatchedPropertiesCache was using weakness to hold alive a cached entry as long
as all of its matched properties are alive. Once a single matched property dies
the entry was removed.

This can be modeled using a custom weakness callback that performs the same
logic. Cached entry don't have any outgoing edges except for their cached
matched properties, so ephemeron semantic is not required. Using a custom weak
callback is also faster because the callback is only executed once and not part
of the ephemeron fixed point protocol. The cached entry is unlinked using the
weak callback and collected on next GC cylce.

After this conversion, custom weakness can be removed from hash traits.
Weakness should always go through already supported types (e.g.
WeakMember).

The reland fixes an issue where the callback was unable to handle entries that
are just being created.

This reverts commit d2707b61.

Bug: 1019191
Change-Id: Iab55a5247d33f50bf60417ba6f15e58dfa3ff08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891171
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711051}

https://webrtc.googlesource.com/src.git/+log/4e19670d3a93..5bd8cb74a659

git log 4e19670d3a93..5bd8cb74a659 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 hbos@webrtc.org Revert "Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5.""
2019-10-30 minyue@webrtc.org Renaming opus_interface.c to opus_interface.cc.
2019-10-30 danilchap@webrtc.org Split out counting unique rtp timestamps from packet_buffer
2019-10-30 trevor.axiom@gmail.com Reland "Implemented screen enumeration and selection for desktop capture under X11 using the X Resize and Rotate extension version 1.5."
2019-10-30 ilnik@webrtc.org Make update_rect optional in VideoFrame

Created with:
  gclient setdep -r src/third_party/webrtc@5bd8cb74a659

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:396091,chromium:b/143582588,chromium:None,chromium:396091
Change-Id: I95e80b26b566d9d6c5179d95130581fbf0b8c17d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891380Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711050}

In cases where deep scanning fails, we currently supply a SAFE verdict.
If the original verdict from Safe Browsing was UNCOMMON, we will
therefore downgrade the warning. This CL preserves the original verdict
and returns it in cases where deep scanning fails. It also adds a test
implementation of the BinaryUploadService, for easier testing of code
using uploads.

Fixed: 1017921
Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711049}

This works around the clang-format runtime/references rule.

If someone forgets to add the `const`, the compiler will hit a
static_assert that will point that out, rather than a harder-to-
read message that buries the mismatched type in the callback's
template parameters.

Bug: None
Test: cast_base_unittests
Change-Id: Ia9610756111b90bb236c98f916a36b2909fd587f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890823Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711048}

Upload screenshots in bug comment 38

Bug: 932818
Change-Id: I83e866377cd2907ac26a969ffa91651f56ca872a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891587Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711047}

This patch moves the basic leveldb layer (and testing utilities) from
the IndexedDB directory to the Storage Service directory.

content/browser/indexed_db/leveldb ->
components/services/storage/leveldb/

Note: The files left in the IndexedDB leveldb directory are part of the
'transactional' leveldb layer, which will soon live in its own
directory in the Storage Service as well, 'transactional_leveldb'.

Bug: 1015212
Change-Id: I834b60cb5b8acdc3137a3b5d60efcfdebc5ede2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888381Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#711046}

This reverts commit 3ef63a6b.

Reason for revert: Looks like this has caused a crash, e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898135829966943488/+/steps/ash_unittests/0/logs/Deterministic_failure:_OverviewSessionWithHomerviewGestureTest.FadeOutExit__x2f_0__status_CRASH_/0

Original change's description:
> Implement transitions to home for homerview feature
> 
> Updates how device transitions to home when home button is tapped and
> when user clicks in empty space in overview grid when kHomerviewGesture
> feature is enabled.
> 
> When overview is active, it should use kFadeOutExit transition (instead
> of slide out) - this also fixes a bug where transform was not cleared on
> item windows when bounds were updated without animations (which was
> causing item window misplacement when the grid was updated while
> minimizing active window before exiting overview).
> FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an
> argument instead of deducing it depending on the animation type, as
> OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if
> using slide out overview exit transition (the animation can also be used
> by fade out exit).
> 
> When clicking home with a window active, the top window is minimized
> using transform to home screen (the same used during drag from shelf),
> while the rest of the windows are minimized with no animations. To make
> this easier, WindowTransformToHomeScreenAnimation is moved to a separate
> file, and is updated to better handle windows whose origin is not in the
> screen origin (which is useful for transforming top windows in split
> view).
> 
> Is split view, the top windows are transformed to home screen as the
> split view ends. If overview session is active together with split view,
> the overview session is ended immediately to avoid showing overview just
> after ending split view (during duration of the exit transition).
> 
> BUG=1005366
> 
> Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710953}

TBR=xiyuan@chromium.org,tbarzic@chromium.org,xdai@chromium.org

Change-Id: Id4020082bc736ec6fc9306fc26c5a7a237cb4c54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890392Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711045}

This reverts commit 433bbd52.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 711038 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzM2JiZDUyMTA0MmRjOTcyMmQ2ZDg2Nzk0MzNjODE0MGRmOWQwNGMM

Sample Failed Build: https://ci.chromium.org/b/8898131381528610928

Sample Failed Step: compile

Original change's description:
> Remove HomeLauncherGestureHandlerObserver
> 
> HomeLauncherGestureHandler currently has two observers:
> *   AppListControllerImpl, which is also a HomeScreenDelegate
>     implementation (on which HomeScreenGestureHandler already
>     depends, so additional observer interface just
>     obscures/complicates this dependency)
> *   HomeLauncherStateWaiter which is used by interactive UI/perf tests
>     to wait for launcher animations to complete
> 
> For the former case, moving the observer methods to HomeScreenDelegate
> interface will work fine.
> For latter case, the test waiter can register a callback with
> AppListControllerImpl to be run when the home launcher animations are
> complete - the same way it's done by LauncherStateWaiter, an equivalent
> test waiter used in clamshell mode (or for waiting for non-visibility
> app list state transitions)
> 
> Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711038}


Change-Id: I449d4c15018c05c09953d445a50d1c1dc6f7c1a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890735
Cr-Commit-Position: refs/heads/master@{#711044}

Set the new QueryableData JS bindings feature on.

Bug: internal b/138623432
Test: E2E manually test
Change-Id: Ia1a3e4f650aeabee3aae90f9e764a63c2d9213b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891738
Auto-Submit: Jiawei Li <lijiawei@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711043}

Add reminders to mark the crbug as "started" before starting
development work and to mark the crbug as "fixed" after landing the
CL.

Bug: None
Change-Id: Id79ff0843679c368773b10d22ea9d72e4b1691d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891730Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711042}

Merge-With: eureka-internal/330177

Bug: internal b/127963522
Bug: internal b/138938216
Change-Id: Ia8b0a705f5ebe8d9b637af85ed537e0c7ac3e0f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888114
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711041}

Land the JPEG YUV decoding feature behind a flag without affecting testing.
Tests will be updated and rebaselined in a follow-up cl.

Bug: 919627
Change-Id: I9debcf08e8eca02bebe53ec0f218843cd28da1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887273
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711040}

This change adds localization strings for JIS B* papers.

Bug: 1017279
Change-Id: I369a016002f29ccbecdf18a9593611fed6084e81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891118Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711039}

HomeLauncherGestureHandler currently has two observers:
*   AppListControllerImpl, which is also a HomeScreenDelegate
    implementation (on which HomeScreenGestureHandler already
    depends, so additional observer interface just
    obscures/complicates this dependency)
*   HomeLauncherStateWaiter which is used by interactive UI/perf tests
    to wait for launcher animations to complete

For the former case, moving the observer methods to HomeScreenDelegate
interface will work fine.
For latter case, the test waiter can register a callback with
AppListControllerImpl to be run when the home launcher animations are
complete - the same way it's done by LauncherStateWaiter, an equivalent
test waiter used in clamshell mode (or for waiting for non-visibility
app list state transitions)

Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711038}

Found with _LIBCPP_DEBUG=0.

Bug: 923166
Change-Id: Ifdb0be8031bc95f05ff3d67876407569bac0e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891235
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711037}

Migrate Update Menu Item preferences to use PrefServiceBridge generic
methods, making use of the prefs.h enums.

Bug: 1016957
Change-Id: I3b37e1251e5c51d0bc08e4cfd0ae05245c2d052f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885103
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711036}