- 11 Dec, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84629852e33d..a030e16bdf09 Created with: gclient setdep -r src-internal@a030e16bdf09 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ff88d678adc149dc066d8f1000f1c2ae1e98bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1372084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615559}
-
Aga Wronska authored
Removed string from ASSERT_DEATH, because official tests strip the string passed to CHECK(false) and LOG(FATAL). Bug: 913441 Change-Id: Ib68905b60d214064f341262789b31f763e8108b3 Reviewed-on: https://chromium-review.googlesource.com/c/1370307Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615558}
-
Kevin McNee authored
This is a reland of b9e5ed2a Original change's description: > Refactor OOPIF scroll bubbling state and cancellation > > Whether or not a child is bubbling scroll was being tracked in both > CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's > simpler to just have it in RWHVCF. > > There are several cases where we generate fake scroll updates when > cancelling scroll bubbling. This is a relic from the non-scroll latching > code paths and has been removed. We also deduplicate the scroll bubbling > cancellation code. > > We were tracking the view from which scroll events are bubbled by keeping > a reference to that view's parent. We now just keep a reference to the > originating view directly. > > We also now properly cancel scroll bubbling when a child detaches. > > Bug: 828422, 897216 > Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057 > Reviewed-on: https://chromium-review.googlesource.com/c/1357563 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615184} Tbr: kenrb@chromium.org Bug: 828422, 897216 Change-Id: If529545300f6bbb7a7056cdbebbd8317cb274f7a Reviewed-on: https://chromium-review.googlesource.com/c/1371010Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615557}
-
Vladimir Levin authored
If the layout is forced, then we temporarily allow the processing of the subtree. The locked element's frame rect still remains to be the same as at the time the lock was acquired. R=chrishtr@chromium.org, mstensho@chromium.org, futhark@chromium.org Bug: 907613, 882663 Change-Id: I9d1f63c287a73e7a8f3cbc9cb5acc2a009ddd024 Reviewed-on: https://chromium-review.googlesource.com/c/1363957 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#615556}
-
Ken Rockot authored
On Windows, non-broker processes should only accept HANDLEs in messages coming from the broker and/or inviter process. This is because a non-broker or invitee receiver has to assume the sender has already duplicated sent HANDLEs into the receiver's process, and making that assumption requires a level of trust that should not be granted to arbitrary peers. This constraint is already met today under normal circumstances, but a malicious or misbehaving process could easily violate it, tricking an unassuming receiver into attempting double-ownership of an existing handle or closure of an invalid handle value, both of which can result in a crash (though thankfully nothing worse, because of ScopedHandleVerifier). This adds an option to Channel which allows it to reject incoming platform handles and essentially treat them as malformed messages. The option is set on Windows for any non-broker process's receiving Channel endpoint which is not connected directly to a broker process or to the process which invited that client. The Channel fuzzer also sets this option to avoid a crash since it exercises only the non-broker receiving path today. A follow-up CL will extend fuzzer coverage to include broker receivers as well. Bug: 909713 Change-Id: Ie0fece347fcf23d6f8111be4e41398f22d617531 Reviewed-on: https://chromium-review.googlesource.com/c/1363649 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615555}
-
Xianzhu Wang authored
We need to attach the document animation timeline to the animation host to make animations work. In pre-CompositeAfterPaint, this is done from PaintLayerCompositor. For CompositeAfterPaint, attach animation timeline from Document::Initialize() and WebLocalFrameImpl::SetFrameWidget(). Bug: 702353 Change-Id: I5e19add5196e5b52ebcade42b58e336051b111e6 Reviewed-on: https://chromium-review.googlesource.com/c/1368994Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615554}
-
Jamie Madill authored
This reverts commit 1a9264dd. Reason for revert: rebaseline didn't seem to work. Failing builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/3655 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/3470 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/2954 Failing tests: gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4 Original change's description: > Re-enable video pixel tests after rebaselining > > The tests were marked as failing and version numbers were incremented in > https://crrev.com/c/1182222, but I forgot to re-enable the tests. > > Bug: 869677, 913138, 858826, 819635, 774809 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08 > Reviewed-on: https://chromium-review.googlesource.com/c/1214364 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615353} TBR=kbr@chromium.org,sunnyps@chromium.org Change-Id: I553c10ca8022a90a0afa73ffafa44aa5bbf4e2d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869677, 913138, 858826, 819635, 774809 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1372234Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#615553}
-
Jeremy Roman authored
A combination of std::atomic (for a raw GC count) and appropriate higher-level primitives from base is used to replace the current use of atomics. Bug: 736037 Change-Id: Id4856d4b8d21ff989694bbece70c61d86c686323 Reviewed-on: https://chromium-review.googlesource.com/c/1369720 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615552}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9cabb4f98e99..4f738832a976 git log 9cabb4f98e99..4f738832a976 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org fix bookmaker 2018-12-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-11 kjlubick@google.com [canvaskit] Refactor Canvas2D JS into own files Created with: gclient setdep -r src/third_party/skia@4f738832a976 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I961018fd96caecd13c2d8a371501981f262f6a53 Reviewed-on: https://chromium-review.googlesource.com/c/1371710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615551}
-
Eric Karl authored
CompositorImpl Android had obsolete Vulkan prototype code. Removing this as all Vulkan access should happen on Viz process. Removes a DCHECK we were hitting when running with the new Vulkan code. Bug: 848375 Change-Id: Ifba9927809290618346867e52ad71f3edc2b66a9 Reviewed-on: https://chromium-review.googlesource.com/c/1370935Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615550}
-
sebsg authored
Bug: 910372 Change-Id: Ic0859c1fab02010f22664d0138d6e3516012545f Reviewed-on: https://chromium-review.googlesource.com/c/1358649 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615549}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a1b0e72..72448bed Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1b37dea72dce8da3904aa7c6f490b8a0ad88f78a Reviewed-on: https://chromium-review.googlesource.com/c/1372024Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615548}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/152255fcc745..c8b5fd3f2752 git log 152255fcc745..c8b5fd3f2752 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 lalitm@google.com Merge "perfetto: fix tracing test on Android ASAN" Created with: gclient setdep -r src/third_party/perfetto@c8b5fd3f2752 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I079a8f7540ce6d1ac814a6d1c64ad0748d1f10bb Reviewed-on: https://chromium-review.googlesource.com/c/1372085Reviewed-by:
-
Josh Karlin authored
Change-Id: I21b6ea7ddeb722bf91ce184c9d21c35baedf8749 Reviewed-on: https://chromium-review.googlesource.com/c/1372046Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615546}
-
Friedrich Horschig [CET] authored
This reverts commit 9ef757a8. Reason for revert: is again needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 was reverted Original change's description: > Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz." > > This reverts commit 0baa5bdf. > > Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 > > Original change's description: > > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz. > > > > Bug: 911836 > > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1361725 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Max Moroz <mmoroz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#613792} > > TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 911836 > Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e > Reviewed-on: https://chromium-review.googlesource.com/c/1365083 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614534} TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836 Change-Id: Id09d7c0394e8c5eb445aa19ba5a62f8fa251ecb0 Reviewed-on: https://chromium-review.googlesource.com/c/1371885Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615545}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f66ddbae325..e011cb742d99 git log 8f66ddbae325..e011cb742d99 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 terelius@webrtc.org Move chart proto for event_log_visualizer. 2018-12-11 nisse@webrtc.org Rename EncodedImage::_size to capacity_, make private. 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aec72e9e..d5698f68 (615246:615355) Created with: gclient setdep -r src/third_party/webrtc@e011cb742d99 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5a31afacdbc38767ae24412a821ba8738974fbcc Reviewed-on: https://chromium-review.googlesource.com/c/1371711Reviewed-by:
-
Dan Elphick authored
Replaces many deprecated uses of v8 functions Object::Get/Set, Value::ToString, in extensions/renderer with versions that return Maybe/MaybeLocals or by using casts if there are already checks that ensure the cast will always succeed. Bug: v8:7279, v8:7283, v8:8562, chromium:913942 Change-Id: I4aeec76251bd11dfc274156d8d00586e04e9a99e Reviewed-on: https://chromium-review.googlesource.com/c/1353985 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615543}
-
Nico Weber authored
chrome_nibs.gyp went away a while ago, and gyp is no longer deps'd in. Bug: none Change-Id: I71d7503b0f95ff15575653da7efe35e4e62a6fcd Reviewed-on: https://chromium-review.googlesource.com/c/1371928Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615542}
-
Michael Ludwig authored
Bug: 913948 Change-Id: I2712119f0ff48a56d1a8b994dc470e76b37250d2 Reviewed-on: https://chromium-review.googlesource.com/c/1371925Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#615541}
-
Ned Nguyen authored
Bug:913625 Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84 TBR=jbudorick@chromium.org, bradhall@chromium.org NOTRY=true # linux_chromium_rel_ng flake Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84 Reviewed-on: https://chromium-review.googlesource.com/c/1371646 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615540}
-
John Chen authored
Make Add Cookie command compliant to W3C spec. Also added a set of helper functions to help parsing some property types used in W3C spec. ChromeDriver now passes all WPT WebDriver tests related to cookie. Bug: chromedriver:2002 Change-Id: I3779a14e010bca865498a9d40710974e38ede829 Reviewed-on: https://chromium-review.googlesource.com/c/1366925 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#615539}
-
Florian Uunk authored
The AutofillProfileDataTypeController waits for PDM to load all its data before doing data association. However, with Butter, PDM needs to ask the sync service whether the sync feature is enabled to know whether to read the server cards from the local or account database. Currently, PDM only gets the sync service whenever we create an AutofillManager, which isn't always the case on startup. This CL adds a quick fix, where we also pass the sync service to PDM in the AutofillProfileDataTypeController, so we know for sure it can load all data. A better fix would be to have a single place where we pass the sync service to PDM, and remove both the call in AutofillManager and this new call. Bug: 913945 Change-Id: Ia872cb8ce0cb97467237665e5a92b1d70eb1c2bc Reviewed-on: https://chromium-review.googlesource.com/c/1371427 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615538}
-
Owen Min authored
Disable this data upload as it's not used by server. Change-Id: I7da2e3b82aef19318a3ed5ec6c00f2cabe15fb2b Reviewed-on: https://chromium-review.googlesource.com/c/1370723Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615537}
-
Jeremy Roman authored
These are the ones that didn't explicitly include wtf/atomics.h and so were missed earlier. Bug: 736037,247328 Change-Id: I407d1ad6f53c058866bb4a98ca910768fe9ce6c5 Reviewed-on: https://chromium-review.googlesource.com/c/1370187Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615536}
-
Stephen McGruer authored
This CL adds a README.md to the fast/animations/scroll-animations directory, explaining when that directory should be used vs external/wpt/scroll-animations (aka, rarely). Bug: 911254 Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c TBR=yigu@chromium.org Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c Reviewed-on: https://chromium-review.googlesource.com/c/1367825Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#615535}
-
Jesse Doherty authored
There will need to be a follow up CL that adds an implementation for Chrome to provide an actual key. Bug: 906202 Change-Id: Ib471b1124e19b11755b410f384a447f929a1b547 Reviewed-on: https://chromium-review.googlesource.com/c/1351709 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#615534}
-
Xiyuan Xia authored
ash::Shell owned by ChromeBrowserMainExtraPartsAsh is released before UiDevToolsServer owned by ChromeBrowserMainExtraPartsViews. This causes a use-after-free in DOMAgentAura dtor when it tries to RemoveObserver from the already released Env of ash::Shell. Fix the issue by explicitly releasing |devtools_server_| in ChromeBrowserMainExtraPartsViews::PostMainMessageLoopRun. Bug: 896977 Change-Id: I07172d8014dc17c1a91a11e220579a13ad0524b0 Reviewed-on: https://chromium-review.googlesource.com/c/1370832Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615533}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3e8e3c9e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I5349c5b8538c4f94cb3341c878c95cbc7b3a73b7 Reviewed-on: https://chromium-review.googlesource.com/c/1371647Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615532}
-
John Budorick authored
Bug: 731964,913687 Change-Id: Ie7de1a0aba1316b8916219afb766b18e95dc5549 Reviewed-on: https://chromium-review.googlesource.com/c/1372026Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615531}
-
Li Hao authored
Sometimes we expect to build mac target without v8, but there is a warning that v8_current_cpu is set as a build argument, but not appeared in declare_args(). If the declaration file v8_target_cpu.gni is not imported, we should not override it. Change-Id: I04ef533a565fb9272aa1117ccea1bdee022f5c9a Reviewed-on: https://chromium-review.googlesource.com/c/1369645 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Dave Tapuska authored
CSS Font Loading spec refers a font-loading task queue. Add a queue matching that name and update it to use that queue. Change-Id: I885962521f2a17f3b35b181d3dc1066cc86a4e6e Reviewed-on: https://chromium-review.googlesource.com/c/1370707 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615529}
-
Sami Kyostila authored
This patch fixes a problem in the Mac message pump where we kept calling Delegate::DoDelayedWork even if a previous call to Delegate::DoWork caused the runloop to quit. This matches the behavior outlined in message_pump.h[1] as well as that of the other platform-specific pumps. We also introduce a message pump unit test that verifies behavior across all message pump types. Bug: 891670 [1] https://cs.chromium.org/chromium/src/base/message_loop/message_pump.h?rcl=a28a6097182e739c4a8c600b538fcc07681fc7a3&l=58 Change-Id: I00ccb5c55ac8551259a2febd343ec64fdd55630d Reviewed-on: https://chromium-review.googlesource.com/c/1370367Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615528}
-
David 'Digit' Turner authored
This CL fixes compile_resources.py to ensure that it correctly includes missing localized strings into the final APK. The problem was that some android_resources() targets declared some Filipino resources under values-fil/ directories, and some Indonesian ones under values-in/ 'fil' is a 3-letter ISO 639-2 language code, that was not supported before Android 5.0/Lollipop. Hence, our script only tried to include strings from 2-letter locale qualifiers, excluding the -fil one entirely. Due to the problem above, most packages place their localized strings for Filipino are placed under 'values-tl/' instead, because 'tl' matches Tagalog, a related but lesser spoken language in the Philippines. Except a few packages that still use values-fil/, for examples see [2]. 'in' is a new 2-letter ISO 639-2 language code, but due to compatibility concerns, our script wants to use 'id' instead for the Indonesian language (see [1] for a little bit more details). A few packages provide their localized strings for Indonesian under values-in/, which was ignored [3]. This CL fixes the issue by renaming "newer" locale qualifiers to "older" ones. This is done by extracting the qualifier from values-<locale>, converting it to its Chromium version, then back to its Android version. In practice it also deals with BCP 47 codes, as in: values-fil/ -> values-tl/ values-in/ -> values-id/ values-b+en+US -> values-en-rUS/ The last example above is not relevant, but opens the door to supporting more locales in Chromium in the future. The end result is adding missing localized strings for Filipino and Indonesian for 30 string resources (listed below). This ends up increasing the size of MonochromePublic.apk by about 2000 bytes. BUG=921044 R=agrieve@chromium.org,estevenson@chromium.org,yfriedman@chromium.org,torne@chromium.org [1] https://developer.android.com/reference/java/util/Locale The section in the Locale() constructor that reads: * ISO 639 is not a stable standard; some of the language codes it defines (specifically "iw", "ji", and "in") have changed. This constructor accepts both the old codes ("iw", "ji", and "in") and the new codes ("he", "yi", and "id"), but all other API on Locale will return only the OLD codes. Older Android system releases could only read compiled resources from obsolete config locale qualifier (e.g. 'in' for Indonesian). [2] https://cs.chromium.org/chromium/src/third_party/feed/src/src/main/java/com/google/android/libraries/feed/basicstream/internal/viewholders/res/?q=values-fil&sq=package:chromium&dr [2] https://cs.chromium.org/search/?q=values-fil/&sq=package:chromium&type=cs [3] https://cs.chromium.org/search/?q=values-id/&sq=package:chromium&type=cs [4] List of affected string resources: back_button_content_description cancel_button dialog_button_got_it dialog_button_open_help_center dialog_message_incompatible_phone dialog_message_no_cardboard dialog_title dialog_title_incompatible_phone dialog_title_vr_core_not_enabled dialog_title_vr_core_not_installed dialog_title_warning dialog_vr_core_not_enabled dialog_vr_core_not_installed go_to_playstore_button go_to_vr_listeners_settings_button more_button_label no_browser_text no_suggestions place_your_phone_into_cardboard place_your_viewer_into_viewer_format settings_button_content_description setup_button snackbar_fetch_failed snackbar_fetch_no_new_suggestions suggestions_section_empty switch_viewer_action switch_viewer_prompt zero_state_text_afternoon zero_state_text_evening zero_state_text_morning To obtain this list, process the unoptimized resources archives (where resource names are not obfuscated) as follows: aapt dump resources \ out/Release/obj/chrome/android/monochrome_public_apk.unoptimized.ap_ | \ sed -e 's/d=0x[0-9a-f]*//g' > /tmp/A/Resources.txt Do this for the build before and after this CL is applied and compare the results. The 'sed' part is used to get rid of irrelevant differences in each resource allocation. Change-Id: I4a7d961d68de381106347072a69eda6751d1bf7f Reviewed-on: https://chromium-review.googlesource.com/c/1367730 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615527}
-
Justin DeWitt authored
This causes a lint error on the official builders. Bug: 894334,913755,913012 Change-Id: I9dbaa9932873755639d22618b3d758ef87c840cb Reviewed-on: https://chromium-review.googlesource.com/c/1370587Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615526}
-
Oleh Prypin authored
The Android test runner, when retries were enabled, previously would overwrite the isolated-script-test-perf-output JSON file with the latest try, which means that all previous results would be lost. Now it will still write to the provided 'file-name.json' first, but then for following tries it will write to 'file-name_1.json', 'file-name_2.json', etc., which can allow to salvage the results in post-processing. Unrelated change in behavior due to refactoring: --app-data-file previously used this naming scheme for outputs: ['file-name_0.ext', 'file-name_1.ext', ...]; now it's ['file-name.ext', 'file-name_1.ext', ...]. Bug: 755660 Change-Id: Id8ecb506ef91504b925178b433544faa3db8c476 Reviewed-on: https://chromium-review.googlesource.com/c/1371426 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
-
Alex Clarke authored
As a temporary measure add an aliased variable to record the size of the queue. Bug: 912541 Change-Id: I874fcc7cb463b3b891fbe875d42539e72d771767 Reviewed-on: https://chromium-review.googlesource.com/c/1371809Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615524}
-
Maxim Kolosovskiy authored
According to metrics, 0.3% of forms have >100 fields (the current limit), increase the limit to 250 in order to cover all forms. Autofill throttling limits the number of queries/uploads are sent for a given form by a given user. Therefore, uploading huge forms wouldn't flood network. Bug: 857454 Change-Id: Ia92a3d6f2033159df121d8728a263c70ee7914f7 Reviewed-on: https://chromium-review.googlesource.com/c/1369772Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615523}
-
Friedrich Horschig [CET] authored
This test is consistently failing on Mac since the last wpt roll. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913932, 626703 TBR=robertma@chromium.org Change-Id: I071d68a9003edecf4b24b10b4adfe1c86cf7da61 Reviewed-on: https://chromium-review.googlesource.com/c/1371904 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Tim Schumann authored
Change-Id: I1b762a554913d0e3b3df0792c2ff845c4dde5a53 Reviewed-on: https://chromium-review.googlesource.com/c/1370365Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#615521}
-
Friedrich Horschig [CET] authored
This reverts commit d1317fc3. Reason for revert: SyncSchedulerImplTest is failing and this is the most likely culprit. More information in the linked bug. Bug: 913946 Original change's description: > [Reland #3] Use the SequenceManager in ScopedTaskEnvironment > > A reland of https://crrev.com/c/1324391 > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI and IO threads. > > RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing > mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems > to have fixed this. > > > TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1361863 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615496} TBR=wez@chromium.org,gab@chromium.org,fdoray@chromium.org,skyostil@chromium.org,alexclarke@chromium.org Change-Id: If5ff0362758b5270eb3113d2fd6eeeb7facc37c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341, 891670, 708584 Reviewed-on: https://chromium-review.googlesource.com/c/1371811Reviewed-by:
-
![Friedrich Horschig [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich Horschig [CET]")
