- 13 Apr, 2017 40 commits
-
-
ljusten authored
Codes are used internally only right now. Authpolicy shouldn't actually send them yet. This might be implemented in a future CL. BUG=chromium:676607 TEST=Squinted eyes to make sure XML is valid. Review-Url: https://codereview.chromium.org/2809413002 Cr-Commit-Position: refs/heads/master@{#464402}
-
johnchen authored
When ChromeDriver sets focus on an element, a descendant node of that element may receive the focus instead. Modifying ChromeDriver code to handle such a case. Review-Url: https://codereview.chromium.org/2813043003 Cr-Commit-Position: refs/heads/master@{#464401}
-
jdoerrie authored
TBR=mtomasz@chromium.org BUG=711290 Review-Url: https://codereview.chromium.org/2815293003 Cr-Commit-Position: refs/heads/master@{#464400}
-
gab authored
For them to compile when copy-pasted (proper base:: prefixes and avoiding english logic in code example). BUG=667892 NOTRY=true Review-Url: https://codereview.chromium.org/2815463003 Cr-Commit-Position: refs/heads/master@{#464399}
-
noel authored
Add fuzzer that reads test input and creates a color profile from it (or bails if not). Given that profile |test|, create another profile |srgb| used to transform colors to/from when running the color transform fuzzer test stage. Test ICC version 2 profiles only since ICC version 4 support in QCMS is not enabled in Chrome. Add third_party/qcms/DEPS: allows qcms_color_space_fuzzer to use //base and //testing code. Speed: achieves ~2300 execs/s on Mac Air. Seed corpus of ICC profiles uploaded to qcms_color_space_fuzzer GCS bucket. Set max_len to 4Meg (color profiles can be large and this is the limit that Chrome accepts), and use the ICC profile dict added in http://crrev.com/461603 TBR=inferno@chromium.org BUG=708016 Review-Url: https://codereview.chromium.org/2807083002 Cr-Commit-Position: refs/heads/master@{#464398}
-
stkhapugin authored
This test is failing after a chromium roll. Temporary disable it for a greener tree. BUG=711291 Review-Url: https://codereview.chromium.org/2816023003 Cr-Commit-Position: refs/heads/master@{#464397}
-
jdoerrie authored
Both SettingsEasyUnlockBrowserTest.EasyUnlock and SettingsUIBrowserTest.All are flaky on Release builds. TBR=dpapad@chromium.org BUG=711256 Review-Url: https://codereview.chromium.org/2815513010 Cr-Commit-Position: refs/heads/master@{#464396}
-
jkrcal authored
We have two code paths that download favicons from different favicon servers. We can switch between them based on a field trial feature. This CL adds logging of success rates for both the code-paths. BUG=709498 Review-Url: https://codereview.chromium.org/2812243002 Cr-Commit-Position: refs/heads/master@{#464395}
-
rduszynski authored
If disable_ffmpeg_video_decoders is set to true on platfoms other than Android ffmped_video_decoder.* is always included. This patch removes those sources and fixes dependencies in code. Review-Url: https://codereview.chromium.org/2808093008 Cr-Commit-Position: refs/heads/master@{#464394}
-
treib authored
BUG=583292 Review-Url: https://codereview.chromium.org/2814753002 Cr-Commit-Position: refs/heads/master@{#464393}
-
alexclarke authored
BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Original-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b89274a52def52e6a Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#464392}
-
rch authored
with alt-svc disabled, and if that succeeds then mark QUIC as broken. Protected by the retry_without_alt_svc_on_quic_errors finch param. BUG=705033 Review-Url: https://codereview.chromium.org/2818623002 Cr-Commit-Position: refs/heads/master@{#464391}
-
hablich authored
This is a roll-back to 5.9.211. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2822443002 Cr-Commit-Position: refs/heads/master@{#464390}
-
lpromero authored
BUG=none R=rohitrao@chromium.org Review-Url: https://codereview.chromium.org/2812133004 Cr-Commit-Position: refs/heads/master@{#464389}
-
pastarmovj authored
The call to WTSQuerySessionInformation can take arbitrary long time and thus can crash the browser when it takes more then expected. This even if not crashing the browser also was stalling the FILE thread. BUG=706737 TEST=Wait and see if crash rate falls. Review-Url: https://codereview.chromium.org/2814793005 Cr-Commit-Position: refs/heads/master@{#464388}
-
wnwen authored
There is no android:action in intent-filter: https://developer.android.com/guide/topics/manifest/intent-filter-element.html This causes errors in Android Studio when including this AndroidManifest. BUG=620034 Review-Url: https://codereview.chromium.org/2815083002 Cr-Commit-Position: refs/heads/master@{#464387}
-
lod authored
This CL adds the functionality to open the 4 search modes in the main application: regular, incognito, voice and qr code. UI support will be in a future CL. BUG=622743 TBR=jif Review-Url: https://codereview.chromium.org/2809173002 Cr-Commit-Position: refs/heads/master@{#464386}
-
jkrcal authored
Previously, accepting EULA issued a browser-foregrounded trigger. This trigger is now ignored on default in release channels. This CL changes it to persistent fetch trigger so that we are sure the initial fetch is performed, no matter how we change the params in the future. BUG=676662 Review-Url: https://codereview.chromium.org/2817903003 Cr-Commit-Position: refs/heads/master@{#464385}
-
poromov authored
This is partly rollback of http://crrev.com/2702313002 While content of policy compliance report is not important for starting kiosk app, ChromeOS should wait for compliance report from CloudDPC side to ensure that all permissions are already correctly granted before app is started. BUG=b/36678353 TEST=ArcPolicyBridge unittests Review-Url: https://codereview.chromium.org/2809773004 Cr-Commit-Position: refs/heads/master@{#464384}
-
perezju authored
The catapult CL [1] will introduce a change where running adb commands may now raise device_errors.DeviceUnreachableError if the device is no longer found. This change adjusts clients that were hoping to catch this kind of error as a device_errors.[Adb]CommandFailedError. [1]: https://codereview.chromium.org/2808763004/ BUG=https://github.com/catapult-project/catapult/issues/3476 Review-Url: https://codereview.chromium.org/2811993002 Cr-Commit-Position: refs/heads/master@{#464383}
-
alexclarke authored
The old Delegate API made it rather awkward to get at the full details of the request. This new API fixes that, whilst allowing more flexible request modification. BUG=546953 Review-Url: https://codereview.chromium.org/2815003003 Cr-Commit-Position: refs/heads/master@{#464382}
-
kylechar authored
This CL switches the content/browser/ part of offscreen canvas to use FrameSinkManagerHost instead of directly accessing SurfaceMananger. OffscreenCanvasProvider(Impl) exists for the renderer to request other interfaces from the browser. The renderer uses it create both a OffscreenCanvasSurface and MojoCompositorFrameSink. This is a simplification of OffscreenCanvasCompositorFrameSinkProvider and OffscreenCanvasSurfaceFactory interfaces. RenderProcessHostImpl creates a single OffscreenCanvasProviderImpl on demand and uses it for all offscreen canvas requests from the renderer. The renderer will first request a OffscreenCanvasSurface and specify the FrameSinkId. This always happens from the main renderer thread. A OffscreenCanvasSurfaceImpl will be created for the browser side of this connection. The renderer will then likely request MojoCompositorFrameSink for the FrameSinkId, from either the main thread or a worker thread. This request is forwarded to MojoFrameSinkManager. This sets up two connections. There is a MojoCompositorFrameSink from MojoFrameSinkManager to the renderer. This is used to submit CompositorFrames. There is MojoCompositorFrameSinkPrivate from OffscreenCanvasSurfaceImpl to MojoFrameSinkManager. This gives the browser control over the CompositorFrameSink created in MojoFrameSinkManager. The render can close the OffscreenCanvasSurface and MojoCompositorFrameSink connections in any order. The assumption is they will both be closed at approximately the same time. The remaining direct access to SurfaceManager by offscreen canvas code is blocked on other features being completed. BUG=664547,686861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2789753002 Cr-Commit-Position: refs/heads/master@{#464381}
-
fdoray authored
Skipping tasks when destroying ScopedTaskEnvironment or ScopedAsyncTaskScheduler means that DeleteSoon() tasks can be skipped, resulting in memory leaks. BUG=708584, 709095 Review-Url: https://codereview.chromium.org/2812293002 Cr-Commit-Position: refs/heads/master@{#464380}
-
poromov authored
BUG=710896 TEST=Run components_unittests Review-Url: https://codereview.chromium.org/2811303003 Cr-Commit-Position: refs/heads/master@{#464379}
-
nikhil.sahni authored
BUG=703559 Review-Url: https://codereview.chromium.org/2803603003 Cr-Commit-Position: refs/heads/master@{#464378}
-
bsazonov authored
This CL fixes crashes caused by calls to Profile.getLastUsedProfile() before browser initialization is completed. In such a case ProfileManager will try to create new Profile and that will eventually crash Chrome, because Prefs are not registered yet (Profile-related Prefs are registered during browser initialization by ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt). BUG=704025,710968 Review-Url: https://codereview.chromium.org/2809223003 Cr-Commit-Position: refs/heads/master@{#464377}
-
jdoerrie authored
Reland of Move ScriptState::GetExecutionContext (Part 5) (patchset #2 id:300001 of https://codereview.chromium.org/2821443002/ ) Reason for revert: Broke Build Original issue's description: > Revert of Move ScriptState::GetExecutionContext (Part 5) (patchset #3 id:40001 of https://codereview.chromium.org/2816543002/ ) > > Reason for revert: > Suspected culprit of webkit_tests failing on chromium.webkit/WebKit Linux Trusty MSAN. > > BUG=711250 > > Original issue's description: > > Move ScriptState::GetExecutionContext (Part 5) > > > > This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From. > > > > BUG=682322 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2816543002 > > Cr-Commit-Position: refs/heads/master@{#464056} > > Committed: https://chromium.googlesource.com/chromium/src/+/d2d9a34e2fd74fd45026a8fed6f4715de18df747 > > TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=682322 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=711250 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2815313002 Cr-Commit-Position: refs/heads/master@{#464376}
-
zqzhang authored
This CL adds a number of JUnit tests for testing MediaNotificationManager in the following aspects: * Check if MediaNotificationManager handles the ListenerService correctly. * Check if ListenerService can correctly process Intents. * Check if the Notification presrented to Android NotificationManager is correct. Many MediaNotificationManager members are changed to package scope access to avoid too many "ForTesting" names. BUG=705919 Review-Url: https://codereview.chromium.org/2816603002 Cr-Commit-Position: refs/heads/master@{#464375}
-
maxmorin authored
Currently, the sync socket in MojoAudioOutputStream is closed by both Mojo and the SyncSocket destructor. This causes problems if a handle happens to be reused. BUG=709394 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2809673002 Cr-Commit-Position: refs/heads/master@{#464374}
-
jdoerrie authored
Revert of Move ScriptState::GetExecutionContext (Part 5) (patchset #3 id:40001 of https://codereview.chromium.org/2816543002/ ) Reason for revert: Suspected culprit of webkit_tests failing on chromium.webkit/WebKit Linux Trusty MSAN. BUG=711250 Original issue's description: > Move ScriptState::GetExecutionContext (Part 5) > > This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From. > > BUG=682322 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2816543002 > Cr-Commit-Position: refs/heads/master@{#464056} > Committed: https://chromium.googlesource.com/chromium/src/+/d2d9a34e2fd74fd45026a8fed6f4715de18df747 TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682322 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2821443002 Cr-Commit-Position: refs/heads/master@{#464373}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98d73506..2e896f6f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2810223004 Cr-Commit-Position: refs/heads/master@{#464372}
-
capn authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ed3149..400667e BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2817783002 Cr-Commit-Position: refs/heads/master@{#464371}
-
capn authored
BUG=707298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec Review-Url: https://codereview.chromium.org/2812963003 Cr-Commit-Position: refs/heads/master@{#464370}
-
mvanouwerkerk authored
Review-Url: https://codereview.chromium.org/2819533002 Cr-Commit-Position: refs/heads/master@{#464369}
-
hs1217.lee authored
This patch changes DocumentMarkerController::RenderedRectsForMarkers() to ignore disconnected nodes. and it is first step to use EphemeralRange in updateMarkerRenderedRect(). we will progress three steps. [1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes. [2/3] In-place change of Range::textRects() and boundingBox() to EphemeralRange version in "Range.cpp" [3/3] Rewrite updateMarkerRenderedRect() to use EphemeralRange instead of Range BUG=691202 Review-Url: https://codereview.chromium.org/2776103002 Cr-Commit-Position: refs/heads/master@{#464368}
-
dpranke authored
These tests have been failing for a little while, but since I just moved the builder onto the chromium.memory waterfall, they will now be reported to the sheriffs, and so it's better to disable them until they can be triaged. TBR=thakis@chromium.org, danakj@chromium.org, fsamuel@chromium.org, dalecurtis@chromium.org BUG=697171 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Review-Url: https://codereview.chromium.org/2817443004 Cr-Commit-Position: refs/heads/master@{#464367}
-
julien.isorce authored
And rename files gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.{cc,h} => gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.{cc,h} From this CL the 2 files above are now also build on linux. But for now GpuMemoryBufferFactoryNativePixmap::CreateImageForGpuMemoryBuffer is only implemented on ozone as it was previsouly. A follow-up CL will implements it for linux. This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux. BUG=584248 R=reveman@chromium.org TBR=kbr@chromium.org, piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2709163004 Cr-Commit-Position: refs/heads/master@{#464366}
-
lizeb authored
BUG=699080 Review-Url: https://codereview.chromium.org/2815103002 Cr-Commit-Position: refs/heads/master@{#464365}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d20e3880234a..e0b592236db9 $ git log d20e38802..e0b592236 --date=short --no-merges --format='%ad %ae %s' 2017-04-12 tsepez Refcount CPDF_CryptoHandler Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ia64c6d854cee8cacedd8af7c77e1e6016bd95045 Reviewed-on: https://chromium-review.googlesource.com/476027 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#464364}
-
jkrcal authored
This CL adds UMA metrics for sizes of favicons from which fallback style was generated (because large enough icon is missing). This is important for evaluating if changing the minimum size limit / using more advanced method for upscaling would help. BUG=709498 Review-Url: https://codereview.chromium.org/2809783003 Cr-Commit-Position: refs/heads/master@{#464363}
-