GitLab

onto chrome://extensions.

BUG=282710
NOTRY=true

Review URL: https://codereview.chromium.org/81953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/379563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281890 0039d316-1c4b-4281-b951-d872f2087c98

Instead of returning ERR_ABORTED, we should return 0 and Reset the stream.

Review URL: https://codereview.chromium.org/372343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281889 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Possibly-uninitialized local variable

This also contains a small number of other cleanups/simplifications to nearby
code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/377803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281888 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Octal escape sequence terminated by decimal number

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/375773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281887 0039d316-1c4b-4281-b951-d872f2087c98

The OOBE process may install some default apps. We need to ignore these
when determining whether or not any apps have been synched when
determining the OEM folder position.

BUG=chrome-os-partner:29764,chromium:391683

Review URL: https://codereview.chromium.org/373923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281886 0039d316-1c4b-4281-b951-d872f2087c98

We would like single-line messages to center align with the icon and multi-line messages to top align with the icon.

In the existing implementation, we use a different CSS rule for multi-line messages to adjust the padding.  This is undesirable as we can't predetermine whether a message would fit in one line before actually laying it out.

This change simplifies the CSS by vertical aligning text for error messages, which can achieve the desired behavior for both single and multi line messages.

Review URL: https://codereview.chromium.org/317013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281885 0039d316-1c4b-4281-b951-d872f2087c98

Defines an InvalidationInterface class and uses it to break any direct
dependencies from sync code on syncer::Invalidation.  Despite its name,
syncer::Invalidation should belong solely to the invalidations
component, which code in the sync/ directory should not depend on.

Changes the interface in the sync engine from copying
syncer::Invalidation to managing scoped_ptr<InvalidationInterface>.
This change in memory management was required to support the use of an
abstract interface.

Removes the DroppedInvaldiationTracker.  This class was previously only
used by sync.  The small benefit provided by this class is outweighed by
the amount of glue code it would take to maintain it.

Changes tests to conform to the new interface.  Adds some test-only
implementations of InvalidationInterface and some associated classes.

BUG=259559

Review URL: https://codereview.chromium.org/322333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281884 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281883 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wez@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/373213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281881 0039d316-1c4b-4281-b951-d872f2087c98

Chromium r281546 introduced some #if-guarded code in prep for a Blink
roll. Now that Blink r177616 has rolled and brought in the new code,
these can be removed.

BUG=100123
R=ericu@chromium.org

Review URL: https://codereview.chromium.org/377953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281880 0039d316-1c4b-4281-b951-d872f2087c98

We need to ensure that the PepperPluginInterface is non-NULL before every use.
I found this code with a missing check while doing code inspection for
nativeclient:3883.

BUG=nativeclient:3883

Review URL: https://codereview.chromium.org/369543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281879 0039d316-1c4b-4281-b951-d872f2087c98

Fix bug where idle power was measured on every browser invocation rather than once per run.

BUG=339180

Review URL: https://codereview.chromium.org/371383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384434,390573
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/370983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281877 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Octal escape sequence terminated by decimal number
* Possibly-uninitialized local variable
* Assignment inside conditional
* Signedness mismatch

This also contains a very small number of other cleanups to nearby code.

BUG=81439
TEST=none
R=rch@chromium.org

Review URL: https://codereview.chromium.org/374033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281875 0039d316-1c4b-4281-b951-d872f2087c98

The problem with having a single observer method with a phase param is that it's cumbersome and error prone to use for most clients that just want to know when something *has* changed. I think it's appropriate then to create separate methods for each phase and have the client override the one (or both) that is relevant to them.

TBR=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/374933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281874 0039d316-1c4b-4281-b951-d872f2087c98

- Remove some calls to base::CreateStringValue
- pass some things by const ref instead of copying or scoped_ptr

BUG=160586

Review URL: https://codereview.chromium.org/377723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281873 0039d316-1c4b-4281-b951-d872f2087c98

This change enables running the JavaScript unit test on try bots and build bots using the browser test infrastructure. 

To run a QUnit test suite as a browser test. 
1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite. 
2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite. 
3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable 

Summary of changes: 
1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results. 

2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.

3. Updates browser_tests.isolate so that the test can run in an isolated test environment.  See http://www.chromium.org/developers/testing/isolated-testing.

Review URL: https://codereview.chromium.org/376803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281872 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/372473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281871 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

This also contains one cleanup change (to remove an extra set of parens).

BUG=81439
TEST=none
R=rch@chromium.org

Review URL: https://codereview.chromium.org/371213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/373233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281868 0039d316-1c4b-4281-b951-d872f2087c98

Includes a fix to shaders that affect Earth View in Maps.

BUG=391697

Review URL: https://codereview.chromium.org/378503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281867 0039d316-1c4b-4281-b951-d872f2087c98

Add helpers to RenderWidgetHelper to associate a NSView with
a given RenderWidgetHelper (process and widget routing id), so
that browser compositor swaps can be received while pausing
waiting for correctly sized frames.

BUG=388005
TBR=cevans

Review URL: https://codereview.chromium.org/370513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281866 0039d316-1c4b-4281-b951-d872f2087c98

Since g_browser_process can only be accessed by ui thread, and GoogleUpdateSettings::GetCollectStatsConsent should be called by FILE thread, it doesn't make sense to put them in the same function, which is executed through posttask on FILE thread. 

Schedules only GoogleUpdateSettings::GetCollectStatsConsent on FILE thread, and does everything else on IO thread in ShowForReal()

BUG=

Review URL: https://codereview.chromium.org/369933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281865 0039d316-1c4b-4281-b951-d872f2087c98

See the bug for a more detailed discussion of the problem when we don't make
this accessible through ADL.

BUG=391117

Review URL: https://codereview.chromium.org/367063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375538

Review URL: https://codereview.chromium.org/293253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281863 0039d316-1c4b-4281-b951-d872f2087c98

This makes GPU rasterization on Android 4.4.4 dependent on the device
whitelist, rather than being enabled for all devices.

BUG=391750

Review URL: https://codereview.chromium.org/375823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281862 0039d316-1c4b-4281-b951-d872f2087c98

Add a probability to Alternate-Protocol support. Can be enabled either via a field trial or a command line flag.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281777

Review URL: https://codereview.chromium.org/339663010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168658

Review URL: https://codereview.chromium.org/332243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281860 0039d316-1c4b-4281-b951-d872f2087c98

In M35 release, we had a lot of user feedbacks of Chrome native crash.
We had great difficulty to investigate these native crashes
because user feedbacks don't have minidumps.
    
By keeping the CHECK error message in logcat, it'd be a lot easier
to investigate these user reports of Chrome crashes.

The binary size increase: ~0.5% (188k out of 34.4M).

BUG=378974

Review URL: https://codereview.chromium.org/336413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392194

Review URL: https://codereview.chromium.org/372283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281858 0039d316-1c4b-4281-b951-d872f2087c98

This will be useful for Contextual Search to determine when to trigger.

BUG=391973

Review URL: https://codereview.chromium.org/371133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281857 0039d316-1c4b-4281-b951-d872f2087c98

Also require the list of values to be nonempty and add tests.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/375993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281856 0039d316-1c4b-4281-b951-d872f2087c98

Also add tests.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/365993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390820
TEST=Start chrome with --new-profile-management. Choose "Not <profile>" from
the avatar bubble. In the User Manager, press 'tab' until focus reaches the
drop down arrow of a user pod. Press 'enter', whcih should show you the delete
button. Press the down arrow to focus the delete button, and press 'Enter'. This
should show the warning view, with the big red button focused, and pressing
'Enter' again should delete the pod. Yay!

Review URL: https://codereview.chromium.org/373813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281852 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281851 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13442: (dyen) Added support for log uploading for commands in toolchain_build.
r13443: (noelallen) Rolls DEPS file to get deps aware toolchains.
r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes.
r13446: (ncbray) Factor arg parsing in sel_ldr into its own function.
r13447: (ncbray) Add my chromium account to OWNERS with my google account.
r13448: (dyen) Fixed repo_tools invalid reference to pynacl.
r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck.
r13450: (ncbray) Consolidate sel_ldr's configuration logic.
r13451: (dyen) Package Version script now supports downloading build logs.
r13452: (hamaji) Non-SFI Mode: Add isatty interface

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/371413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391953
TEST=webgl conformance on gpu bots
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/376703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281848 0039d316-1c4b-4281-b951-d872f2087c98

This test skips the managed_node because it's not synced. The test
assumed that the managed_node always comes next to the mobile_node but
this is not true on iOS.

This fix changes the test to look for the managed node via
BookmarkClient::CanSyncNode, which is the correct check in the first
place.

BUG=383398

Review URL: https://codereview.chromium.org/376993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281847 0039d316-1c4b-4281-b951-d872f2087c98