- 13 Jan, 2021 40 commits
-
-
Javier Fernández García-Boente authored
In r837379 we landed support for this feature in LayoutNG. This CL implements the feature for Legacy layout. Bug: 1155633 Change-Id: I2b974daad7a98d26fdc4d4468572840e30be5cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598843 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842846}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610474333-6e9ea86fde1168dfc05bd82ef581aacfe157db52.profdata to chrome-mac-master-1610495996-38f3d5c57ab4be3d52eaefe38d45ce16ec0addd8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f437e77504e02d63397aedb85313d017ad272f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842845}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e59aac750e..002c03c4b6ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7270cac7bbf84b0d262c265daba3a69f1941912c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625509Reviewed-by:
-
Adam Langley authored
This dates back to when we still used NSS(!) and thus didn't have access to group operations for any elliptic curves. We can just use BoringSSL now. Change-Id: I8bc4bc09fdd26feb25a76c17bf716808eb1cb2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623123 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#842843}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 80b0b297. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Icf6482a2f8c5cc1a1a14c8c9e580323fd03b42d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626587Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842842}
-
Stephan Hartmann authored
Change-Id: I70cedfa4d20b09192ba749a0866ac531aeaf0db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601365Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842841}
-
Glen Robertson authored
Missed when moved out to util. Change-Id: I6684b417d869f3ebac6b53c3e549f49b41d1d6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612289 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#842840}
-
Christopher Cameron authored
Move methods for getting and setting color space and pixel format from a string to CanvasColorParams. CanvasRenderingContext has ColorSpaceAsString and PixelFormatAsString method, which are redundant because it also has a method to get the CanvasColorParams, from which these can be queried. CanvasRenderingContext also has logic to handle situations where the color space and pixel format are changed from what was specified. This never happens, so remove it. Also remove a number of redundant ColorSpace and PixelFormat accessors. This will simplify adding these parameters to WebGLContextAttributes, which was accidentally forgotten. Bug: 1164230 Change-Id: I0471939c1f98b0c78f7a5dbbd3fb61940b9d7a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617110Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#842839}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16b9bbbd..3d7f91cf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e6bd28e5993737e9d4c5a9f3d23da4a71a41218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625773Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842838}
-
Eugene Zemtsov authored
to be reused in AudioEncoder Bug: 1094179 Change-Id: I3e693a3da7727bd827440c391e2ababca5681b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623950 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842837}
-
Takashi Sakamoto authored
Disable MemoryMap.SelfLargeMapFile, MemoryMap.SelfLargeFiles and MemoryMap.SelfBasic when PartitionAlloc is used as malloc. When PartitionAlloc is used as malloc, malloc() will cause mmap(). So while reading and parsing /proc/self/maps, we should avoid memory allocation. If malloc() is invoked, the maps file will be updated and we will see parse error. Bug: 1163794 Change-Id: Ifc008c1b23a37ec0405056cdfbe4582233c16d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612872Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#842836}
-
adamta authored
This CL allows for the fake omnibox to stick to the top of the NTP when scrolling through the page. The width animation before sticking is handled by the ContentSuggestionsLayout, as it was before. This layout will perform the initial "stick" once the animation is over. Once the user scrolls passed the ContentSuggestionsHeader, the fake omnibox ownership is transferred to the Discover feed, so that it could stick to the top of the NTP and receive tap actions. Bug: 1114792 Change-Id: I15d5c32cba1aedfe0756b23c19a55f59d48806ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622314 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#842835}
-
David Maunder authored
Speedup: 49246ms -> 10061ms (80% improvement) Bug: 1164552 Change-Id: I85bf73b14b2def7b9c0d5d3d4a1f2505d037a2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617051Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#842834}
-
tby authored
Bug: 1034842 Change-Id: I00eb83f557262e97d990cd4544b55a68f8c31aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617403Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#842833}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.149. R=rmhasan@google.com Bug: 1041619 Change-Id: I8ce43219aa1519bce42b76fe44f48f08ec9c6ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626509 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#842832}
-
Xinghui Lu authored
Add a feature flag SafeBrowsingkRealTimeUrlLookupEnterpriseGaEndpoint to control whether enterprise requests are sent to the new endpoint. The new endpoint is currently not reachable, so the flag is disabled by default. Bug: 1155272 Change-Id: Iba7851a6cd48dd44713e69460bb916357614de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595916Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842831}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98eb0a70aead..d79335daa04a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com,dfried@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1097080,chromium:1150968 Tbr: yukishiino@google.com,dfried@google.com Change-Id: Ie63f268d7ddc22a2277a895b0ba59e1d639c5c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626190Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842830}
-
Peter Kotwicz authored
The motivation for this change is FragmentPagerAdapter being deprecated. BUG=1162839 Binary-size: viewpager2 already in internal Chrome build Change-Id: If223fdea7ec5003681d4183ad764314b18c83d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605476 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842829}
-
Joshua Peraza authored
cce6b30149d3 Optimize calls to std::string::find() and friends for a single char 2e066d2e56d0 Use chromeos buildflags 0f70d9477ea8 Fix typo in build target Change-Id: Ia834a10c6a82cfe40395921c34236b1153a152ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626128Reviewed-by: -
rajendrant authored
Moves the robots_rules.proto from chrome/renderer to components/ Bug: 1160424 Change-Id: I0b2af266e3a6de40872bf094195b7f0c21c42096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623647 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842827}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - actions_model.js - actions_model_unittest.m.js - list_thumbnail_loader.js - list_thumbnail_loader_unittest.m.js - mock_thumbnail_loader.js In //ui/file_manager/file_manager/foreground/js/ui/: - action_model_ui.js - file_grid.js - file_metadata_formatter.js - file_table.js - file_table_unittest.js - file_table_list.js - file_table_list_unittest.js - a11y_announce.js - file_tap_handler.js - file_tap_handler_unittest.js - list_container.js Bug: 1133186 Change-Id: I0d4106d55c6b059149b1b677ac00ec31398d7a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621792 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842826}
-
Regan Hsu authored
Previously, this metric was logged in UpdateStatus(), which can be influenced by connecting to a tether network in locations other than via PhoneHub (e.g in OS Settings). This CL adds an attempt connection tracking variable which is checked in UpdateStatus() before logging the success metric. Fixed: 1164570 Bug: 1106937 Change-Id: I9c070b7e644bcd6357bdb78f9b1e8a06bb275349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622953Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842825}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ace3f2939f89..0a69b4bb071c 2021-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2c65da28a2ee to 5b8dec52b68f (3 revisions) 2021-01-12 csmartdalton@google.com Move GrAATriangulator into its own file 2021-01-12 johnstiles@google.com Add flag to force skslc to compile one test file at a time. 2021-01-12 csmartdalton@google.com Move various static GrTriangulator functions into structs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: Ia69d560efb6153b726c92a0ea0a78938af977685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625848Reviewed-by:
-
Mike Reed authored
This may allow us to separate two issues: moving away from (deprecated) SkFilterquality, and exactly how to post-sampling picture-shaders. Change-Id: Icb81d5779173a518ecc4bee1fcfcbf3223337ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626169 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#842823}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2f00da00409a44d0e8d2e55e478ed00b170458fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625849Reviewed-by:
-
Joe DeBlasio authored
This CL changes the way async callbacks to the lookalike service are handled. Previously, if the list of engaged sites was out of date, a background task would be spawned to update them. This could result in a spike of near-simultaneous background tasks that would contend for the same lock. This contributes to jank. This CL changes the process to ensure that only one update is in flight at a time, and simply pushes the on-updated callbacks onto the end of the task sequence after any existing update completes. Bug: 1157596,1135279 Change-Id: I0629f523491d8e4b8e966fa3b65f670c901e7169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623005 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842821}
-
Mason Freed authored
Prior to this CL, a horizontal range slider with ltr text direction would increase in value if Right Arrow is pressed, and decrease for Left Arrow. However, if the range were vertical (with -webkit-appearance: slider-vertical), those directions were reversed: Right Arrow decreases the value, while Left Arrow increases it. Similarly, Home and End keys had reversed operation for vertical ranges. With this CL, the same keys produce the same (semantic) result. Fixed: 1162640 Change-Id: Ia2251ffe9e2056f1c20d25130b8a0d2e3d1e79ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623117Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#842820}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2881d6b22d1e..44ba8e1708ab 2021-01-12 treehugger-gerrit@google.com Merge "tp: don't log updated clocksnapshot if the clock is not changing" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5be1d0ff55bf084378fa62548e0c298d284c2ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625857Reviewed-by:
-
Eric Willigers authored
ImpressionNavigation_OriginTrustworthyChecksPerformed is failing with MemorySanitizer: use-of-uninitialized-value Disabling while investigating. Bug: 1165985 Change-Id: I9d7686698acec29bfe1a3704b6f7bea36108a1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626687Reviewed-by:
Dana Fried <dfried@google.com> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842818}
-
Collin Baker authored
IPH bubbles can get arbitrarily long with as the body text gets longer. The text should instead be wrapped at a certain point. This implements a max width as per https://docs.google.com/presentation/d/1A9QtE_cxJYLs3E7fQs9-tiCtLfEwxQiYDZUMYkYVHmI/edit#slide=id.g338d2b5135_0_19 beyond which the bubble contents are wrapped. Bug: None Change-Id: If3912ec379e52d2244bd3567dd23d14a3c229360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626189 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842817}
-
Haiyang Pan authored
Enable the following as they are consistently green: * chrome_public_smoke_test * weblayer_unittests * webview_ui_test_app_test_apk Run chrome_public_test_apk at 100% experimentally. According to the bot usage (http://shortn/_hEy8np3sYC) and swarming tasks status (http://shortn/_7gxoNS82Qr), the test pool might experience some pending time. Will keep an eye on it and revert if it causes any issue. Also disabled 4 flaky tests. See the filter file for details. Bug: 1111436, 1165449, 1165456, 1165459 Change-Id: Ic1e2a1e431639f8f0ea882f2a412281166222abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622006Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#842816}
-
David Bokan authored
ForceLoadAtTop is a DocumentPolicy header but was originally shipped as an OriginTrial since it was needed before DocumentPolicy was shipped. The OriginTrial worked by enabling a RuntimeEnabledFeature; the use counter was based on this REF. However, once DocumentPolicy shipped, the OriginTrial was abandoned and ForceLoadAtTop was enabled using a DocumentPolicy header. However, we forgot to update the UseCounter code to use the DocumentPolicy header. This CL updates the UseCounter to be based on the DocumentPolicy header. A followup CL will remove the REF. Bug: 1165340 Change-Id: I163f20620e1b63ef46cb202a1511059468e43abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622323Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842815}
-
Dana Fried authored
TBR=hansberry@chromium.org Bug: 1165955 Change-Id: I55392bd0adbe9f83cfcfd13564417f7420384e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626131 Commit-Queue: Dana Fried <dfried@google.com> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842814}
-
Allen Bauer authored
Bug: 938501 Change-Id: Ia852579e7e600d08c704b67d4dfdd84ea14db5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625969 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#842813}
-
Xiaohui Chen authored
This avoids potential race when conversation involves opening a new window which immediately closes the conversation. Bug: b/173833583 Change-Id: I56654232099c5bb7318fcd17ed26e0d3bbb0d66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623116 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842812}
-
Trevor Perrier authored
This CL adds one more language to kSupportedSpellCheckerLanguages. This makes it so that all region/dictionary values in kSupportedSpellCheckerLanguages that are also in kAcceptLanguageList have their own entry in kSupportedSpellCheckerLanguages and prevents duplicate overflow values for languages in kAcceptLanguageList. Bug: 1074284 Change-Id: Id99ef28e99367672a92c14d2dbfa7eeb23ceaf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625588Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Josh Simmons <jds@google.com> Auto-Submit: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#842811}
-
Jeffrey Kardatzke authored
This is done to match changes Intel is making in the driver which will be merged shortly. BUG=b:153111783,b:155508443 TEST=CBC HEVC/AVC, CENCv1 AVC, CENCv3 VP9/AVC/HEVC work Change-Id: I45b4c7d1399040baebdf47aa31f06f6ea502445f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625772Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#842810}
-
Jared Saul authored
Change-Id: I9d663a1b4c3603fe1e42bd46a476f5d791654325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625748Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#842809}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c60dda78e4ab..2881d6b22d1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I049d67aba73695b8b164ff7341881ed239592aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626450Reviewed-by:
-
Francois Doray authored
This is a cleanup prior to fixing crbug.com/1164477. It improves readability by removing code that handles situations that never occur. Bug: 1164477 Change-Id: I97e77b54ffc40e100b07b00ab44fbe3a46bb9eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618159 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#842807}
-
