- 10 Jan, 2020 40 commits
-
-
evliu authored
Bug: 1033227 Change-Id: Ib7d6630860f11237639f46023788adabe1273138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988377Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#730282}
-
Dave Tapuska authored
Move tracking of DidAccessInitialDocument into frame loader. Add a HasAccessedInitialDocument API to WebLocalFrame to maintain state data for dispatching unload message. This may be removed if we move the logic into blink instead of the content layer at a later time. BUG=1008432 Change-Id: Ifbdaa53931cf0824678618275ec39723918e0c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951576Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#730281}
-
Mason Freed authored
The CL [1] caused several perf regressions (see [2] for example). Basically the only change in [1] was to convert this: RuntimeEnabledFeatures::FormControlsRefreshEnabled() to this: features::IsFormControlsRefreshEnabled() This CL attempts to reduce the overhead of checking the feature flag. [1] https://chromium.googlesource.com/chromium/src/+/6da8104d37c254c842a7fd6dfffb208bd303788d [2] https://crbug.com/1039272 Bug: 1039272 Change-Id: I47213d88a64f33ad3eddc3fd2fefb921d377395e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993672 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730280}
-
Eric Stevenson authored
Downstream usages have been deleted. Change-Id: If677937e97efc7686d07b56a787d781d1bc0c318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992349 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#730279}
-
Livvie Lin authored
This CL adds a ScriptCommandSubscription to IOSSSLErrorTabHelper to manage the command listener for SSL interstitials. This subscription will listen for JS commands that come from the interstitial (for which JS has been updated to properly pass messages for iOS) and forward commands to the security interstitial subclass, which has a command handler method implemented for the specific relevant cases. Most of the commands re-use logic from non-committed interstitials, except for IOSSSLBlockingPage's proceed command. This CL also makes SessionCertificatePolicyCacheImpl::RegisterAllowedCertificate public so that it can be used for allowlisting a cert when a user proceeds on an SSL interstitial. This method is also updated to handle AllowCertForHost so that only one method needs to be called for allowlisting. Bug: 987407 Change-Id: I5b216cca66f2aebf0df8cec293b60ed0f862fae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937853 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730278}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ef3661d276c..d01eb543e70e git log 2ef3661d276c..d01eb543e70e --date=short --first-parent --format='%ad %ae %s' 2020-01-10 kahinds@microsoft.com Animation Timeline keyboard focus and interactivity Created with: gclient setdep -r src/third_party/devtools-frontend/src@d01eb543e70e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd06e3f5ff9d3fd20b90595247585872752aef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730277}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6f813d450e5..164f811b2cf6 git log f6f813d450e5..164f811b2cf6 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 jbudorick@chromium.org devil: introduce autoformatting and format devil/android. Created with: gclient setdep -r src/third_party/catapult@164f811b2cf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040208 Tbr: crouleau@google.com Change-Id: I9ae7f231ee4b6b41d33677cd7cf5240d01820a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730276}
-
Charlie Hu authored
- Advertise required document policy on out-going requests. - Parse and initialize document policy in security context. - Replace with page with empty document when incoming document policy is incompatible with required policy. - A boolean flag body_loader_finished is added to SimRequestBase::Finish because when testing page blocked by document policy situation in document_loader_test.cc, body_loader.Finish will be called twice, once in WebNavigationParams::FillStaticResponse, once in test framework, which will crash the test because of a DCHECK. Bug: 993790 Change-Id: I823675408a0d52e8048172ae23d409a5f14e8eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947187 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#730275}
-
Matthew Mourgos authored
With this change, the padding between the edge of the screen and the status area widget no longer has anything to do with the hotseat state. This edge padding will now only ever have two possible values, one value in tablet mode and another value in clamshell mode. This is a reland of crrev.com/c/1977025, which was reverted because of a test failure when the hotseat flag was enabled. The addition of UpdateIsDense() in OnAppListVisibilityWillChange() fixes the test failure. UpdateIsDense() has been changed to help minimize the number of times OnShelfConfigUpdated() will be called. Bug: 1035716 Change-Id: Iddf1e13928d73f6783d33bddfd6cc1796d0abe31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990513Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#730274}
-
Tibor Goldschwendt authored
That way the background color will be correct as soon as the page loads and we prevent a white flicker. Bug: 1039393 Change-Id: Ia857a259e3e8d46a3231012f5efaf4996d411fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994419 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#730273}
-
Jimmy Gong authored
- This change will allow any printer setting dialog to have a custom height - Adjusts make and model dialog height to have less white space, which results in a smaller dialog. - Allow any newly introduced dialog to have a non-350px height. Bug: 1015628 Test: end to end manual Change-Id: Ib7ba28aced27d2cb7a576e1edf9a6d24fa1fb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955024Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#730272}
-
Tom Anderson authored
This is needed after [1] used weak undefined symbols to test feature support in libgbm. The dependencies for the Chrome debian package are unchanged before/after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1988382 BUG=1031269 R=thestig,thakis CC=spang Change-Id: I760033d5883bf65a5a39316ea382766ae3754088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992340Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730271}
-
Eric Seckler authored
This reverts commit d8710dd9. Reason for revert: trace collection overhead reduced (see bug) Original change's description: > Disable webrtc/multiple_peerconnections on low end win 10. > > NOTRY=true > TBR=crouleau@chromium.org > CC=qiangchen@chromium.org,mbonadei@chromium.org,phoglund@chromium.org > BUG=1039726 > > Change-Id: I20cfd146d010a9645db2f33920f5e91443308f3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989748 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729063} TBR=crouleau@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039726 Change-Id: I87448ffdd29147d0378047f38839a003e24b04b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995176Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#730270}
-
Mohammad Refaat authored
Remove Assert in the ChromeEarlGrey Cookies method, which was there to assert that the object returned from the javascript execution is iterable object. The respondtoSelector method doesn't work properly in that case and it returns always false even if the EdoObject is actually an Array. Bug: 1019670, 1041000 Change-Id: I11f042d1ff2ffaeeabef1f39deffe6ed554d1e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994101 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#730269}
-
Richard Knoll authored
If the URLLoaderFactory pipe gets closed after an error, we need to reset it before binding a new pipe to it. Bug: 1041003 Change-Id: Ida95194941234fd91b1a6324586677672dad5d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991489 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730268}
-
wutao authored
BoxLayout will set child view's cross axis bounds based on the preferred size. When SetText and AddStyleRange are called, it can set two different bounds of the styled_label and cause Launcher resize. To avoid BoxLayout change the width of styled_label, we can use kStretch mode in the cross axis. Bug: b/146940170 Test: manual Change-Id: If905ccd6e739d1487095d6a0b59e1093487b9523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991758 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#730267}
-
Sasha McIntosh authored
Disable YUV jpeg decoding in cases where the bitmap is is directly requested from the decoder. Bug: 1039405 Bug: 1031016 Change-Id: Id97f4933ea63ff484edb0fadb1642a80df04d381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988929Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730266}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab826cd1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3815d3292caa2c3793b416d88b888f71ee8227f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995217Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730265}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2cad713..7006065f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I595c355516a2e5ade0026272b9713b3124237015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994904Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730264}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/504032e57526..8964bc13dafc git log 504032e57526..8964bc13dafc --date=short --first-parent --format='%ad %ae %s' 2020-01-10 reed@google.com forward concat44 in nway canvas 2020-01-10 kjlubick@google.com [canvaskit] Roll to 0.11.0 2020-01-10 nifong@google.com Fix san error by initializing new bool in debugcanvas 2020-01-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-10 jlavrova@google.com height_override without a multiplier 2020-01-10 halcanary@google.com tools/git-sync-deps works with either python Created with: gclient setdep -r src/third_party/skia@8964bc13dafc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Ie05d7bdd9c6a44881e0c84041c33f90a025d4ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730263}
-
Eric Orth authored
Remove all logic around maintaining a single DoH probe runner or single probe context in HostResolverManager. Requests created by HostResolverManager::CreateDohProbeRequest() are now independent, can run concurrently, and can be independently cancelled. Bug: 1022059 Change-Id: I1fb8522771132114d0b22f293fec2328598e5b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982789 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#730262}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I771aeefd4085e84d560cfd88b986b336fe0657f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993481 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#730261}
-
Chris Hamilton authored
A further CL will convert content_public.browser.MessagePort and transferable_message.mojom to use content_public.browser.MessagePortDescriptor instead of mojom.MessagePipeHandle. This whole migration will allow Javascript message ports to be instrumented. BUG=980533 Change-Id: Ib091b5f12836c2c6e5ff13bfdad8a9ee353bea57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974674Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#730260}
-
Wez authored
- Rename the USB_KEYMAP() macro to DOM_CODE() in the data file. - Update call-sites which include the DomCode data file. Bug: 949593 Change-Id: I2bd7a09c387b53d17245827bb0b2bad27c29b3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986133 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#730259}
-
Michael Irani authored
Change-Id: Ib7e52abca8b7a7221bd51ff7518477f208feddba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981140Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#730258}
-
Alex Newcomer authored
The failed drag should result in an extended hotseat. Change-Id: I98c8852f829172a471e0af1b78ff19563f4c57f9 Bug: 1024358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961209 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#730257}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/51813670627c..d203754bc116 git log 51813670627c..d203754bc116 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 johnkslang@users.noreply.github.com Merge pull request #2046 from Roy-AMD/Fix-multiple-AST-spv-generate-crash-issue Created with: gclient setdep -r src/third_party/glslang/src@d203754bc116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ibcb4f7765623a8f35fdd46b45849572b0d0bb420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730256}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: Id4a8efd8be201f231c9dc6ad275762e7bedbdfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992621 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730255}
-
John Budorick authored
Bug: 1039873 Change-Id: Ib0d4948cb203cd766d4fac86fb3a700ab40ad64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994168Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#730254}
-
Marijn Kruisselbrink authored
There doesn't really seem to be any reason to encode blob infos as early as the code was doing it, so this seems like a decent simplification. This will also enable doing asynchronous work needed to serialize native file system handles in a future CL. Bug: 955193 Change-Id: I27acabe29b67d7adb678c58b4c0ecca9cb46b80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993651 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#730253}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I52fc21dc6441c2384df84bf26640cc3ecbf2601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993438 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730252}
-
Aaron Krajeski authored
Bug: 1040544 Change-Id: I2364a12f741ce295a7bbcf644d818138ee9f7535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993445Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730251}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b0705913917..b42aeaa3fb21 git log 4b0705913917..b42aeaa3fb21 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 danilchap@webrtc.org Move RtpDepacketizerH264 into own files 2020-01-10 philipel@webrtc.org Use a TaskQueue for decoding in VideoStreamDecoderImpl. 2020-01-10 ilnik@webrtc.org SimulcastEncoderAdapter: In passthrough mode set correct lenght for frame_types parameter Created with: gclient setdep -r src/third_party/webrtc@b42aeaa3fb21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I275b980f64d047a960174e4f22c3d21d9da25f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730250}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the PartnerBrowserCustomizationsUnitTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: I61fe3e37bbf4986b93e1a47d9ee348f19e97372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991736 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#730249}
-
Eric Karl authored
Adds tracking to detect this issue earlier and CHECK with a more informative error message. Also fixes one known case of incorrect destruction order. Bug: 1040275 Change-Id: Id611b56a605b738bd1088940460a5a62182bfefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993671 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730248}
-
Zentaro Kavanagh authored
- This disables the feature by default - Updates tests based on changed feature state - Fixes a race condition checking the sensor status via powerd - Support for ambient EQ is now going to be gated on a cros config value because some devices have the sensor but can't support the feature - The cros config value will enable the feature only on explicitly supported devices - This is a partial revert of [1] which can't be cleanly reverted because the pref value on unsupported devices may have already been set [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1974815 BUG=1034068,1036038,1036546 TEST=NightLightTest.*,manual Change-Id: If51ec1b6a8ae787fb64b89f2f536eec0087b09af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992183Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#730247}
-
Elly Fong-Jones authored
It seems that either r728531 (disable shadows altogether on bots) or r726087 (disable frame-resize shadow invalidation hack on bots) have sufficiently mitigated the windowserver crash everywhere except 10.10. Since browser_tests are disabled altogether on 10.10 as of r726124, we can stop filtering browser_tests suites. Bug: 899286 Change-Id: I55b7a5e76ff095c6c3d1abeba17e6056a9fe510b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994421Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#730246}
-
Tommy Li authored
Currently, for elided HTTPS URLs, (omnibox displays 'google.com' instead of 'https://www.google.com'), when the user mouse clicks into the omnibox and presses Enter, we make a request to http://google.com. This is a regression introduced in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1854501 This CL is a partial revert of that CL. I think the reverted part wasn't necessary to fix the original bug in the first place, and was likely included by mistake. This CL does the partial revert and also enhances our existing unit test to make sure it won't happen again. Bug: 1037889 Change-Id: Ia5e742c02ac35f7b013ce42bc01c1217304ab303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990253 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730245}
-
Sadrul Habib Chowdhury authored
It is possible for a WebContents to be destroyed while it is being activated in response to a mouse-click. Handle such case gracefully. BUG=1040725 Change-Id: Ic73e631bf04e170bc8b1cd818da8d39f1963e006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994394 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#730244}
-
kylechar authored
SkBitmap allocations were using allocPixels() which will crash on OOM. In order to indicate the crash is due to OOM use tryAllocPixels() and then call base::TerminateBecauseOutOfMemory() on failure. This will improve crash reports. If SkBitmap allocation fails for a CopyOutputRequest we can handle the OOM gracefully, since the caller has to be able to handle failed requests regardless. Bug: 995411 Change-Id: Ifad190badca49c948e5ae612dd33df39ef5923f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993667Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#730243}
-