- 17 Sep, 2019 40 commits
-
-
Benedikt Meurer authored
This adds a bunch of missing values to the "DevToolsPanel" enum, as otherwise all these drawers get logged with the code 0 instead, which makes it impossible to distinguish. Bug: chromium:993562 Change-Id: Icdb11f6c35fe8f521e141c487c6a0b483fa4ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805663 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697206}
-
Javier Ernesto Flores Robles authored
Bug: 1004749 Change-Id: I3c6560e27d38e9880d7bdd2b09235db38ecc336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809164 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697205}
-
Friedrich Horschig authored
This CL reenables the ManualFillingControllerTest that was previously disabled because the SetUp failed when initializing the initial navigation for the RenderViewHostTestHarness. This cannot happen anymore since the Test doesn't use any navigations anymore but instead calls the controller interface directly. Therefore, it also isn't a subclass of RenderViewHostTestHarness anymore but uses TestProfile and TestWebContents directly. Bug: 1004585 Change-Id: I6c48c651447645453fc080a35efa90c7d7b60c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807224 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697204}
-
Mikel Astiz authored
This introduces basic functionality related to this passphrase type, which behaves similarly to KEYSTORE_PASSPHRASE but is designed to receive the encryption key by means other than the sync protocol. Bug: 1000146 Change-Id: I0a3f093ae47a8efcb79794572c6e7ac30b335d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806874Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697203}
-
Lowell Manners authored
The word 'flush' is a slightly ambiguous but 'destroy' describes exactly what this method does, so "DestroyEvictedFrames" is a clearer name. Change-Id: I22654a1c10e6c5a0c2a94c7d04a75c1cbf8e913b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803436Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697202}
-
Alex Clarke authored
This is helpful whern diagnosing test failures resulting from scheduler policy changes. Bug: 971191 Change-Id: I835db83e62895e45ef7400d231db8b6e30f14ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806464Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#697201}
-
Mathias Bynens authored
Previously, there was a property order mismatch between the DevTools Console Preview and the expanded view. For example: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {a: 1, b: 1, c: 1, __proto__: Object} This patch removes the confusing mismatch as follows: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {c: 1, b: 1, a: 1, __proto__: Object} The core change happens in ObjectPropertiesSection.js. The test expectations are updated accordingly (note that for each test, only the order in which properties/values are printed changes). The patch also includes a drive-by change across files unifying the way U+00A0 is escaped in string literals. Screenshot: https://goo.gle/devtools-property-order-mismatch BUG=989514 Change-Id: I102afcbd107100a52e0932401429a3fa8db99eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806457Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e25bd5bbc4f..56bc26904935 Created with: gclient setdep -r src-internal@56bc26904935 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id090e3578adb369b0d19d77a9e305f9decea1b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697199}
-
Ivan Sandrk authored
Bug: 891222 Change-Id: I6675c208550affd8f8bb1316d4935c02f0e07a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783439Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697198}
-
Dominik Röttsches authored
Implement the CSS fonts property font-optical-sizing [1]. Typographic optical sizing means that a font has slight variations in glyph contrast to better optimize for legibility at different font sizes: The glyph shapes vary between for example a headline font size and a body text font size. The CSS font-optical-sizing property with its default value of auto exists to automatically apply the current font size value to a variable font's 'opsz' axis. This means, if a variable font supports the 'opsz' axis and optical sizing, the right value is automatically applied without the need for an explicit font-variation-settings styling. Intend to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Y3lhEykjfV0 Chromestatus entry: https://www.chromestatus.com/feature/5685958032752640 [1] https://drafts.csswg.org/css-fonts-4/#font-optical-sizing-def Bug: 773697 Change-Id: Ifa4b6e042204a3fbf172b8cfe232821d8691283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795244 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cc17f852d575..99f23d6ff220 git log cc17f852d575..99f23d6ff220 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check table index. Created with: gclient setdep -r src/third_party/freetype/src@99f23d6ff220 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ibcb85facaaf5583378c111554fe542c746d4c339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#697196}
-
Vikas Soni authored
A recent change - https://chromium-review.googlesource.com/c/chromium/src/+/1783526 requires |context_state| to be passed to SharedImageRepresentationSkiaGL::Create(). This started causing nullptr deref crashes since it was passed as nullptr before in SharedImageVideo. Change-Id: Ia060262be9c0a28b7b62ef318cd83fe5d22880f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807603 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697195}
-
Dominic Battre authored
Autofill's form parsing can abort due to a number of reasons (wrong scheme, not enough fields, form target url matching some suspicious patterns, ...). This CL introduces logging for these aborts to chrome://autofill-internals to speed up the understanding why autofill is disabled for a certain form. Bug: 928595 Change-Id: I754b56bb6b30ab3b2809c8bf508b74f6bbd380c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804298 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/69dd79c4f0ca..6ca32387e704 git log 69dd79c4f0ca..6ca32387e704 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Revert "Add x86 ASAN to CI builds."" Created with: gclient setdep -r src/third_party/perfetto@6ca32387e704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie75794a2fe63e762ff0f266651f63a080ba1e46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808514Reviewed-by:
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I2806b40040f96fde571fb725dc1a3ed885a4629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808840Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697192}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c6284cd11f..4a822f4b3c64 git log c1c6284cd11f..4a822f4b3c64 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e4ccff8..dbd15694 (696956:697157) 2019-09-17 danilchap@webrtc.org In TaskQueueTest::PostDelayedAfterDesctruct increase timeout Created with: gclient setdep -r src/third_party/webrtc@4a822f4b3c64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1000531 Change-Id: I8734d8e8efbb8ef949237b8ac94c1bff0bfdff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809240Reviewed-by:
-
Denis Solonkov authored
We can't expect that the test array would be put in the same place in memory between test runs and since [l, r) is being rounded to the page size. Due to that we can't make any assumptions about the elements inside of the final range and can't calculate the resulting sum, since all elements inside of the range are zeroed. The tests were modified the following way: 1) All zeroes in the test array were replaced by one to be able to locate all zeroed elements in it. 2) GetSum method was replaced by GetZeroes method which is expected to return 4096. 3) The size of the array was set to 2*4096 - 1 to prevent unlikely case of array aligning perfectly on memory and having 2 pages cut out of it. Bug: 998082 Change-Id: Idde87569decd3a52ecd1a0c034ab638833d8e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795791 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697190}
-
Jan Wilken Dörrie authored
The checked iterators model the RandomAccessIterator concept, however they did not implement operator>, operator>= and operator[], which are part of the concept requirements [1]. This change adds implementations of these operators and adds appropriate tests. [1] https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator#Requirements Bug: 817982, 828324 Change-Id: I14d80a412a9071c5ba50c57114ffec794cde9f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807195Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#697189}
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1vuvx8gWWX-f2Tb01QmorWg3EGJpP9VU6/view?usp=sharing Screenshot after: https://drive.google.com/file/d/12i0Dw3h82IjPTU4VP-LmCsHobZE38pU4/view?usp=sharing Bug: 995720 Change-Id: I86ddfd04ad59e16abc546fa97fcebbdd715616bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807314Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697188}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41079d70e469..65a5036eb041 git log 41079d70e469..65a5036eb041 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 1e146e8a3485..99793fa67d78 (2 commits) Created with: gclient setdep -r src/third_party/angle@65a5036eb041 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I6c0ecf18ef577f28e32c47009c53beec06137e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809237Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df432d5efb70..d545bfbb94ca git log df432d5efb70..d545bfbb94ca --date=short --no-merges --format='%ad %ae %s' 2019-09-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@d545bfbb94ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I9dec96d1d33ad47325b049d342d106fc1e81f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809239Reviewed-by:
-
Robbie Gibson authored
The root cause looks like the BVC view will show up momentarily when closing the last tab. I assume that all the actual tab views are removed, which lets the BVC shine through. Bug: 1003485 Change-Id: I4760cd2031abdcb5d04572efd5c1fbb637dae6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807221Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697185}
-
Nikita Podguzov authored
This is required to clean several expired print jobs at once. Bug: 992889 Change-Id: Iecfedcd1282fe610c6bcc60c7f42746916dc9497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804486 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#697184}
-
Robbie Gibson authored
Here, the root case is that the accessibleElements array keeps growing and eventually has many many copies of self.trailingButton (once on each page load). This causes voice control to think there are many buttons named share, so it asks which one to choose. This also seems to fix a bug where you can't swipe past the share button when using voiceover. I assume it's a similar issue coming from -indexOfAccessibilityElement:. Bug: 1004331 Change-Id: Iaed748b8488451704d8d338c50b5d12cfce61986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807114Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697183}
-
Tanmoy Mollik authored
To enable the feature flag that will make android manual start it is necessary to change the tests that assume android is auto start. This signIn method is used by some sync autofill and bookmark tests that needs to manually set setFirstSetUpComplete to start the sync process. Bug: 1004264 Change-Id: Ie33ae3b69478794b32530dd5596af66d813ee84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798323 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Christoph Schwering authored
Blacklist some social titles from being autofilled for company name: - English: Mr, Mr., Mrs, Mrs., Ms, Ms., Miss, Mistress, Mister, Miss; - German: Frau, Herr, - Mme, Mlle, Mlles, M. - Academic: Prof, Prof., Dr, Dr. Bug: 999952 Change-Id: I9cfe9f00263148b7821d8b7069651a7835fb6e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807316Reviewed-by:
-
Paul Lewis authored
We currently use the mime-type determine into which mode to put CodeMirror. For the most part this is fine, save for JSX/TSX projects where the files are saved with .js/.ts files suffixes. Typically this causes the non-x mime-type to be chosen, which in turn puts CodeMirror into the wrong mode. Since JSX/TSX are supersets of the non-x versions this CL simply pushes the mode over to the respective superset. Bug: 659515 Change-Id: I186d976a6a1ac991a296f92a22c8a0b3e83743c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800748 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
-
Nikita Podguzov authored
This will be used in follow-up CLs. This involves splitting PrintJobHistoryService into interface and implementation. Bug: 992889 Change-Id: I52909c73a52d834cb9147d1e09e2cf9af83ba3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798662Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#697179}
-
Nikita Podguzov authored
This will allow to resolve possible race conditions when the client tries to access database before it's fully initialized. Bug: 992889 Change-Id: Ie890e1c83add83f7be0892ad8a4a990730a38a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798603Reviewed-by:
-
Alexander Timin authored
At the moment cr tool sets is_component_build=true by default, overriding the existing value of the flag, which is not particularly helpful when trying to use is_official_build=true. This patch disables this functionality and removes all smartness associated with trying to guess the correct is_component_build, leaving the user free to choose whatever they please. R=skyostil@chromium.org Change-Id: I8953e0e3e8fea676b044d04460b418f310b9656c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807829Reviewed-by:
-
Wanming Lin authored
Following tests are still flaky on Mac10.13 builders: - external/wpt/gyroscope/Gyroscope.https.html - external/wpt/accelerometer/Accelerometer.https.html - external/wpt/orientation-sensor/AbsoluteOrientationSensor.https.html - external/wpt/orientation-sensor/RelativeOrientationSensor.https.html And remove external/wpt/accelerometer/LinearAccelerationSensor-shake-threshold-manual.https-expected.txt which is unnecessary as it has already been in web_tests/NeverFixTests file. Bug: 731018 Change-Id: I7cdd26682981e07695d9928536be3cbc0fca7890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808390Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#697176}
-
Javier Ernesto Flores Robles authored
It looks like changes in the interface style are delayed until the app comes back to the foreground. Because of this, it feels that "Currently Used" is more appropriate. Bug: 1001192 Change-Id: Ie437609564cd38f4a79b6684a418b963003803c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800991Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Yannic Bonenberger authored
Change-Id: I2c4154d1fc58185155fcfcba758dbd33a2fe8b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803918 Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697174}
-
Dominic Battre authored
This CL resolves an older TODO. With the LogBuffer now living in common/ instead of browser/, it is possible to do the serialization of these two enums in common/ as well. TBR=ftirelo@chromium.org Bug: 928595 Change-Id: Ie9a0f8352b38202b1b87a269256ecf4e6e4421ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803925 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d1647412c08..c1c6284cd11f git log 3d1647412c08..c1c6284cd11f --date=short --no-merges --format='%ad %ae %s' 2019-09-17 nisse@webrtc.org New (empty) build target api:media_stream_interface 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cf04dec..2e4ccff8 (696812:696956) 2019-09-16 dinosaurav@chromium.org Refactor Rtp Receivers to accept SSRC 0. Created with: gclient setdep -r src/third_party/webrtc@c1c6284cd11f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I62e738167c00c9f355ee282fc485982662302d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808785Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd3c3cc8eea4..69dd79c4f0ca git log cd3c3cc8eea4..69dd79c4f0ca --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Add x86 ASAN to CI builds." 2019-09-17 hjd@google.com Merge "Guess resolution based on trace size" 2019-09-17 hjd@google.com Merge "Fix process summary on very long traces" 2019-09-17 hjd@google.com Merge "Dedupe ToHex" Created with: gclient setdep -r src/third_party/perfetto@69dd79c4f0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia05419642fb14b3f018ffa2ce5b658d8fcea60cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808236Reviewed-by:
-
chrome://flagAlexander Timin authored
Make it easier (or possible) to test bfcache on Android devices by exposing a flag via chrome://flags page. R=nasko@chromium.org CC=arthursonzogni@chromium.org,clamy@chromium.org,lowell@chromium.org,clamy@chromium.org Change-Id: If233505268bec27d2aa616ab1d5679e2a1ac3e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807317Reviewed-by:
-
Camille Lamy authored
This CL simplifies the management of the HistoryItem of the DocumentLoader. It no longer has to clear it when taking into account a redirect, as the browser process will ensure no HistoryItem is provided in this case. The previous HistoryItem is also passed directly by the FrameLoader before committing the provisional DocumentLoader, instead of the DocumentLoader asking the FrameLoader about it at commit time. This is a preparatory CL to move the creation of the provisional DocumentLoader after the Unload event, part of a chain of CLs to remove the provisional DocumentLoader. Bug: 855189 Change-Id: I8c7ca86e5f5931dbfd91e688aaff391867b9595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796356 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This demonstrates the use of accessibilityUserInputLabels. Before, the default Voice Control name for one of the settings rows was both the setting name and the value (e.g. "Search Engine Google"). This is because the default name comes from the text in the cell. Now, the name is manually set to just the type of setting (e.g. "Search Engine"), which is a better experience. Bug: 1004319 Change-Id: Ie79a5bba46f8c6b688f1a31be20ef802875a2a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806462 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697168}
-
Alex Chau authored
- Committing proto change ahead of main CL, so we can export proto change to Sync server earlier Bug: 991971 Change-Id: I11807960d5f7486cc1c16def63da4956834ac326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806861 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697167}
-
