GitLab

This is to prepare the field for removing feature
kAutofillExpandedPopupViews.

Bug: 831603
Change-Id: I7db276de2da430634e146ad7641669e139fc6fa1
Reviewed-on: https://chromium-review.googlesource.com/1210387Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589308}

- Assistant flow will show after PlayStore flow and before User Image
  select screen.
- Verified on both desktop and device build oobe flow went through well.

Bug: b/114055787
Test: Manual Test
Change-Id: I84092a3a17be3b89bde37476b4bdda43aa2bcbd0
Reviewed-on: https://chromium-review.googlesource.com/1207578Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589307}

Frame owners may have pointer-events: none property which blocks them
from receiving mouse and touch events. Currently in V2 viz hit testing
hit test data provider has no information about whether OOPIFs have
pointer-events: none property.

This CL plumbs pointer-events: none property from HTMLFrameOwnerElement
to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl
will be able to generate proper hit test data for pointer-events: none
OOPIFs.

Bug: 841358

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182
Reviewed-on: https://chromium-review.googlesource.com/1127440
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589306}

This is to prepare the field for removing feature
kAutofillExpandedPopupViews.

Bug: 831603
Change-Id: I3f0d8ee5359be4c89b5284aef6bbdca0edf86da1
Reviewed-on: https://chromium-review.googlesource.com/1210545
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589305}

Bug: 875284
Change-Id: Id802fe60adaa4f49af2105fffedca7a024c0c82d
Reviewed-on: https://chromium-review.googlesource.com/1211107
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589304}

This CL shows a policy indicator and a disabled toggle when the suite
or a specific feature (on the subpage) is prohibited by policy.

Note that some unrealistic cases are not handled. This includes:

1) suite is prohibited but the mode (a.k.a. host status) is something
other than "no eligible hosts"
2) the user is in the subpage but the suite is prohibited by policy.

Screenshots:

Suite prohibited by policy (main Settings UI page):
http://screen/EbYef2RFFrf

Individual feature prohibited by policy (subpage):
http://screen/D3iqHQCW4B3


Bug: 870127
Change-Id: Iebeed37255e4a3dffb4f1b6376acfe5a9c26cc2d
Reviewed-on: https://chromium-review.googlesource.com/1208900Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589303}

Builds the Surface tree considering Surfaces that correspond to
RootFrameSinks and detached Surfaces as root Surfaces. All of these are
attached to RootElement.

Bug:816802

TBR=sadrul@chromium.org

Change-Id: I74d11ddb0fed9dc31712dc6e98cf20e936856400
Reviewed-on: https://chromium-review.googlesource.com/1185964
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589302}

When Chrome tries to figure out which text field of a password form
is the username, it picks one and stores the rest in
PasswordForm::other_possible_usernames.

This field has so far only been populated by the old form parser
(password_form_conversion_utils.cc). This CL also teaches the new
parser to populate that field.

However, there is a slight change: the new parser will include also
the username which Chrome picked, for simplicity of the processing of
the information later. The change in meaning is not breaking, because
the output of the old and the new parser is consumed by different
versions of PasswordFormManager. https://crbug.com/881346 tracks
renaming of the other_possible_usernames field once there is only one
meaning to it.

Bug: 880721
Change-Id: I114472dc8d1b37a8f77bdb79689008e7795d81a4
Reviewed-on: https://chromium-review.googlesource.com/1210503
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589301}

Bug: 876432

Change-Id: Id2b3539f1072289f7110db126793ad69f66240e9
Reviewed-on: https://chromium-review.googlesource.com/1192588
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589300}

The max and min valures for the OscillatorNode.detune parameter has been
reduced according the latest version of the spec.  Make it so.

Also implement clamping of the total frequency to Nyquist so that we don't
generate infinity or NaN doing the computations.  This is ok because anything
beyond Nyquist would output 0 anyway.  But we're careful to preserve the slope
of automations; test added for this as well.

Update expectations for AudioParam/audioparam-nominal-range.html because of
the new warnings produced by clamping detune.

Bug: 865552, 860347
Test: the-oscillatornode-interface/detune-limiting.html
Change-Id: I35a214b0f3156ad8912718dcb277f1967f70df8f
Reviewed-on: https://chromium-review.googlesource.com/1138638
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589299}

Adds an exception to contents/description experiment for
DOCUMENT_SUGGESTION result types.

Bug: 876429
Change-Id: I66aa037b36460c7c08b310474c60b02500bd1c8f
Reviewed-on: https://chromium-review.googlesource.com/1192328
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589298}

Settings WebUI: prevent settings-subpage from removing itself as a FindShortcutListener if it was not already added as one.

Ensure |active_| has changed value and change onActiveChanged_
observer to a compound observer that also depends on |searchLabel|
to ensure |searchLabel| has been initialized.

Bug: 881104
Change-Id: Icf4e740c766d1069aba9da13b25879c95a1959eb
Reviewed-on: https://chromium-review.googlesource.com/1208822Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589297}

Bug: 871908, 871912, 875059
Change-Id: I2a071d9a2d9b6cdf449d69e42e5bec8fe68f7884
Reviewed-on: https://chromium-review.googlesource.com/1204601Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589296}

The new name is ShouldSwitch, to avoid confusion with http's redirect.

Bug: 880470
Change-Id: Ia25c476a75fb90b1e919df7c114d923da3d688d9
Reviewed-on: https://chromium-review.googlesource.com/1205480Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589295}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f5a0b440989..b56a43a9064c


git log 0f5a0b440989..b56a43a9064c --date=short --no-merges --format='%ad %ae %s'
2018-09-06 bratell@opera.com Read the git config only once when doing a git cl issue -r lookup
2018-09-06 cwallez@chromium.org Add Dawn got_revision_mapping to glient config


Created with:
  gclient setdep -r src/third_party/depot_tools@b56a43a9064c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:880734,chromium:875245
TBR=agable@chromium.org

Change-Id: I018ecfb1f6b0268afd18797281d67e5659877684
Reviewed-on: https://chromium-review.googlesource.com/1210446Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589294}

This CL stops logging into, and deprecates:
PasswordManager.EmptyUsernames.TextAndPasswordFieldCount and
PasswordManager.EmptyUsernames.PasswordFieldCount.

Those metrics were used for an investigation, which has concluded back
in 2016.

Bug: 852772
Change-Id: Ib15807b8384d9053d8df7e09465bbef16f9145fa
Reviewed-on: https://chromium-review.googlesource.com/1209503Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589293}

This reverts commit 28e953d7.

Reason for revert: 
This CL introduces 2 bugs:
1. The new |featuresToBeEnabledOnceAuthenticated_| queue has features pushed to it regardless of whether the user wants to enable or disable the feature. This means the features intended to be disabled are actually enabled when the dialog is closed.
2. The required corresponding backend change required in multidevice_setup_impl.cc is not implemented, meaning the frontend does not prompt the user for a password in situations where the backend expects it. This creates a jarring breakage for the user.

The issue that this is attempting to address should be fixed in M70; instead of merging this broken CL into 70 and then merging a followup, it will be cleaner to revert this CL and then merge a single correct CL into 70.

Original change's description:
> [CrOS MultiDevice] Update password requirements for Connected Devices.
> 
> It should be required that users enter their password to enable
> SmartLock, since it is a security-sensitive feature. As a corollary, it
> should also be required that users enter their password to enable the
> Better Together suite if doing so would implicitly cause SmartLock to
> become enabled.
> 
> Previously, entering a password was required for enabling the Better
> Together suite under any circumstances, but this was unnecessary, since
> no password should be required if SmartLock were turned off.
> 
> This CL fixes this issue; additionally, it updates the authentication
> code here, which was previously not as robust.
> 
> Bug: 876436, 824568
> Change-Id: Ia61dd112675485972361a51b406482a0bb0a1f05
> Reviewed-on: https://chromium-review.googlesource.com/1200148
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588158}

TBR=khorimoto@chromium.org,tommycli@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 876436, 824568
Change-Id: Iec397181ac06c31fd911569c9bb4c22eec4a787a
Reviewed-on: https://chromium-review.googlesource.com/1208954Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589292}

See https://crbug.com/879348 for a description of the issue. This CL
adds a DownloadPrefs::ReinitializeDefaultDownloadDirectoryForTesting()
method to force the global DefaultDownloadDirectory instance to
reinitialize itself to take into account any test configurations.

Bug: 879348
Change-Id: I4a2340fad5f1396196e6746073857d3a09bfa7c1
Reviewed-on: https://chromium-review.googlesource.com/1197724Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589291}

The consent bump eligibility is recorded at every startup when
Unified Consent is enabled.

Bug: 880742
Change-Id: I748c4fff04b58173980ca6c3451dda892c1848a4
Reviewed-on: https://chromium-review.googlesource.com/1207332
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589290}

This patch adds a use counter for PaymentAddress.languageCode to
validate that it's rarely used and can be be removed. Latest discussions
in W3C have placed it at risk in the spec:
https://github.com/w3c/payment-request/pull/764

Firefox and Safari have removed languageCode from their implementations.

Bug: 877521
Change-Id: I9e137d768be87c6dbc8affd3db3c2d6260ada46b
Reviewed-on: https://chromium-review.googlesource.com/1188489
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589289}

This patch adds an API util method that simply does not run the
setAccessibilityTraversalBefore method on devices that are running
Android versions < L.

Bug: 881400
Change-Id: Ie29a7f8f96e87661d0543fe99ca9e5f1a18f468f
Reviewed-on: https://chromium-review.googlesource.com/1211103Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589288}

https://pdfium.googlesource.com/pdfium.git/+log/ad370480282d..59d21660a3d9


git log ad370480282d..59d21660a3d9 --date=short --no-merges --format='%ad %ae %s'
2018-09-06 hnakashima@chromium.org Fix integer overflow in LoadCryptInfo.


Created with:
  gclient setdep -r src/third_party/pdfium@59d21660a3d9

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:847283
TBR=dsinclair@chromium.org

Change-Id: I29b63f62d289f5c1647d782933bec6ee1b8186ef
Reviewed-on: https://chromium-review.googlesource.com/1211043Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589287}

Bug: 879020
Change-Id: I8112074b24ed28fa7fd39ea1cbd0f8fc0b24b043
Reviewed-on: https://chromium-review.googlesource.com/1208933Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589286}

This Cl fixes two problems of ChromePasswordProtectionService::
IsPingingEnabled().

1. We should specifically check if user signed in for sync password
reuse case before sending out the ping.
2. For saved password reuse pings, we don't need to check for
sync status.

Bug: 876788
Change-Id: Iec7ffdc1d1b1af5ae73c9c4b6e8a78930c75aad6
Reviewed-on: https://chromium-review.googlesource.com/1194827
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589285}

This CL implements the renderer side of MimeHandlerView based on
cross-process frames (behind a flag).

The new subclass of MimeHandlerViewContainerBase will use a content
frame inside a plugin element for loading the MimeHandlerViewGuest's
extension.

The current implementation is not complete and the missing features
such as postMessage support will be added in the follow-up CLs.

This CL also introduces a new class of parametric browser tests
(MimeHandlerViewCrossProcessTest) which will be the destination of
the current MimeHandlerViewTests as more features are integrated into
the frame-based version. The new test class runs the test on both
BrowserPlugin-based and cross-process-frame-based versions.

Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w

Bug: 659750
TBR=thestig@chromium.org

Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165
Reviewed-on: https://chromium-review.googlesource.com/1187231
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589284}

The Fuchsia component manifest now allows us to specify arbitrary
binaries in a package as an entry point. Before, the entry point
executable had to reside at the special path /pkg/bin/app.

Keeping the executable name intact will facilitate stack trace
symbolization on multiple packages.

Bug: 798851

Change-Id: Ib116602e2e0e430478d24829112df63c27f3d025
Reviewed-on: https://chromium-review.googlesource.com/1208716
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589283}

Bug: 860311
Change-Id: Id41234cfd6337fd2dcdd319fc514f9ae7663c6a4
Reviewed-on: https://chromium-review.googlesource.com/1211724Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589282}

Animations updates with BlinkGenPropertyTrees require paint in order to have animations
updated. This modifies the animate_only property to not skip paint but
only skip commit.

BlinkGenPropertyTrees changes the blink lifecycle such that painting produces the
property trees which are then directly passed to the compositor. As a result, the
animations update can only happen after we know the painted artifacts which means
that animation updates are now dependent on running paint.

Bug: 872773
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0d2424b3b658a0908a08adfce20940610cdd9b09
Reviewed-on: https://chromium-review.googlesource.com/1199603Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589281}

Patchset 1 is the original CL. https://crrev.com/c/1205806

The only change on this CL is to disable dynamic height
on non-UI Refresh since the legacy cells don't support it.


======= Original Description =======

This CL changes BookmarksTableVC so it uses dynamic row height.

It also updates some EG tests that started to fail once this change
was made. I suspect this has to do with internal TableView management
of cells when using dynamic height.

The BottomCell test cell was moved to the penultimate position since
we now snap at the top of the top cells instead
of using the offset value of the TableView. This meant that the top
cell was completely visible when re-creating the cache and the
"Bottom Cell" was partially hidden.

Bug: 869671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic1844c60f88357acabc008acbb6be6b38f9e99b1
Reviewed-on: https://chromium-review.googlesource.com/1210548
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589280}

Some of the ids comming from payments needed to be converted before
they could be displayed.

This should only affect the sync internals page, no feature code.

Bug: 879556
Change-Id: I423580564574ea5f883044d4a4e08bf0e8c9b1e7
Reviewed-on: https://chromium-review.googlesource.com/1205192
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589279}

This reverts commit 5f80b9a8.

Reason for revert: Revert was wrong; it was OK the first time.

Original change's description:
> Revert "Add `CheckedRandomAccess[Const]Iterator`."
> 
> This reverts commit 383049f2.
> 
> Reason for revert: Landed wrong patchset!
> 
> Original change's description:
> > Add `CheckedRandomAccess[Const]Iterator`.
> > 
> > And add a first call site.
> > 
> > Bug: 817982
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo
> > Change-Id: I2db298494e4f562ffac1f68b87c7a617e592f196
> > Reviewed-on: https://chromium-review.googlesource.com/963726
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Matt Menke <mmenke@chromium.org>
> > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#589244}
> 
> TBR=ajwong@chromium.org,palmer@chromium.org,dcheng@chromium.org,jyasskin@chromium.org,mmenke@chromium.org,tsepez@chromium.org,nharper@chromium.org
> 
> Change-Id: Icf99f8409054d853a15b8d27cdb232ff727f8a42
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 817982
> Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1211743
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589245}

TBR=ajwong@chromium.org,palmer@chromium.org,dcheng@chromium.org,jyasskin@chromium.org,mmenke@chromium.org,tsepez@chromium.org,nharper@chromium.org

Change-Id: Ieba0af822a2287583cf37a109538f6ceeb8e4f98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817982
Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1211902Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589278}

Change-Id: I617662f80f0bcdc723607337d8a2e153f537469b
Bug: 879692
TBR: jbroman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1200149
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589277}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1b63139d..41db1841

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1d84c6755b8854b08b4ed33e325aadc3f98f7382
Reviewed-on: https://chromium-review.googlesource.com/1209544Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589276}

See core/layout/README.md for the definitions of scroll position and
scroll offset.

Previously ScrollTranslation used -LayoutBox::ScrolledContentOffset()
which corresponds scroll offset. This caused trouble in
PropertyTreeManager for blink-gen-property-trees which expects
ScrollTranslation to translate by scroll position (the scroll offset
seen by cc which knows nothing about scroll origin).

Now let ScrollTranslation translate by scroll position (scroll offset
+ scroll origin), so it translates the container's content box space
to the scrolling contents space, and both spaces are originated from
the top-left corner. At places where the code expect the coordinate
space relative to scroll origin, we need to add scroll origin to the
offset to convert to the new space of ScrollTranslation.

Bug: 853945
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9c7d5925a25d42365c8a6fe6951383af8eab127e
Reviewed-on: https://chromium-review.googlesource.com/1181644
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589275}

https://chromium.googlesource.com/angle/angle.git/+log/7359954301e1..4d42ef39658b


git log 7359954301e1..4d42ef39658b --date=short --no-merges --format='%ad %ae %s'
2018-09-06 ianelliott@google.com Add A4A opt-in/out logic
2018-09-06 jmadill@chromium.org Fix JSON cpp DEPS.
2018-09-06 oetuaho@nvidia.com Support multisample arrays in shader programs
2018-09-05 jiajia.qin@intel.com Fix that same resource is bound on SRV and UAV simultaneously


Created with:
  gclient setdep -r src/third_party/angle@4d42ef39658b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I2d3494e590e5597ca0792ce6f9a894fca8c67688
Reviewed-on: https://chromium-review.googlesource.com/1211046Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589274}

Using wpt-import in Chromium a63f1d10.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24195

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
meade@chromium.org:
  external/wpt/web-animations

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: If5164fcab6535f2897adeeb84ee4767ff7c037f5
Reviewed-on: https://chromium-review.googlesource.com/1211025
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589273}

This reverts commit 04bab180.

Reason for revert: Failing DCHECKs by blocking on non-blocking task.
BUG:878750

Original change's description:
> [v8] Re-post non-blocking ScriptStreamer tasks (reland)
> 
> Posted blocking ScriptStreamer tasks can end up in a queue, and have
> their Resource complete loading before the task even starts. When this
> happens, these tasks will no longer block on network input, but they
> will still be posted to the blocking task runner, which does not spin up
> new threads if the running task is not blocked. When there are a lot of
> small functions posted for streaming, this results in a slightly
> paradoxical starvation, where the blocking task runner is processing
> lots of no-longer-blocking tasks all in one thread, as it has no reason
> to spin up new threads.
> 
> To avoid this, if a streaming task isn't started before the resource
> finishes loading, we can cancel this posted task, and instead post a new
> non-blocking task to the non-blocking thread pool. This frees up the
> blocking task runner to process only blocking tasks (and thus allows it
> to spin up new threads for them).
> 
> TBR=kouhei@chromium.org
> 
> Bug: chromium:865098
> Bug: chromium:866868
> Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb
> Reviewed-on: https://chromium-review.googlesource.com/1179744
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584032}

TBR=rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,leszeks@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:865098, chromium:866868
Change-Id: I8c26832b131cf8997c304422eb0324bb0770b947
Reviewed-on: https://chromium-review.googlesource.com/1211582Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589272}

When getting text from PDFium, the library does not filter ZWW
(0x200B), since it is a valid non-control character. It is ignorable
though, so the embedder aka Chrome, has the option of whether or not
to display this character. Given that it shouldn't have any visual
display, including it in the displayed text can lead to weird UI
situations. Like the length of text being longer then number of
characters displayed or navigating the cursor requires multiple key
presses to get over the ZWW.

BUG=chromium:743522

Change-Id: I5312a3aad4a752659fb4455853cd1030f0660bd9
Reviewed-on: https://chromium-review.googlesource.com/1210966Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589271}

Screenshot before:
https://drive.google.com/file/d/1iYtj0IQfLB6KLZmguxpStD_LgYIFCwF9/view?usp=sharing
Screenshot after:
https://drive.google.com/file/d/1fJUyPl6Vs0eiOx9eNJubf-OxEfi0nk3M/view?usp=sharing

Bug: 872647
Change-Id: I681f16b95f56840e16fc49004828c2014a205ef4
Reviewed-on: https://chromium-review.googlesource.com/1210642Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589270}

This ensures that JankTracker cannot be trivially circumvented by
forcing layer promotion of janking content.

Also add a REF check that was missing from crrev.com/587033.

Bug: 581518
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3da0c1986f3b1b033af5f8126459966d1884ef2f
Reviewed-on: https://chromium-review.googlesource.com/1208453
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589269}