GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14889 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100177


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14888 0039d316-1c4b-4281-b951-d872f2087c98

Second attempt at cleaning up handling of --disable-popup-blocking.  I didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab.  This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab.

I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected).
Review URL: http://codereview.chromium.org/99203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14886 0039d316-1c4b-4281-b951-d872f2087c98

* clean up toolbar/infobar/findbar borders
* move findbar to BrowserWindowGtk's vbox (so it stacks on top of infobar, as on windows)
* properly show findbar when switching between tabs
Review URL: http://codereview.chromium.org/99166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14885 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99204


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14884 0039d316-1c4b-4281-b951-d872f2087c98

Move linux version of X509Certificate::IsEV in x509certificate_nss.cc


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14883 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14882 0039d316-1c4b-4281-b951-d872f2087c98

Disable view-source if the page source is not viewable as text.
For example, a page of content type application/x-shockwave-flash
is not viewable.

http://crbug.com/9562

Review URL: http://codereview.chromium.org/66061


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14880 0039d316-1c4b-4281-b951-d872f2087c98

Implement dropping of tabs into an existing tab strip from another window. Implement dragging and dropping of tabs within a window.
Review URL: http://codereview.chromium.org/102010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14879 0039d316-1c4b-4281-b951-d872f2087c98

Allow words to be wrapped in message box.

We use DT_WORDBREK|DT_EDITCONTROL as the argument of DrawText().
With this option, DrawText() try to wrap texts at word-breaks first,
then wraps at non-word-breaks if one line is still too long.

This change only affects for Labels in MessageBox.
If we can always use this policy, please let me know
and I'll fix the code.

http://crbug.com/2441

Review URL: http://codereview.chromium.org/100013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14878 0039d316-1c4b-4281-b951-d872f2087c98

more extensions bookmarks changes:* add schema verification* add unit tests for schema* add a few new methods (getTree, getChildren)* add events
Review URL: http://codereview.chromium.org/102009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14877 0039d316-1c4b-4281-b951-d872f2087c98

Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped files to avoid crashes when Cocoa feeds us files specified on the command line.

Review URL: http://codereview.chromium.org/100142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14876 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14875 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14874 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a couple of bugs in painting and updating:
- properly size the canvas we draw the child views into so the bottom pixel doesn't bleed
- properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes.

Back to using system colors. Adds highlight icons.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826
Review URL: http://codereview.chromium.org/99102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14873 0039d316-1c4b-4281-b951-d872f2087c98

Part 1 of sample sprucing. Also, change chromium_extension.py to generate a random ID if the manifest doesn't have one.

* Create a test/data/extensions/samples directory and add
  Reader and Gmail samples to it.

* Minor fixes to buildbot sample to fit better visually.

* Minor fixes to bookmarks sample to use new button styles.

* Workaround for bug in bookmark sample where extension APIs do
  not load the first time.

* Move Resizer extension into samples/.

* Fix TabsAPI sample to not use old deprecated manifest
  properties anymore.

Part 2 will move the remaining samples into samples/ (don't want
to do that at the same time because git-cl doesn't know how to
tell Rietveld about moves and it would be confusing to review).

Review URL: http://codereview.chromium.org/99172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14872 0039d316-1c4b-4281-b951-d872f2087c98

activeDocumentLoader's url, not the document's current URL.

BUG=10924
Review URL: http://codereview.chromium.org/92090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14871 0039d316-1c4b-4281-b951-d872f2087c98

with one tab, drag the tab, and while dragging click and release the
right mouse button we get all confused. This is because we get two
OnMousePressed events in a row, which results in cancelling out the
current drag which doesn't work well when only one tab with one window
is left.

BUG=10800
TEST=see bug

Review URL: http://codereview.chromium.org/100169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11146
Review URL: http://codereview.chromium.org/99194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14869 0039d316-1c4b-4281-b951-d872f2087c98

. Removes MoveToFront on Widget.
. CHanges AsWindow to GetWindow.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/99133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14868 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6890

Review URL: http://codereview.chromium.org/92116


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14862 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14861 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/bookmarks/bookmark_codec_unittest.cc
chrome/common/accessibility_types.h
Review URL: http://codereview.chromium.org/100108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14859 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10353,10400

Review URL: http://codereview.chromium.org/99158


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14856 0039d316-1c4b-4281-b951-d872f2087c98

24 (12 direct, 12 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 258 
   at malloc (vg_replace_malloc.c:178)
   ...
   by gtk_container_foreach (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by gtk_container_get_children (in /usr/lib/libgtk-x11-2.0.so.0.1200.9)
   by (anonymous namespace)::OnDialogResponse(_GtkDialog*, int, AppModalDialog*) (app_modal_dialog_gtk.cc:24)

Review URL: http://codereview.chromium.org/102007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14855 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision."

This reverts commit r14851.

As it DID NOT PASS THE TRY BOTS.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14853 0039d316-1c4b-4281-b951-d872f2087c98

- It does not look that is a very good idea what it was doing to boot

TEST=no test required


Review URL: http://codereview.chromium.org/100080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14852 0039d316-1c4b-4281-b951-d872f2087c98

Instead of passing down a switch to the renderer, storing a member, etc., just implement --disable-popup-blocking in the browser at the point where we make the final policy decision.
Review URL: http://codereview.chromium.org/100132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14851 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14850 0039d316-1c4b-4281-b951-d872f2087c98

ISO-8859-1 which confuses editors.
Review URL: http://codereview.chromium.org/99191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14849 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99190


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14848 0039d316-1c4b-4281-b951-d872f2087c98

This is what tcmalloc uses to hook out-of-memory cases.

Review URL: http://codereview.chromium.org/99090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14847 0039d316-1c4b-4281-b951-d872f2087c98

This is a changelist for http://codereview.chromium.org/75031 by Kent Tamura (tkent@google.com)


Review URL: http://codereview.chromium.org/100111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14846 0039d316-1c4b-4281-b951-d872f2087c98

The style (or at least the GCs) are shared across widgets, so they shouldn't
be modified, or should be restored.  Creating a GC should be cheap enough, I
was overthinking this.

Review URL: http://codereview.chromium.org/100161


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14845 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: keep links on the edited styles so that they are not collected between debugging sessions.

Review URL: http://codereview.chromium.org/100159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14844 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Open multiple windows, make sure the entries in the Window menu
match the titles of the currently selected tabs.

Review URL: http://codereview.chromium.org/100121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14841 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/102008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14840 0039d316-1c4b-4281-b951-d872f2087c98