GitLab

Introduced by r290692.

BUG=406968

Review URL: https://codereview.chromium.org/470803008

Cr-Commit-Position: refs/heads/master@{#291725}

Includes the following CLs:

Attempt to let nss's SSSE3 files build with clang-cl.
Review URL: https://codereview.chromium.org/493883002/

BUG=82385
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/503063003

Cr-Commit-Position: refs/heads/master@{#291724}

BUG=

Review URL: https://codereview.chromium.org/491443005

Cr-Commit-Position: refs/heads/master@{#291723}

R=pdr
NOTRY=true

Review URL: https://codereview.chromium.org/463333003

Cr-Commit-Position: refs/heads/master@{#291722}

TBR=piman@chromium.org
BUG=169282

Review URL: https://codereview.chromium.org/501913002

Cr-Commit-Position: refs/heads/master@{#291721}

1. The popup needs to hide when the renderer resizes (akin to hiding on scroll or orientation change).
2. There was a race condition where the renderer could say Show() then Hide(), but the Hide() would fall on deaf ears because the popup was still waiting for webdata.

The linked bug occurred when the render view was auto-resized /after/ an orientation change. After the orientation change we'd get a text field changed event which would trigger the popup to reshow. The fix is to make the renderer resizing close the popup, but (2) and (3) above were necessary for this to actually work.

BUG=401752

Review URL: https://codereview.chromium.org/482643004

Cr-Commit-Position: refs/heads/master@{#291720}

In Hangout Remote Desktop, we need to show message windows from the background page for authentication.

This CL introduces the MessageWindow class, which supports showing of both confirm dialogs and message boxes.

BUG=405628

Review URL: https://codereview.chromium.org/493813002

Cr-Commit-Position: refs/heads/master@{#291719}

Part of the refactoring effort to consolidate all fileapi/quota/webkit_database/webkit_blob-related code into a single namespace, directory, and component. Discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4

This is itself part of a larger refactoring effort to get rid of the webkit/ directory, as recorded in the following bug:

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/498273002

Cr-Commit-Position: refs/heads/master@{#291718}

BUG=304341
TEST=RenderFrameHostManagerTest.Disown*

Review URL: https://codereview.chromium.org/505443002

Cr-Commit-Position: refs/heads/master@{#291717}

Password Manager shouldn't push empty pair username/password. We should track how it happens and how often.

BUG=404012

Review URL: https://codereview.chromium.org/493123002

Cr-Commit-Position: refs/heads/master@{#291716}

BUG=392478
NOTRY=true

Review URL: https://codereview.chromium.org/469343003

Cr-Commit-Position: refs/heads/master@{#291715}

* It was possible to click behind the dialog screen by scrolling it out of the way.
* When connecting to a host, scroll-bars appeared, regardless of the window size.

Review URL: https://codereview.chromium.org/478033004

Cr-Commit-Position: refs/heads/master@{#291714}

BUG=406053

Review URL: https://codereview.chromium.org/490333002

Cr-Commit-Position: refs/heads/master@{#291713}

When PictureLayerImpl chooses a scale to raster at, we should accept
tiles at that scale as complete, and not try wait for tiles at some
other scale to be filled in. Such a tiling may not even exist.

R=enne, vmpstr
BUG=406433

Committed: https://chromium.googlesource.com/chromium/src/+/60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f

Review URL: https://codereview.chromium.org/484363003

Cr-Commit-Position: refs/heads/master@{#291712}

The client might wait forever if the server fails to close
the connection.

BUG=

Review URL: https://codereview.chromium.org/501603002

Cr-Commit-Position: refs/heads/master@{#291711}

It broke in r291039.

Review URL: https://codereview.chromium.org/500593002

Cr-Commit-Position: refs/heads/master@{#291710}

Autoroller's not working.  Eric and I are investigating.

CLs:
https://skia.googlesource.com/skia/+log/3e42a4638559d71481ba598857f2d0c715c8d4b3..76db31a2ca11da4dd45016e964b2e49f39f3dd49

BUG=

Review URL: https://codereview.chromium.org/480723005

Cr-Commit-Position: refs/heads/master@{#291709}

Previously AuraWindowRegistry was allocating ID 0 to first window. This
breaks assumptions made in other places, e.g. DCHECK in
DesktopMediaPickerDialogView. After this change the implementation
guarantees that window IDs are always unique positive integers.

Review URL: https://codereview.chromium.org/499813002

Cr-Commit-Position: refs/heads/master@{#291708}

BUG=406957
R=behdad@google.com
TBR=behdad@chromium.org

Review URL: https://codereview.chromium.org/503073002

Cr-Commit-Position: refs/heads/master@{#291707}

When applied together with CL 459403002 it makes DevTools frontend for service
worker to look like the one for local worker (e.g. only the tabs that are
relevant to workers are shown).

BUG=389454

Review URL: https://codereview.chromium.org/496363003

Cr-Commit-Position: refs/heads/master@{#291706}

Fix google credentials support.

Migrate to action_runner when possible.

BUG=

Review URL: https://codereview.chromium.org/485743002

Cr-Commit-Position: refs/heads/master@{#291705}

The CL provides more information in the log messages for the following errors:
- Fixed-size array has wrong number of elements.
- non-nullable field is set to null/invalid handle.

The reason to have better log messages for these errors is that they are
triggered when users (of the bindings) provide invalid arguments. The users
probably want to find out what they have done wrong. The other validation errors
are rarer, caused by bugs in the bindings or malicious senders. Providing better
log messages for them is of slightly lower priority.

BUG=324170
TEST=None

Review URL: https://codereview.chromium.org/494943004

Cr-Commit-Position: refs/heads/master@{#291704}

BUG=328847

Review URL: https://codereview.chromium.org/444603003

Cr-Commit-Position: refs/heads/master@{#291703}

This CL allows the disclaimer label to break within words, so that long emails will appear fully, rather than being cut off/elided.

BUG=406359

Review URL: https://codereview.chromium.org/494383003

Cr-Commit-Position: refs/heads/master@{#291702}

Review URL: https://codereview.chromium.org/377293002

Cr-Commit-Position: refs/heads/master@{#291701}

This was generated by the following command line:

$ for f in $(g grep -l '"grit/ui_strings.h"' -- '*.cc' '*.mm' '*.h'); do
    sed -i -e 's/"grit\/ui_strings.h"/"ui\/strings\/grit\/ui_strings.h"/' $f;
  done
$ python ./tools/git/for-all-touched-files.py -c "./tools/sort-headers.py -f [[FILENAME]]"

BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/499163002

Cr-Commit-Position: refs/heads/master@{#291700}

R=jamesr@chromium.org, jamesr

Review URL: https://codereview.chromium.org/502493004

Cr-Commit-Position: refs/heads/master@{#291699}

Fixed various bugs, including exception on stacktrace and unnamed variable in git parser.
Changed the algorithm to use file_path only instead of file_name.
Removed URL links from the result.
Added commit message to the final result.
Updated OWNERS.

NOTRY=true

Review URL: https://codereview.chromium.org/478763003

Cr-Commit-Position: refs/heads/master@{#291698}

BUG=239656
TBR=asargent@chromium.org for app_view_browsertest.cc, app_view.js. I'm going to add myself to OWNERs in next patch.

Review URL: https://codereview.chromium.org/464213005

Cr-Commit-Position: refs/heads/master@{#291697}

BUG=none
R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Priority list copied here for reference:
P1 But written by different engineers, very uneven quality and voice.
P2 Some documentation could be expanded.
P0 The ramp-in for new users could be improved.
P0 The landing page isn't "cool", it doesn't make developers want to jump in and use it.
    Could we have a more github-like thing that gets people started quickly?
    Could we have a narrative intro?
    We just bought the pna.cl domain, we should use it!
P3 We think it's pretty important to keep the deep-dive in there (e.g. sandbox internals, bitcode reference).

Review URL: https://codereview.chromium.org/476793002

Cr-Commit-Position: refs/heads/master@{#291696}

Previously it would open the item then immediately minimize it. This caused
user confusion because they tried a double-click and didn't see anything
open on the screen.

BUG=404060
TEST=ash_unittests ShelfViewTest.ClickingTwiceActivatesOnce

Review URL: https://codereview.chromium.org/492963008

Cr-Commit-Position: refs/heads/master@{#291695}

NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/504443003

Cr-Commit-Position: refs/heads/master@{#291694}

BUG=406974
TBR=cmp
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/505813002

Cr-Commit-Position: refs/heads/master@{#291693}

These tests were originally made to cover http://crbug.com/398157.
Alas, that bug turned out to be very difficult to test since it does
not affect energy levels. That's what we use as a lightweight way to
detect whether audio is playing, but the bug managed to make audio stop
playing without affecting the levels. Still, I think the tests are
useful.

BUG=402860
R=perkj@chromium.org

Review URL: https://codereview.chromium.org/468243003

Cr-Commit-Position: refs/heads/master@{#291692}

The ARB needs updating to use git commit numbers rather than SVN revisions so trying to manually change DEPS.

BUG=
TBR=gavinp

Review URL: https://codereview.chromium.org/487363005

Cr-Commit-Position: refs/heads/master@{#291691}

Revert of DevTools: Removed refcounting from AndroidWebSocket (patchset #12 of https://codereview.chromium.org/449883002/)

Reason for revert:
There is a crash when port forwarding is turned off while there is at least one connected device.

BUG=407137

Original issue's description:
> DevTools: Removed refcounting from AndroidWebSocket
>
> Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device.
>
> This requires for lifetime of AWS to be manageable in the first place.
>
> BUG=387067
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289306

Review URL: https://codereview.chromium.org/505783002

Cr-Commit-Position: refs/heads/master@{#291690}

git cl upload uses the tracking branch to diff against unless otherwise
specified. This change specifies the origin/master branch should be
used.

BUG=401180

Review URL: https://codereview.chromium.org/487433005

Cr-Commit-Position: refs/heads/master@{#291689}

This CL depends on the following CL to be landed first:
https://webrtc-codereview.appspot.com/15989004
with the addition that that WebRTC revision of it needs to be
be rolled into Chromium DEPS first.

BUG=webrtc:3441
TEST=See https://webrtc-codereview.appspot.com/15989004 for details.

Review URL: https://codereview.chromium.org/321313006

Cr-Commit-Position: refs/heads/master@{#291688}

BUG=

Review URL: https://codereview.chromium.org/465363003

Cr-Commit-Position: refs/heads/master@{#291687}

This CL is one part of the effort to change chrome to use gaiaid instead of
email address as the unique id for an account.

BUG=341408

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263

Review URL: https://codereview.chromium.org/425823002

Cr-Commit-Position: refs/heads/master@{#291686}