- 04 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/589b41e743db..fbc7ed0d7116 git log 589b41e743db..fbc7ed0d7116 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 02cf6c70..8d9e658d (746692:746798) 2020-03-04 ilnik@webrtc.org Enable quality scaler for simulcast and SVC if only one stream is active Created with: gclient setdep -r src/third_party/webrtc@fbc7ed0d7116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe2797c5d16a0801db6f0526ae6252b26db376ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746925}
-
Nick Diego Yamane authored
This should help us to determine what exactly caused XWindow destruction during DelayedResize closure execution so that we can propose a proper fix to it. R=gab@chromium.org Bug: 1021490 Change-Id: Ie8e18d47b4c08d3c8aaf89d4f6dbf230f5c41b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087664 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#746924}
-
Xiaohui Chen authored
This reverts commit 6a1b1ed5. Reason for revert: seems to cause podcast playback issues. Original change's description: > Reland "assistant: add audio ducking for internal media" > > This is a reland of f7860793 > Fix original build error and some additional refactoring. > > Original change's description: > > assistant: add audio ducking for internal media > > > > Bug: b/135064564 > > Test: locally build and run with multiple media playing > > Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 > > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713200} > > Bug: b/135064564 > Change-Id: Ief51c008cb8dba3e6ae4757405c69fca01a94524 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903755 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739453} TBR=xiaohuic@chromium.org,wutao@chromium.org Bug: b/135064564 Change-Id: I7a0c27554af154aa15d4ef3f368bc2a0b15ca7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088220Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#746923}
-
Fredrik Söderquist authored
When StyleDidChange is called we're guaranteed to have a style object attached, so we can just use StyleRef() without checking. Also turn the ternary expression into a logical and for the similar check on the (potential) old style. Change-Id: Ic0ba51a265442e2c67cd4c718e98b42e90bb060a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087919 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#746922}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia56da988faa32212949b824876ba7f9f10295c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088214Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746921}
-
Sigurdur Asgeirsson authored
Bug: 1056188 Change-Id: Idf49bdbff19b234cbd033b7fbb5265aa32c78194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083055 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#746920}
-
Eugene But authored
Use the following format: Switch [from Tab<id>] [to Tab<id> at 0] Old example: Activated Tab1 for user action Tab-1 at -1 New example of the same log: Switch to Tab1 at 0 #user-action Do not log events unless WebState activation was triggered by tab switch (the rest of activation reasons are covered by other WebStateListObserver callbacks). Bug: 1046231 Change-Id: I1c8657de6813bc62a719fed7add55211f9e6ffeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084151Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#746919}
-
Anna Malova authored
- Convert CreateDataCallback - Convert CreateUploadStreamCallback Bug: 1007815 Change-Id: If3b72b4ce85cf7bf7c808a38f8a54b4a496445ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088096 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746918}
-
Nick Diego Yamane authored
This is an attempt to fix or at least mitigate crash https://crbug.com/1021490. A base::WeakPtr is used in to bind XWindow::DelayedResize task to delayed_resize_task_, which is a CancelableCallback, which is not needed and potentially make it harder to understand the aforementioned crash. So use base::Unretained() instead of WeakPtr in that case. Additionally, dcheck Close() is called before XWindow's dtor. Bug: 1021490 Change-Id: Ibf8b2f185dc020258905f6bf5e26305c51e7a215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917079 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bbd4f3e6052c..16f581398d7d git log bbd4f3e6052c..16f581398d7d --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chonggu@google.com [Telemetry] Change fuchsia_output_dir to fuchsia_ssh_config_dir for better clarity. Created with: gclient setdep -r src/third_party/catapult@16f581398d7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058255 Tbr: wenbinzhang@google.com Change-Id: If00db40ca541b33e90ad43c5210be7903b0ac0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087949Reviewed-by:
-
Anastasia Helfinstein authored
Also removed a TODO, as the code no longer polls for the back button. Bug: None Change-Id: I167aca4a6e98ae7537bca431e33973a45dbf256d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071040 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#746915}
-
chrome://extensionsArchana Simha authored
Records Extensions.Checkup.TimeSpent when the ExtensionsCheckup feature is disabled so that we can compare the behavior of the experiment and control groups. Bug: 1034541 Change-Id: I58213193bc4d24ba1a2c832c69885fd62ed882e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083744Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#746914}
-
Ahmed Mehfooz authored
There is currently no way to close notifications in tablet mode with chrome vox enabled. Bug: 1022595 Change-Id: Ia7fcfa5139bed04cfc465e2342b0938b6431c89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072910 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746913}
-
Ken Rockot authored
Missed this bot in r746454, which added the same tests to Windows and Chrome OS FYI bots. Bug: 1052045 Change-Id: I5096307255c6534b3e3f97158988c7ccc9144e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085842 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#746912}
-
Xianzhu Wang authored
This prepares for crrev.com/c/2070688 which will fix transparent background hit test in CompositeAfterPaint. This CL avoids too many paint chunks that would be created in that CL. In PaintLayerPainter, instead of forcing paint chunks at the beginning of paint phases, now use ScopedPaintChunkHint which forces a paint chunk only when necessary, and when the scope ends and no paint chunks created (i.e. no paint has happened), the scope restores the original state of forcing paint chunk to avoid extra paint chunk even if we paint nothing during the scope. Also remove most of the DisplayItem::kLayerChunk* types which were needed with the original force chunk method. Change-Id: Iccf224b9647d282c64139fd723d6fe68b8f2eeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076849Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746911}
-
Patrick Noland authored
This should be a purely mechanical change that reduces the boilerplate needed for ToolbarManager to track the current tab. Bug: 865801 Change-Id: I04f0273902bc4fe966a424d30a900492ac874aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076402 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#746910}
-
Etienne Pierre-doray authored
As preparation for NativeUnwinderAndroid, ModuleCache needs to support adding native modules. This CL - adds ModuleCache::AddCustomNativeModule. - Renames Unwinder::AddNonNativeModule to Unwinder::AddInitialModules - Turns android ChromeModule to a native module Follow-up: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 Bug: 989102 Change-Id: I5f2319e999f04e76de96702f811b3bfa50f5b17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080776Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#746909}
-
Peter Kasting authored
Bug: 1050801 Change-Id: I67a09733abcc07e83031e05541b945ccdd56eece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073158 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#746908}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6e9087162a1c..14f128e8dc29 git log 6e9087162a1c..14f128e8dc29 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 rharrison@google.com Remove deprecated methods no longer used by Dawn (#993) Created with: gclient setdep -r src/third_party/shaderc/src@14f128e8dc29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I83eabdd44018100eb5979309e1cd1a3725f5ffaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087948Reviewed-by:
-
Etienne Bergeron authored
Default ignorable codepoints should not be considered for choosing a fallback font. see: http://www.unicode.org/L2/L2002/02368-default-ignorable.pdf """ Default-ignorable codepoints are those that should be ignored by default in rendering (unless explicitly supported). They have no visible glyph or advance width in and of themselves, although they may affect the display, positioning, or adornment of adjacent or surrounding characters. """ The API used to determine fallback fonts on Mac is CTFontCreateForString(...). The API is not able to match default ignorable codepoints like ZWJ and NZWJ. GetFallbackFont(...) was failing when an ignorable codepoints is present and the expensive GetFallbackFonts(...) is used instead. Bug: 1036652 Change-Id: If44c5b8887a7186863d8e40bde5d4ba4f94ed0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076439 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746906}
-
Victor Costan authored
The NaCL SDK is 32-bit only. This situation is unlikely to change, because NaCL is deprecated and slated for removal from the codebase. macOS 10.15 removed support for running 32-bit binaries. Since the NaCL compiler cannot run on macOS 10.15 or above, attempting to build Chromium with enabled_nacl=true on this OS currently fails with obscure errors. This CL adds a GN assert with a clear error message that includes an easily actionable step for developers encountering this situation. Bug: 1049832 Change-Id: I2d4bccc7110cdb1f54cf302327cce0858e01bbb4 Tested: Checked out the error message on macOS 10.15.3. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087430Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746905}
-
Paul Moy authored
Now that cros_healthd collects backlight information, use it to fetch and report this information in DeviceStatusCollector. Bug: chromium:1056408 Change-Id: Iefd183f58bc277c87e46bd8f372557c1d52bc74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079522 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746904}
-
Evan Stade authored
Bug: none Change-Id: I0dda6eb22f1bbdb6f11b4da0818ca34adb259728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086688 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746903}
-
Robert Liao authored
The flag declarations are still used by dependent directories. BUG=1057239 TBR=brucedawson@chromium.org Unit test deps change due to flag removal. Change-Id: If5404c1855ee1b284c37b773b3fb835e6c8ee8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080867 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746902}
-
rbpotter authored
Bug: 1026426 Change-Id: Ib8a555f05f6f3934a5eac32340c99442bc02c71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086312 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746901}
-
Ben Pastene authored
The 'chromium.tests.template' pool is identical to the 'chromium.tests' pool (same bots) but uses swarming task templates. This temporarily moves all ios tests to the new pool while I work on adding templates to the old pool. Bug: 812428 Change-Id: I4e3cf7b94bd0e8d371bf39ab2f13d56256d27b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083919Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#746900}
-
Darwin Huang authored
Add kRawClipboard to the bad flags list. This will allow the dev trial to continue, but with a clear indicator of a dangerous API being exposed. Bug: 897289 Change-Id: I401d01a884d653caa50b767f118edf136ce99a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086011Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746899}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad298fa3..ddac4370 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7a7dea2b847bf62d1c8b6909ccbedb661506f903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088131Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746898}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d71548adfb09..eced98b5eacf git log d71548adfb09..eced98b5eacf --date=short --first-parent --format='%ad %ae %s' 2020-03-04 michaelludwig@google.com Enforce saveLayer ignoring restore paint's mask filter 2020-03-04 reed@google.com Reorganize vertices internals, in prep for extending with per-vertex-data Created with: gclient setdep -r src/third_party/skia@eced98b5eacf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ibca1503c6d64b1b2385603c307f5a14f40fc345f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087945Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: Id2e44ecc0bac22f9db94eb86247f71c29d359447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087346 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Ben Joyce authored
Custom_tabs still needs old references. Bug: 1052460 Change-Id: Id79b88e6e924de6d92e0e38284f687082afc7894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086268 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746895}
-
rbpotter authored
Move the tests for the clear browsing data dialog to a separate file, since this element and its children live in c/b/r/settings/clear_browsing_data_dialog, not in the privacy_page folder. Also adding an import for a dependency that wasn't imported correctly before. Bug: 1026426 Change-Id: Icaaba7ac9c361f25f6c6fbcecc45132cc81f2c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085695 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I264f5bc31c07711065a4840ce6836e3e5cc9777c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087588 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Kalvin Lee authored
This change implements the PrinterConfigCache and provides unit tests for the same. Bug: 888189 Change-Id: I01ca78b196fdc3392464f7c033bfa2b2db4b2a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013321 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#746892}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device keyboard page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ib53c91f9cce5da404f54cd2c0fd05dbd3cab393a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067278 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746891}
-
Tom Anderson authored
After [1], the sync info container now respects the GTK theme. However, this exposed an issue when using the Ambiance theme (default on Ubuntu), where the sync info container appeared dark on a light popup window. This was caused by Ambiance using light popups, but dark menus. The simple fix is to use BubbleFooterBackground instead of HighlightedMenuItemBackgroundColor. These colors are both SkColorSetRGB(0x32, 0x36, 0x39) in the dark theme and gfx::kGoogleGrey050 in the light theme. It's also makes more logical sense to use a "Bubble" color rather than a "MenuItem" color here anyway. [1] https://crrev.com/744759 R=pkasting Bug: 1056594 Change-Id: I3efb17c11bd383a84287efc1d420a12ad917a537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080711 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Mason Freed authored
TBR=masonfreed@chromium.org Change-Id: I35f4d2b46e2311c7a9092d69d4c636795559eea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087426Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#746889}
-
Nina Satragno authored
Remove web platform tests that erroneously expect failures for converting objects like arrays into dictionaries and other values into booleans. The webauthn spec does not impose any such restrictions and the ECMAScript spec precisely specifies how those values are converted. Bug: 875444 Change-Id: I8c131735808205313314b9043da7e775a51dd9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086253 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746888}
-
Chong Gu authored
Bug mentioned was fixed, should be able to reenable canvas acceleration now. Bug: 1058255,1019212 Change-Id: I6508a2591ef30c207664a205b1ad6d4c21839311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088215 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746887}
-
Dominique Fauteux-Chapleau authored
That feature flag is no longer necessary since showing the UI should now be the default behavior. The one exception to this are unit tests, so this CL adds DeepScanningDialogDelegate::DisableUIForTesting to handle that case. Bug: 1058002 Change-Id: Ie823b3635139c89b844e796a7aa3498ebae1d6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081630Reviewed-by:
-
