GitLab

o Adds Cocoa implementation of the extension installation prompt.
o Added new cross-platform implementations of the extension install error prompt.
o Got rid of unused extension install strings from early implementations.
o Added a string to display as the header of the error dialog, since it was inline English.

Patch by Andrew Bonventre <andybons@gmail.com>

BUG=19654
TEST=Install an extension on any platform, observe consistent visual behavior and messaging.
Review URL: http://codereview.chromium.org/333015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/335033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30089 0039d316-1c4b-4281-b951-d872f2087c98

This also cleans up some of the InfoBubbleGtk code a bit.

BUG=23373
TEST=tested LTR and RTL under metacity

Review URL: http://codereview.chromium.org/332022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30088 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkHTMLWriterTest.Test (suspected resource flakiness)
LoginPromptTest.TestTwoAuths

TEST=none
BUG=17592, 25794

Review URL: http://codereview.chromium.org/332024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30087 0039d316-1c4b-4281-b951-d872f2087c98

BUT=24145
Review URL: http://codereview.chromium.org/338024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30086 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/337029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25823
TEST=HostCacheTest.KeyComparator

Review URL: http://codereview.chromium.org/338023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=gspencer

Review URL: http://codereview.chromium.org/337028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30083 0039d316-1c4b-4281-b951-d872f2087c98

 * Swapped the positions of entry field and navigation buttons.
 * Hide navigation buttions when the entry field gains focus.
   - To implement this, I added OnKillFocus in AutocompleteEditController, and updated
     corresponding files.
 * Added accelerator (shift-ctrl-0) to toggle compact navigation bar
Changes to BrowserExtender
 * Made all virtual methods in BrowserExtender pure virtual.
 * Added HideToolbar method to control visibility of toolbar from Extender.

Review URL: http://codereview.chromium.org/329009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build test_shell_tests only and run.
BUG=none
Review URL: http://codereview.chromium.org/335030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30081 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow

Review URL: http://codereview.chromium.org/332028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30080 0039d316-1c4b-4281-b951-d872f2087c98

Fixes cmd-c, cmd-v, cmd-x, cmd-a.

The menu blinking is worth the extra IPC hop.

BUG=25254
TEST=Select text, hit cmd-c. "Edit" menu should blink. Hit cmd-v. "Edit" menu should blink again, correct text should be pasted.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30045
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=30046

Review URL: http://codereview.chromium.org/330014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30079 0039d316-1c4b-4281-b951-d872f2087c98

The About box now knows how to check to see if updates have been installed
in the background without anyone having to click the Update button in the box.

The About box no longer gets stuck in the "installed" state.  Even if an
update has been installed, the About box will still check for new updates when
reopened.

BUG=13165, 20488
TEST=Play with the about box and auto-update a whole lot
Review URL: http://codereview.chromium.org/338012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98

Adjusted timeouts for a couple failing tests; switched from umount to hdiutil detach to solve some unmounting problems seen on Tiger.
Review URL: http://codereview.chromium.org/332030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/329020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/307030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30074 0039d316-1c4b-4281-b951-d872f2087c98

* added member vars for main menu and compact navbar
* show/hide main menu/compact navbar/status area upon fullscreen mode change.

I'll work on linux_views as well.

BUG=22805
TEST=Create new window from compact navbar menu, and toggle full screen mode

Review URL: http://codereview.chromium.org/332027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30073 0039d316-1c4b-4281-b951-d872f2087c98

When creating the canvas, take cues from the image we
just loaded and don't hard code it to 19x19. This way
we can have smaller than 19x19 icons that show up
centered within the browser icon button.

This doesn't attempt to deal with scaling down images
that are too large to fit the 19x19 canvas, but we
haven't decided how to handle those anyway.

BUG=25487
TEST=Load the api_test/browser_action_tab_specific_state
extension and click on the browser action. The red
square within the button should not grow in size as you
click.

Review URL: http://codereview.chromium.org/337026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30072 0039d316-1c4b-4281-b951-d872f2087c98

This does not fix undo, it just makes the implementation break it
less.

BUG=18084
TEST=Omnibox should continue to work.

Review URL: http://codereview.chromium.org/337027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30071 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30070 0039d316-1c4b-4281-b951-d872f2087c98

This can happen legitmately if the icon has been moved or
corrupted on disk.

I think we are hitting it too frequently for that to be the
whole explanation, but since this code is moving around a
lot shortly, it seems prudent to put in the quick fix and
worry about what's really going on post-refactor.

BUG=25601
TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action.

Review URL: http://codereview.chromium.org/339005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30069 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98

* New, crisper icons that are exactly 19x19
* Add a loading animation at the beginning before Gmail
  responds.
* Fix a bug where we sometimes don't update the UI after a
  logout/login cycle.

Review URL: http://codereview.chromium.org/338013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30067 0039d316-1c4b-4281-b951-d872f2087c98

Move creation of SEH frame into a separate funcion.For any function that uses SEH, the compiler creates a single EXCEPTION_REGISTRATION record at the function prolog (even if the function has nested or inside condition statement __try/__except constructs). When __try block is entered and leaved only the index to the relevant scope table is updated.When the exception occurs the  __except_handler4 may ignore it if there is no scope table set i.e. we are outside __try block.In ChromeFrame when exception happens, the global vectored exception filter walks through the SEH chain and is misled that there is handler/filter installed and therefore skips creation of a crashdump.
BUG=23845
TEST=crashes in ChromeFrame background threads are reported.
Review URL: http://codereview.chromium.org/335011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25804
TEST=none
TBR=aa

Review URL: http://codereview.chromium.org/333027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25200
TEST=running tab_switching_test in VS reports results

Review URL: http://codereview.chromium.org/307047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30064 0039d316-1c4b-4281-b951-d872f2087c98

Refactor: Change the interface from HostResolver::DisableIPv6() to HostResolver::SetDefaultAddressFamily(), to make it more general.

This came up in a codereview comment, but was after I had checked in.

Review URL: http://codereview.chromium.org/303026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30063 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/21910
TEST=none

Review URL: http://codereview.chromium.org/334019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30062 0039d316-1c4b-4281-b951-d872f2087c98

 * Closing a submenu was hitting NOTREACHED in OnMenuHidden.
 * Changed to register OnMenuHidden callback only when we're
   about to open the menu, then disconnect it when closed.
   This is safer as the same menu can be used as submenu
   (although that's probably not great style)

Review URL: http://codereview.chromium.org/328002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30061 0039d316-1c4b-4281-b951-d872f2087c98

I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed).

[N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.]

BUG=25810
TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift).

Review URL: http://codereview.chromium.org/333026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30059 0039d316-1c4b-4281-b951-d872f2087c98

This is an update to r29904 and came out of a discussion with Darin.

BUG=http://crbug.com/24493
TEST=NONE

Review URL: http://codereview.chromium.org/335010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30058 0039d316-1c4b-4281-b951-d872f2087c98

because we get CERT_RDN_ENCODED_BLOB on machines patched for the
CryptoAPI ASN.1 security vulnerabilities.

R=rvargas
BUG=24190
TEST=the X509CertificateTest.PaypalNullCertParsing test
in net_unittests (debug build) should not hit a NOTREACHED()
assertion failure when running on a patched Windows machine.
Review URL: http://codereview.chromium.org/337014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30057 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/334027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98

when they belong to a doomed entry.

BUG=25588
TEST=unittests

Review URL: http://codereview.chromium.org/335015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9787
TEST=green

Review URL: http://codereview.chromium.org/334015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30053 0039d316-1c4b-4281-b951-d872f2087c98

Also moves the guts of WebFrameImpl::GetWebViewImpl to WebViewImpl's
FromPage method since it involves dipping into ChromeClientImpl.

R=dglazkov
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/339001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30052 0039d316-1c4b-4281-b951-d872f2087c98

The test timed out on one of the bots last time.  This change tries to fix that, and it breaks down the test into multiple tests to isolate the problem in case it isn't fixed.

No changes to code outside the test and the test HTML file.  Previous review at http://codereview.chromium.org/284015.

BUG=24447
TEST=RenderViewHostManagerTest.*SwapProcess*

Review URL: http://codereview.chromium.org/328017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30050 0039d316-1c4b-4281-b951-d872f2087c98

mouse moves over another folder, the menu for that folder is shown.

BUG=355
TEST=thorougly test all possible permutations of bookmark menus you
     can think of, including drag and drop to the menus.

Review URL: http://codereview.chromium.org/328012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98

When middle-clicking a tab to close it, one should be able to move the mouse off
the tab before releasing to cancel it.

BUG=16019
TEST=Get a 3-button mouse. Make sure middle-clicking tabs to close them still works. Make sure moving the mouse off the tab before releasing the button cancels.

Review URL: http://codereview.chromium.org/333021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30048 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30046 0039d316-1c4b-4281-b951-d872f2087c98