- 10 Oct, 2019 40 commits
-
-
Mohsen Izadi authored
Everywhere we access OzonePlatform, it is already initialized (and should be in future). There is no need for EnsureInstance() anymore. BUG=958387 Change-Id: I1adf0f65ce8a446275417856caeb56c2310bea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763633Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704838}
-
Andrew Luo authored
Bug: 765833 Change-Id: Icf477e67b98c58bd45d1c7328081a9d6e25c5e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832289 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704837}
-
Giovanni Ortuño Urquidi authored
Two issues came up when trying to import bindings_lite as a module: 1. Closure compiler generated the following code in order to polyfill Number.MAX_SAFE_INTEGER: ``` Number in this ``` `this` is undefined inside modules, so the above code caused an error. We get around this by changing Closure to compile to ES2015. 2. Namespaces were being added to `this` which again is undefined in modules. To get around this, we change to `self`[1] which should work in regular scripts, modules, and workers. This CL also moves mojo tests to http/ so that the resources are served from a server which is needed in order to import modules. Not all tests need their resources to be served from a server, but we move them to http/ regardless to avoid having tests in two places. [1] https://developer.mozilla.org/en-US/docs/Web/API/Window/self Bug: 1004256 Change-Id: I5c32e37e1f57e8539b39f0bdcc85f796e114f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831660 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704836}
-
Sophie Chang authored
This also only creates the prediction manager if the feature is enabled and overrides any target decision if feature is enabled Bug: 1001194 Change-Id: Iea7db02a4e7b851967228df44c8ce7458118d1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853863Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d8a95ee71b5..66ae304f501e git log 2d8a95ee71b5..66ae304f501e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 robertphillips@google.com Plumb GrTextureProxies down into emitSampler/addSampler 2019-10-10 kjlubick@google.com [canvaskit] Enable tests for getGlyphPosition Created with: gclient setdep -r src/third_party/skia@66ae304f501e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I5c93ea91fd52d6b4088e11f19ee75be6565067db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854025Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704834}
-
Antonio Gomes authored
This wraps up Onion souping of media_stream_video_webrtc_sink_unittest.cc|h that happened on [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1811179 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4302207403f614cdac329be3cb591a13f13db52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816793 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704833}
-
Simon authored
TBR=perezju@chromium.org Bug: 1013317 Change-Id: Ie5fd327f9973cce71da173a4d70539de2f859370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853947Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#704832}
-
Hesen Zhang authored
- Deleted the redundant style appled in dialog linear layout. Bug: 1012450 Change-Id: Ice1accff7bc3bc09dc625c622a679328be133d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846470Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704831}
-
Tao Bai authored
Bug: 10128236 Change-Id: Ibe238ddd409a00ae256d15e705d2c95dfad67f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849633 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704830}
-
Kevin Marshall authored
The use of leading slashes causes path validation issues in VFS implementations like vfs::PseudoDir. This fixes the issue by discarding the leading slash from the path component of requested URLs. Adds a browser test which validates the use of PseudoDir and VfsFile with ContentDirectoryProvider. Bug: 1011180 Change-Id: I2b47ad35023be73cc32538f83b166ebaa9b85f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848411 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704829}
-
Lei Zhang authored
Instead of trying to handle a NOTREACHED() condition, just crash if the impossible happens. Change-Id: I01f79600aa0c58ec9f6276f30a4e0cc8c2f729f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853887Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704828}
-
Yuwei Huang authored
This CL renames jid_util.* to signaling_id_util.* and renames its functions from Jid to SignalingId. Bug: 983282 Change-Id: I94b50afc6b9c33031905e17c5c55ada3d846e9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853868Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#704827}
-
Josh Nohle authored
This flag will be used to enable the CryptAuth v2 DeviceSync protocol. The Chrome OS migration plan from CryptAuth v1 to v2 DeviceSync is outlined in the design document http://go/cros-devicesync-v2. Bug: 951969 Change-Id: I317f0027012fba111244ca7180e3002946074165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845431Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#704826}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1007760 Change-Id: Idc44c0d854b36239257f4bf25eeab74bd1cbd170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849489 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704825}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1007760 Change-Id: Ia37dc17f05b941994c11cbbefc99832fcc9f7179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849536 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704824}
-
Miguel Casas authored
This CL disables support for VP9.2 and VP9.3 in Vaapi so that decoding of these profiles falls back automatically to libvpx. This is because the majority of content in those formats is also HDR, and Vaapi does not support on ToT colorspace information nor high bit depth. Bug: 1011469, 1011454 Cq-depend-on-chromium:1845616 (CrOs tast repo). Change-Id: I1cb1d9c4f91181b7049caab961d2dec2427f360c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842564 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704823}
-
Brian Ho authored
To load the Vulkan instance function pointers, we currently use the Vulkan API version of the VkInstance (returned via vkEnumerateInstanceVersion) which refers to the maximum supported version of the Vulkan implementation on the system. The actual hardware, however, may only support up to an earlier API version. When the API versions differ between the VkInstance and the VkPhysicalDevices, the spec mandates that you must use the lowest API version [1]. More concretely, this bug manifests in Chrome when the VkInstance supports 1.1, but the GPU only supports 1.0. In this case, we load 1.1-specific functions like vkGetPhysicalDeviceFeatures2, but when we actually try to run them on our 1.0 VkPhysicalDevice, the GPU process crashes [2]. This CL fixes this bug by explicitly checking the VkPhysicalDevice's API version instead of just seeing if vkGetPhysicalDeviceFeatures2 is non-null. [1] https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkPhysicalDeviceProperties.html [2] https://cs.chromium.org/chromium/src/gpu/vulkan/vulkan_instance.cc?l=282&rcl=cf2dfbbe19a94a77242a325388eeaeb62f530483 Bug: 1012880 Change-Id: I5e60bae02cf47e3c94f0ac9ba1ed60c0712e8d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853871Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#704822}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=satorux@chromium.org Change-Id: I5e053dd1816ad2385dc393153e1bbcc5da20eac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853945Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704821}
-
Wez authored
Bug: b/142153531, b/142153531 Change-Id: I02b6429bae3bc5897f2d632b09062a72689123e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850970 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704820}
-
Robbie McElrath authored
This is a reland of 362070db Original change's description: > Don't include JNI headers in chrome android when they're not used. > > This CL removes dependencies on JNI headers when they're not used and > the Java implementation isn't included. This makes chrome_public_apk > work with crrev.com/c/1743088. > > Bug: 836335 > Change-Id: Iec02f4fec9cf93183949547960e191e675e62ebf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746641 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694921} Bug: 836335 Change-Id: Id7307e38f44a0e07f9dc8cf6dbe350d5b76ba9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793943Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#704819}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within miscellaneous tests pertaining to Chrome OS, Downloads, Sync, and WebUI This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Ibf5e29e596542002594d6a8cc4034751d45e84e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849426Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704818}
-
rbpotter authored
The initial viewportChanged_() call, where the previous most visible page is undefined, should not trigger the page indicator. See https://crbug.com/969050 Bug: 1010843 Change-Id: Id4e9b5a7db10ef21b2a205027dd30f8152e4578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852488Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#704817}
-
Sebastien Marchand authored
The ukm.xml change simply add an enum value to a metric that has already been approved here: https://bugs.chromium.org/p/chromium/issues/detail?id=753486#c26 Bug: 980533 Change-Id: I1166ca372c5b3f076a9df89b48407b84d2f06876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845621 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#704816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6f52934. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." bcaa3f35 "Port visibility-interpolation.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3691547e374e6887e1529a1cb38648a8e78984d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853944Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704815}
-
nancy authored
This is the follow up for crrev.com/c/1830483 and crrev.com/c/1816495. Those UMA records have been moved to AppService, so the UMA interface in app_list/internal_app should be replaced with the AppService interface. Otherwise, we have duplicate interface, which could cause confusing for the future change. Although app_list/internal_app will be replaced by AppService for the long term goal, in short term(one or two months), they are still there, so as the temporary solution, update it to use the AppService's interface. BUG=1005640 Change-Id: Ibc0b6d6cb592590e016d7a0795926d0b23478e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851890Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704814}
-
Sam Fortiner authored
With BGPT launching, this test collateral is now unused. Change-Id: I24b499f0f93d676ccd07a8a8b9cbc378a1926ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853852Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704813}
-
Alex Newcomer authored
The hotseat was losing its opacity, and animating off screen, then animating back to it's kShown position. Instead of this it should keep its opacity and animate directly to kShown. Bug: 1007091 Change-Id: I0a8541ffebaa35a384906d8565a9a2c21a1b2e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848902Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704812}
-
Lei Zhang authored
- Use nullptr. - Don't use "sandbox::" inside namespace sandbox. Change-Id: I30dc95ba7248ace1ceae52df14c6f1470b18f7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565558Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704811}
-
danakj authored
Initializing the compositor requires a ScreenInfo which is not present until a main frame comes with a VisualProperties. We don't need the compositor until the RenderWidget will be used, when it is revived from undead. R=avi@chromium.org Bug: 419087 Change-Id: Idfc3e1417e58dd1dac3dfbb92b3868ca857dc511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850774 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704810}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f67cf3bf610..364848cc9284 git log 1f67cf3bf610..364848cc9284 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 yuhsuan@chromium.org Revert "Update test to match audio group membership." Created with: gclient setdep -r src/third_party/chromite@364848cc9284 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I170abed8800104e8dcc2337786bb90292f0a6394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704809}
-
Anthony Polito authored
Bug: b/140589523 Change-Id: I01e015551729dc440187735fd689486eaabd6cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838053Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Cr-Commit-Position: refs/heads/master@{#704808}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b21973d2c0c9..847b3f98194e Created with: gclient setdep -r src-internal@847b3f98194e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1316c9d93178aaf87f8dd8d1e255a3bff164b3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704807}
-
Luke Sorenson authored
Bug: 1003037 Change-Id: I527dde7eff1e4e902d4bb81d94bdfec6867b2126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799442Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#704806}
-
Peter Boström authored
Bug: chromium:1005563 Change-Id: I77db7e5ac5365f6aceab8b85d108ba1237b8024d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853859 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704805}
-
Daniel Hosseinian authored
In preparation of sfntly's replacement by HarfBuzz, remove sfntly_fuzzer. Any issues found by ClusterFuzz are unlikely to be fixed. Bug: 931719, 1009078 Change-Id: Ia0e3661afc5d92b57b16bf1e4fb4e4cc00b8783f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853844 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#704804}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14bf0b9d8122..60e30b8a1a53 git log 14bf0b9d8122..60e30b8a1a53 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 treehugger-gerrit@google.com Merge "tools: format Python scripts" 2019-10-10 fmayer@google.com Merge "Add canned query for bytes per type." Created with: gclient setdep -r src/third_party/perfetto@60e30b8a1a53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I961a334449ced516f36870b86bea1f0aa61a5fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704803}
-
Morten Stenshorne authored
In the initial column balancing pass we don't know the block-size of the columns (fragmentainers). We previously set the column size to "infinity" (LayoutUnit::Max()) in this initial pass. Apart from being slightly ugly, it is also problematic, as that would cause containers of children with forced breaks to become "infinitely" tall, and we'd thus end up with "infinite" column sizes. Instead leave the fragmentainer block-size at unknown (kIndefiniteSize) in the initial column balancing pass, and have the algorithms cope with this. At the same time, replace FragmentainerSpaceAtBfcStart in NGConstraintSpace with an offset; i.e. instead of storing the remaining *space* at the nearest BFC block-start, store the *offset* from the fragmentainer block-start to the nearest BFC block-start. One good thing about this is that we only need to deal with one kIndefiniteSize field, instead of two, but this change will also come in handy when we add support for calculating the tallest unbreakable piece of content in the initial column balancing pass (in an upcoming CL). Bug: 829028 Change-Id: Id66c44452601d499d3d22c9f231576d26e10c459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852290 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#704802}
-
jonross authored
This change is setting up a new CI bot on the chromium.gpu.fyi waterfall: "Win10 FYI x64 SkiaRenderer GL (NVIDIA)" This bot will be used for testing the SkiaRenderer configuration on Windows, backed by GL not Vulkan. This patch also includes the desired tests suites. Additionally sets up a trybot "gpu-fyi-try-win10-nvidia-skgl-64" so that we can send changes for dry-runs. Bug: 1011512 Change-Id: I56db11aa3a0147b2d496cb5bb95ebb1813e420a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841238 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704801}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iec5e418841e98a31d3922dd941bdbb9d3975ea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704800}
-
Yusuke Sato authored
This allows us to abort the upgrade process when arcvm-server-proxy fails to start. BUG=b:142144019 TEST=ran the new test Change-Id: I18f5740c36d949af17a76a6e481041f08f2dad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850365 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#704799}
-