- 04 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c3f7873b9a3a..a1bf69967a32 git log c3f7873b9a3a..a1bf69967a32 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 teisenbe@google.com Fuchsia: Migrate to new libasync-loop API Created with: gclient setdep -r src/third_party/angle@a1bf69967a32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I2de5accc7689abfb5d78f290a46b1ee64c68d518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693007}
-
Rakina Zata Amni authored
The rendersubtree attribute adds style, layout, and (if it contains "invisible") size containment to the element it's on, keeping existing containments and adding to them. See draft spec at https://github.com/whatwg/html/pull/4862. Bug: 991095 Change-Id: I91666603e3fde7cdb637e0911a232daa7245edb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780093 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693006}
-
Fergal Daly authored
Just running clang-format Change-Id: I855e9fd343c063d787f46a352895bfa834a97b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781131Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693005}
-
Tetsui Ohkubo authored
As MacViews was launched, PopupsOnlyUiController::Delegate no longer needs to be a delegate. Currently, PopupsOnlyUiDelegate is the only class that implements PopupsOnlyUiController::Delegate. This CL removes them and moves the unit tests. TEST=PopupsOnlyUiControllerTest TEST=Checked https://crbug.com/901350 did not reproduce on Linux Chrome BUG=None Change-Id: I48785667c8336fcffd31776991157ba38295c62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771526Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#693004}
-
Kent Tamura authored
This CL reduces the esitamated pre-processed size of document.h from 4.18MB to 3.05MB. Change-Id: Icf6ed523ace7f7ed827861b3fdb5b81923ed16cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782210Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#693003}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4e32bb25503..9ad1bbf6e1e6 Created with: gclient setdep -r src-internal@9ad1bbf6e1e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I042c223790361c5f3b3bc6389799e656fce9d85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783746Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693002}
-
Dominic Mazzoni authored
Fixes two issues: 1. If a web page starts talking and you switch out of Chrome, it will stop speech now. 2. If a web page tries to start speaking after a setTimeout delay, it won't speak if Chrome doesn't have a visible window at the time it would speak. This doesn't necessarily address the issue of a background tab trying to speak, that would require plumbing through a lot of information that's not available now. Let's see if this is good enough, and revisit if we also need to keep track of tabs? Bug: 998328 Change-Id: I5f4d2dbeb033b9868eee0faf242522f1f0796a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779172Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693001}
-
Dominic Mazzoni authored
I think it'd be good to have a fuzzer that creates some random accessibility trees with lots of random ignored nodes, to test functions like PlatformDeepestLastChild that are crashing for an unknown reason. Perhaps we can also use this as a template to create some platform-specific fuzzers for public accessibility APIs. Bug: 989997 Change-Id: I9e62f174c7722e4add1dbf7ead510fd37b394e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780944Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693000}
-
nancy authored
This is the first part of App Service integration to shelf: Adding AppService AppIconLoader. The second part will be adding AppService LauncherAppUpdater. The third part will be a refactor: Moving App Service files in ui/app_list to a directory. BUG=998004 Change-Id: I400bc25bbc874ce12524f76f6e50c3cfa95b2b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771228 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692999}
-
Michael Spang authored
This fixes the following error from gn check: The target: //chromecast/media:cast_media_unittests is including a file from the target: //chromecast/media/base:monotonic_clock It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //chromecast/media:cast_media_unittests --> //chromecast/media:media --> //chromecast/media/audio:audio --[private]--> //chromecast/media/base:monotonic_clock Bug: b/140414631 Change-Id: Ief92c8a19020b7a345d6b013207511a35b49fcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784003 Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692998}
-
Kenichi Ishibashi authored
This CL: * removes one not-well-documented method from WebServiceWorkerContextClient * is a preparation for a potential fix of race condition in service worker extension The context of the second bullet is a bit complicated. Service worker background extension has following ordering assumption at initialization: 1. ExtensionMsg_Loaded is received on renderer extensions::Dispatcher::OnLoaded() 2. Installing extension API bindings extensions::Dispatcher::DidInitializeServiceWorkerContextOnWorkerThread() However there is no such guarantees. The current implementation happens to be working just because creating EmbeddedWorkerInstanceClient is bound to RenderThreadImpl and StartWorker() mojo message is handled after ExtensionMsg_Loaded. To make sure the above ordering we need to wait for the loaded message before installing extension API bindings. DidInitializeWorkerContext() isn't a right place to install extension API bindings because it is called via blink::WorkerThread::InitializeOnWorkerThread(), which doesn't wait for anything after StartWorker() mojo message is received. Fortunately we have blink::WorkerGlobalScope::ReadyToRunScript(). This was introduced for service worker update to suspend service worker execution after script fetch. We could probably use this to wait for the extension loaded IPC message. ReadyToRunScript() calls WillEvaluateScript() before executing the script so this would be a better place to install extension API bindings. Bug: 995134 Change-Id: I54d44391149225c5c52294bcca32a86705a9c0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775856 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#692997}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ia2580b68a951e0f96b9c3d1fcc6e4083528d6f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781298 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/086835f3ffbf..ce2adba679a3 git log 086835f3ffbf..ce2adba679a3 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 enga@chromium.org Fix parsing of DawnPerfTest --override-steps argument Created with: gclient setdep -r src/third_party/dawn@ce2adba679a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I82da0ecee0ab92977759472de8353f07162e9056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783745Reviewed-by:
-
Kayce Basques authored
Bug: 986998 Change-Id: Ic641ac9ffd4464ef79dbf6e20c133a46145793c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783399 Auto-Submit: Kayce Basques <kayce@google.com> Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#692994}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aeba7fa1fd36..6be3ea7a7d72 git log aeba7fa1fd36..6be3ea7a7d72 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 bungeman@google.com [pdf] Disable default width calculation. Created with: gclient setdep -r src/third_party/skia@6be3ea7a7d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I22403944dbe5a3c13f854823962d1c9fe3ffdcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783674Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I15d79cc3e9e8689486e8d7d164b00757b40032dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784097Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692992}
-
Fergus Dall authored
We currently have metrics for the installer, but no way to tell how many people are experiencing errors starting crostini after that. Bug: 977201 Change-Id: If828e4cefc10197ddc9dbdc5b867f68184975f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773999 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#692991}
-
Jeevan Shikaram authored
This is a reland of 2fd01309 Original change's description: > [App Management] Enable App Management by default. > > Enable App Management by default. Current entry points are about:settings > and about:app-management. > > Bug: 906508 > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659341} Bug: 906508 Change-Id: I08def499ce0c87ff44ac722b3bdcd8a238938959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782363 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#692990}
-
dalyk authored
Uses a hardcoded mapping to upgrade insecure DNS and DoT services to associated DoH services. The mapping is preliminary and will be adjusted before we run an experiment. Whether upgrade is attempted is controlled by the new kDnsOverHttpsUpgrade feature, which is enabled by default on ChromeOS, MacOS, Android, and Windows. Problematic providers can be excluded from the mapping using the kDnsOverHttpsUpgradeDisabledProvidersParam feature. Example usage: --enable-features="DnsOverHttpsUpgrade<DoHTrial" \ --force-fieldtrials="DoHTrial/Group1" --force-fieldtrial-params=\ "DoHTrial.Group1:DisabledProviders/Google" Bug: 985589 Change-Id: Ife81913bf5b7aade66cace1d3d8ad87d55b11ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638928 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#692989}
-
Jinsuk Kim authored
Favicon callbacks can be invoked after the navigation sheet is already closed. There is a null check against |mModelList| but it never becomes null. Its state should have been checked instead. This CL checks such case correctly. Bug: 1000220 Change-Id: I724b7c3a7d79e36a99d6c102849312e8010f2548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783680 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#692988}
-
Glen Robertson authored
Only implemented for extensions for now. Will be used in subsequent CL. Bug: 989792 Change-Id: I9d15f7c007ecdf655c060d858122a7b3b3ed768a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783679 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#692987}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I54ef7e914cc427136c9f43fc9ecbccf4c8985af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783998Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b56e61af91f..f4e32bb25503 Created with: gclient setdep -r src-internal@f4e32bb25503 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8d73466a5eae34c7572b2bbdf69295fb76b75817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783997Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 206ddf5d. Reason for revert: causes compile failure on android-archive-rel bot Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4265 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903288806742935296/+/steps/compile/0/stdout?format=raw --- lib.java/android_webview/support_library/callback/callback_java.jar lib.java/android_webview/glue/glue.jar lib.java/android_webview/support_library/support_lib_glue_java.jar lib.java/build/android/buildhooks/build_hooks_android_impl_java.jar ) In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizationpasses In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizations Item boolean org.chromium.base.library_loader.LibraryLoaderConfig.areTestsEnabled() was not discarded. boolean org.chromium.base.library_loader.LibraryLoaderConfig.areTestsEnabled() |- is invoked from: | void org.chromium.content.app.ContentChildProcessServiceDelegate.onConnectionSetup(android.os.Bundle,java.util.List) |- is reachable from: | org.chromium.content.app.ContentChildProcessServiceDelegate |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:29:1 Item boolean org.chromium.base.library_loader.LibraryLoaderConfig.useChromiumLinker() was not discarded. boolean org.chromium.base.library_loader.LibraryLoaderConfig.useChromiumLinker() |- is invoked from: | void org.chromium.content.app.ContentChildProcessServiceDelegate.onConnectionSetup(android.os.Bundle,java.util.List) |- is reachable from: | org.chromium.content.app.ContentChildProcessServiceDelegate |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:29:1 Error: Discard checks failed. Compilation failed --- Original change's description: > Reland: Android: Make Linker.java optimized out when use_chromium_linker=false > > This reverts commit f6e84797. > > Reason for reland: Removed -checkdiscards. > > TBR=agrieve # Trivial rename > > Change-Id: I8924fb2ef16ba1a1704e33634c45471c56d84e21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780955 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692947} TBR=agrieve@chromium.org,lizeb@chromium.org,smaier@chromium.org Change-Id: I99b31d3eb3ee630e5270fe9c9f747a9867d8e57e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784019Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#692984}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e576e759..6b931165 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5055c5db61e3fa9a7e0e981e595d2df0f2cb0b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783216Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692983}
-
Julie Jeongeun Kim authored
This CL converts BlobPtr from Write in native_file_system_file_writer.mojom and Register in blob_url_store.mojom and updates methods and members to implement them. Bug: 955171, 978694 Change-Id: If254a289988e7a7eb852988cb99a3a2e9a254e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757946Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#692982}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a9881e19baa..ac9e322afcdc git log 1a9881e19baa..ac9e322afcdc --date=short --no-merges --format='%ad %ae %s' 2019-09-04 lgoodby@google.com config: Remove hwtests from Jetstream release builders Created with: gclient setdep -r src/third_party/chromite@ac9e322afcdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I89f642de4d1e059b97c5e1c1bbb02273e78fe42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783675Reviewed-by:
-
Kurt Horimoto authored
This metric will help us understand how users interact with the non- modal dialog feature. Bug: 999356 Change-Id: I563be6a26d05c622828c33d57cc7966a847e094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776714 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692980}
-
Darwin Huang authored
Change-Id: I18866d9a69a846ebc5aed73200d643c386717d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776930 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#692979}
-
Gyuyoung Kim authored
This CL converts the old Mojo types to the new Mojo types in CppSideConnection class. Additionally, this CL needs to add EnableTestingMode to Receiver in order to continue calling EnableTestingMode after replacing mojo::Receiver. Lastly, js_side() is removed because nobody calls it. Bug: 955171, 978694 Change-Id: I17f7aa4cb2a83826902e3818c3c88008f46cb059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778892 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Simon Que authored
CI/Try migrated: - Win ASan Release - Win ASan Release Media Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I496c7e6a5c9d31733bdfdfda5178ff015768805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778900Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Timothy Loh authored
This CL reduces the code duplication for calling DBus methods in concierge_client.cc. Change-Id: Id5a9ca03f7faad049460f047c6f1ca63c2ea847f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778442Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692976}
-
Yutaka Hirano authored
This reverts commit a689aa50. Reason for revert: suspected to break content_unittests. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14863. Original change's description: > [scheduler] Relanding registering the task executor in TLS. > > I am attempting to reland > https://chromium-review.googlesource.com/c/chromium/src/+/1751251 > with a fix. The race condition which triggered the revert is test-only, > I have now marked it as benign and it shouldn't fail TSAN anymore. > > TBR=alexclarke@chromium.org,tedchoc@chromium.org > > Bug: 968047 > Change-Id: Iafbc31a80144371b22c0cd4ef6547c2ef2adfd62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781596 > Reviewed-by: Karolina Soltys <ksolt@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Karolina Soltys <ksolt@chromium.org> > Auto-Submit: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692708} TBR=tedchoc@chromium.org,alexclarke@chromium.org,ksolt@chromium.org Change-Id: I3c65ae5ae5ff3e8ecf3f990bb4464d3c6cab34ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784017Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#692975}
-
Kurt Horimoto authored
activity_services::RetrieveCanonicalUrl() is used to fetch the URL to add a page to the reading list, but this function requires JavaScript execution, which is paused while JavaScript dialogs are presented. This CL disables the "Read Later" button in the popup menu while overlay UI is displayed in OverlayModality::kWebContentArea. Bug: 986760 Change-Id: I6fef342a740846fe849ed38d8f25ec90228cc54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752288 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#692974}
-
Manu Cornet authored
The issue was that we were calculating centering coordinates according to the whole screen rather than each individual display. Add a test for this. This change also fixes a bug in ash/screen_util where the shelf bounds were not returned in terms of the whole screen's coordinates. A few unit tests in ash/wm also needed fixing in that sense. Bug: 997768 Change-Id: I91ab6ef2f85601edc115743dd0ab0ae83076be94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773891 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Andrew Grieve authored
And also rename to "waitForFirst()" to distinguish them. This should remove a source of flakes in tests. The bug is that code looked like this: CallbackHelper helper = new CallbackHelper(); someAsyncStuff(helper); helper.waitForCallback(); But if someAsyncStuff() happened before waitForCallback(), then waitForCallback() would wait forever since it was setting currentCallCount=getCallCount(). The only way the waitForCallback() methods make sense when not given an explicit "currentCallCount" parameter, is to assume currentCallCount==0. Bug: 1000510 Change-Id: Ife495efda5cac6e826e8ee184245026af5ba8a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777023 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692972}
-
Naoki Fukino authored
Enabling the flag allows per-device setting for external storage in Settings > Device > Storage management > External storage preferences. Bug: 954228 Change-Id: I4fa197d768df02a76375c9a101bcde691a1db004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782207Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#692971}
-
Yulun Wu authored
Bug: 999376 Change-Id: Ib47b1e86a147a0292ba0a0f11dfa2983de8da562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776856Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/feb8507f4b52..c3f7873b9a3a git log feb8507f4b52..c3f7873b9a3a --date=short --no-merges --format='%ad %ae %s' 2019-09-03 lujc@google.com Use TransformFeedbackID in place of GLuint handle Created with: gclient setdep -r src/third_party/angle@c3f7873b9a3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I7c8f9a8bd4296501aa23128fd17ae4eb4e12f9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783671Reviewed-by:
-
Miyoung Shin authored
This CL converts WakeLockObserverPtr and WakeLockObserverRequest in chromeos and services to the new Mojo types, and uses pending_remote<WakeLockObserver> in wake_lock_provider.mojom. Bug: 955171 Change-Id: I64737987808d286ae0c15ab50f2250f7cd503ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771225Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#692968}
-
