GitLab

(in the top level Autofill Preferences page)

BUG=461006

Review URL: https://codereview.chromium.org/952613003

Cr-Commit-Position: refs/heads/master@{#318828}

Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.

BUG=334090
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/966433003

Cr-Commit-Position: refs/heads/master@{#318827}

Introduced in https://codereview.chromium.org/938873002/

R=piman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/967343003

Cr-Commit-Position: refs/heads/master@{#318826}

chrome.management.uninstall.

R=rdevlin.cronin@chromium.org
BUG=463003

Review URL: https://codereview.chromium.org/971993002

Cr-Commit-Position: refs/heads/master@{#318825}

This is a follow-up to https://codereview.chromium.org/874283006
which introduces the cr-network-icon Polymer element for
displaying an icon representing network state in web UI.

It also includes minor changes to the fake shill implementation to facilitate manual testing.

BUG=455499

Review URL: https://codereview.chromium.org/954293003

Cr-Commit-Position: refs/heads/master@{#318824}

This is part 1 (chromium),
part 2 (clank) is https://chrome-internal-review.googlesource.com/#/c/195455/

This CL is only about propagation/plumbing.
Neither the reporting of audible state my players nor the consumption
(UI notification) are implemented.

This patch creates a new object AudioMonitorAndroid and
attaches it to MediaWebContentsObserver. The AudioMonitorAndroid
maintains the audible state for the tab. It receives notifications
from MediaPlayerAndroid objects and sends the resulting
notification to the WebContents.

BUG=414810

Review URL: https://codereview.chromium.org/896673003

Cr-Commit-Position: refs/heads/master@{#318823}

The cl does 4 things:
(1) Adds a list (in gyp) for the feedback_consent js files.
(2) Uses build-html.py to build feedback_consent.html from a template.
(3) Adds an action to run jscompile over the feedback_consent js files.
(4) Fixes the errors/warnings reported by jscompile.

BUG=

Review URL: https://codereview.chromium.org/964403004

Cr-Commit-Position: refs/heads/master@{#318822}

(Views only for now.)

BUG=463291

Review URL: https://codereview.chromium.org/969223002

Cr-Commit-Position: refs/heads/master@{#318821}

R= bradnelson@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/971493004

Cr-Commit-Position: refs/heads/master@{#318820}

BUG=463132

Review URL: https://codereview.chromium.org/969133002

Cr-Commit-Position: refs/heads/master@{#318819}

BUG=273710

Review URL: https://codereview.chromium.org/959123004

Cr-Commit-Position: refs/heads/master@{#318818}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3a0ba1e..fcd7003

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/967313005

Cr-Commit-Position: refs/heads/master@{#318817}

As the TODO in power_api_manager.h by derat@,
move PowerApiManager to power_api and rename to PowerAPI.

BUG=
R=derat@chromium.org

Review URL: https://codereview.chromium.org/958313002

Cr-Commit-Position: refs/heads/master@{#318816}

Similarly GbmWrapper to GbmDevice. This was done to better reflect their
role.

BUG=none

Review URL: https://codereview.chromium.org/908993003

Cr-Commit-Position: refs/heads/master@{#318815}

This CL causes the app list tab navigation to correctly cycle to and from
the custom launcher page. This has been fixed by adding a SearchBoxFocusHost
which directs the focus search to the search box.

BUG=462079

Review URL: https://codereview.chromium.org/960133005

Cr-Commit-Position: refs/heads/master@{#318814}

The #if around NativeWebContentsModalDialog is a problem for building
the MacViews browser. Unify them to be gfx::NativeWindow on all platforms.
Refactor the cocoa side to move code from ConstrainedWindowMac into
SingleWebContentsDialogManagerCocoa, while keeping
ConstrainedWindowMac's interface the same as before.
The Views side only needs simple changes from NativeView to NativeWindow.

BUG=425229

Review URL: https://codereview.chromium.org/866263008

Cr-Commit-Position: refs/heads/master@{#318813}

Use INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT instead of
INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT as the
final component to calculate input latency.

This will more accurately reflect latency regressions in the
code we have direct control of in Chrome.

Also make PassThroughImageTransportSurface::PostSubBuffer
add a INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT, which it
was missing before.

Followup patches will snap
INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT
to the next vsync to reflect the real display time.

The real display time can then be used for better
smoothness metrics and also to track latency regressions
at the OS/driver level for Ozone and potentially other
platforms where we can extract swap info.

BUG=360844

Review URL: https://codereview.chromium.org/918883002

Cr-Commit-Position: refs/heads/master@{#318812}

BUG=463184

Review URL: https://codereview.chromium.org/969063002

Cr-Commit-Position: refs/heads/master@{#318811}

Revert of Refactoring: de-couple Extensions from "script injection System" [render side]:2 (patchset #8 id:350001 of https://codereview.chromium.org/906493004/)

Reason for revert:
broke the extension tests:

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10543

Original issue's description:
> This CL adds routing info for content scripts from <webview>.
>
> To support dynamically added/removed content scripts in <webview>, we store
> these content scripts in the same shared memory where user scripts from
> declarative content API are stored, but the decision for injection will
> be made in the render once the url pattern is matched. Since render doesn't
> need to send IPCs to ask a decision from browser, it makes a precise time
> injection possible.
>
> Special to <webview>, once the content scripts are updated (added/removed),
> browser will only notify the render process of the given <webview>, rather than
> all of the renders (which is the case for user scripts).
>
> BUG=437566
>
> Committed: https://crrev.com/f853287c95cf818d0b5b02d7f4a6588761096d1c
> Cr-Commit-Position: refs/heads/master@{#318774}

TBR=rdevlin.cronin@chromium.org,fsamuel@chromium.org,hanxi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566

Review URL: https://codereview.chromium.org/972863002

Cr-Commit-Position: refs/heads/master@{#318810}

See: https://codereview.chromium.org/935243002

R=erickung@chromium.org,lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/976473002

Cr-Commit-Position: refs/heads/master@{#318809}

The recent patch crrev.com/895933007 introduced a regression by using size_t
for offsets, which on 32bit builds is sizeof(size_t) = 4 which was causing
broken offset values due to assigning a uint64_t variable to such variables.

This CL fixes that by simply converting the types to uint64_t.

TEST=*FileSystemProvider*BigFile* on a 32 bit build Chromium build with
    chromeos=1.
BUG=375297, 458122

Review URL: https://codereview.chromium.org/959113002

Cr-Commit-Position: refs/heads/master@{#318808}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b421650..7ab4277

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/973603003

Cr-Commit-Position: refs/heads/master@{#318807}

BUG=454789

Review URL: https://codereview.chromium.org/957353003

Cr-Commit-Position: refs/heads/master@{#318806}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b517bea..3a0ba1e

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/973613002

Cr-Commit-Position: refs/heads/master@{#318805}

This adds the recipient name to the server profile database. This was added to the schema since the original check-in.

Review URL: https://codereview.chromium.org/949563003

Cr-Commit-Position: refs/heads/master@{#318804}

Remove deprecated extension notification from ExtensionHost.
Use ExtensionRegistryObserver instead.

BUG=411568

Review URL: https://codereview.chromium.org/964193002

Cr-Commit-Position: refs/heads/master@{#318803}

This forces the compositor to use textures and allows us to verify the
texture upload path is working, instead of just testing solid color
layers work.

R=sadrul

Review URL: https://codereview.chromium.org/963303003

Cr-Commit-Position: refs/heads/master@{#318802}

Ozone includes the internal keyboard in the actice keyboard devices
even if the TV mode disables it due to the fact that the volume keys
can still be pressed. We now explicitly check the state of maximized
mode when deciding to show the keyboard.

TEST=VirtualKeyboardControllerAutoTest.EnabledDuringMaximizeMode, VirtualKeyboardControllerAutoTest.SuppressedInMaximizedMode
BUG=462666

Review URL: https://codereview.chromium.org/970983003

Cr-Commit-Position: refs/heads/master@{#318801}

This doesn't do anything on linux. On windows it means the task may
perform a "long wait", which also doesn't apply here. Opening a device
is fast.

BUG=none
TEST=boot link_freon & type on the keyboard. input still works :)

Review URL: https://codereview.chromium.org/972803002

Cr-Commit-Position: refs/heads/master@{#318800}

BUG=463265
NOTRY=true

Review URL: https://codereview.chromium.org/973653002

Cr-Commit-Position: refs/heads/master@{#318799}

(Attempt #2, after a speculative revert from a flaky test.)

BUG=461494
TEST=Crash report should show that --site-per-process flag is present.

Review URL: https://codereview.chromium.org/972773003

Cr-Commit-Position: refs/heads/master@{#318798}

Also introduce a build number in the package name, stop versioning
the Blink GC plugin, and remove repackage.sh.

BUG=444089
TBR=jln, jbauman
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/975503002

Cr-Commit-Position: refs/heads/master@{#318797}

BUG=463261
TBR=enne@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/971953002

Cr-Commit-Position: refs/heads/master@{#318796}

This flag was used to disable linking when the bots were too behind. It's not needed any more.

Review URL: https://codereview.chromium.org/974543002

Cr-Commit-Position: refs/heads/master@{#318795}

These methods were introduced before Promises were implemented to simplify
code that just needs an email address but wouldn't otherwise need to be
written asynchronously. With Promises, asynchronous code reads a lot more
naturally, and it's less of a concern.

Having explicit accessors for cached state means that there needs to be
some (asynchronous) initialization code to save them, which complicates
some of the changes I'm planning on making to application start-up. The
simplest fix is eliminate them altogether and make all the call-sites
asynchronous.

Review URL: https://codereview.chromium.org/963103004

Cr-Commit-Position: refs/heads/master@{#318794}

BUG=459877

Review URL: https://codereview.chromium.org/935193003

Cr-Commit-Position: refs/heads/master@{#318793}

This CL makes the RenderFrameHostChanged observer method behave consistently and as described in the WebContentsObserver header file.

BUG=450799

Review URL: https://codereview.chromium.org/950223006

Cr-Commit-Position: refs/heads/master@{#318792}

R= bradnelson@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/971043002

Cr-Commit-Position: refs/heads/master@{#318791}

When the status bubble is in state kBubbleHidden, its width is now always 1pt.
This prevents us from wasting time resizing and redrawing a hidden bubble.

BUG=454502
TEST=No visible impact.  Status bubble should continue to show when hovering over links and resize properly when the window size is changed.

Review URL: https://codereview.chromium.org/895713002

Cr-Commit-Position: refs/heads/master@{#318790}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/281bf52..b421650

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/967403003

Cr-Commit-Position: refs/heads/master@{#318789}