GitLab

Remove the code in sync/ that checks if the device is a tablet
and perform the check in the chrome/ layer based upon a
command line switch.

Additionally, rather than looking for a tablet when (not) setting
the Mobile specific user agent, look for --use-mobile-user-agent. The
embedder should set these command line switches as appropriate, so
remove the code that used to set them in the generic process startup.


Review URL: https://chromiumcodereview.appspot.com/10808052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148091 0039d316-1c4b-4281-b951-d872f2087c98

WebFrame::loadData accepts HTML that is wrapped into a 'data:' scheme URL
and two URLs: the base URL is used for resolving relative URLs in the HTML,
the history URL is put into the navigation history.

WebKit has all the required support for this method. What is required is
to pass base and history URLs from RVH to WebKit's WebFrame. Also, as
Chromium contains additional security checks when loading page resources,
we need to add the base URL into the list of request URLs for the security
policy.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10544175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148090 0039d316-1c4b-4281-b951-d872f2087c98

Update the image for 2x which only had 4 icons
Show mute icon when volume is 0 (+ some simplification)

BUG=122992,137763
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10781021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148089 0039d316-1c4b-4281-b951-d872f2087c98

R=oshima@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10807065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148088 0039d316-1c4b-4281-b951-d872f2087c98

Since some iOS devices are single-core, a busy loop on one thread can
starve the thread that the test is waiting for to finish.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10810061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148087 0039d316-1c4b-4281-b951-d872f2087c98

It's used in addition to frame ids to identify frames correctly.

Also expose the processId via webNavigation.getFrame and getAllFrames

BUG=136090
TEST=ExtensionApiTest.WebNavigationGetFrame

Review URL: https://chromiumcodereview.appspot.com/10805066

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10808097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no additional exit time dtors

Review URL: https://chromiumcodereview.appspot.com/10806084

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10818024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148085 0039d316-1c4b-4281-b951-d872f2087c98

The #endif comments were missed in the original CL.

TBR=
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10795086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138400
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10808071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108999
TEST=Nothing breaks


Review URL: https://chromiumcodereview.appspot.com/10805057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148082 0039d316-1c4b-4281-b951-d872f2087c98

On OS X, CFBundleVersion is used by LaunchServices, and must follow
specific formatting rules, so the four-part Chrome version is in
CFBundleShortVersionString. On iOS, however, CFBundleVersion can be the
full version, but CFBundleShortVersionString has a policy-enfoced limit
of three version components.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10809059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148081 0039d316-1c4b-4281-b951-d872f2087c98

Since iOS is a very memory-limited environment, a very large stack
isn't desireable.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10796098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148080 0039d316-1c4b-4281-b951-d872f2087c98

Now it monitors mouse/touch/gesture events and hides the tooltip if necessary.

BUG=137678
TEST=manually verified && aura_shell_unittests passed


Review URL: https://chromiumcodereview.appspot.com/10810011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148079 0039d316-1c4b-4281-b951-d872f2087c98

HttpResponseHeaders::RemoveHeaderWithValue did not correctly remove headers if the passed value contained a comma. For a header "Foo: bar, baz", RemoveHeaderWithValue("Foo", "bar, baz") would be be a non-op. This CL fixes that. As the web request API is the only consumer of this function, there will be no side effects on other code due to the changed behavior.

BUG=137396
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10809011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no additional exit time dtors

Review URL: https://chromiumcodereview.appspot.com/10806084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148077 0039d316-1c4b-4281-b951-d872f2087c98

Suppress races in browser_sync::NewNonFrontendDataTypeControllerMock::RecordUnrecoverableError (issue 138691)

BUG=138691,138693
TBR=zhaoqin
Review URL: https://chromiumcodereview.appspot.com/10810067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148076 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148075 0039d316-1c4b-4281-b951-d872f2087c98

It's used in addition to frame ids to identify frames correctly.

Also expose the processId via webNavigation.getFrame and getAllFrames

BUG=136090
TEST=ExtensionApiTest.WebNavigationGetFrame

Review URL: https://chromiumcodereview.appspot.com/10805066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148074 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10790139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148073 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that a CXXRecordDecl can change between the call to
HandleTagDeclDefinition and HandleTopLevelDecl. This happens in the
case of nested class declarations, causing us to fail to emit warnings
in some cases (see the test). See crbug.com/136863 for the full discussion.

BUG=136863
TEST=tools/clang/plugins/tests/test.sh


Review URL: https://chromiumcodereview.appspot.com/10808078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126947
TEST=chromeos_unittests and try bots

Review URL: https://chromiumcodereview.appspot.com/10806028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148068 0039d316-1c4b-4281-b951-d872f2087c98

ANDROID_SDK_HOME is set in build/android/envsetup.sh, so android will
try to search for AVDs in that folder when running tests.

If not set this variable in this script, the AVDs created with this script
are invisible for the tests.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10782024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:32338
TEST=unit tests. Manual testing can be done by setting the new policy in a DM server to true and verifying that external storage is not mount and shown in the file manager in Chrome.


Review URL: https://chromiumcodereview.appspot.com/10697097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148065 0039d316-1c4b-4281-b951-d872f2087c98

Many tests are failed due to sqlite errors on Android.
The reason is that sqlite need a temporary directory to
store internal temporary files. However, Android doesn't
have this kind of directory while Linux has /var/tmp.

To fix this, use in-memory temporary files. It also includes:
1) Add one unit test in sql unittests to reproduce this
issue for Android.
2) Remove those disabled cases for content unitests on
Android.

BUG=
TEST=run_tests.py -s sql_unittests; run_test.py -s net_unittests


Review URL: https://chromiumcodereview.appspot.com/10809015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests --gtest_filter="GData*"


Review URL: https://chromiumcodereview.appspot.com/10790135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148063 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=135535
TEST=manually checked the behavior by keep pressing Ctrl-F5 on lumpy


Review URL: https://chromiumcodereview.appspot.com/10802046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129799
TEST=Manual + autotests


Review URL: https://chromiumcodereview.appspot.com/10808061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148061 0039d316-1c4b-4281-b951-d872f2087c98

This breaks the NaCL compiler, as the addition the base.gypi results in a too long command line. For the sake of getting the tree green, I'm reverting this, although the NaCL compiler is really to blame

Review URL: https://chromiumcodereview.appspot.com/10796047

TBR=kaiwang@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10807083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148060 0039d316-1c4b-4281-b951-d872f2087c98

The change to use these in the omnibar is coming soon.

TBR=sky@chromium.org

BUG=129598
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10817024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148059 0039d316-1c4b-4281-b951-d872f2087c98

    
Fix ScopedVector API to follow this style.
    
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variable_Names#Variable_Names

BUG=136196
R=willchan@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10796028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148057 0039d316-1c4b-4281-b951-d872f2087c98

* Update the display bounds correctly in |Fix coordinates for minimize animation|. Update the test so that it will fail with original code, and removed the debugging message that was checked in by mistake.
* Update the display layout after the secondary display is initialized on startup.
* Fix comment in Display.h. It was probably cut&paste error.

BUG=123160
TEST=Updated MultiDisplayTest::NativeDisplayTest

Review URL: https://chromiumcodereview.appspot.com/10795080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148056 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10796047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110823
TEST=included

Review URL: https://chromiumcodereview.appspot.com/10808093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146954

Review URL: https://chromiumcodereview.appspot.com/10779008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148053 0039d316-1c4b-4281-b951-d872f2087c98

This CL reverts r144508 because the crash no longer happens.

BUG=134507
TEST=none.

Review URL: https://chromiumcodereview.appspot.com/10808063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148052 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=136944
TEST=No animation of the promo text when opening an NTP.

Review URL: https://chromiumcodereview.appspot.com/10689164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148051 0039d316-1c4b-4281-b951-d872f2087c98

This change disables PageCyclerCachedBrowserTest.PlaybackMode and PageCyclerCachedBrowserTest.URLNotInCache also on Mac debug bots.

TBR=rdevlin.cronin@chromium.org
BUG=131333
TEST=make the "Mac 10.6 Tests (dbg)(1)" bot green.
Review URL: https://chromiumcodereview.appspot.com/10796105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148048 0039d316-1c4b-4281-b951-d872f2087c98

*) Set min-width to prevent broken layout in narrow windows.
*) Reduce spacing to 8px.
*) Add border-radius to preview image.


BUG=138599
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10805079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148044 0039d316-1c4b-4281-b951-d872f2087c98

Depends on http://codereview.chromium.org/10700007/

BUG=133094
TEST=Use browserAction.disable/enable(tabid), observe that the browser action becomes grayed out.

Review URL: https://chromiumcodereview.appspot.com/10789026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148043 0039d316-1c4b-4281-b951-d872f2087c98