Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 24 Oct, 2020 31 commits
  3. 23 Oct, 2020 9 commits
    • Jesse Schettler's avatar
      scanning: Add dropdown for page size · 5ab38ebd
      Jesse Schettler authored 
      Add a new Polymer element, page-size-select, to display the page sizes
in a dropdown.

Bug: 1059779
Change-Id: Ia546795ab44e350adbf8256867e7e5fccb42dc02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492944Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarJimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820494}
      5ab38ebd
    • David Van Cleve's avatar
      Android: Document unit test runner incompatibility with recent versions · 44e5cb58
      David Van Cleve authored 
      Android unit tests don't work on Android R+, but this isn't mentioned
in the docs, and the error message is pretty arcane and hard to
understand. This change updates the docs to mention this problem.

Bug: 1094062
Change-Id: I77b196febde1009eb13b195be937243e96ace1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495968
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820493}
      44e5cb58
    • Scott Violet's avatar
      Revert "indexeddb: defer journal cleanup in CommitPhaseTwo" · a4867eda
      Scott Violet authored 
      This reverts commit 715577e4.

Reason for revert: This caused compile failure:
https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/97365?
[8734/14809] CXX obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o
FAILED: obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o
/b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long)
../../content/browser/indexed_db/indexed_db_backing_store_unittest.cc:924:20: error: no member named 'SetExecuteJournalCleaningOnNoTransactionsForTesting' in 'content::indexed_db_backing_store_unittest::TestableIndexedDBBackingStore'
backing_store()->SetExecuteJournalCleaningOnNoTransactionsForTesting();
~~~~~~~~~~~~~~~  ^
1 error generated.

Original change's description:
> indexeddb: defer journal cleanup in CommitPhaseTwo
>
> Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo
> calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs
> in the recovery journal (under some conditions).  Unfortunately, it
> doesn't remove the blobs that were just written in that transaction from
> the recovery journal prior to calling DidCommitTransaction.
>
> This patch rearranges the calls so that DidCommitTransaction is always
> called in CommitPhaseTwo, but only after the journal has been updated.
>
> Bug: 1131151
> Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872
> Commit-Queue: enne <enne@chromium.org>
> Auto-Submit: enne <enne@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820486}

TBR=mek@chromium.org,enne@chromium.org

Change-Id: Id3876068e31e91817ff7c396f024cf159b3c1dfe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496035Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820492}
      a4867eda
    • Tomasz Wiszkowski's avatar
      Extract MostVisited from ZeroSuggestProvider. · 66c9d659
      Tomasz Wiszkowski authored 
      This change splits the ZeroSuggestProvider into
- ZeroSuggestProvider serving the Search suggestions and
- ZeroSuggestMostVisitedSitesProvider, serving the MostVisited
  suggestions.

The Most Visited Sites are served specifically on mobile devices
and are therefore wired specifically for iOS and Android.
This change enables MostVisited suggestions to be served
alongside the zero-prefix REMOTE_SEND_URL suggestions.

Bug: 1106109
Change-Id: I1053f5dfcd539e056d8443e31294c00bb0145588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488982
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820491}
      66c9d659
    • Michael Irani's avatar
      ChromeVox focus not properly shown when navigating: Apps page · 4e63842d
      Michael Irani authored 
      If you navigate to "Apps" page and then to an application,
and then hit the back button the focus does not highlight the
application that was chosen when in ChromeVox mode.

Steps (in ChromeVox mode):
1. Apps
2. Chrome
3. Back button

Bug: 1029954
Test: Manual
Change-Id: I8c54f7fb88379392ebfc373f209b9386a84a345e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493826
Commit-Queue: Michael Irani <michaelirani@chromium.org>
Auto-Submit: Michael Irani <michaelirani@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820490}
      4e63842d
    • Scott Violet's avatar
      Revert "Reland "Adds parental handoff login screen in oobe."" · 21560195
      Scott Violet authored 
      This reverts commit 27e795c1.

Reason for revert: Sorry for another revert, but this is still causing flake. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9353 . Specifically:
../../content/public/test/browser_test_base.cc:702: Failure
Failed
RunLoop::Run() timed out.
Stack trace:
#0 0x56324b6c5e50 base::internal::Invoker<>::Run()
#1 0x56324b623b4f base::(anonymous namespace)::OnRunLoopTimeout()
#2 0x56324b6249e3 base::internal::Invoker<>::RunOnce()
#3 0x5632492266ab base::internal::CancelableCallbackImpl<>::ForwardOnce<>()
#4 0x56324b63bc46 base::TaskAnnotator::RunTask()
#5 0x56324b64c845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#6 0x56324b64c588 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#7 0x56324b69fb29 base::MessagePumpLibevent::Run()
#8 0x56324b64cf9a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#9 0x56324b62363e base::RunLoop::Run()
#10 0x5632483f1f23 chromeos::EduCoexistenceLoginBrowserTest::WaitForScreenExit()
#11 0x563248402206 chromeos::ParentalHandoffScreenBrowserTest_RegularUserLogin_Test::RunTestOnMainThread()
#12 0x56324bae8dd1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#13 0x56324b6fff04 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#14 0x56324b6ff3b9 ChromeBrowserMainParts::PreMainMessageLoopRun()
#15 0x563248bf574e chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#16 0x563249bdf3b0 content::BrowserMainLoop::PreMainMessageLoopRun()
#17 0x563249f3668a content::StartupTaskRunner::RunAllTasksNow()
#18 0x563249bde45b content::BrowserMainLoop::CreateStartupTasks()
#19 0x563249be0bba content::BrowserMainRunnerImpl::Initialize()
#20 0x563249bdcbd2 content::BrowserMain()
#21 0x56324b198740 content::RunBrowserProcessMain()
#22 0x56324b1995d1 content::ContentMainRunnerImpl::RunServiceManager()
#23 0x56324b199234 content::ContentMainRunnerImpl::Run()
#24 0x56324a5c8687 content::RunContentProcess()
#25 0x56324a5c8c16 content::ContentMain()
#26 0x56324bae8a00 content::BrowserTestBase::SetUp()
#27 0x56324b5d8620 InProcessBrowserTest::SetUp()

Original change's description:
> Reland "Adds parental handoff login screen in oobe."
>
> This is a reland of dca1afe8
>
> This is an interesting failure point due to the difference between
> official builds and non official builds. In official builds, the
> Sync Consent screen is shown and it will not exit until we interact
> with it. The waiters timeout waiting for the Parental Handoff Screen
> to be shown.
>
> Original change's description:
>
> > Adds parental handoff login screen in oobe.
> >
> > The description and mock can be seen in the comments in the bug report.
> >
> > Bug: 1134567
> > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618
> > Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> > Reviewed-by: Aga Wronska <agawronska@chromium.org>
> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > Reviewed-by: Jesse Doherty <jwd@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819158}
>
> Bug: 1134567
> Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756
> Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820388}

TBR=jwd@chromium.org,rsorokin@chromium.org,agawronska@chromium.org,yilkal@chromium.org

Change-Id: I6febf7f06a0d5d7a072be1e50aaa9cc2a4d3c217
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495423Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820489}
      21560195
    • Sharon Yang's avatar
      [fuchsia] Handle receiving multiple accessibility trees · cbfdc1e3
      Sharon Yang authored 
      A WebContentsObserver may receive updates from multiple AXTrees.
Currently, that isn't supported, so add a fix that ignores updates that
aren't from the first tree that the WebContentsObserver receives.

Test: AccessibilityBridgeTest.MultipleAXTrees
Bug: 1136541
Change-Id: If1fb3de647c150c58bc07b55477452f91abfcef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469470
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820488}
      cbfdc1e3
    • Zentaro Kavanagh's avatar
      Diagnostics: Add test routines to CPU card · 28198c08
      Zentaro Kavanagh authored 
      - Does not run tests yet

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Idbe2de1c4f4f3100b36a49947a3e6ded79ba2eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469448
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820487}
      28198c08
    • Adrienne Walker's avatar
      indexeddb: defer journal cleanup in CommitPhaseTwo · 715577e4
      Adrienne Walker authored 
      Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo
calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs
in the recovery journal (under some conditions).  Unfortunately, it
doesn't remove the blobs that were just written in that transaction from
the recovery journal prior to calling DidCommitTransaction.

This patch rearranges the calls so that DidCommitTransaction is always
called in CommitPhaseTwo, but only after the journal has been updated.

Bug: 1131151
Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820486}
      715577e4