GitLab

The function is used in a very few cases and is equivalent of ==.

Bug: 1033903
Change-Id: I8339ac5a43005759c19616684eb04829afe6f551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218089Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776044}

This CL migrates to vector icon for the show password icon
and adds proper support for dark mode.

Icons are slightly different, but, this is a change in the right
direction.
Pixel test output
pre-Butter:
https://chrome-gold.skia.org/detail?test=BrowserUiDialog_All_PasswordBubbleBrowserTest_InvokeUi_PendingPasswordBubble_0__windows&digest=48c9f80c9c4a11172a598cd9d392add4&issue=2235512
After-Butter:
https://chrome-gold.skia.org/detail?test=BrowserUiDialog_All_PasswordBubbleBrowserTest_InvokeUi_PendingPasswordBubble_1__windows&digest=48c9f80c9c4a11172a598cd9d392add4&issue=2235512


Screenshots:
Light Mode Hidden: https://screenshot.googleplex.com/vZyG8WZWPVX
Light Mode Shown: https://screenshot.googleplex.com/34Y11w12Qrg
Dark Mode Hidden: https://screenshot.googleplex.com/x4Z5yf68kaY
Dark Mode Shown: https://screenshot.googleplex.com/Q6wXbUPpEjS

Bug: 1091842,1044038
Change-Id: Id123d79d5f8c927219413abd33dab44e5ee531b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235512Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776043}

Handle focusing cr-input in oobe-dialog, and add utility method to
add default action when 'Enter' is pressed when user enters data.

Bug: 981472
Change-Id: I24af81d0aced7394ecd1a579068833fe8fe7cf7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235693
Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776042}

This CL adds sign-in/sign-out methods to AccountManagerTestRule and
replaces SigninTestUtils usage in ChromeBrowserTestRule with
AccountManagerTestRule.

Bug: 1085034
Change-Id: I482061fd46728e50330f9d0afb2597d9411fd676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231041Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776041}

When computing the MaxContentForChild size for the tracks by the
IndefiniteStrategy we were not considering the baseline shim, since we
assumed it was enough to do it for the MinContentSize.

However, there are possible definitions of the grid track that cause
the MinContentForChild function to not be called, leading to an
incorrect intrinsic size for the grid.

Bug: 1091944
Change-Id: I91a35852dd044ded0fc14f03e97d3e140d80ba12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233239Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776040}

MetricsWebContentsObservers should be created through the
|CreateForWebContents| factory function. Hiding the constructor ensures
callers can't accidentally skip initialization handled by the factory
function.

Change-Id: I332aa234c7a307d80d8793ed4ebb4d2efb987448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233411Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776039}

https://skia.googlesource.com/skia.git/+log/f9ffdd6942f9..6e659e960945

2020-06-08 nifong@google.com Add a gm for ManagedAnimation.setColor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: Idf3fe02a606f4d44bf530e69f52d400da8a5f213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776038}

The UI is implemented in a separate delegate class, to make testing
easier.

Bug: 1076880
Change-Id: Iff148c5b5b4b88b3c4fa926af07548b2fca50856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231045
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776037}

-UIViewController.modalPresentationStyle needs to be set before
accessing UIViewController.presentationController.
Bug introduced with crrev.com/i/2199465 when the presentation controller
delegate has been set.

Before:
https://drive.google.com/file/d/1rjwVvABB6VlrhvOhBfisLhIsgLj-_QET/view?usp=sharing
After:
https://drive.google.com/file/d/1U0-ww3gydS1bccVqwQHaoImj1lJPqpCH/view?usp=sharing

Fixed: 1084968
Change-Id: Ibeaaca60105f677bc192eb4be5833bf28abc04f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235812
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776036}

This CL adds a Signin.Extensions.GetAuthTokenResult histogram that
records the result of chrome.identity.getAuthToken() call.

I modified the error handling in IdenityGetAuthTokenFunction class to
report an IdentityGetAuthError object instead of a string. This object
is then converted to an enum for the histogram recording and to a string
for returning to the the extension.

Some error strings got mapped to several error codes so we can uniquely
identity a code path that returned an error.

Bug: 1091423
Change-Id: I4ab1116305a0aa3777d829b002165b4c4c1a2cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234752
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776035}

Migrate the legacy IPC message DragMsg_TargetDragLeave to the
TargetDragLeave Mojo message in blink.mojom.FrameWidget.

Bug: 1039255
Change-Id: If7974b94d7d32e8b764eee9eea6797a31ba053b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195244Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776034}

Will enable me to see any changes that are relevant for WebLayer's
fork of this code.

Bug: 1025620
Change-Id: I21fb901924255932124979b714e7590697d9368f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232864Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776033}

Bug: 1018157
Change-Id: I6121544c9f0bac1ef9f6ec2f7479d09596c38dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219461
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776032}

Bug: 1069036
Change-Id: Ibadd664260b9e2eb7b38ce1fde78ad6715748093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233194
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776031}

Fix the spurious crash in the policy_fuzzer caused by missing ICU
initialization.

The ICU functionality is used by one of the fuzzer policy handlers.

Bug: 1092058
Change-Id: Ic93a61e9d4f9b7cc51d464582e7a42e262442152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232943Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776030}

Bug: 1018157
Change-Id: I4b5bd3e4d5d917ad4798b105db308b8c04b4aac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217851
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776029}

Example trace spending 1.5s handling native events : https://snipboard.io/onXdYE.jpg
Full trace : http://goto.google.com/memlog/trace?reportid=bf8612d8125a1b99

The goal of this CL is to have sub-trace-events under the toplevel
ProcessMessageHelper event.

R=robliao@chromium.org, sky@chromium.org

Bug: 899897
Change-Id: I2f14e6d2da355f7d484da99889e281c08ecd4842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229611Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776028}

https://chromium.googlesource.com/angle/angle.git/+log/38e96a12f183..3e1a57b83a52

2020-06-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 74130f2d3ab1 to 7c213720bb46 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I1dd531e01ca7744c006d23f3a3ea7f7e0495df11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776027}

Bug: 1088462
Change-Id: I7ed01ac5022a6f2c32c0ca43f11678c69c395035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231698Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776026}

This duplicates the applicable eval test cases for the Function
constructor, which has mostly but not entirely the same behaviour.

Bug: 1087743
Change-Id: I82fe44050edf6fe696216045e1dd78b77240e61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231098Reviewed-by: Yifan Luo <lyf@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776025}

Have seen (and can no longer find) traces where work was happening
inside of WaitForWork()'s PeekMessage.

R=fdoray@chromium.org

Bug: 1078836
Change-Id: Ic9be2202ac2f692f79dcc75a5e20a55e69a9fc9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229587Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776024}

This CL tunes the flinging behavior of the player to feel more normal.
Near the start/end of the page the old implementation would lag. The
friction also felt too-high compared to a Tab.

Bug: 1092406
Change-Id: I1aa606d8a75da4df091d97889b3e2da8226e76d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218558
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776023}

This reverts commit be32a5a1.

Reason for revert:
* Downstream target renamed.
* Perf tryjob shows issue is fixed.
* No changes from original.

Original change's description:
> Revert "Add resource_sizes targets for webview bundle & trichrome"
>
> This reverts commit 7a07674d.
>
> Reason for revert: Causing build errors on perf waterfall (crbug.com/1091991)
>
> Original change's description:
> > Add resource_sizes targets for webview bundle & trichrome
> >
> > Bug: 1091256
> > Change-Id: I244afe4d9735901937b39c0d0c554eddaf88eace
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230493
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#775727}
>
> TBR=torne@chromium.org,agrieve@chromium.org,benmason@chromium.org
>
> Change-Id: Id9ac2e4f9ec7fc9eb0c2b3a6761ca2a822d8b242
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1091256, 1091991
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233860
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775803}

TBR=torne@chromium.org,agrieve@chromium.org,johnchen@chromium.org,benmason@chromium.org

Bug: 1091256, 1091991
Change-Id: Icd2c9aff8a4d9c9e2c0268df010bfad95643c1b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233922Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776022}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8d842d5c5c3..675551d57710

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC treib@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: treib@google.com
Change-Id: I838a1adfc487ae6dd0207613c87eaf5c4d9628db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235633Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776021}

Ran `tools/clang/scripts/upload_revision.py f7f1abdb8893af4a606ca1a8f5347a426e9c7f9e`.

Bug: 1092413
Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome
Change-Id: I5543afe105f89035235032583f8029cdf5c9b53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231222
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776020}

The conflict exists because the initial authentication request calls
RunAuthorizationCallbacks right before unregistering its instance ID,
causing a race that mostly results in the request that was waiting for
authentication to have its ID unregistered, causing it to timeout. The
fix in this CL is to only start that request after the authentication
request has finished unregistering its ID.

Bug: 1090504
Change-Id: Ieb5a7da3a7e75662105a0e00d956473f0f624c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225287Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776019}

They're failing consistently on linux-chromeos-chrome.

TBR=rdevlin.cronin@chromium.org

Bug: 1092345
Change-Id: I7e9c9305a1cd40e0a16ecc8be4184a86dc78a501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235075Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776018}

UX has confirmed their approval with that change.

Bug: 1090740
Change-Id: Ibed141cd10c493bd24f3d27a8d2d268ddc098249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235674
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776017}

https://android.googlesource.com/platform/external/perfetto.git/+log/080c1b433d37..3ea2467b7947

2020-06-08 rslawik@google.com Scrape threads discovered when reading stats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:158206652
Tbr: perfetto-bugs@google.com
Test: Test: perfetto_unittests
Change-Id: I5c17a9d3fefcf1c700f94cded5fc821d04d95269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776016}

I plan to implement legacy list markers using LayoutBlockFlow and
LayoutInline in order to support the 'content' property in ::marker.

This patch is a step towards that goal, it moves LayoutNGListMarkerImage
out of /ng/ and renames it to LayoutListMarkerImage. This way it will be
possible to use it both in LayoutNG and legacy layout.

The only difference is that IsLayoutNGObject should keep returning true
for LayoutNG, but should return false when used in legacy. Then, this
patch adds a IsLayoutNGObjectForListMarkerImage flag in LayoutObject.

Note that LayoutListMarkerImage is not used in legacy yet, so this patch
should have no effect in practice.

BUG=457718

Change-Id: I5252919ececfd0d367d5e08d6575067598564cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109697Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776015}

Bug: 1058764
Change-Id: I351965d331519be885b51d894052952058585eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231360Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#776014}

These are symptomatic of crbug.com/1047818, but to stop the pain for
sheriffs lets mark them timeout=long for now.

TBR=robertma@chromium.org

Bug: 1092140, 1092234, 1092229, 1092143
Change-Id: Iec381fff06f8bf389c36ada9753b40b3e6048200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235459Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776013}

Following HTTPWG discussions[1] about reprioritization, this CL
lands a flag that would enable testing without H2 reprioritization,
to measure its impact.

[1] https://lists.w3.org/Archives/Public/ietf-http-wg/2020AprJun/0230.html

Change-Id: I43ac096f04a3fb73ef2a0bf7f5cfed073ef8d7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232923
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776012}

Bug: b/155715151
Change-Id: I0addcea6365a51e8b077fca487472b03383e5d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233318
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776011}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12e579fd1925..78f57416d0e1

2020-06-08 tvanderlippe@chromium.org Remove debug_devtools flag from devtools-frontend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1087379
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib6dfbf4e8586f544eafdf24bfd41fb9ad69bad72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776010}

Bug: 1044038
Change-Id: I01eb844b2d73563e5e394d6ab725bc2e9d056928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232840
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776009}

This CL adds basic reporting tests for browsing context switches.
It provides a reporting endpoint (report.py), and reusable helpers
within reporting-common.js, allowing future tests.
The helpers provided verify that expected report templates are present
on the expected endpoints, and that no extraneous reports are present.

This CL only convers the cases:
Popup opened from pages with coop :
 Same-origin with report only navigating to *
 Same-origin (without report) navigatin to *-with report
Follow ups will cover redirects (moved to follow up as it had timeout
 issues), other origins and iframe cases.

Bug: 1076456
Change-Id: I7a39d4def20692d8628ce2406569638310684f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207451Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776008}

This reverts commit 2001eb11.

Reason for revert: Suspected of breaking mini_installer_tests on Win7; see crbug.com/1092356

Original change's description:
> Install 64-bit browser versions under "C:\Program Files" by default
> 
> Browsers installed under "C:\Program Files (x86)" remain in that
> directory and will continue to be updated. They must be uninstalled
> first to be reinstalled under "C:\Program Files".
> 
> Bug: 380177
> Change-Id: I45b8898ddf39dd7a5fe7e6e0ce258da313ea880f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204420
> Commit-Queue: Yann Dago <ydago@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#775810}

TBR=grt@chromium.org,ydago@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 380177, 1092356
Change-Id: Ic63cc4adcf2285f7e41fa8dc35d7260cf86bc64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232949Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776007}

When an account is fully removed from the signin cookies (i.e. doesn't
show up in either signed-in or signed-out accounts), then any
account-storage-related settings should also be cleared, most notably
the opt-in bit.

Bug: 1052005, 1079297
Change-Id: I6b5441abd60fb05e8001e770e46f72b8d083ea04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232327
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776006}

1088641, 1088640

Bug: 1089485, 1089483, 1089482, 1089481, 1089480, 1088643, 1088642,
Change-Id: Idb6ffe84ba4b2614ea4a3c1ca64f8e624cf29940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233058Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776005}