GitLab

Currently, we don't pass the provider-populated (generally
server-provided) subtype_identifier field into the aqs= CGI parameter.

We just statically make one in the AutocompleteController
AutocompleteMatchToAssistedQuery static method.

This more or less works, but in our ideal system, we would have these
qualities:

 1. We decentralize this provider-specific logic into the providers
    themselves, rather than having a centralized switch statement that
    handles all these per-provider cases.

 2. If the server passes us some special subtype_identifier, we can
    pass it along in our aqs= parameter without updating the Chrome
    binary.

This CL makes AutocompleteMatchToAssistedQuery start with the
provider-populated integer.

It also adds a test.

Ideally in the future, all of the logic within that static method
could be migrated into the individual provider classes.

Bug: 1064327
Change-Id: I8b56a6623f61520218f2f4001787171c300fb192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118221Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754651}

Bug: 1044401
Change-Id: I7b8c69a390f47e86b864360d1913bf593c8b69ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124969Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754650}

This CL moves flexbox-with-multi-column-property.html from
css3/flexbox/ to external/wpt/css/css-flexbox/. It also adds
links and references to the related spec, and expected behavior.
Last, it replaces uses of -webkit-column-* by their respective
column-* counterparts.

Relevant spec change: https://github.com/w3c/csswg-drafts/issues/1364
([css-multicol-1][css-flexbox-1][css-grid-1] Clarify that column-*
properties only apply to block containers).

BUG=1063749
R=dgrogan@chromium.org

Change-Id: Icd31c1974af431bd8cd6de94970e4e29137a669e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127294
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754649}

Use GetLastCommittedItemInCurrentOrRestoredSession() instead of
GetLastCommittedItem() so restore session URL's aren't suppressed.
Otherwise a cancelled/stopped navigation during the first post-restore
navigation will always return early from Reload.

Bug: 1050518
Change-Id: I352e430abcf888ae8488150b6511e8a7fd9bd4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125870Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754648}

The tests were using chrome:// URLs to trigger SafeBrowsing warnings.
They also wait until the pages are ready which is done by running
JavaScript. In some cases, WebUI bindings aren't yet ready for the loaded
page so executing JS fails, causing the tests to crash.

This CL switches to HTTP pages instead.

Bug: 1065742, 1057157
Change-Id: Ie3302e7c63bf8d4d7c9db687c95ce1e9e8da483c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127733Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754647}

This CL renames FeaturePolicyDisposition to PolicyDisposition, because
it is now used for both feature policy and document policy.

Change-Id: I2ff2f0a9a167ca56f5aeac14adff660f8504a949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127734Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#754646}

Bug:949839

Change-Id: Iea808d532584089d974032e5eef3eeee8eb57a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126572Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754645}

Bug: b/150400326
Change-Id: I5a4dc3c2adbc40510750b14b254dd7e998dfa404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127987
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754644}

With this, -Wunreachable-code is enabled on all platforms for
chromium_code (which is the default config for all GN targets).

Targets that explicitly opt out of chromium_code and into
no_chromium_code don't get the warning.

(libfuzzer builds also don't get the warning, that's issue 1063180).

Bug: 346399
Change-Id: I88ea45eddf55d4ba5170ff89367d6afcf27891a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128189
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754643}

Added the ability for callers of SetIdentityInfo() to specify which
vector icon to fall back to in the case that an empty |image| is
supplied.

This allows the incognito profile menus to specify the incognito
icon and color required.

This is necessary as previously the incognito image was generated
prior to having access to the Widget, resulting in incorrect colors.

Bug: 1065294
Change-Id: I4bc78e692abb7354e6cd5fcdeccd5483dc2c964a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127410
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754642}

The webrtc::FrameTransformerInterface is transitioning to using
TransformableVideoFrameInterface instead of video_coding::EncodedFrame.
Use new webrtc::FrameTransformerInterface methods.

Bug: 1052765
Change-Id: I533118ca692e77229975874f446cdd6fde08461f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126670
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754641}

There were two tests written in the way that its test body is inside
the FrameSequenceTrackerTest class. This was because there were a few
APIs that were not ready at the moment.

Now that we have all the instruments in the FrameSequenceTrackerTest
class to access APIs in FrameSequenceTracker, this CL cleans up the
test.

Bug: None
Change-Id: I88e09893500381669fd2d3d5bc04eccad839455c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126249
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754640}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/d52066592790..f085b9745fc1

git log d52066592790..f085b9745fc1 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 dgkoch@users.noreply.github.com Roll glslang dependency to SDK-candidate tag (#1024)

Created with:
  gclient setdep -r src/third_party/shaderc/src@f085b9745fc1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: Ibcacdccaeeca5394a82e1636a3b523f142ae4ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754639}

https://webrtc.googlesource.com/src.git/+log/c24b6b7815ce..1d0faee9aa1a

git log c24b6b7815ce..1d0faee9aa1a --date=short --first-parent --format='%ad %ae %s'
2020-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dfa4a7a6..a0d7df33 (754373:754491)
2020-03-30 kerl@google.com Add packet rate plots to event_log_visualizer.

Created with:
  gclient setdep -r src/third_party/webrtc@1d0faee9aa1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ie3b14edbd07512b756fe040fd2f811e1588037c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127758Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754638}

This CL moves negative-overflow.html from css3/flexbox to
external/wpt/css/css-flexbox.

<link ref=help|match> tags were added, as well as <title>.
CSS and JS referenced paths were also updated.

BUG=1063749
R=dgrogan@chromium.org

Change-Id: I4091fc870f51a31ac9fbac51b42eaa6cd33a16de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127607
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754637}

BUG=none
TEST=none

Change-Id: I5baa25638f3f46f057be4c560b8ce37fbb497f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125301Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754636}

Pass request parameters from the native side to BLEHandler and through
to CableAuthenticator on the Java side, and use them when making FIDO
API requests. From the responses to those API requests, pass values back
to the native side and return them in the CTAP response.

This also includes using parameters from the googleAndroidClientData
extension and handing back clientDataJSON in the response.

Bug: 1002262
Change-Id: I6c5b202f9fa1df5e90f53fe3140cfbc1fc4b589a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127516
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754635}

https://swiftshader.googlesource.com/SwiftShader.git/+log/81d8c2ada561..45755df21024

git log 81d8c2ada561..45755df21024 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 capn@google.com Eliminate the legacy PowerVR SDK
2020-03-30 capn@google.com Integrate PowerVR OpenGL ES samples
2020-03-30 capn@google.com Fix completeness test of OpenGL ES immutable textures
2020-03-30 cwallez@google.com Revert "MetalSurface: set layer.device to a ref of the system default device."

Created with:
  gclient setdep -r src/third_party/swiftshader@45755df21024

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I075049127a2746022b411204c25409def6273b95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754634}

Previous fix to the failing test was to add a setTimeout on
resize javascript so that the initial frame can be rendered
before the resize.
(https://chromium-review.googlesource.com/c/chromium/src/+/2090457)

It turns out setTimeout is not a reliable way to force
layout. This CL uses |runAfterLayoutAndPaint| to force
multiple layouts happening instead of only once at the end
by default for pixel tests.

Bug: 1061539, 1060776

Change-Id: If068a63655eaacf1300b963e60e441a04fc59784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124888
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754633}

This reverts commit 916ac566.

Reason for revert: apparently mb.py now using the go client
means we depend on this change. And I don't want to revert
the switch to the go client since it's so much faster. So
let's reland this, land https://chromium-review.googlesource.com/c/chromium/tools/build/+/2127067
and then hopefully quickly find a fix for the regression that
the deterministic bots now miss some stuff.

Original change's description:
> Revert "compare_build_artifacts.py use *.runtime_deps"
> 
> This reverts commit 0f71cedd.
> 
> Reason for revert: .runtime_deps currently aren't always in
> the root build dir, see
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/2127067/1#message-9a3c93e50651dc80dfbfefb762db5841ef159b13
> (Also, https://crbug.com/1065750)
> 
> Original change's description:
> > compare_build_artifacts.py use *.runtime_deps
> >
> > *.isolate file is deprecated.
> > use *.runtime_deps file, generated by gn, instead.
> >
> > Bug: 972075
> > Change-Id: I5bc47cbe058c1550fdca4d1d89928c3daf4bc0e5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061575
> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#745827}
> 
> TBR=maruel@chromium.org,thakis@chromium.org,ukai@chromium.org,tikuta@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1065750,972075
> Change-Id: I49426f0a40d013f6ffacc9524120b1b58db2f03b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128186
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754587}

TBR=maruel@chromium.org,thakis@chromium.org,ukai@chromium.org,tikuta@chromium.org

Change-Id: Iff3934bc722eebbfe023f10f65704387626d1806
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1065750, 972075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127894Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754632}

This reverts commit c3f6c6c0.

Reason for revert: Causes regressions in the below linked bugs.

Original change's description:
> overview: Fade the crostini window back in if it fails to close.
> 
> The crostini installer (and other non-closeable) windows will reverse
> their animations in overview if the CloseWidget call fails to close
> the window.
> 
> Test: manual
> Bug: 970196
> Change-Id: I7aeab07c9d7f2f5e94a34ac8b3a43bdde3610b6f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121346
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753660}

TBR=xdai@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id0a29e92c3711a79771a22a59a8301a1fa5a43f1
Fixed: 1066167, 1066169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128230Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754631}

has_key() has been removed in Python 3.
Use the 'in' operator which works in both Python 2 and 3.

Traceback (most recent call last):
  File "../../components/schema_org/generate_schema_org_code.py", line 148, in <module>
    sys.exit(main())
  File "../../components/schema_org/generate_schema_org_code.py", line 139, in main
    template_vars = get_template_vars(args.schema_file)
  File "../../components/schema_org/generate_schema_org_code.py", line 111, in get_template_vars
    template_vars['properties'].append(parse_property(thing, schema))
  File "../../components/schema_org/generate_schema_org_code.py", line 72, in parse_property
    if not prop.has_key(schema_org_id('rangeIncludes')):
AttributeError: 'dict' object has no attribute 'has_key'

Bug: 941669
Change-Id: I29f7ac1e7c1aca7275412c068a59070f4c18f69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124609
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754630}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9195e7c7a..7e3ad7980

git log 9195e7c7a..7e3ad7980 --date=short --no-merges --format='%ad %ae %s'
2020-03-30 cblume@chromium.org Fix Mac builds of libjpeg-turbo
2020-03-27 dalecurtis@chromium.org Fix include directories for NASM.
2020-03-27 dalecurtis@chromium.org Switch to NASM for libjpeg_turbo.

Change-Id: Ia7a9ff83b9c55e37265099bc7b072f042ee50d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125950Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754629}

Bug: 1066161
Change-Id: I2c6c2e0da5424942cda6db78ac65887102dc6885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127912
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754628}

TBR'ing yusufo@ as this is the same as the original CL.

This is a reland of a33032ad

Original change's description:
> [WebLayer] Delete browserservices.Origin
>
> This is the last CL to move browserservices.Origin to
> //components/embedder_support so it can be used by WebLayer. This was
> split into multiple CLs to avoid breaking Clank.
>
> Bug: 1058597
> Change-Id: I1964b9fc54c378528ba4935e2385da99fc663e70
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106889
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#752248}

TBR: yusufo@chromium.org
Bug: 1058597
Change-Id: Idf41f87ec6203f236b922e2330bf6f6d2e227d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115462
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754627}

This change calls OnMainFrameDocumentIntersectionChanged for the main
frame. The RenderFrame resets the main frame's intersection when the
frame commits a navigation to ensure we propagate a new intersection
for each committed navigation (otherwise we may lose updates when the
render frame observer propagates values for uncommitted loads to
page load metrics).

This allows consumers to compare frame intersections with the main
frame's rect. This is a precursor to measuring page ad density.

BUG=993453

Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754626}

https://android.googlesource.com/platform/external/perfetto.git/+log/e7603d3ab878..de6d9fd4428c

git log e7603d3ab878..de6d9fd4428c --date=short --first-parent --format='%ad %ae %s'
2020-03-30 treehugger-gerrit@google.com Merge "TrackEvent: Add entry point for track+timestamp+lambda"

Created with:
  gclient setdep -r src/third_party/perfetto@de6d9fd4428c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I81ef5c156ff65d13a23270b1f016c9d4432e1870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127421Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754625}

Attempting to keep a list of proxied methods on MTLDevice is a losing
battle. So use -forwardInvocation: to implement blanket forwarding.

Bug: 1065146
Change-Id: I3110a3b02430590664545be5072c993e64a14cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125462
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754624}

This implements a basic CookieManager for WebLayer which allows getting
and setting cookies.

Bug: 1054160
Change-Id: I4d875ce95abc75f8012a222778e4eb1ed6839a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122475Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754623}

On Aura and Android, there is a feature that describes the document/frame
selection to the compositor for touch selection. These coordinates are
layer-relative so that they can later be used to determine whether or not
the start and end of the selection is visible and whether the handles
should be rendered.

This currently relies on Blink being able to query compositing state,
which is not available during PrePaint with CompositeAfterPaint enabled.

This change has us early-out for CAP and leaves a TODO with bug to go
implement this for CompositeAfterPaint

Bug: 1007989

Change-Id: I2876a5bdc847b4e9e8afbbf7b75f4701b387fa23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120091
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754622}

Extensions used to be able to override the bookmark star view in order
to provide a custom bookmark manager (this was used for the Stars
extension). The extension has been deprecated and removed, and the API
never launched. Clean up the remnants.

No longer check for extension overrides when bookmarking a tab, and
simplify the methods to simply be BookmarkCurrentTab().

In addition to removing what was thought to be dead code, this also
fixes a bug that exists today that allowed non-Stars extensions to
implicitly override the "Bookmark this tab..." behavior, independent of
whether they were actually a bookmark manager. (This was caused because
we didn't check the command was active before using it in
browser_commands.cc.)

Bug: 894447, 1065167
Change-Id: I975cac58e72e113c351fe63735c4be5c3f08aa4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123315Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754621}

This is a reland of 8e70db4d

Original change's description:
> [PM] Connect dedicated workers to their client frames in the graph.
>
> Bug: 993029
> Change-Id: Iae20fa0ede4421782fc5fbf2851d21c83cfbf4c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095452
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753319}

Bug: 993029
Change-Id: I859f004b938164a02e43b74e6f9225d25e90d083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122476Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754620}

This reverts commit a18fd063.

Reason for revert: Branch is coming up, and this CL is the likely cause
of a release-blocking bug on Android (https://crbug.com/1065341).

Original change's description:
> Persist Reader Mode theme and font family settings on desktop.
>
> This CL expands the existing JavaScript bindings to allow storing the
> theme and font family selected via the in-page appearance settings
> dialog to the corresponding synced preferences.
>
> The ability to persist the font size/scale will be added in a
> follow-up CL. Storing that setting requires some additional work to
> convert the font size in pixels used by the desktop UI to the scale
> relative to base size expected by the pref.
>
> Bug: 1016615
> Change-Id: Ia7f8c86b8e9fa136b2b18429ba4b9d89272d1893
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922788
> Commit-Queue: Aran Gilman <gilmanmh@google.com>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753277}

TBR=estark@chromium.org,wychen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1016615, 1065341
Change-Id: Icd8a8e6d3cdc06931e5f4aa083217a07df3c7a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127908
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754619}

Change the BluetoothKernelSuspendNotifier flag to be enabled by default.
Also extend the expiry to 84 (that is when we will remove the flag
entirely).

BUG=b:149795111
TEST=Built for Hatch, deploy_chrome, checked flag in guest mode is
      enabled by default. Verify via shell that prepare_for_suspend in
      /sys/class/bluetooth/hci0 is set to enabled.

Change-Id: Ibe064b57ca5db7dcce516f5c41a5b11de7aff2fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116592
Auto-Submit: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754618}

This is one of a series of CLs updating Trust Tokens key commitment
state to use a singleton in-memory store owned by NetworkService and
updated via Mojo from the component updater. This involves

1: Remove key commitment-related state from the on-disk trust
token store
[2, this CL]: Mojoify TrustTokenKeyCommitmentResult and remove
commitment fetching and parsing code:
- Remove network::TrustTokenKeyCommitment{Parser, Controller, Result}
- Clean up the persistent storage schema, removing the proto
TrustTokenKeyCommitment (a key with metadata, similar to Result::Key)

3: Add a centralized issuers-to-commitments store in the network
service.
4: Add component updater logic to populate this store.

Bug: 1063510
Change-Id: Ie64e778c47a1e570087c8a305bf02c88e223f035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117467
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754617}

Currently, GetURL(url::kAboutBlankURL) is called with returns a GURL
ending "/ad_tagging/about:blank" instead of just an about:blank GURL.

Bug: 1064783
Change-Id: I11d9e26ec8ee32eef924ccfc6d07c218f144d7b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119223Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754616}

Bug: 1051042
Change-Id: I4a2cdae3db41bf4da2839d2779f0928573f5675d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127519Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Hongbo Song <hbsong@google.com>
Cr-Commit-Position: refs/heads/master@{#754615}

Prior to this change there exists a window between when GpuMain()
hands off log collection and when GpuServiceImpl::InitializeWithHost()
starts forwarding to the GpuProcessHost. We have sometimes lost key
debugging logs in these cases.

Now GpuServiceImpl handles collection of GpuMain() logs all the way up
until GpuServiceImpl::InitializeWithHost() takes over, so no logs are
lost during startup.

Fixed: 1065082
Change-Id: I1d0376ca917218cb6cb6c7298ad59021ba6832ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123329
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754614}

WebXrPermissionsApi is still targeting a launch in 83; however given the
current state of affairs, this switches it to be launched as a "soft
launch" via finch, so that it can easily be disabled if approval to
launch is denied at a late stage.

Change-Id: I2ada82e5649fcdb9526a07363bb15ddfd2c32b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122608Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754613}

If the time requested in cancelScheduledValues overlaps the time of a
setValueCurveAtTime, then the setValueCurveAtTime is also removed.

Bug: 1063502
Change-Id: I6e8bd4bf802cd76f26b46f60905f977ab76d5b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121353Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754612}