GitLab

BUG=485955
NOTRY=true

Review URL: https://codereview.chromium.org/1135213003

Cr-Commit-Position: refs/heads/master@{#329380}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e4c5505..eaa355a9

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1139893002

Cr-Commit-Position: refs/heads/master@{#329379}

BUG=484997

Review URL: https://codereview.chromium.org/1129323005

Cr-Commit-Position: refs/heads/master@{#329378}

This CL is took over from issue 1112573005 at patchset 30001 (http://crrev.com/1112573005#ps30001)

BUG=476688
TEST=*ImportController*

Review URL: https://codereview.chromium.org/1126043005

Cr-Commit-Position: refs/heads/master@{#329377}

Revert of Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf (patchset #1 id:1 of https://codereview.chromium.org/1133063002/)

Reason for revert:
The test should now work with the more aggressive v8 gc() after a gc fix in the test (https://codereview.chromium.org/1138073003/)

Original issue's description:
> Disabled WebRtcBrowserTest.CanSetupCallAndSendDtmf
>
> TBR=tommi
> BUG=486654
>
> Committed: https://crrev.com/fc57f2cec564c344e3e17023b41c008f574b65a7
> Cr-Commit-Position: refs/heads/master@{#329147}

TBR=henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=486654

Review URL: https://codereview.chromium.org/1141533002

Cr-Commit-Position: refs/heads/master@{#329376}

This changes RecorderPageTest class to pass CustomizeBrowserOptions to
a page test object if there is one.

BUG=486776

Review URL: https://codereview.chromium.org/1138763004

Cr-Commit-Position: refs/heads/master@{#329375}

This CL makes the FSP section a prerequisite for the permission. It also adds
a warning if a section is used without a permission.

TEST=unit_tests: *FileSystemProviderHandlerTest*"
BUG=474146

Review URL: https://codereview.chromium.org/1133013002

Cr-Commit-Position: refs/heads/master@{#329374}

BUG=486654

Review URL: https://codereview.chromium.org/1138073003

Cr-Commit-Position: refs/heads/master@{#329373}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fe317c..a442694

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1139503003

Cr-Commit-Position: refs/heads/master@{#329372}

In chrome.launcherSearchProvider API, support iconUrl field in search result.
Currently only chrome-extension:// url is supported.

BUG=440649,486236
TEST=out/Release/unit_tests --gtest_filter=ExtensionBadgedIconImageTest.*

Review URL: https://codereview.chromium.org/1060733003

Cr-Commit-Position: refs/heads/master@{#329371}

TypedUrlChangeProcessor is a HistoryService observer and gets notified
about changes to all addresses, not just typed ones. This means that
when HistoryService::SetPageTitle() is called for a non-typed URL,
TypedUrlChangeProcessor::OnURLsModified() will be triggered and,
consequently, TypedUrlChangeProcessor::CreateOrUpdateSyncNode().
As the name suggests, if the modified node was not previously present
(because it was filtered out by ShouldSyncVisit() in OnURLVisited()),
it would be created.
End effect was that *all* URLs that had their title updated (which means
every page that has a <title> tag) were synced, even if they were not typed.

The solution is to return early in CreateOrUpdateSyncNode() if we detect
that the URL in question has no typed visits.

(Caused by https://codereview.chromium.org/1087773002/)

BUG=

Review URL: https://codereview.chromium.org/1126633005

Cr-Commit-Position: refs/heads/master@{#329370}

This CL in order to add the icon implements a cr.ui.ProvidersMenuItem class
since cr.ui.MenuItem doesn't handle icons with hidpi properly, nor it supports
well custom icons (setting a label overwrites any inserted DOM elements to the
menu item).

TEST=Tested manually.
BUG=474146

Review URL: https://codereview.chromium.org/1132843004

Cr-Commit-Position: refs/heads/master@{#329369}

This CL adds a UMA stat that tracks how far an opened app list search
result is from the top left of the search results view. This will provide
information on the quality of search result ranking.

BUG=485449

Review URL: https://codereview.chromium.org/1132943004

Cr-Commit-Position: refs/heads/master@{#329368}

Support more kinds of `pname` for these two interfaces.

BUG=429053

Review URL: https://codereview.chromium.org/1133033002

Cr-Commit-Position: refs/heads/master@{#329367}

Move setting of NSWindowHostsLayersInWindowServer to
ContentMainRunnerImpl::Initialize. Use the CoreFoundation API so
that it can be called from C code.

BUG=450173

Review URL: https://codereview.chromium.org/903943002

Cr-Commit-Position: refs/heads/master@{#329366}

BUG=479898

Review URL: https://codereview.chromium.org/1128083003

Cr-Commit-Position: refs/heads/master@{#329365}

The |mock_server_response_| field was being set in parallel with
actually running the query, so there was a race condition if the network
request came in before the response field is set.

Now sets the |mock_server_response_| before starting the query.

BUG=246136

Review URL: https://codereview.chromium.org/1137113002

Cr-Commit-Position: refs/heads/master@{#329364}

Ensures that all converted timestamps will be monotonically increasing
within a single call to GetWallClockTime.

Performance seems unchanged (unit tests take the same amount of time).

As part of this change, also does the following:
- VideoRendererImpl unit test switched to WallClockTimeSource to avoid
having to reimplement the vector conversion routine.

BUG=485042
TEST=new unittest.

Review URL: https://codereview.chromium.org/1136513004

Cr-Commit-Position: refs/heads/master@{#329363}

There's an expected ~443kB sizes regression in ChromiumFramework with
this. This is because large portions of views.dylib are still culled at
link time with -dead_strip, but this CL makes more symbols reachable.
For a full accounting see http://crbug.com/485854#c1 (nothing
unexpected).

The dialog is enabled by linking in app_info_dialog_views.cc to provide
functions previously provided (but NOTIMPLEMENTED()) by
app_info_dialog_cocoa.mm.

Note that the views CanShowAppInfoDialog() is implemented as
IsMacViewsAppListListEnabled(), so no user-visible changes occur unless
Chrome is run from the command line with --enable-mac-views-app-list.

With this flag, the `Details` link at chrome://extensions will show the
views-based (and offline-enabled) AppInfo dialog rather than taking the
user to the webstore URL. And the context menu for icons at
chrome://apps will have an `App Info` option.

(Note that the views-based App Launcher isn't currently linked in on
Mac, so the app launcher shown with --enable-mac-views-app-list
--show-app-list doesn't support this dialog yet).

Screenshot at http://crbug.com/485854#c2

BUG=485854

Review URL: https://codereview.chromium.org/1048343002

Cr-Commit-Position: refs/heads/master@{#329362}

In addition fixed an issue where <- button was shown when it should not.

BUG=472671
TEST=manually,tested FrE and recovery modes, button works as expected.

Review URL: https://codereview.chromium.org/1132043002

Cr-Commit-Position: refs/heads/master@{#329361}

Previously, MultiThreadedProxyResolverTest.ThreeThreads_Basic started
multiple requests in parallel and expected resolvers on three threads
to be created and used. However, the new resolver thread can take long
enough to become ready that it doesn't finish initializing its resolver
before all requests complete on other threads and the test finishes.
This CL fixes this by blocking the resolvers to force requests to run on
new resolver threads.

BUG=486257

Review URL: https://codereview.chromium.org/1132943003

Cr-Commit-Position: refs/heads/master@{#329360}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bedb2c7..1fe317c

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1133733006

Cr-Commit-Position: refs/heads/master@{#329359}

https://codereview.chromium.org/1126133003 changes the behavior of
Blink CSS file support; we need to send the proper MIME type, even in
quirks mode. This CL fixes the tests which broke when that patch
initially landed way back when.

BUG=419383
TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/1136493003

Cr-Commit-Position: refs/heads/master@{#329358}

BUG=

Review URL: https://codereview.chromium.org/1129293003

Cr-Commit-Position: refs/heads/master@{#329357}

We now highlight (in bold) the part of the query that you typed, just as
we do with other types of queries.

Moved AppResult::UpdateFromMatch into SearchResult so it can be used by
any provider.

BUG=481837

Review URL: https://codereview.chromium.org/1110883003

Cr-Commit-Position: refs/heads/master@{#329356}

As mentioned in Issue 480666, touch effect should be square.
However, the newly-added sort button have the circle effect, so this CL fixes it.

BUG=none
TEST=manually

Review URL: https://codereview.chromium.org/1124403004

Cr-Commit-Position: refs/heads/master@{#329355}

This fixes the component=shared_library build on Chrome OS.

BUG=none
TEST=cros chrome-sdk --board=link
  GYP_DEFINES="$GYP_DEFINES component=shared_library" gclient runhooks
  ninja -C out_link/Release chrome chrome_sandbox

Review URL: https://codereview.chromium.org/1136123004

Cr-Commit-Position: refs/heads/master@{#329354}

It wasn't quite wide enough.

TBR=jyasskin@chromium.org
BUG=480750

Review URL: https://codereview.chromium.org/1135563006

Cr-Commit-Position: refs/heads/master@{#329353}

Revert of Be explicit about forcing TouchSelectionController updates (patchset #2 id:20001 of https://codereview.chromium.org/1127383007/)

Reason for revert:
This has caused failures on the memory bots. e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179

Sample test output:
[ RUN      ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection
==6485== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f5bc93bb605 in ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound const&, ui::SelectionBound const&) ui/touch_selection/touch_selection_controller.cc:71:27
    #1 0x7f5bc922803a in ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool, gfx::RectF const&, bool) ui/touch_selection/touch_selection_controller_unittest.cc:147:5
    #2 0x7f5bc9278c8d in ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody() ui/touch_selection/touch_selection_controller_unittest.cc:946:3
    #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0
    #5 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #6 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #8 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #9 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #10 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #13 0x7f5bc92f85ee in Run base/callback.h:396:12
    #14 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #17 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #18 0x7f5bc9188f38 in _start ??:0:0

  Uninitialized value was created by a heap allocation
    #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0
    #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp() ui/touch_selection/touch_selection_controller_unittest.cc:65:23
    #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0
    #4 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #5 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #7 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #8 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #9 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #12 0x7f5bc92f85ee in Run base/callback.h:396:12
    #13 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #16 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605)
Exiting

Original issue's description:
> Be explicit about forcing TouchSelectionController updates
>
> Previously, cached values in the TouchSelectionController would be reset
> to force future selection updates. However, these cached values can
> actually be used outside of selection update calls, e.g., when force
> showing the selection from the current cached values. Instead of
> resetting the cached values, simply set a dirty bit that forces an
> update, avoiding issues when dealing with the reset values.
>
> BUG=393025
>
> Committed: https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83
> Cr-Commit-Position: refs/heads/master@{#329325}

TBR=mohsen@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=393025

Review URL: https://codereview.chromium.org/1139533006

Cr-Commit-Position: refs/heads/master@{#329352}

BUG=451917
TEST=DriveApiRequestsTest.BatchUploadRequestProgress

Review URL: https://codereview.chromium.org/1130183003

Cr-Commit-Position: refs/heads/master@{#329351}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c327f6..bedb2c7

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1131413005

Cr-Commit-Position: refs/heads/master@{#329350}

This change prevents any *.googlezip.net Data Reduction Proxy from being
configured as part of the ProxyService's ProxyConfig via the
proxy pref.

Specifying a DRP in the proxy rules is not a supported means of
activating the DRP, and could cause requests to be sent to the DRP
without the appropriate authentication headers and without using any of
the DRP bypass logic.

This is a fix for http://crbug.com/476610, to be merged into M43.

BUG=476610

Review URL: https://codereview.chromium.org/1126413006

Cr-Commit-Position: refs/heads/master@{#329349}

Revert of [Chromecast] Ignore interfaces not used to connect to internet. (patchset #1 id:1 of https://codereview.chromium.org/1137483004/)

Reason for revert:
broke the Android builds. Not sure how "cast_shell_android" passed, actually.

Original issue's description:
> [Chromecast] Ignore interfaces not used to connect to internet.
>
> Add NetworkChangeNotifierFactoryCast to create instance of
> NetworkChangeNotifierLinux that ignores interfaces that will not be
> used to connect to internet.
>
> BUG=469863
> R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org
>
> Committed: https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614
> Cr-Commit-Position: refs/heads/master@{#329319}

TBR=byungchul@chromium.org,wzhong@chromium.org,derekjchow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469863

Review URL: https://codereview.chromium.org/1141503002

Cr-Commit-Position: refs/heads/master@{#329348}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1107e90..06f3647

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1127353003

Cr-Commit-Position: refs/heads/master@{#329347}

BUG=483716
TEST=manually

Review URL: https://codereview.chromium.org/1140653003

Cr-Commit-Position: refs/heads/master@{#329346}

BUG=486194

Review URL: https://codereview.chromium.org/1137993002

Cr-Commit-Position: refs/heads/master@{#329345}

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214

Review URL: https://codereview.chromium.org/1131993005

Cr-Commit-Position: refs/heads/master@{#329344}

Previously, all Webstore results had an internal relevance score of 0.0.
Now they are scored based on the query matched against the app's title,
and scores of 0.0 are discarded. This fixes app results showing up
because the word you typed appears in the app's web store description,
but not its title.

BUG=481837

Review URL: https://codereview.chromium.org/1110903002

Cr-Commit-Position: refs/heads/master@{#329343}

- Use core-toolbar for header.
- Change close button div to a paper-icon-button.
- Remove close-gray.png and close-gray2x.png.
- Remove unneeded CSS, modifies some positioning.

Review URL: https://codereview.chromium.org/1134463008

Cr-Commit-Position: refs/heads/master@{#329342}

TBR=kpschoedel@chromium.org
BUG=487056

Review URL: https://codereview.chromium.org/1128253007

Cr-Commit-Position: refs/heads/master@{#329341}