- 18 Oct, 2017 40 commits
-
-
Siddhartha authored
The block cache is shared across multiple databases. So, calculate the correct sizes of each leveldb database for the memory dumps. Bug: 758267 Change-Id: I4ca76422754c0a7fce46354f79631362d5553cdc Reviewed-on: https://chromium-review.googlesource.com/667916 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#509677}
-
Weidong Guo authored
Changes: Combine AccessibilityController::RequresCursorCompositing() with NightLightController::GetEnabled() and move the function to CursorWindowController. BUG=772457 Change-Id: I8b662c0a68aff6bdd0d69852f5516b4b9f564d3f Reviewed-on: https://chromium-review.googlesource.com/706058 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#509676}
-
Stephen McGruer authored
blink::AnimatableValueKeyframe is no longer used outside of tests. This CL converts the remaining tests that use it to use StringKeyframe instead and deletes AnimatableValueKeyframe. Using a StringKeyframe rather than an AnimatableValueKeyframe does cause some code churn, most notably: * The underlying interpolation becomes an InvalidatableInterpolation rather than a LegacyStyleInterpolation. This requires us to 'play nice' in certain places to make sure the interpolation result has been cached. * AnimatableValueKeyframe does no CSS 'type checking', which allowed the tests to abuse types (ignoring units, using invalid values for the property, or using AnimatableUnknown with interpolable CSS properties to make them noninterpolable). StringKeyframe does do CSS type checking, so all that code had to be fixed. Bug: None Change-Id: Ief3772390aaa72135fff23ccdfb85bc622bdb5cd Reviewed-on: https://chromium-review.googlesource.com/717574Reviewed-by:Robert Flack <flackr@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509675}
-
Eric Roman authored
(Wired up TestRootCerts). Bug: 649017 Change-Id: I30e22e12a963d0fc398f679dcf79aa7f896557a0 Reviewed-on: https://chromium-review.googlesource.com/720596 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509674}
-
Andrey Kosyakov authored
we were waiting for undefined instead of a promise. Bug: 775756 Change-Id: I2fcddae0df9aaab48aa803787b46e87aa72ed61e Reviewed-on: https://chromium-review.googlesource.com/724427Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#509673}
-
Tetsui Ohkubo authored
According to new message center mock (go/cros-md-notificaiton-mock), - Notifications in message center no longer have shadows. Instead of that, they have rounded corner border. - The padding between notification: 10dp -> 8dp - Background color of is changed. In the mock, blur background like app launcher is specified, but it's still not implemented in this CL. Before: http://screen/m7HbFpaHWUu After: http://screen/mwr5kPmv7p3 TEST=ash_unittests BUG=726246 Change-Id: Ie3ec6c66a6b7b360f2112eaefad71915e74d3f11 Reviewed-on: https://chromium-review.googlesource.com/722303 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#509672}
-
Nico Weber authored
All the calls are protected by gclient conditionals now, so the flags are no longer needed. Mostly no functional change, except one: The Windows orderfiles hook now runs on non-Windows hosts when targeting Windows. Bug: 495204 Change-Id: I549409dc945b7ecf0fe060908923834dbf0cf0a3 Reviewed-on: https://chromium-review.googlesource.com/723922Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509671}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I019ce7539ab6ec15c5ad8bfd5557f19728130148 Reviewed-on: https://chromium-review.googlesource.com/724979Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#509670}
-
Matt Menke authored
Bug: 746977 Change-Id: Ib0439337359486f1523e85963d8549fbae58ee08 Reviewed-on: https://chromium-review.googlesource.com/705695 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#509669}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e148bf714e39..d71c6d1994f6 $ git log e148bf714..d71c6d199 --date=short --no-merges --format='%ad %ae %s' 2017-10-17 bungeman Make SkTFitsIn and SkTo constexpr. 2017-10-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 1bfa6b715..8a9e0fc23 (3 commits) 2017-10-17 herb Revert "Use combined three pass code for image blur." 2017-10-17 benjaminwagner Fix FxAA job names. 2017-10-17 bungeman Remove redundant parentheses. 2017-10-17 scroggo Remove "-Wno-over-aligned" from x86 Android builds 2017-10-17 angle-deps-roller Roll skia/third_party/externals/angle2/ cc8e2738d..1bfa6b715 (1 commit) 2017-10-17 kjlubick Shard GCE Coverage bot to decrease latency 2017-10-17 borenet bin/try: add support for internal bots Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Id9c10b7f6ce19f29d1919185ef764fe643908d06 Reviewed-on: https://chromium-review.googlesource.com/724290Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509668}
-
Dirk Pranke authored
Infra side at https://chromium-review.googlesource.com/c/chromium/tools/build/+/721690. TBR=scottmg@chromium.org Bug: 758256 Change-Id: I236568f4bcd75f1106d017454fba5f5a950ef11a Reviewed-on: https://chromium-review.googlesource.com/724620Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509667}
-
Chris Mumford authored
File::OSErrorToFileError() was only mapping EMFILE to FILE_ERROR_TOO_MANY_OPENED. Mapping ENFILE is one less FILE_ERROR_FAILED returned. Will not fix issue 766896, but might produce better logs. Bug: 766896 Change-Id: I2c2a0fafe15b0415da1c65cfe9b6f13cafe38206 Reviewed-on: https://chromium-review.googlesource.com/706545Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#509666}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 TBR=jam@chromium.org, sdefresne@chromium.org Change-Id: I855377dae3464f268c02595269cc8f96341ad593 Reviewed-on: https://chromium-review.googlesource.com/724161Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Dan Sanders authored
This CL moves the CTS computation to AdvanceSample(), which now returns a bool. Callers have been updated to fail when AdvanceSample() fails. Bug: 772874 Change-Id: I1215f6a259eff310b964e1899be4e4138ff34087 Reviewed-on: https://chromium-review.googlesource.com/722164Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#509664}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4479b97c. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/3386 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I3bbe2f334d976f483d006f3d980b7ce4c9cd936e Reviewed-on: https://chromium-review.googlesource.com/724459 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509663}
-
Peter Mayo authored
Removed from CompositorMutatorImpl::RegisterCompositorAnimator, then it becomes uncalled, and can be cleaned up. The plumbing for AnimationWorklet is different, being driven by timelines. Without SetNeedsMutate, LayerTreeMutatorClient is empty, and we don't need to register them on AnimationHost s or CompositorMutatorClient s any more. BUG=746212 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87186826450351876045fd8fa9d0a2b3d1f242d4 Reviewed-on: https://chromium-review.googlesource.com/690805Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
R=einbinder@chromium.org,dgozman@chromium.org Bug: chromium:681333 Change-Id: Id844ed73938074f2b9035f17479a016403132d9e Reviewed-on: https://chromium-review.googlesource.com/724203 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
danakj authored
This allows CreateTransferBuffer to succeed still when the context is lost. That means context loss doesn't look like other fatal errors with shared memory when setting up a context, allowing us to tell if we should retry making a context. If CreateTransferBuffer fails, then we should not retry unambiguously. R=piman@chromium.org Bug: 772574 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia4c9f75ed40aa0483fed94552d6689b84efc379b Reviewed-on: https://chromium-review.googlesource.com/720269 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509660}
-
Wenzhao Zang authored
Bug: 766964 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3ea67c04d2c1f825848ba015714a45661c0771bb Reviewed-on: https://chromium-review.googlesource.com/724125Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509659}
-
Takuto Ikuta authored
Goma gce staging bots on win fails on content_unittest. I'm suspecting it is due to inappropriate setting of vm. Let me enable swarming for those bots to pass test. Bug: 687037 Change-Id: Ib89cb0716ca26a69392471d5c77e8d4a12e640cc Reviewed-on: https://chromium-review.googlesource.com/721224Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Darren Shen authored
We add layout tests for CSSStyleValue.parse and parseAll [1]. These two methods are very similar so we test them in the same file to avoid code duplication. This will be first of many patches to add tests for CSS Typed OM. We follow WPT guidelines for these tests, with the intent that these tests will eventually be incorporated into WPT. Of note: - We organise the directory structure based on the heading structure of the spec. - We include metadata containing links to sections of the spec. - We use modern javascript features like 'const' and 'let'. As recommended by [2], we will land these tests in Chromium first. Once the spec has stabilised enough, we will upstream them to WPT. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parse [2] https://chromium.googlesource.com/chromium/src/+/lkcr/docs/testing/web_platform_tests.md#write-tests-against-specifications Currently failing: - parseAll is not implemented. - parsing a custom property doesn't seem to be implemented. - parsing list value properties doesn't seem to work. - parsing an invalid cssText should throw. Bug: 774887 Change-Id: If7fd3ed222dd6371a8a6077777742860a81ff4dc Reviewed-on: https://chromium-review.googlesource.com/720577 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#509657}
-
Han Leon authored
ThreadSafeInterfacePtr wraps a non-thread-safe InterfacePtr, it may be created/used to make mojo function call on another thread other than the binding thread of the InterfacePtr it wraps. Currently async calls are posted to the sequence that the InteracePtr is bound to, and the responses are posted back, but when the InterfacePtr encounters error or destroyes, it is destroying the response callbacks directly on the binding thread. Because the response callbacks are providerd from the caller thread, it should be better to destroy them also on the caller thread to avoid some thread hostile issues possibly. This CL aims to do this. BUG=775395 Change-Id: Ifd289e0c07ec52fd22674c8d049724d102598a8c Reviewed-on: https://chromium-review.googlesource.com/722719Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#509656}
-
Max Moroz authored
TBR=metzman@chromium.org, ochang@chromium.org, rharrison@chromium.org Bug: 775615 Change-Id: I2aaa15cfcde324974ca9352169aa595fc571f5e1 Reviewed-on: https://chromium-review.googlesource.com/724732Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509655}
-
Sean Kau authored
To determine what printers users are having difficulty setting up, record the printer if setup is abandoned from the PPD selection screen. This will tell us where our PPD coverage is lacking. Bug: 756576 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1e0913a3096d8a674a14cf230f6b97af456b330 Reviewed-on: https://chromium-review.googlesource.com/602696 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#509654}
-
Misha Efimov authored
Bug: 684616 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0398a6195459918550b8e90e6c8236c7a1e11487 Reviewed-on: https://chromium-review.googlesource.com/723719 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509653}
-
Kyle Horimoto authored
Now, BleScanner is a base class with a BleScannerImpl implementation and a FakeBleScanner test double; additionally, BleScannerImpl has a factory. This will be used in a follow-up CL to improve the robustness of the initialization flow. Note that some other files were edited slightly due to compiler errors which resulted from the change. Bug: 761532, 672263 Change-Id: I95bf3686dd1074275db670ef2791a38cb75c7805 Reviewed-on: https://chromium-review.googlesource.com/724269 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#509652}
-
Iris Uy authored
Bug: Change-Id: I96727d1c6b4cd09303eba6ca88630d83405623e2 Reviewed-on: https://chromium-review.googlesource.com/722362 Commit-Queue: Iris Uy <irisu@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#509651}
-
Max Moroz authored
TBR=rsesek@chromium.org Bug: 687076 Change-Id: Ia3e3f412fe8fa61c19887573e01cffd0ed751bff Reviewed-on: https://chromium-review.googlesource.com/724729Reviewed-by:
-
Gregory Chatzinoff authored
SendAlgorithmTest tests are failing on iOS due to a memory issue. This CL disabled them to make the tree green. TBR=rch Bug: 775492 Change-Id: I179b0a56495335008c728fa6054f6159236470cd Reviewed-on: https://chromium-review.googlesource.com/724619Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509649}
-
Xianzhu Wang authored
When an ancestor clip changes, we set kSubtreeVisualRectUpdate to update descendant visual rects which may be affected by the clip change. Previously we early returned in PaintInvalidator::InvalidatePaint() for descendants that had only kSubtreeVisualRectUpdate flag set. This caused other visual rects (of e.g. scrollbars, carets) that are updated during LayoutObject::InvalidatePaint() not updated. Now move the early return from PaintInvalidator::InvalidatePaint() into ObjectPaintInvalidator::ComputePaintInvalidationReason() to ensure the visual rects are updated. Bug: 727155 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I28f92281363c693b16121f48d21ab4f808990f14 Reviewed-on: https://chromium-review.googlesource.com/719716 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Robert Liao authored
scoped_comptr.h is going away. BUG=638327 Change-Id: Iedfc41cda41e717eda28f593b129207c3749891e Reviewed-on: https://chromium-review.googlesource.com/724232 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#509647}
-
Derek Cheng authored
- Added OnUserGesture() method to MediaSinkService, which gets called on MRDesktop::OnUserGesture(). - The method is meant to signal the MediaSinkService that a user gesture has occurred. It can then use this signal to "force" sinks to be discovered right away, if supported. - CastMediaSinkService::ForceDiscovery is renamed to OnUserGesture(). - DialMediaSinkService::OnUserGesture will re-sync DIAL-discovered sinks to CastMediaSinkService. This helps in a very specific scenario: if mDNS stopped working and a Cast sink that was discovered before was lost due to network flakiness, then this gives CastMediaSinkService a chance to recover sinks via this "forced" dual discovery mechanism. - Another thing we can try in a future patch is to have CastMediaSinkService retry connections for sinks stored in the per-networkID cache. We should also have a mechanism to evict stale entries from the cache. Bug: 752310, 753175 Change-Id: I77cdca84e607699b581d189d8d00380979ef5451 Reviewed-on: https://chromium-review.googlesource.com/714639 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509646}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 TBR=garykac@chromium.org Change-Id: I579160fb7c69c7b5cbc77e1d8349e144320319bd Reviewed-on: https://chromium-review.googlesource.com/724261Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
-
James Cook authored
Now that the service manager has moved back into the browser process these tests have become reliable again. The last 100 FYI runs have had other test suites fail, but not mash_browser_tests: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/?limit=100 * Eliminate single_mash_browser_tests step (which was running 1 test) and fold into mash_browser_tests * Put mash_browser_tests back with ~125 tests * Synchronize mash.browser_tests.filter with mojo.fyi.browser_tests.filter Bug: none Test: bots Change-Id: I44d5280ab69dcd1c27c11228737b357bece22154 Reviewed-on: https://chromium-review.googlesource.com/722107Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509644}
-
Blake O'Hare authored
ChromeKeyboardUI used to be a trivial class that implemented KeyboardContentUI. Because it was the only implementer, these two classes were flattened into one in crbug.com/739083 However, this inadvertently caused us to lose OWNERS control over this code. Bug: Change-Id: I980ef970f1a8467e7f8dcc0a675068d8b6d22a00 Reviewed-on: https://chromium-review.googlesource.com/720718Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Matt Menke authored
These are the cases in which URLFetcher supports retries. Unlike URLFetcher, there's a single method to enable both types of retries, and a single counter. Unlike URLFetcher, this does not support backoff via the ThrottleManager (Something only used in the service process). We may want to implement something simpler, or just let the service process consumers themselves deal with backoff. Bug: 746977 Change-Id: I31c81652176856231289ad88d082713bad6df61d Reviewed-on: https://chromium-review.googlesource.com/701215 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Alexei Filippov authored
Change-Id: Ib636810dc68a8d39adf486397123e5000787aa49 Reviewed-on: https://chromium-review.googlesource.com/724020 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#509641}
-
Hans Wennborg authored
It turns out the first attempt (#502428) got the flag backwards. *headdesks* Bug: 761633,765793,775258 Change-Id: I6ef2203822c4b0a5d04d6c8d564e0d347b2d104d Reviewed-on: https://chromium-review.googlesource.com/724263Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509640}
-
Han Leon authored
For Unregister related codes: kServiceWorkerUpdateErrorPrefix --> kServiceWorkerUnregisterErrorPrefix BUG=775412 Change-Id: Ib2a0dff68caef88cacd7ce6d449a7ef6adb4a8c6 Reviewed-on: https://chromium-review.googlesource.com/724439Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#509639}
-
Blake O'Hare authored
This is a re-attempt at crrev.com/c/715576 which was rolled back due to memory issues. The problem is that some callers pass in their own InputMethod and also manage the lifecycle themselves, whereas the Fake is created locally and needs to be cleaned up in the destructor. This CL is identical to the previous with the exception of the added is_input_method_owner_ field and its use in the destructor. Bug: Change-Id: If3f911fb42bc34a2805beceb49143a96ac7e6098 Reviewed-on: https://chromium-review.googlesource.com/720722Reviewed-by:
-
