- 20 Jul, 2018 40 commits
-
-
Khushal authored
This includes the browser side setup for initializing a seperate disk cache for skia generated shaders. It also temporarily disables using this cache in the GPU, to narrow down whether that is causing the CQ bots to fail. TBR=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1a84d2757fa0e534dd57e89d68ba6a374be26d77 Reviewed-on: https://chromium-review.googlesource.com/1144647 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#576792}
-
Yuichiro Hanada authored
Bug: 845079 Test: Ran on DUT. Change-Id: Icc7653a29afc42aea7abeacebcd412aef70c2eee Reviewed-on: https://chromium-review.googlesource.com/1143105Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#576791}
-
Ramin Halavati authored
Network traffic annotation for Geo location is updated. Change-Id: Iea53ce53c8f9262055212b49675c2cb4e4afeb32 Reviewed-on: https://chromium-review.googlesource.com/1142775 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#576790}
-
Sebastien Marchand authored
This CL add a feature parameter to the Proactive Tab Discarding and Freezing experiment to prevent discarding tabs that share their browsing instance with another tab. This might be too agressive, in practice we might just want to consider tabs under the same SiteInstance but this is not an information that we can access yet. Check this page for more details about the SiteInstance/BrowsingInstance concepts: https://www.chromium.org/developers/design-documents/process-models#Implementation_Notes UKM privacy document has been updated here (pending approval): https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAABzM-vE0 Bug: 775644, 862203 Change-Id: Iaf5107db1d68aa4a0155ecbae7283f487c23bb7c Reviewed-on: https://chromium-review.googlesource.com/1144188 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576789}
-
Tetsui Ohkubo authored
Input method icon color was affected by UnifiedSystemTray flag. TEST=manual BUG=859824 Change-Id: Id004e2bfe7e0f9addbc02385cd829b2b278eee6b Reviewed-on: https://chromium-review.googlesource.com/1143110Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576788}
-
Fady Samuel authored
This CL replaces primary and fallback SurfaceIds stored internally in SurfaceLayer and SurfaceLayerImpl with a SurfaceRange. This simplifies code substantially and makes updating surface layers faster because it involves creating fewer temporary objects. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib0d0e96210366f5127c34ccd2a46f103a6c208a3 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1144207Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576787}
-
Scott Violet authored
All interesting tests have been moved into ash_unittest and/or nuked. BUG=842365,725095,838520 TEST=covered by tests Change-Id: I27069966c2ea214a071371b7959f4e44b533dd83 Reviewed-on: https://chromium-review.googlesource.com/1142622 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576786}
-
tzik authored
Remove tzik from Service Worker and Pepper to reduce the CCed CLs. Tbr: tzik@chromium.org Change-Id: I962235b70453c15c65699a6168b99c72e4b0e61a Reviewed-on: https://chromium-review.googlesource.com/1144596Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#576785}
-
Hiroshi Ichikawa authored
Bug: 862537 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib7f92055fb4bdcf1b27b1801be2d6f1dad969282 Reviewed-on: https://chromium-review.googlesource.com/1143100 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576784}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I62e30adfad4dfded4c9644d8859bf3897cda8548 Reviewed-on: https://chromium-review.googlesource.com/1143020 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576783}
-
Paul Irish authored
Change-Id: I2184b7fbd0d16543c310a5f52195feae60962c23 Reviewed-on: https://chromium-review.googlesource.com/1142730Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#576782}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20c1311957dd..3899f1bcce7b git log 20c1311957dd..3899f1bcce7b --date=short --no-merges --format='%ad %ae %s' 2018-07-20 vapier@chromium.org pylint: upgrade to 1.5.6 Created with: gclient setdep -r src/third_party/depot_tools@3899f1bcce7b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:863669 TBR=agable@chromium.org Change-Id: I367e9aa371d3240965079c92b6b1598a24b60f7f Reviewed-on: https://chromium-review.googlesource.com/1144681Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576781}
-
Dominic Farolino authored
This aims to tackle the issue of setting a ResourceRequest's referrer and referrer policy (corresponding to Fetch's concept request referrer and concept request referrer policy) independently. There is no observable effect from this CL; it serves only as a refactoring of when we generate a ResourceRequest's Referer header. Before this CL, in order to set a ResourceRequest's referrer policy, the Referer header had to be generated on the spot. After this CL, a ResourceRequest's referrer and referrer policy are stored and able to be set independently. Prior to the ResourceRequest being sent out, we generate the final Referer header (analogous to Main Fetch invoking "determine request's referrer" algorithm). This CL also adds TODOs for later work revolving around storing ResourceRequest's referrer in the form of a separate member, as opposed to a Referer header. Bug: 863769 Change-Id: I269c95a956b347c131115ce2cec34965d1baf090 Reviewed-on: https://chromium-review.googlesource.com/1137928 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576780}
-
Yutaka Hirano authored
http/tests/fetch/chromium/call-extra-crash-tee.html and http/tests/fetch/chromium/release-handle-crash.html are marked as slow. Let's mark virtual/outofblink-cors-ns/ ones as slow as well instead of marking them as TIMEOUT. Bug: 862184, 853977 Change-Id: Ia26c116e5c43912591ce61137abe50473c9e8881 Reviewed-on: https://chromium-review.googlesource.com/1144592Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576779}
-
Ian Kilpatrick authored
This shouldn't have any behaviour change. Instead of using the ComputeInlineSizeForFragment call directly, we optimistically perform layout on the float to determine this size. This saves an allocation of an NGConstraintSpace (and simplifies the code dramatically), which results in a 25% perf increase in some float benchmarks (see previous pinpoint result). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I111e62a4c16c206473085ebd309719f017196959 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1143882 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576778}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eb4ac1447746..25fb576a3ccd git log eb4ac1447746..25fb576a3ccd --date=short --no-merges --format='%ad %ae %s' 2018-07-20 dgarrett@google.com config_lib: Add workspace_branch option. 2018-07-20 derat@chromium.org cbuildbot/stages: Make TastVMTest support "informational". Created with: gclient setdep -r src/third_party/chromite@25fb576a3ccd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If23ca05714fc8058607479b386b054299b537ba6 Reviewed-on: https://chromium-review.googlesource.com/1144680Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576777}
-
Kenichi Ishibashi authored
When S13nServiceWorker is on, this test was faiiling because we didn't implement SetIdleTimerDelayToZero() in MockServiceWorker. This resulted in not calling StopWorkerIfIdle() on the first active ServiceWorkerVersion. This CL implements SetIdleTimerDelayToZero() as an empty virtual method in EmbeddedWorkerTestHelper. MockServiceWorker just calls it. Subclasses of the helper implement the method as needed. To make ServiceWorkerActivationTest.NoInflightRequest pass, this CL creates a new subclass of the helper. It implements SetIdleTimerDelayToZero() so that it calls RequestTermination() for the corresponding EmbeddedWorkerInstanceHost. This results in calling ServiceWorkerVersion::StopWorkerIfIdle(). Bug: 860361 Change-Id: Ibd178d5ca1f01e7fddd115296188793fb31edb53 Reviewed-on: https://chromium-review.googlesource.com/1136160 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576776}
-
Ramin Halavati authored
Preferences defined in 'components/translate/core/browser/translate_pref_names.h' 'components/translate/core/browser/translate_prefs.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I5d54f16d6637a6da53514a01ffe1f19f9ad2f4f1 Reviewed-on: https://chromium-review.googlesource.com/1142774Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576775}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I090c5ba73823e8586533d5ad2ce27824d2223841 Reviewed-on: https://chromium-review.googlesource.com/1144654Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576774}
-
Matt Falkenhagen authored
This more closely matches the legacy code path. We wait for network quiet as an optimization, as the update may adversely impact page load performance. The design is: - During the main resource request, mark the provider host as needing to update its controller service worker. - After navigation, the renderer sends the provider host a HintToUpdateServiceWorker IPC on network quiet. When the host receives this message, it schedules an update task on the relevant ServiceWorkerVersion, which triggers after 1 second. - If the HintToUpdateServiceWorker IPC was never received and the host is being destroyed while marked as needing to update, it schedules the update task then on the ServiceWorkerVersion as above. This CL handles the major case. Future work can be to expand this to shared workers and intermediate service workers in the redirect chain. A unit test is added. There is also an existing WPT: update-after-navigation-fetch-event.https.html See also design doc: https://docs.google.com/document/d/1f0oVW9d04qTLRX9e0qJ9gQW6bQIgN-_fiAFgmn6UcpI/edit?usp=sharing Bug: 853635 Change-Id: I7196d4e8b84312504851bf04defb3d8cfae291c6 Reviewed-on: https://chromium-review.googlesource.com/1143061Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576773}
-
Dean Liao authored
Move constructor must be explicitally defined. In the mean time, disable copy constructor and adds Clone() as an explicit object copier for parameter passing. BUG=b:110815424 TEST=pass media_unittests --gtest_filter=VideoFrameLayout.* Change-Id: I70af93080107280ac7e062d222c73d7947c45d07 Reviewed-on: https://chromium-review.googlesource.com/1143122 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576772}
-
Parastoo Geranmayeh authored
Regex constants are added to cover phone code (as in +1). The regex for other languages are also improved. Bug: 865704 Change-Id: Iab678b7419f04fb6e495eda1c35d5911b2217997 Reviewed-on: https://chromium-review.googlesource.com/1144251 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576771}
-
Yutaka Hirano authored
Based on UMA data, it's fairly common for extensions to modify WebSocket cookie headers. Support this in the network service. Only adding cookie headers is supported. Extensions don't see cookie headers that would be sent to the network. Extensions cannot express an intent not to attach cookies. Bug: 721400 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I462735930f63a8d45cc66604888bae2e71e6345f Reviewed-on: https://chromium-review.googlesource.com/1143088 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#576770}
-
Jared Saul authored
A sign-in promo pops up right after a card is saved locally. This also introduces a "Manage cards" bubble, with a footnote of a sign-in promo. An organized list of the diffs -- https://screenshot.googleplex.com/kMBPkpWZYsq.png A rough doc I quickly put together of the changes in this CL -- https://docs.google.com/document/d/1DarGyLBDSBWcsumcxhpojuvugUTUU6r5j6uI0RZZAo0/edit?usp=sharing Here are different screenshots explaining why we chose to have the promo not display a title -- Using promo's title (The string isn't updated in this screenshot): https://screenshot.googleplex.com/kiYnAynyedD Empty promo title, using main bubble title: https://screenshot.googleplex.com/rT3F9RETsgq No promo title, using main bubble title: https://screenshot.googleplex.com/nMXOdNvysbR This is what the mocks were like (with the old UI): https://screenshot.googleplex.com/AhXfxONG0sO Additionally, this is what the sync promo looks like: https://screenshot.googleplex.com/J3huQ06Y5X8 Sign-in promo on the Manage Cards view: https://screenshot.googleplex.com/MJqf5Fbhnpa Sync promo on the Manage Cards view: https://screenshot.googleplex.com/cNLy78Ts80k Metrics, additional browser tests, and omnibox icon animation to follow. Bug: 855186 Change-Id: I74ecdd802da960120baacfdd771c90cb126fbd10 Reviewed-on: https://chromium-review.googlesource.com/1134514 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#576769}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea9328b8e855..9cf0f36d349f Created with: gclient setdep -r src-internal@9cf0f36d349f The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852038,chromium:852034 TBR=mmoss@chromium.org Change-Id: I07282894134f4ba5d4aa6f4888c92d79871a1a1f Reviewed-on: https://chromium-review.googlesource.com/1144283Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576768}
-
Makoto Shimazu authored
Adding tests to check if DNT header is perserved when a page is controlled by a service worker but requests fall back to the network. Bug: 853085 Change-Id: I9beeda397d4fbdef13aee11e36af3efaaec142f1 Reviewed-on: https://chromium-review.googlesource.com/1139458Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576767}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0d3804ca43ac6e26ef1d835e3c0366563a60501d Reviewed-on: https://chromium-review.googlesource.com/1144491Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576766}
-
Tien-Ren Chen authored
This CL changes the pre-snapping policy of <video> so that only the size of the contents is pre-snapped, while the location will exactly match the content box's final location. BUG=730284 Change-Id: I6d02bb09fc5d570f74b94923b6b806e16ed4f119 Reviewed-on: https://chromium-review.googlesource.com/1144256 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576765}
-
Yoshifumi Inoue authored
This patch get rid of redundant |NOTREACHED()| from |CompositeEditCommand:: Apply()| since we can apply any commend to plaintext-only content editable. Bug: 863708 Change-Id: Id3e7377d88ffc16f0a8f32f13002de01e3184b67 Reviewed-on: https://chromium-review.googlesource.com/1143112Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576764}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ddcb32d165e..d26f5c315d5e git log 0ddcb32d165e..d26f5c315d5e --date=short --no-merges --format='%ad %ae %s' 2018-07-19 benjhayden@chromium.org Extend Descriptor to support more test suites. Created with: gclient setdep -r src/third_party/catapult@d26f5c315d5e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iee2a3a754e9b51f68976a6a52dd91f506549aa12 Reviewed-on: https://chromium-review.googlesource.com/1144066Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576763}
-
Tommy Martino authored
This CL addresses a UX regression caused in this revision: https://chromium.googlesource.com/chromium/src/+/fa89015c94aa96aed4bcf1452b8c808de3ab627c Specifically, the extra height which compensates for corner rounding in the footer was removed. In pixel terms, this shrunk the footer row from 40px to 36px. This CL reintroduces the extra height. Change-Id: Ib5d6c1d0a8af1bd63c960597654f85982e280e3a Bug: 865479 Reviewed-on: https://chromium-review.googlesource.com/1143688Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576762}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5deb17553471..20c1311957dd git log 5deb17553471..20c1311957dd --date=short --no-merges --format='%ad %ae %s' 2018-07-19 robliao@chromium.org Replace Right Single Quotation Mark (U+2019) with Apostrophe (U+0027) Created with: gclient setdep -r src/third_party/depot_tools@20c1311957dd The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I296e4d351a0d74113cf3956101ee574fea4a89fe Reviewed-on: https://chromium-review.googlesource.com/1144028Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576761}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e34766b47b67..eb4ac1447746 git log e34766b47b67..eb4ac1447746 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 sawlani@google.com chromeos_config: Customize lakitu-full build config. 2018-07-19 pprabhu@chromium.org sysmon: Ignore lab servers in chromeos9- 2018-07-19 mikenichols@chromium.org metrics: Introduce float based timings metric. 2018-07-19 dhanyaganesh@chromium.org CreateTarball: print unformatted results from lsof 2018-07-19 dgarrett@google.com generic_stages: Remove _ExtractStages helper. 2018-07-19 xixuan@chromium.org SkylabSuite: Add swarming task priority for skylab suite. Created with: gclient setdep -r src/third_party/chromite@eb4ac1447746 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c33981d0d3fcc3d58eef9187a040dc36d024d18 Reviewed-on: https://chromium-review.googlesource.com/1144024Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576760}
-
Justin Novosad authored
BUG=788439 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib758904323adb6039d21f916d4aed9fdc631278e Reviewed-on: https://chromium-review.googlesource.com/1144275 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576759}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 942c9ea0. With Chromium commits locally applied on WPT: 1f227e06 "Implement FeaturePolicy sync-script (as an experimental feature policy)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21567 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=foolip No-Export: true Change-Id: Ib97b8245f59ff04b9715a5cce4ad78947d677cd3 Reviewed-on: https://chromium-review.googlesource.com/1144529 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576758}
-
Wenzhao Zang authored
cr_checkbox started to use FlexBox in https://chromium-review.googlesource.com/c/chromium/src/+/1033346 So the custom margin is no longer needed. Bug: 864935 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idf0d2eb549a026cee160dc16e37cc2b770a5fc89 Reviewed-on: https://chromium-review.googlesource.com/1144476Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576757}
-
chrome://flags#enable-web-authentication-cable-supportKim Paulhamus authored
caBLE is a transport option for the WebAuthN API Bug: 837088 Change-Id: I81ea955bb95848161a927fb2a1b84773cf572d24 Reviewed-on: https://chromium-review.googlesource.com/1144418 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576756}
-
Tetsui Ohkubo authored
ARC++ notifications are shown above scroll bar, so we temporarily make scroll bar invisible as a workaround. When the limitation is removed from ARC++, the flag will be removed and the scroll bar will be restored. TEST=manual BUG=858940 Change-Id: I6931c6406c9feb2bb4159d737205187bdc88b86b Reviewed-on: https://chromium-review.googlesource.com/1140014Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576755}
-
Xing Liu authored
Uses weak pointer in DownloadServiceImpl to fix a potential memory corruption in |pending_tasks_|. Bug: 860771 Change-Id: Ib84f4c27aa4d2f1e7560434d41175ecba0a622e5 Reviewed-on: https://chromium-review.googlesource.com/1144464Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576754}
-
Kenichi Ishibashi authored
As a comment in ServiceWorkerRequestHandler::InitializeHandler() says[1], we may call it but do nothing when S13nServiceWorker is enabled. Skip tests for InitializeHandler() when S13nServiceWorker is enabled. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_request_handler.cc?l=232&rcl=e09f67110c9a517c981814b643b69c8de0833aac Bug: 860361 Change-Id: I55afa47c165c33d82b38e9e2b89b153ff8aaffb2 Reviewed-on: https://chromium-review.googlesource.com/1144580Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576753}
-