GitLab

BUG=none
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/286023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272936 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces AsyncUtil.ConcurrentQueue class, which is almost same as AsyncUtil.Queue but it can run multiple jobs concurrently.

BUG=367123
TEST=Files.app works well

Review URL: https://codereview.chromium.org/293053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272934 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noamsml
NOTRY=True

Review URL: https://codereview.chromium.org/298883012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272933 0039d316-1c4b-4281-b951-d872f2087c98

Breaks device enumeration.

BUG=377650

> reland 260073013: Added automatic mode to FakeInputAudioStream to generate automatic beeps
> 
> Added automatic mode to FakeInputAudioStream to generate automatic beeps.
> 
> This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing.
> 
> Previously it broke the mac bots due to it somehow triggered crbug/288562, crbug/371271, which should have been fixed by https://codereview.chromium.org/274073002/
> 
> TBR=ananta@chromium.org, dalecurtis@chromium.org
> 
> NOTRY=true
> 
> BUG=358541
> TEST=bots existing webrtc tests.
> 
> Review URL: https://codereview.chromium.org/279223002

TBR=xians@chromium.org

Review URL: https://codereview.chromium.org/300143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272932 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds following keyboard shortcuts for debugging Files.app.

* Ctrl+Shift+I: Open inspector
* Ctrl+Shift+J: Open inspector and focus to console.
* Ctrl+Shift+C: Open inspector and start element inspection.
* Ctrl+Shift+B: Open inspector for the background page.

BUG=280551

Review URL: https://codereview.chromium.org/299443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272931 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272930 0039d316-1c4b-4281-b951-d872f2087c98

process_resources.py already implements almost everything from
apk-codegen.xml so just use that instead.

BUG=359249, 375324, 375431
TBR=yfriedman

Review URL: https://codereview.chromium.org/306453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177319,374943
NOTRY=true

Review URL: https://codereview.chromium.org/291153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272927 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows hosted app windows to be pinned to the taskbar by
right-clicking the taskbar icon and pressing the "Pin to taskbar" button.

This CL pulls out the code that sets the relaunch details of v2 app
windows into web::UpdateRelaunchDetails.

BUG=368101
TEST=Run a hosted app as a window. Pin it from the taskbar icon right click
menu. Relaunch the app from the pinned icon.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851

Review URL: https://codereview.chromium.org/258243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/300703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272922 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377599
TBR=hidehiko@chromium.org,bbudge@chromium.org

Review URL: https://codereview.chromium.org/306503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272921 0039d316-1c4b-4281-b951-d872f2087c98

This keeps tests on a particular shard, until their name changes.

Currently tests can move to a different waterfall bot between runs;
whenever a test is added or removed "before" it in the test suite. This
makes it very hard to track failure history of a particular test, since
it can "disappear" from prior builds on that bot.

Also, since the shards do not have synced cycles, a revision that breaks
test "A" might never be in a blamelist. E.g. Bad revision X breaks test
"A", good revision X+1 adds unrelated test "B". Blamelists
bot0:[X],[X+1] and bot1:[X, X+1]. Only bot0 will run test "A", and only
on its second run, but it will not blame revision "X". Note "X" could
even be the revision that adds test "A".

Hashing the name does not guarantee an even distribution of tests.
However, the duration of a test is not predictable, so the change to
load variance should balance out except in pathological cases or very
small test suites.

BUG=372461
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/292973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272920 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272914 0039d316-1c4b-4281-b951-d872f2087c98

Currently resource sharing across versions and registrations is not supported,
so resource ids should not be overlapped between a new registration and an old
registration on WriteRegistration().

This change adds a check to make sure it.


BUG=n/a
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/302623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176891
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/305543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272911 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357693

Review URL: https://codereview.chromium.org/296023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272909 0039d316-1c4b-4281-b951-d872f2087c98

context menu on long press if the events are targetted at a view
which can show the context menu. If a different view is the gesture
handler and the event was targetted at a different view (e.g.
because the maximize button handled ET_GESTURE_TAP_DOWN) the parent
view should not show a context menu on long press.

Previously, we were assuming that events were in the coordinates of
|PostEventDispatchHandler::owner_| and were sometimes passing an
incorrect position to BrowserFrame::ShowContextMenuForView().

BUG=375232
TEST=RootViewTest.ContextMenuFromLongPress

Review URL: https://codereview.chromium.org/291273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376038

Review URL: https://codereview.chromium.org/302443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272906 0039d316-1c4b-4281-b951-d872f2087c98

Previously Android client was crashing because JingleThreadWrapper
was not initialized for the networking thread. It was broken by
crrev.com/271351, which removed JingleThreadWrapper initialization
from  LijbingleTransportFactory.

TBR=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/298013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272905 0039d316-1c4b-4281-b951-d872f2087c98

Remove unused code in DesktopScreenPositionClient. In the cases that it is called DesktopNativeWidgetAura::ForWindow() always returns NULL

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/292583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272904 0039d316-1c4b-4281-b951-d872f2087c98

It's been a couple years since anyone worked on it, and there
are no plans to enable it by default.

Cached pipelining-related server information will automatically
be cleared when server information is next saved, so there are
no issues on that front.

BUG=364557
R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/275953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272903 0039d316-1c4b-4281-b951-d872f2087c98

This is to facilitate the addition of an app launcher example/demo app,
separate from the browser, and to assist testing of the out-of-process
compositor on mac.

The change splits out from the current views_examples_with_content_exe
target a new views_content_client target placed in
ui/views_content_client. views_examples_with_content_exe is updated to
use it.

This will allow the app launcher to have its own example app, while
reusing the logic to set up the multiprocess runtime environment for
using views and content.

Follow-up patches for the views_content_client runtime will: isolate
aura dependencies, introduce the gpu_process UI compositor, and
implement the runtime environment for mac.

BUG=365977

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272476

Review URL: https://codereview.chromium.org/284113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272902 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for weird platforms that don't present the buffer without
extra help. In particular gbm (from EGL_MESA_platform_gbm) has this
requirement.

TBR=kbr
TEST=ozone build
BUG=377497

Review URL: https://codereview.chromium.org/300023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/296693013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374183

Review URL: https://codereview.chromium.org/298953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272899 0039d316-1c4b-4281-b951-d872f2087c98

* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they
run in a separate process and previous base::DIR_HOME override does not apply there.

This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.

Note:
download_prefs.cc still uses GetHomeDir() in its DownloadPathIsDangerous() check.
// Consider downloads 'dangerous' if they go to the home directory on Linux and
// to the desktop on any platform.
In this context correct behavior is to use "real" base::GetHomeDir() and not "virtual one" base::DIR_HOME.
Since latter is remapped to some test dir in tests, in some subfolders in Chrome OS etc.

BUG=331530
TBR=vitalybuka@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270872

Review URL: https://codereview.chromium.org/200473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377508
TEST=Manually verified this updated angle matches expectations.

Review URL: https://codereview.chromium.org/293383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272897 0039d316-1c4b-4281-b951-d872f2087c98

This is an intermediary CL. The FaviconClient is moving towards being a KeyedService.

BUG=377505

Review URL: https://codereview.chromium.org/303453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272896 0039d316-1c4b-4281-b951-d872f2087c98

We need to call ui::InitializeInputMethodForTesting. This is currently
protected by USE_X11 but should not be.

TBR=pfeldman
BUG=none
TEST=content_shell --ozone-platform=egltest

Review URL: https://codereview.chromium.org/301603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272895 0039d316-1c4b-4281-b951-d872f2087c98

Fixed playout time calculations by relying on the sender reports in order
to compute reliable capture timestamps in terms of the local clock.  Added
a ClockDriftSmoother to smooth out jitter/skew in the "NTP to local clock
TimeTicks" conversions.  Used the same to provide a gradual timeline shift
in the case where a receiver had to "hack up" playout times before the
first sender report was processed.

As proof-of-concept, also added playout_time "smoothness" testing to the
End2EndTest's.  Both first and second order effects are tested.

Miscellaneous clean-ups and fixes in timing code throughout media/cast.

BUG=356942

Review URL: https://codereview.chromium.org/280993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272893 0039d316-1c4b-4281-b951-d872f2087c98

In current code, EmbeddedWorkerDispatcher is deleted in the destructor of RenderThreadImpl.
If EmbeddedWorkerDispatcher contains any WorkerWrapper in workers_, WorkerWrapper and EmbeddedWorkerDevToolsAgent will be deleted at that time.
And the destructor of EmbeddedWorkerDevToolsAgent will call RemoveEmbeddedWorkerRoute of RenderThreadImpl which is being deleted.

To avoid this we should delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown().

BUG=377258,358657

Review URL: https://codereview.chromium.org/297343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264
TBR=jam@chromium.org for code deletion in content/public/browser_plugin_guest_delegate.{cc|h}

Review URL: https://codereview.chromium.org/295083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272889 0039d316-1c4b-4281-b951-d872f2087c98

Roll the script to 209116 to match a recent clang roll.

BUG=375245
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/301583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272888 0039d316-1c4b-4281-b951-d872f2087c98

This adds the image that Issue 294343004 is dependent on.

BUG=331453
R=bauerb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/293363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272887 0039d316-1c4b-4281-b951-d872f2087c98

Similarly to chrome://drive-internals, this patch introduce a webui page
showing what's going on in the system.

Currently, only mounted file systems, and number of active requests are shown,
however more is coming soon.

TEST=Tested manually by invoking chrome://fsp-internals with a running
     providing extension.
BUG=376095

Review URL: https://codereview.chromium.org/296003012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272886 0039d316-1c4b-4281-b951-d872f2087c98

We used to declare sanitizer interface functions explicitly because we didn't
have access to sanitizer interface headers. That has not been the case for a
while. Also, a recent clang roll changed the signature of
__sanitizer_sandbox_on_notify() causing conflicts with our own declaration.

BUG=none
TBR=jln@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/294093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272885 0039d316-1c4b-4281-b951-d872f2087c98

Added automatic mode to FakeInputAudioStream to generate automatic beeps.

This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing.

Previously it broke the mac bots due to it somehow triggered crbug/288562, crbug/371271, which should have been fixed by https://codereview.chromium.org/274073002/

TBR=ananta@chromium.org, dalecurtis@chromium.org

NOTRY=true

BUG=358541
TEST=bots existing webrtc tests.

Review URL: https://codereview.chromium.org/279223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272884 0039d316-1c4b-4281-b951-d872f2087c98

content Response::Parse doesn't match chrome Response::Serialize.

BUG=373325

Review URL: https://codereview.chromium.org/300703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/291343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272882 0039d316-1c4b-4281-b951-d872f2087c98