GitLab

This reverts commit 44e43142.

Reason for revert: Lots of builders are failing in gclient runhook.
https://ci.chromium.org/p/chrome/builders/ci/test-wifi-tablet/19099?

Original change's description:
> Reland "Temporary add verify_file_exists to check files downloaded."
> 
> This reverts commit 2b17e053.
> 
> Reason for revert: Reland initial cl after fix the typo
> 
> Original change's description:
> > Revert "Temporary add verify_file_exists to check files downloaded."
> >
> > This reverts commit e69f63a3.
> >
> > Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206.
> >
> > Original change's description:
> > > Temporary add verify_file_exists to check files downloaded.
> > >
> > > R=​bsheedy@chromium.org
> > >
> > > Context: to make sure those wprarchive files are downloaded properly.
> > > Bug: 1096656
> > > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > > Commit-Queue: Arthur Wang <wuwang@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#801957}
> >
> > TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org
> >
> > Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1096656
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541
> > Reviewed-by: Brandon Wylie <wylieb@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Brandon Wylie <wylieb@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#801977}
> 
> R=​bsheedy@chromium.org
> TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org
> 
> # Not skipping CQ checks because this is a reland.
> 
> Bug: 1096656
> Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892
> Commit-Queue: Arthur Wang <wuwang@chromium.org>
> Reviewed-by: Arthur Wang <wuwang@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#802390}

TBR=dpranke@google.com,bsheedy@chromium.org,wylieb@chromium.org,wuwang@chromium.org

Change-Id: Ia62b89df8121aa6cbf6726a81f8f64a400a49d33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1096656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380742Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802407}

A previous CL changed two spots that call UpdatePolicy() to instead
directly change the compositor policy since a full policy update was
not needed. This CL further modifies that change by moving the
compositor priority out of the policy so that it can be changed without
altering the policy outside of a call to UpdatePolicy().

Change-Id: Ibf2ad8da64ea34f0c0aa776b1be8dc79a3bbfe2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357092
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802406}

This is a reland of f1d35ca2

Original change's description:
> linux sysroot: fix libwayland-client-symbols file.
> 
> I initially generated it by myself and made a huge mistake by
> setting base version to a single version. However, some symbols
> only appeared after certain version. Thus, fix that problem by
> copying and using the symbols file from wayland packages
> in https://git.launchpad.net/ubuntu/+source/wayland.
> 
> Bug: 1116384
> Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674
> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802226}

Bug: 1116384
Change-Id: I0bbdcc98f0c88d414edef74db8b38e30249cbc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380318Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802405}

When the top toolbar in new tab page layout view is out of screen,
we need to notify SnapScrollHelper in FeedSurfaceMediator.ContentChanged
to bring back the toolbar. This is done by hooking up the stream
content change listener between FeedStream and FeedSurfaceMediator.

Bug: 1120298
Change-Id: Ib763185f33c78308372914f87b45989e55827fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377608
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802404}

Bug: 1035213
Change-Id: I3da4241c0e97ab3b546ee3cf8b4dc885cc93359d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369573
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802403}

This moves the clearing of the gesture state to before the ole32 drag
drop. Otherwise, the ole32 drag drop nested event loop can trigger
two kGestureScrollBegin events in a row, causing a DCHECK.

Long term, per mustaq@, when the drag-drop controller takes over control
from the gesture recognizer at gesture-long-press, the GR should be
ignoring the "current gesture stream" (from the very first finger going
down until the very last finger leaving the screen).

Bug: 1120809
Change-Id: I792471a2212647282b84d7745c5e7f861b15a28d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378851
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802402}

https://quiche.googlesource.com/quiche.git/+log/d8fb72d5ad9c..e447bc609047

$ git log d8fb72d5a..e447bc609 --date=short --no-merges --format='%ad %ae %s'
2020-08-27 fayang Neuter initial packet in the coalescer when discarding initial keys.
2020-08-27 fayang Deprecate gfe2_reloadable_flag_quic_update_packet_size.
2020-08-27 bnc Refactor GOAWAY-related accessors.
2020-08-26 dschinazi Add memory safety guard for QuicFrame
2020-08-26 dschinazi Add some QUIC DCHECKs

Created with:
  roll-dep src/net/third_party/quiche/src

R=dschinazi@chromium.org

Change-Id: I66ddfd794c1ff4620603d9a954375686c0fae256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380214
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802401}

The 'generated_script' type in MB configs allows the user
to specify an alternative to "bin/run_$target" as the script to
use. However, in order to make things consistent, we really don't
want to support that.

This CL is a first pass at cleanup by removing every case where
script was set to match "bin/run_$target", and then adjusting
the logic in mb.py to supply that.

It also removes a bunch of unnecessary `args` settings where the
setting just matched the default ([]), and updates the doc
comments in gn_isolate_map.pyl.

Bug: 816629
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: Iedd072c4fc2b53605c0f225152bcc7ee6b80ec5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380420Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#802400}

This CL plumbs the blink::mojom::FocusType of a focus event into
WebContentsObserver via FocusedNodeDetails. This allows observers to
differentiate focuses that occurred from mouse clicks vs keypresses
etc.

Bug: 1104280
Change-Id: I01494e89034e7172dfa808965280013987ac1c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378392
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802399}

kSigninShouldPromptForSigninAgain should be reset before any EG tests,
like other preferences.

Fixed: 1122648
Change-Id: I4cb998134b2c4e4b0f8819ebc87fab03a53911de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380272
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802398}

This CL returns back MemoryPressureMonitor for Linux that was temporarily removed during memory subsystem changes.
Based on the previous implementation with some refactoring.

Bug: 463606
Change-Id: I5e6fbf46c913a86c152faea7964288249cc04247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1386856
Auto-Submit: Kirill Ovchinnikov <kirill.ovchinn@gmail.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802397}

Spec:
https://drafts.csswg.org/css-content/#quotes

Intent-to-ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/iqihcxi-CzY/m/U_0GkEoqCAAJ

Bug: 990557
Change-Id: I82ab72f05468b846bf10c6b37b74eaa3e35c457c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366720Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802396}

As per suggestion at https://docs.google.com/document/d/1Q9oYW2w0-QTR6R8uI6yjriFu75e6_K50qcHyj3lda6c/edit?disco=AAAAKHpexIU
It will be renabled with a separate pool, but currently disabling it to free up the resources

Bug: 1024915
Change-Id: I83f411ccfc3aa7db690fb175810f5287153ff96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379399
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802395}

https://android.googlesource.com/platform/external/perfetto.git/+log/8e6246dafe61..cc61e5a98324

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I9cde8726e2fd67c65015929c2ac31a1e6f2a9609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380570Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802394}

Bug: 1102927
Change-Id: Iee104ca7c5c75ecaa964e8d121c331cfbb8b5abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289384
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802393}

Allow git to ignore build/fuchsia/internal directory.
Make DeviceTarget generic class for non-emulator targets that don't need provisioning.
Replace original DeviceTarget with GenericX64Target, for provisioning devices with generic x64 build.

Bug: 1080854
Change-Id: I2e70a85689ce9527b86bcb5eeb24895119454da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343228
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#802392}

Renames EncodedVideoConfig -> VideoDecoderConfig.
Adds coded, crop, and display sizes, removes aspect ratio.

Bug: 1122126
Change-Id: If80fef74d64f35a83e531bc7789d3559ec510a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377899Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802391}

This reverts commit 2b17e053.

Reason for revert: Reland initial cl after fix the typo

Original change's description:
> Revert "Temporary add verify_file_exists to check files downloaded."
>
> This reverts commit e69f63a3.
>
> Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206.
>
> Original change's description:
> > Temporary add verify_file_exists to check files downloaded.
> >
> > R=​bsheedy@chromium.org
> >
> > Context: to make sure those wprarchive files are downloaded properly.
> > Bug: 1096656
> > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Commit-Queue: Arthur Wang <wuwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#801957}
>
> TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org
>
> Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1096656
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541
> Reviewed-by: Brandon Wylie <wylieb@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Brandon Wylie <wylieb@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#801977}

R=bsheedy@chromium.org
TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1096656
Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#802390}

CandidateWindowView inherits from BubbleDialogDelegateView which
creates a NonClientFrameView with a non-zero default corner radius.
It then replaces the border with its own BubbleBorder subclass with
a corner radius of 0.

This was causing issues where a clipping mask would initially be
applied due to non-zero border radius but never updated once the 0
radius border was set (masks aren't applied to views that are
identified as not needing one).

This CL fixes the issue by disabling the use of rounded corners on
the CandidateWindowView, bringing the class' behavior inline with the
code author's intentions.

Bug: 1122476
Change-Id: I8c727e1c04ceab6e650924159dab2ef47c3b5eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380211Reviewed-by: My Nguyen <myy@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802389}

Combine OverflowClipBehavior enums for platform overlay scrollbars
and CSS overlay scrollbars because they don't have any difference about
layout and clipping behavior.

We clip for overflow:overlay (CSS overlay) scrollbars because we didn't
properly handle z-order of these scrollbars, and they might be covered
by stacked children. Now use the same z-ordering algorithm for both
overflow:overlay scrollbars and platform overlay scrollbars.

This CL fixes issues of overflow:overlay scrollbars, and also makes it
easier to remove it in the future because this CL reduces the difference
of overflow:overlay scrollbars from platform overlay scrollbars.

Bug: 984167
Change-Id: Id239734ec773d826291ec357fa1036f6b4b95038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370564
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802388}

Bug: 1111979
Change-Id: I3aba5bdebdb47ebf75b954e67ce1f4948e1d761a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380691
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802387}

This is a revised version of original attempt crrev.comc/c/2166804.
Instead of creating a new layers, this clone and animate the window's layer,
but makes sure that the animating layer is at the bottom of other layers
within the window.

* It adds a invisible view with a layer
  at the bottom of the non_client_view (no frame w/o this, so we can exclude such case).
* Adds the animating layer as a child of this view, with
  "SetMasksToBounds(false)" so that it will not be clipped during animation.
* Once animation is done, this animating, old layer will be removed.

Bug: 1073685
Test: covered by unittests.
Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1
Fixed: 2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802386}

https://chromium.googlesource.com/catapult.git/+log/788aa6fd2c18..be71f6d9f008

2020-08-27 agrieve@chromium.org Add npm-debug.log and out-devil-deps to .gitignore

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: oysteine@google.com
Change-Id: I4ca78935635c5b53da113d7dfe099e72b2c445a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380203Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802385}

CommandId and ClickInfo are sent by OneGoogle inside a 'data' property
in MessageEvent.data. This CL fixes handling of OneGoogle promo browser
commands by looking for CommandId and ClickInfo in
MessageEvent.data.data

Bug: 1106421
Change-Id: I87f2d58ea47aa71e6662bb331170d0074cefb212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376979
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802384}

These are failing on recent builds.
StartSurfaceLayoutTest.testThumbnailAspectRatio_default.
StartSurfaceLayoutTest.testThumbnailAspectRatio_point75.

TBR=wychen@chromium.org

Bug: 1122657
Change-Id: Ib68765728b77dbb08c23d81667a2eb680231781a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380199Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802383}

https://android.googlesource.com/platform/external/perfetto.git/+log/11944f7122cf..cc61e5a98324

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I41e102bbb1e6f694d47e7b27e028614c63186f38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380082Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802382}

_generate_js_imports() was assuming that HTML files have no copyright
header, and consequently produced incorrect results when that
assumption was broken.

Tests based on lucmult@ attempt at:
https://chromium-review.googlesource.com/c/chromium/src/+/2379414

Bug: None
Change-Id: I1ac190518fb7141d0016b7d4717cee08146e3853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380076
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802381}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fd76f85b10e..aac228ce1bbf

2020-08-27 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.3.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:772558
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ia499d1b5c0bb78e4b8597fb55fae672d5b01940d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802380}

This config makes a difference for test suite to pass or not.
See crbug.com/1115229#c51. So add it the trybot config.

Bug: 1115229
Change-Id: Ib7c738608ebc2ff6e92d6287b38ea52354254fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380103
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802379}

Change-Id: Idcf17aad024c6417976615f8bfbf3cc2df138369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378800
Commit-Queue: Wayne Piekarski <waynepie@google.com>
Auto-Submit: Wayne Piekarski <waynepie@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802378}

This test is timing out frequently on Mac, so this CL adds that to
TestExpectations.

TBR=gogerald@chromium.org

Bug: 1045599
Change-Id: I77d567490cb3a9b200522670e8973e4e83c2aa90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380146Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802377}

This reverts commit 0ad6a0b8.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 802334 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzBhZDZhMGI4YjRlNGIyZWMwZmE2ZTY3ZWZmNzk5MDYwZGMyMDA0ZTQM

Sample Failed Build: https://ci.chromium.org/b/8870779059616927872

Sample Failed Step: compile

Original change's description:
> Replace AndroidX Preference[Dialog]FragmentCompat with the version from master
> 
> This CL replaces the PreferenceFragmentCompat and
> PreferenceDialogFragmentCompat classes in the AndroidX preference
> library with the version from master, which has a change needed for
> WebLayer. The preference library maintainers say they won't create a new
> release just for this fix, so to get it we'll have to pull it in
> ourselves.
> 
> Bug: 1092986
> Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802334}


Change-Id: I25e202b3329b651719e2903f7378b7d5811b3435
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1092986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380635
Cr-Commit-Position: refs/heads/master@{#802376}

Add UI for the update check, and support for base error and
offline for the update check.  Actual update check logic will be
added later after addition of support for ad-hoc queries to the service.

Bug: 1078782
Change-Id: I78a5a5b1713a8a040dde638cfbcdecbb313bbd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352907
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802375}

Chromecast implementation of ExtensionsBrowserClient can
return null for GetExtensionResourceManager. Added
a check to return early if null.

Bug: internal b/166307109
Test: Local display assistant build with screen reader extension
Change-Id: I61e3a1a55026d531e1947cd0d80e59e57d386a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372890
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802374}

The pool is going to be removed.

Bug: 1119885
Change-Id: I5dc5511a8078e305a139c07fd572ab2fac373fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378777Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802373}

This cl downloads and encodes instrument icon for SPC before it is
written to db.

Bug: 1121021, 1121331
Change-Id: Ifa875ad6a42380fb5f7a7790022f4dd17b835122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380142
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802372}

When running under a VNC session, the connection setup data sometimes
has duplicated depths, like so:

depth=24: visuals={123,456}
depth=24: visuals={789}

Previously, we were searching for the unique depth that matches the
root depth, then searching for the visual within the list
corresponding to that depth.  However, since the depths may not be
unique, search through all depths until we find a matching visual ID,
and then use that to set both the default depth and default visual.

R=sky

Change-Id: I51f75260f584f85f2bdc93048e6c4848cf00997a
Fixes: 1121438, 1115929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375888Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802371}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/80848e3b..81f3d945

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ide9420d14b8d9271c462bd9f9065050aa735dfe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379633Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802370}

https://skia.googlesource.com/skia.git/+log/faa844b3686c..532a264c141d

2020-08-27 herb@google.com use bit 15 to encode page information in glyph UV
2020-08-27 adlai@google.com Add GrDirectContext arg to SkImage::readPixels
2020-08-27 csmartdalton@google.com Don't pre-scale tessellated strokes by the matrix scale
2020-08-27 brianosman@google.com Run glnarrow/glesnarrow on GPU perf bots
2020-08-27 reed@google.com use pathbuilder
2020-08-27 brianosman@google.com Make SkRuntimeShaderBuilder safe for reuse
2020-08-27 johnstiles@google.com Improve control-flow support in early-return detection.
2020-08-27 bsalomon@google.com New helpers for SkYUVAInfo when used with pixmaps.
2020-08-27 bsalomon@google.com Remove do-nothing MPD benchmarking from nanobench

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: mtklein@google.com
Change-Id: Ie546955976a0d4665307f374713fe276c3c9aa3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380378Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#802369}

This is a fix for logic introduced in:
https://chromium-review.googlesource.com/c/chromium/src/+/2350315

It also includes a unit test that would have caught the regression.

BUG=1112814

Change-Id: I057f01f29892278231f36e6abb5334692e8ea401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378459Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802368}