- 20 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/410cf3af9982..d4d1ba4971aa git log 410cf3af9982..d4d1ba4971aa --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ehmaldonado@chromium.org git-cl: Use buildbucket v2 to schedule try jobs. Created with: gclient setdep -r src/third_party/depot_tools@d4d1ba4971aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I31da36727b1d0e0ac4f56996b86f1ddd82c7085a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698667}
-
Miguel Casas authored
This CL migrates MailboxVideoFrameConverter from using Textures to using SharedImages. No external functionality changes are expected. Couple of things need to be added: - ScopedSharedImage: an internal class to scope a SharedImage lifetime. SharedImages are kept in |shared_images_|, indexed by a unique id. - Added GetGpuChannelCB that can be derived from the GetStubCB and that is needed for SharedImage creation and destruction. They are generated on Create(), so this interface doesn't change. - This CL uses a WeakPtr to the GpuChannel, accessing its SharedImageStub and the gpu::Scheduler that way. Most of the work goes in: - InitializeOnGpuTaskRunner() and then - the sequence ConvertFrameOnGPUThread() (calls either GenerateSharedImageOnGPUThread() or UpdateSharedImageOnGPUThread()) then jumps back to WrapMailboxAndVideoFrameAndOutput(). Test: crosvideo.appspot.com resolution-changing videos (vp9, h264, vp8) of course with the new VD decoder, on kohaku and scarlet/dru. Bug: 998279 Change-Id: Ic9b5b2270d1b488562bc2725bba89dc2a0350012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772642 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698666}
-
Matt Menke authored
The class has a per-server cache that could be used for fingerprinting. As it's defined outside of net/, rather than make QuicCryptoClientConfig NetworkIsolationKey-aware, this CL has QuicStreamFactory create one QuicCryptoClientConfig per NetworkIsolationKey, as needed. Once there are no live QuicSessions/QuicStreamFactory::[.*]Jobs using a particular QuicCryptoClientConfig, the QuicCryptoClientConfig is added to an MRU cache of recently used configs, and reused/evicted as needed. This CL also passes in a NetworkIsolationKey to the HttpServerProperties::*QuicServerInfo calls, to finish hooking up NetworkIsolationKeys to HttpServerProperties. It's needed in this CL because the only integration tests for QuicCryptoClientConfig rely on those methods. Bug: 1003423, 969890 Change-Id: Id1823012104b84677f6684205bb58fa0227825b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809601Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#698665}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a75fd3592a81..7c07ddc63030 Created with: gclient setdep -r src-internal@7c07ddc63030 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1003454 Change-Id: Ifa7e52e3e9e210060e71b4c41fb911da72dec4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698664}
-
James Cook authored
These were added to support mustash/mash but we're not doing that project any more. aura::client::kMinimumSize is written, but the value is never actually used to apply a constraint. aura::client::kMaximumSize is never used. This CL is a partial revert of: [mus+ash] Fixes minimum browser window size with --mash https://codereview.chromium.org/2914793005 Bug: 728455 Test: existing unit tests and browser tests Change-Id: I0733ca35ddd4cec7ba04e11d47189d40549248f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815726 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#698663}
-
Sven Zheng authored
All new live tests should inherit from LiveTest. Bug: 992143 Change-Id: Ic8f0d05275a2f3fd4ab8eec40d8cb21c5215f8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767087Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#698662}
-
Ana Salazar authored
The page switcher buttons on the folder view didn't show the ripple effect when hovered, as opposed to the page switcher on the app list. This change adds the effect to be consistent Bug: 998388 Change-Id: I49e48680a9bb4106e069c0e031b1e43c7c120794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816982 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698661}
-
Steven Bennetts authored
Bug: 1001598 Change-Id: I93286efb961af979168f011360dd0329aa23ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803787 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698660}
-
Peter Boström authored
Makes sure this class is not instantiated during the kExtensionsToolbarMenu experiment. Also clearly documents that we expect this class to be removed once the experiment is launched. Bug: chromium:985834 Change-Id: Ic9cd2bb03cba4a3765317cb6d67bf7a2676e418c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814661 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#698659}
-
Gavin Mak authored
Currently, common.py uses the capability 'loggingPrefs'. Since ChromeDriver 75.0.3770.8, this name has been renamed to 'goog:loggingPrefs' as required by W3C standard. 'goog:loggingPrefs' has been changed to be the default capability. The flag --ignore_logging_prefs_w3c enables the 'loggingPrefs' capability instead. Bug: 1004566 Change-Id: Ib6b8f3260560ce48471952946fc2b98849157b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808088Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#698658}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b921b7e4add..942d69fa9d5f git log 6b921b7e4add..942d69fa9d5f --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ethannicholas@google.com Revert "Fixed GLSL ES compilation error in GLTestAtlasTextRenderer" 2019-09-20 ethannicholas@google.com Fixed GLSL ES compilation error in GLTestAtlasTextRenderer 2019-09-20 bsalomon@google.com Check for scratch textures in GrResourceProvider. Created with: gclient setdep -r src/third_party/skia@942d69fa9d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:1005237 Change-Id: I4b656d62de889c974622d551cc7cb73cea34fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815831Reviewed-by:
-
Manu Cornet authored
This is mostly useful for tests where the display ID starts off as this invalid ID. Not adding a unit test in this change because after CL 1814222 at least two tests will fail if this regresses. Bug: 982512 Change-Id: Ie447aa88fda66794a722d7e9cf478749ff4f8398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816734Reviewed-by:
-
Miguel Casas authored
Original CL got reverted due to breaking ChromiumOS ASAN and Linux ChromiumOS MSan builders: [48790/51498] LINK ./content_shell FAILED: content_shell ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecsta...(too long) ld.lld: error: undefined symbol: media::ChromeosVideoDecoderFactory::GetSupportedConfigs() >>> referenced by gpu_mojo_media_client.cc:162 (../../media/mojo/services/gpu_mojo_media_client.cc:162) >>> services/gpu_mojo_media_client.o:(media::GpuMojoMediaClient::GetSupportedVideoDecoderConfigs()) in archive obj/media/mojo/services/libmedia_mojo_services.a clang: error: linker command failed with exit code 1 (use -v to see invocation) Cq-Include-Trybots:luci-chromium-try:linux_chromium_chromeos_asan_rel_ng;luci-chromium-try:linux_chromium_chromeos_msan_rel_ng Original CL description ---------------------------------------------- This CL restricts //media/gpu:image_processor and :video_frame_mapper to ChromeOS and ChromeCast, since they are only implemented for these platforms. Same for image_processor_test. video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_| in an OS_LINUX and left others unprotected, which confused OS_WIN builds. This CL changes those to if defined(OS_CHROMEOS), since I don't think this file is meant to be compiled nor run on OS_LINUX. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#698566} Bug: 1006266 Change-Id: I6c9982015829863694e9f48815105f371548f9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816799Reviewed-by:
-
Miyoung Shin authored
This CL converts IdentityAccessorPtr and BindingSet<IdentityAccessor> in chromeos and services to the new Mojo type. Bug: 955171 Change-Id: Icb122470713bd84a6718483853f50aff45df1b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810449Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#698654}
-
Robert Ogden authored
Bug: 1005295 Change-Id: Ie301aae1507a6fa0f020fe302386458d924c4256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811959 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/234dcc192464..2ef66b69cea5 git log 234dcc192464..2ef66b69cea5 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 natsu@google.com [android] Add missing lib to _common_debug target Created with: gclient setdep -r src/third_party/swiftshader@2ef66b69cea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138239233 Change-Id: Iaf3329e4dec9b913c116d6044983eedf216e7644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815829Reviewed-by:
-
Kelvin Jiang authored
This CL removes the NONE action type. Instead of returning a vector of one action with the NONE type, RulesetManager::EvaluateRequest will instead return an empty vector if no DNR rules match with the request. Bug: 1004006 Change-Id: I7dc2b7b59540f3d185b9585e530818f92e6201b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809882Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698651}
-
Avery Musbach authored
The present CL rids ShellObserver of OnSplitViewModeStarted and OnSplitViewModeEnded, because they are not especially conducive to the plan that each RootWindowController shall have its own SplitViewController which shall have its own observers. Bug: 970013 Change-Id: Ic7fbf7b4cad35d148928b03142bf0a892c5742cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811643 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#698650}
-
Toni Barzic authored
AppListFolderView should ensure it respects apps container margins when shown with ScalableAppList feature enabled, in particular it should ensure its bounds do not overlap with the search box widget. It was using search_box_fullscreen_top_padding() to determine search box location, but this does not work correctly for ScalableAppList - when the feature is enabled, use AppsContainerView::CalculateMarginsForAvailableBounds to get the container margins. BUG=999273 Change-Id: Ie842da042cf6215fe9b1345229a1575d10ca55a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815581 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
It's currently returning a double. As part of the process of rewriting the animation engine we're replacing doubles by base::Time* alternatives. Bug: 737867 Change-Id: Ibfaf523e3879ed2b8a34bf0ca710d46b3ac1f8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814820Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#698648}
-
Nico Weber authored
No behavior change. Bug: 961769 Change-Id: I6cd1658bf18f6c0f66348d0270b0d1e08082cf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817097Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698647}
-
Eric Stevenson authored
This reverts commit 611c2959. Reason for revert: Relanding without breaking downstream by keeping nativeIsGoogleSearchUrl around until downstream use is removed. Original change's description: > Revert "JNI refactor: @NativeMethods conversion for more //chrome classes." > > This reverts commit 266b083e. > > Reason for revert: Compile break on android-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/113718 > > Original change's description: > > JNI refactor: @NativeMethods conversion for more //chrome classes. > > > > This CL was partially generated by > > //base/android/jni_generator/jni_refactorer.py. > > > > Two classes converted in this CL: > > * UrlUtilities.java > > * DevUiModuleProvider.java > > > > The tests were manually refactored to not use robolectric shadows > > for UrlUtilities native methods. > > > > Bug: 929661 > > Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344 > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#698556} > > TBR=agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org > > Change-Id: I2c9251ec65af0ab7ff5012d218c3860f14214e9d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 929661 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816970 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698594} TBR=japhet@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org Bug: 929661 Change-Id: I0fe8d84b9fd1992d598fa7630b1f42042dca3279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816728 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698646}
-
dpapad authored
The dedicated folders do not add much value, and in-fact get in the way by resulting in too many BUILD.gn files and js_type_check targets. For example viewer-pen-options:closure_compile target was not referenced anywhere (fixed). Merging all elements to a single folder makes things a bit easier for the Polymer2 to 3 migration. Bug: 1005029 Change-Id: Ic01de6e17486417dee79de791baddf3d9b338f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815078 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698645}
-
Peter Boström authored
Speculative fix for UAF when Tabs are being destroyed while their context menu is still active. This destruction seems to happen due to nested event loops running during context menus where tab-removal animations can finish and delete a Tab while its context menu is still running. This ends up cleaner than prior as Tab would always delegate to TabStrip, now TabStrip gets called directly, removing one step in the call chain. It also removes a method from the TabController interface. Before this change Tab was its own ContextMenuController and ContextMenuController::ShowContextMenuForView() accesses |is_opening_| after ShowContextMenuForViewImpl returns, hence the use-after-free. After this change TabStrip is the context-menu-controller. TabStrip is expected to outlive any Tab context menus here, which would take care of this specific use-after-free. This implementation is still brittle as BrowserTabStripController::TabContextMenuContents holds on to a dangling pointer, though this seems OK for now as tabstrip_->GetModelIndexOfTab() is checked, so the pointer isn't dereferenced as it won't belong to any TabStrip. A follow-up change here might track the Tab pointer using a ViewTracker. Bug: chromium:976318, chromium:1003313 Change-Id: I4c9a6b16ca12e695fdf055a995d526f6da1a0712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816971 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#698644}
-
Peter Boström authored
Only affects ExtensionsToolbarContainer which is under a flag. Bug: chromium:1006192 Change-Id: I0e414881815635b7a4810930cc0ebd142ef493ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815594 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Max Moroz authored
Bug: 1002923, 539572 Change-Id: Iecd42a6ac0748041a07acbb79d49a52611608fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816639 Auto-Submit: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#698642}
-
Tomasz Wiszkowski authored
This change introduces DecoratedSuggestionView that is hosting the final suggestion content view. This class features suggestion icon that is rendered on the left side of the suggestion itself. Since the ViewGroup serves as an isolated focus area, it must be a separate entity from BaseSuggestionView. I chose to implement it in a separate file for clarity and to ensure future changes do not increase entanglement between the classes. Change-Id: I413c901b1e119355b27b1f8f970d0acc80cd1d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726900 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#698641}
-
Erik Chen authored
Tests were setting a global without unsetting it [after the object the global was pointing to was destroyed]. This would cause subsequent tests to flakily fail. Change-Id: I31761deb1f7fe2c592c8e4ead302665f39688a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815830 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0aac4191fbd..6f647b543901 git log e0aac4191fbd..6f647b543901 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 engeg@google.com paygen: Extend Mem Semaphore across processes 2019-09-20 ahassani@chromium.org nebraska_wrapper: Fix the logic of raise error 2019-09-20 andrewlamb@chromium.org chromeos_config: Remove provision suite. 2019-09-20 tcwang@google.com afdo: Update mechanisms of comparing newer artifacts. Created with: gclient setdep -r src/third_party/chromite@6f647b543901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I87602f107852573932d85a7e2b407d7917d77499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815825Reviewed-by:
-
Lukasz Anforowicz authored
Change-Id: Ide1b92ea746db1bee5c6cc9f12bbbc875fa58341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790380 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698638}
-
Henrique Ferreiro authored
Convert the remaining references to the old Mojo types from the mojom::ModuleEventSink interface. Bug: 955171 Change-Id: I130747ca282ac78fe4046ff50c3d942f51661d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813324 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#698637}
-
David Bienvenu authored
headless_browser_tests fail with native window occlusion turned on. Specifically, headless browser tests have |root_window_hwnd| of 0, which causes a DCHECK when the tracking is disabled for the window. This is in preparation for enabling native window occlusion by default. Bug: 813093 Change-Id: I525f8f1c1572654bc5e5ea25dca385d3d7c48fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815609Reviewed-by:
-
Tim Song authored
The relayout after toggling a checkbox resets the scroll poition, causing a jarring scroll to start of the list. The fix is to retain the original scroll position during the layout. BUG=1000599 Change-Id: I9102c924ac9526ed604124d99677506bca76469f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815537Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#698635}
-
Pavel Yatsuk authored
This CL adjusts the logic of merging prepopulated data into search engines. The goal is to preserve Play API search engine record.The behavior should be: - When new prepopulated engine matches Play API engine, merge them. - When prepopulated Play API engine gets updated, apply updates. - When prepopulated Play API engine gets removed, keep the record. BUG=1002271 R=pkasting@chromium.org,wylieb@chromium.org Change-Id: I75822512bde4024f32af24565d66d87158732cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814642Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#698634}
-
khmel@chromium.org authored
Now it is possible to define exact set of sys events to trace. This CL utilizes this functionality in order to reduce footprint on memory usage and speedup tracing analysis. TEST=Locally, tracing tool works as expected BUG=b:140939504 Change-Id: Ibceca4d372a368bc07a38812f9c87381199c51d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816798 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698633}
-
Austin Eng authored
These tests were crashing due to a Dawn bug in resource deallocation which has been fixed. Bug: dawn:227 TBR: kainino@chromium.org Change-Id: Ia16c3c53eabbea2837a47402d8326b0b940ef69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816983Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#698632}
-
Avery Musbach authored
In preparation for RootWindowController to own a SplitViewController, the present CL arranges for the objects to be created at about the same time, and destroyed at about the same time. Bug: 970013 Change-Id: I0bcb60c76055124521dd3a33c4a06a299e9ccf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811639 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#698631}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e63bdb69ecd3..a75fd3592a81 Created with: gclient setdep -r src-internal@a75fd3592a81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idcea8d6c96ebddf0ffe57c7fa4dcd18827e2f663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816994Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dd4a00a06d01..11dc16350cd4 git log dd4a00a06d01..11dc16350cd4 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 aukinros@microsoft.com Add support for generating UWP (Windows Store) projects again Created with: gclient setdep -r src/third_party/angle@11dc16350cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I338729368905d22f1b93c7599a4ff3562c4eb975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816556Reviewed-by:
-
Avery Musbach authored
All observers of the AccessibilityController shall be removed before the AccessibilityController is destroyed. Change-Id: I8b4cab4ce71a3bfb53c2f04b940dde218a494124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816301 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
