GitLab

BUG=

Review URL: https://codereview.chromium.org/1922533003

Cr-Commit-Position: refs/heads/master@{#389846}

BUG=589318

Review URL: https://codereview.chromium.org/1922023002

Cr-Commit-Position: refs/heads/master@{#389845}

TBR=phajdan.jr
BUG=589318

Review URL: https://codereview.chromium.org/1914073002

Cr-Commit-Position: refs/heads/master@{#389844}

SnapshotController implementation. It will be used in WebContentsObservers for Offline Pages - to detect the right moment to make a snapshot.
It will take input and generate a sequence of StartSnapshot calls (typically 1 or 2) to its Client.
This is initial implementation, in the future we might update the logic to rely not on a timer and onload event,
but rather on some more specific indicators (meaningful layout or proportion of resources loaded).

BUG=606106

Review URL: https://codereview.chromium.org/1920603002

Cr-Commit-Position: refs/heads/master@{#389843}

Extracted from https://codereview.chromium.org/1910043002/ to help reduce an issue.

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1918333002

Cr-Commit-Position: refs/heads/master@{#389842}

null process id was being sent for threads created in the shell process. Use shell process id instead.

R=jam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1922043003

Cr-Commit-Position: refs/heads/master@{#389841}

BUG=591164

Review URL: https://codereview.chromium.org/1914643003

Cr-Commit-Position: refs/heads/master@{#389840}

BUG=589318

Review URL: https://codereview.chromium.org/1921363002

Cr-Commit-Position: refs/heads/master@{#389839}

This introduces the plumbing required for custom paint.

PaintGeneratedImage - Holds onto a SkPicture for painting. This is
produced as the result of custom paint.

CSSPaintImageGeneratorImpl - Generates a PaintGeneratedImage based on a
LayoutObject and size. Invokes the custom paint callback inside
CSSPaintDefinition.

BUG=578252

Review URL: https://codereview.chromium.org/1866623002

Cr-Commit-Position: refs/heads/master@{#389838}

Expecting this to fix base_unittests, unit_tests, content_browsertests

BUG=589318

Review URL: https://codereview.chromium.org/1922083003

Cr-Commit-Position: refs/heads/master@{#389837}

Review URL: https://codereview.chromium.org/1906603003

Cr-Commit-Position: refs/heads/master@{#389836}

Add dependency on google_play_resources.

Original description:
This adds a "Share" button. Clicking it brings up an account-chooser
dialog for selecting the account to use for XMPP.
Then it connects to the Directory server, and gets back an It2Me access
code.

BUG=602355

Review URL: https://codereview.chromium.org/1888653002

Cr-Commit-Position: refs/heads/master@{#389835}

There is no dialog latency data since yesterday, it is caused by crrev.com/1907073002, the action to open/close dialog was deleted by mistake.

This change just adds the action to open/close dialog back.

BUG=

Review URL: https://codereview.chromium.org/1919293002

Cr-Commit-Position: refs/heads/master@{#389834}

Test utilities should not be a part of the test case target.

BUG=606815

Review URL: https://codereview.chromium.org/1922633003

Cr-Commit-Position: refs/heads/master@{#389833}

This adds a command-line flag, --origin-trial-public-key, which can be used by
developers to override the public key used to verify the signed tokens for
origin trials.

BUG=603588

Review URL: https://codereview.chromium.org/1737693002

Cr-Commit-Position: refs/heads/master@{#389832}

BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1922883002

Cr-Commit-Position: refs/heads/master@{#389831}

Nacl uses its own toolchain with the target sysroot.
System libdir should be respected with that toolchain too.

BUG=606432

Review URL: https://codereview.chromium.org/1914103002

Cr-Commit-Position: refs/heads/master@{#389830}

This is more natural here, and will make it easy to add a bit that
tracks if a document would be in "deferred commits" mode even if its
not the main document. Then we can use that bit to trigger pipeline
throttling for iframes when they're loading avoiding FOUC in a sane
way.

This patch doesn't change any behavior and only moves the logic.

BUG=521692
TEST=DocumentLoadingRenderingTest.*

Review URL: https://codereview.chromium.org/1922793002

Cr-Commit-Position: refs/heads/master@{#389829}

Extracted from https://codereview.chromium.org/1910043002/ to help identify an issue.

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1918343002

Cr-Commit-Position: refs/heads/master@{#389828}

BUG=579697

Review URL: https://codereview.chromium.org/1922833003

Cr-Commit-Position: refs/heads/master@{#389827}

Aligns email with the header text except in route-details, where the email is aligned with the back button.

BUG=604596

Review URL: https://codereview.chromium.org/1915383002

Cr-Commit-Position: refs/heads/master@{#389826}

We're long-past due for this ...

R=ukai@chromium.org
BUG=605732

Review URL: https://codereview.chromium.org/1915423002

Cr-Commit-Position: refs/heads/master@{#389825}

This experiment has been on canary for a week, and unambiguously
demonstrates that using memory mapped files is better for font loading
perf. Using a memory mapped file improves font family load time by up
to 5-25%, and even shows a tiny improvement in overall startup time.

BUG=577387

Review URL: https://codereview.chromium.org/1920843004

Cr-Commit-Position: refs/heads/master@{#389824}

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1867873002

Cr-Commit-Position: refs/heads/master@{#389823}

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1919323002

Cr-Commit-Position: refs/heads/master@{#389822}

The cast_sender target ends up including video_decoder_config.h, and
I've recently added 'include media_features.h' to that header. So now
targets that include video_decoder_config need an explicit dependency
on media_features target, to ensure media_features.h is generated and
can be included by those targets.

BUG=606829
TBR=miu,wolenetz
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1919163003

Cr-Commit-Position: refs/heads/master@{#389821}

Revert of 🍈 Unify application context usage. (patchset #25 id:480001 of https://codereview.chromium.org/1879013002/ )

Reason for revert:
Broke CQ unittests as they did not set native application context properly. See https://codereview.chromium.org/1919283002/ for context.

Original issue's description:
> Unify application context usage.
>
> Separate out ContextUtils initializing the global application context
> on java-side vs native-side. Have LibraryLoader initialize
> native-side application side and initialize java-side application
> context as early as possible.
>
> This allows callers to be certain that they are interacting with the
> application context instead of a local context, and will allow
> consolidating application-wide context-based globals like
> SharedPreferences in subsequent CLs.
>
> BUG=552419
>
> Committed: https://crrev.com/6b5b7b5d2a1d2cdfa58e8e06f9a350ea4d1b286a
> Cr-Commit-Position: refs/heads/master@{#389782}

TBR=torne@chromium.org,davidben@chromium.org,yfriedman@chromium.org,nyquist@chromium.org,caitkp@chromium.org,sergeyu@chromium.org,amistry@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=552419

Review URL: https://codereview.chromium.org/1917193003

Cr-Commit-Position: refs/heads/master@{#389820}

Removes
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
from the list of SmokeTests, since it's flaky on Android and doesn't
seem to be maintained.

BUG=602268

Review URL: https://codereview.chromium.org/1922843003

Cr-Commit-Position: refs/heads/master@{#389819}

Move the size check and static_cast to from the generic Hash to the specific SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int for size. This is leaking a mistake from third_party code into our wrapper. Client code that wants to be clear that it is using SuperFastHash specifically (not just generic Hash) should be able to do so with a size_t type.

Review URL: https://codereview.chromium.org/1916193003

Cr-Commit-Position: refs/heads/master@{#389818}

BUG=490795

Review URL: https://codereview.chromium.org/1865383002

Cr-Commit-Position: refs/heads/master@{#389817}

When chrome is launched in mus, it always needs to block on Initialize
to complete, regardless of whether run as 'chrome --mash' or as
'mojo_runner mojo:mash_session'.

BUG=594852

Review URL: https://codereview.chromium.org/1915053004

Cr-Commit-Position: refs/heads/master@{#389816}

Review URL: https://codereview.chromium.org/1915853007

Cr-Commit-Position: refs/heads/master@{#389815}

The controller is now simply referred to and kept alive from the
associated master Document, detached of and disposed during
Document detach.

R=haraken
BUG=585328

Review URL: https://codereview.chromium.org/1914183002

Cr-Commit-Position: refs/heads/master@{#389814}

https://codereview.chromium.org/1908423006/ makes CastAudioManager
run on CMA thread. Now there is no need to post tasks when using
CMA backend in CastAudioAoutputStream.

BUG=594234

Review URL: https://codereview.chromium.org/1913973003

Cr-Commit-Position: refs/heads/master@{#389813}

BUG=604468

Review URL: https://codereview.chromium.org/1915293005

Cr-Commit-Position: refs/heads/master@{#389812}

Preliminary CL for tackling changing the [Exposed] attributes for the
partials, split the URL methods defined in FileAPI [1] out into their
own implementation files. Also update bindings template to ensure the
method supporting the partial interface / static method / conditional
exposure combination was exported for use in modules.

No behavior changes.

[1] https://w3c.github.io/FileAPI/#creating-revoking

BUG=604951
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1921063002

Cr-Commit-Position: refs/heads/master@{#389811}

This CL adds logging for the internals page during filling passwords in the
renderer code. Those have been missing and would have been helpful for
investigating the associated bug.

BUG=606736

Review URL: https://codereview.chromium.org/1918823005

Cr-Commit-Position: refs/heads/master@{#389810}

TEST=Navigate to chrome://chrome-urls, then navigate to one of the other
chrome:// pages using the displayed links.

BUG=579697

Review URL: https://codereview.chromium.org/1921093002

Cr-Commit-Position: refs/heads/master@{#389809}

Since we no longer use NSS for SSL/Crypto, the debugging information
for it is outdated and we no longer need to include the Valgrind
Suppressions.

BUG=604728

Review URL: https://codereview.chromium.org/1921743002

Cr-Commit-Position: refs/heads/master@{#389808}

BUG=597761

Review URL: https://codereview.chromium.org/1922013002

Cr-Commit-Position: refs/heads/master@{#389807}