GitLab

Bug: 864449
Test: Manually tested both Enable/Disable options.
Change-Id: I57a768421e3a86e1bae63c72f1467911ddb6096f
Reviewed-on: https://chromium-review.googlesource.com/1140110Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575623}

Following bot results are included.
7953 7954 7956 7959 7960 7961 7962 7967 7986 7988 7991 7995
7998 8008 8013

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia160044568587e39dcf25d2a40618ae86a4dbdb4
Reviewed-on: https://chromium-review.googlesource.com/1137801
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575622}

https://skia.googlesource.com/skia.git/+log/9c98576bceff..94fee93c9b23


git log 9c98576bceff..94fee93c9b23 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 robertphillips@google.com Reduce arbitrary opList splitting when sorting


Created with:
  gclient setdep -r src/third_party/skia@94fee93c9b23

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I8ed1316abb15379572c0d2d88f2bff1adf587b23
Reviewed-on: https://chromium-review.googlesource.com/1139918Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575621}

https://android.googlesource.com/platform/external/perfetto.git/+log/4d831cea60c7..0b69a335b882


git log 4d831cea60c7..0b69a335b882 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 michaschwab@google.com Merge "Handle Resize"
2018-07-16 michaschwab@google.com Handle Resize


Created with:
  gclient setdep -r src/third_party/perfetto@0b69a335b882

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I0ae10fdbb340d13a6003648690246e48f24a00b9
Reviewed-on: https://chromium-review.googlesource.com/1139917
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575620}

Add an 'Add account' button in Chrome OS Account Manager's account list
page in Settings.

Bug: 833797
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id1626114bcfda15c6c1b2a549cde152045dfac84
Reviewed-on: https://chromium-review.googlesource.com/1105773
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575619}

This CL don't trigger the new animation for OpenInNewTab when the
TabStrip is present as the TabStrip already have an animation.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2cb7a5e67695b2249373a519e6521523dfa0354d
Reviewed-on: https://chromium-review.googlesource.com/1140159Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575618}

Adds a new animation for the location bar when the
omnibox is focused and defocused.

Bug: 821809
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1eeeccc99322bb2ad67e7bd75d24578066451c8f
Reviewed-on: https://chromium-review.googlesource.com/1131749Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575617}

This reverts commit 4c7b65f6.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 575597 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjN2I2NWY2MzA3YTI3ODA4NDhkMzFjYjgxZWRlODg1NjQzNzcyMTAM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6868

Sample Failed Step: browser_tests

Original change's description:
> Fill username field with prefilled values by server hints.
> 
> This CL is implementation of overriding of prefilled values in username
> fields if the server believes that these values are placeholders.
> 
> The life of server prediction for filling prefilled values is the
> following (it's called may_use_prefilled_placeholder in code):
> 1. The server sends it and it's propagated as part of FormStructure to
> FormParser (it's implemented before this CL).
> 2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction
> 3. FormParser puts it to PasswordForm.
> 4. In password_form_fill_data.cc it's propagated to PasswordFormFillData
> 5. It's sent to the renderer over MOJO
> 6. PasswordAutofillAgent uses it to override prefilled values if any.
> 
> The reason of putting processing may_use_prefilled_placeholder in
> FormParser not in NewPasswordFormManager is that NewPasswordFormManager
> should know nothing about form structure, it's FormParser responsibility
> to process it.
> 
> Small deletion of dead code is done: parameter |set_selection| from
> FillUserNameAndPassword, since it's never set to true.
> 
> Bug: 847793, 831123
> Change-Id: Id86d0992428e520718a6ab6e9f50e8064444d030
> Reviewed-on: https://chromium-review.googlesource.com/1124474
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Reviewed-by: Ioana Pandele <ioanap@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575597}

Change-Id: Ibcea367414987035718f8010320921bc851dc406
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847793, 831123
Reviewed-on: https://chromium-review.googlesource.com/1140213
Cr-Commit-Position: refs/heads/master@{#575616}

Make hbos@...
1. per-file web_rtc_* OWNER of
   third_party/blink/renderer/platform/exported

   hbos@ is already per-file web_rtc_* OWNER of
   third_party/blink/public/platform. This is where the header files of
   interfaces are placed, but often times the .cc files which are placed
   in "exported" need to be modified too for things like out-of-line
   constructor and destructor.

2. per-file testing_platform_support_with_web_rtc.* OWNER of
   third_party/blink/renderer/platform/testing/.
   Any substantial changes in WebRTC requires updating some "platform"
   interface and then these files have to be updated to update the
   mocks.

We frequently have to bring in non-webrtc reviewers for the sake of
stamping some minor webrtc interface being updated. The webrtc reviewers
already do a good job of reviewing these things, better to make a webrtc
owner OWN these few files too.

NOTRY=True

Bug: 777617
Change-Id: Ie0e5dbd43d93df89524c50bed3683f681d47778d
Reviewed-on: https://chromium-review.googlesource.com/1140063Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575615}

This enum is going away, and is always assumed to be kIgnore within Skia.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1d330478aab486864395ef36762f12f3df76c4d2
Reviewed-on: https://chromium-review.googlesource.com/1135551Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#575614}

The default storage for OverlayUserPrefStore which is used for
incognito preferences is the persistent storage in the regular profile,
and preference types that should not be stored there must be enumerated
in CreateIncognitoPrefServiceSyncable.

This is changed so that the default storage is in memory, and
preferences that need a persistent storage would need enumeration.

Bug: 861722
Change-Id: Ia4c8f655752a07f81fb6d35685876cd252118999
Reviewed-on: https://chromium-review.googlesource.com/1128753
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575613}

Long live base::TestMockTimeTaskRunner.

Bug: 863350
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id3df59c1fb1588e95e0135c7c6a90cfad47d29f1
Reviewed-on: https://chromium-review.googlesource.com/1140062
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575612}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1b3e80f..dcf3638e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2a8194643473bf816ddc6aa84c362e4a747cb058
Reviewed-on: https://chromium-review.googlesource.com/1139909Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575611}

Bug: 863350
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74b5ab9428ec1b5452c374f4c9dccea7e26612ab
Reviewed-on: https://chromium-review.googlesource.com/1138313
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575610}

https://skia.googlesource.com/skia.git/+log/bf2a980d03db..9c98576bceff


git log bf2a980d03db..9c98576bceff --date=short --no-merges --format='%ad %ae %s'
2018-07-17 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 e076a2327f0d..6fb8ba4e8660 (3 commits)


Created with:
  gclient setdep -r src/third_party/skia@9c98576bceff

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I47ccd1d1e1c0745e7f8b2185ad2152b39331d02d
Reviewed-on: https://chromium-review.googlesource.com/1139915Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575609}

skcms' Transform_inl.h assumes support for 16-bit floating point in the
__ARM_FP macro means the __fp16 (and corresponding SIMD data type) is
present.

While this is currently true for LLVM, which always sets the equivalent of
GCC's -mfp16-format=ieee internally on ARM builds, GCC explicitly needs that
option to be specified in order to enable support for __fp16. Doing so
allows GCC ARM builds to proceed without the following error:

    ../../third_party/skia/third_party/skcms/src/Transform_inl.h: In function 'F_from_Half_':
    ../../third_party/skia/third_party/skcms/src/Transform_inl.h:101:72: error: 'float16x4_t' undeclared (first use in this function); did you mean 'float32x4_t'?
         SI ATTR F   NS(F_from_Half_(U16 half)) { return      vcvt_f32_f16((float16x4_t)half); }
                                                                            ^~~~~~~~~~~
                                                                            float32x4_t
    ../../third_party/skia/third_party/skcms/src/Transform_inl.h:101:72: note: each undeclared identifier is reported only once for each function it appears in
    ../../third_party/skia/third_party/skcms/src/Transform_inl.h:101:84: error: expected ')' before 'half'
         SI ATTR F   NS(F_from_Half_(U16 half)) { return      vcvt_f32_f16((float16x4_t)half); }
                                                                                        ^~~~
                                                                                        )
    ../../third_party/skia/third_party/skcms/src/Transform_inl.h: In function 'Half_from_F_':
    ../../third_party/skia/third_party/skcms/src/Transform_inl.h:102:5: error: can't convert a value of type 'int' to vector type '__vector(4) short unsigned int' which has different size
         SI ATTR U16 NS(Half_from_F_(F      f)) { return (U16)vcvt_f16_f32(                f); }
         ^~

Bug: 819294
Change-Id: Ib7417fb9bdc6bd93553084053ba69f9d3409b112
Reviewed-on: https://chromium-review.googlesource.com/1138251Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#575608}

This is a follow-up to 199e61ec.

Bug: 850921
Change-Id: Icabee6ab7f196b3a59bf3b541aa9bc698f636386
Reviewed-on: https://chromium-review.googlesource.com/1140056Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575607}

Bug: 859440
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28b4542d8752d3c8ee52f62aa2894dabf787a0d7
Reviewed-on: https://chromium-review.googlesource.com/1139606Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575606}

Bug: 859555
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6c4c564f12ee0acb89fdcc9538f89e4277f1461a
Reviewed-on: https://chromium-review.googlesource.com/1139528Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575605}

We no longer define OS_POSIX under Fuchsia, so the !OS_FUCHSIA part of
these conditionals is no longer required.

TBR: jsbell, gab, thestig, rockot, kbr, sergeyu, skyostil, fdegans, alexmos, asanka
Bug: 854721
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia35a44036d520a6b5104ac3ee12f5469cbaf457f
Reviewed-on: https://chromium-review.googlesource.com/1135898
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575604}

Similarly to r574552 this change moves the map of descriptors from the
platform implementations to the BluetoothRemoteGattCharacteristic base
class. In addition, default implementations for GetDescriptor() and
GetDescriptors() are provided. Lastly, this change cleans up a few lint
errors, mostly missing includes.

Bug: 821766
Change-Id: Iada71c198d241acf3bddcc1414ff89aa150c1c84
Reviewed-on: https://chromium-review.googlesource.com/1136296Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575603}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0c5d09a8e978..9e945c84d2be


git log 0c5d09a8e978..9e945c84d2be --date=short --no-merges --format='%ad %ae %s'
2018-07-17 manojgupta@google.com cros_chrome_sdk: Use cros nm for target builds.


Created with:
  gclient setdep -r src/third_party/chromite@9e945c84d2be

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I728eb50ce12cb807ca24f04ae25cffd769e7d57a
Reviewed-on: https://chromium-review.googlesource.com/1139916Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575602}

Bug: chromium:823663
Change-Id: I228aab31b4f152e0edc8310d3f4674a7f2022964
Reviewed-on: https://chromium-review.googlesource.com/1138617Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575601}

We previously implemented constructable CSSStyleSheet synchronously,
but discussions in  https://github.com/WICG/construct-stylesheets/issues/2
have gravitated away from that and we are now interested in asynchronous
creation of CSSStyleSheet.

This CL added Document.createCSSStyleSheet that returns a
Promise<CSSStyleSheet>, while also removing the exposed CSSStyleSheet
that was previously exposed. Note that because CSS parsing is still
done on the main thread, this function is actually still blocking.

The previously implemented CSSStyleSheet is changed to only produce
empty CSSStyleSheets in this CL: crrev.com/c/1126898

Bug: 807560
Change-Id: I9f9d17ae04829ff399ae384f8b3a6d97a3b0613b
Reviewed-on: https://chromium-review.googlesource.com/1126754
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575600}

This was implemented in crbug.com/633007 but was never adopted
by any standards, and could not get much attention from developers
except for testing use cases.

As this was dismissed from the standard, we have to pursue the
testing use cases in other forms.

Bug: 829713
Change-Id: I2b053a15e96d68ff5a8c632e65b7b2feefb15dab
Reviewed-on: https://chromium-review.googlesource.com/999453Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575599}

Bug: 850161
Change-Id: I1fdb08aa752c5297e59245065830955447e01cf1
Reviewed-on: https://chromium-review.googlesource.com/1127163
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575598}

This CL is implementation of overriding of prefilled values in username
fields if the server believes that these values are placeholders.

The life of server prediction for filling prefilled values is the
following (it's called may_use_prefilled_placeholder in code):
1. The server sends it and it's propagated as part of FormStructure to
FormParser (it's implemented before this CL).
2. It's parsed in password_field_prediction.cc to PasswordFieldPrediction
3. FormParser puts it to PasswordForm.
4. In password_form_fill_data.cc it's propagated to PasswordFormFillData
5. It's sent to the renderer over MOJO
6. PasswordAutofillAgent uses it to override prefilled values if any.

The reason of putting processing may_use_prefilled_placeholder in
FormParser not in NewPasswordFormManager is that NewPasswordFormManager
should know nothing about form structure, it's FormParser responsibility
to process it.

Small deletion of dead code is done: parameter |set_selection| from
FillUserNameAndPassword, since it's never set to true.

Bug: 847793, 831123
Change-Id: Id86d0992428e520718a6ab6e9f50e8064444d030
Reviewed-on: https://chromium-review.googlesource.com/1124474
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575597}

Leading white-spaces are indeed breaking opportunities that should
prevent, if there are no other css properties forcing it, breaking text
in the middle of a word when honoring the word-wrap/overflow-wrap CSS
property.

We are doing so if the leading white-space sequence is longer than 1
character, but when we have a single leading white-space, we are missing
that breaking opportunity and we may lead to cases, like the one
described in the bug.

However, this breaking opportunity should be considered together
with other provided by the word-break CSS property (eg, break-word or
break-all).

There is a discussion [1] in the CSS WG github about this issue, which
provides an interoperability analysis of a few cases where a single
leading white-space character may produce different results, depending
on the browser and the combination of line-breaking properties.

[1] https://github.com/w3c/csswg-drafts/issues/2907

Bug: 854624
Change-Id: I49ec8282e899a32990662c104b48cab04057b909
Reviewed-on: https://chromium-review.googlesource.com/1130515
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575596}

This CL introduces InputMethodSurface class for handling input method
surface role.
Also the version of remote_shell interface is bumped to 17.

Bug: 845079
Test: Ran on DUT.
Change-Id: I79d26a941deb621c5155e53ad6989414a6bd3614
Reviewed-on: https://chromium-review.googlesource.com/1131052
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575595}

The file has many tests. Give it a long timeout.

Bug: 863160
Change-Id: Idfad60c6e088b97bdc279c648037ecbf5d33861f
Reviewed-on: https://chromium-review.googlesource.com/1139935Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575594}

These are not recorded when S13nServiceWorker is enabled.

Bug: 852673
Change-Id: I0dd94ec089e7a6e36b0cc9fbc2ee85078e622725
Reviewed-on: https://chromium-review.googlesource.com/1119738Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575593}

When we load subresorces from the main thread and dedicated workers
we use RenderViewImpl's RendererPreferences to check DNT header
should be set or not. Since RenderViewImpl may not be available
for service workers we need another way to pass RendererPreferences
from browser to renderer. This CL adds a method to ContentBrowserClient
to get RendererPreferences from chrome/ to content/, and piggybacks
the preferences in EmbeddedWorkerStartParams to populate it from
browser to renderer.

Bug: 853085
Change-Id: Ibdd6bac46bbf0e27c02866f496482041e8789138
Reviewed-on: https://chromium-review.googlesource.com/1130967
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575592}

We should not extend selection looking for special elements if the
delete operation has been triggered by a caret based selection.

This change is based on a recent [1] resolution of the Editing TF,
which acknowledges that behavior of single-cell tables must be the
same that multi-cell tables and even if the last character is
deleted, we should not delete the whole table structure.

A different case would be when the user actively selects the whole
content of a table; in this case, as we do in multi-cell tables,
the structure of single-cell tables should be deleted together
with the content.

[1] https://github.com/w3c/editing/issues/163

Bug: 731320
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8c3e4efcc63410bf30b4889a715d92e9dda8189b
Reviewed-on: https://chromium-review.googlesource.com/1126255
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575591}

This CL updates the tab grid transitions to cleanly match the presented tab views.

The basic abstraction for this transition is the GridToTabTransitionView protocol which defines a set of 'cell' and 'tab' views, and methods to lay them out. The general idea is that a view conforming to this protocol can either be in 'cell' mode (where it exactly matches a tab grid cell), or in 'tab' mode (where it exactly matches an open tab).

Most of the work is done by the GridTransitionCell subclass of GridCell, which positions and scales the "tab" and "cell" views it is supplied with so they animate smoothly. All of this positioning/scaling logic is internal to that class and nothing else depends on it.

Providing the transition cell with the tab views is handled in the transition animator, mostly leveraging the content area layout guide. This doesn't require any direct integration with the tab view (that is, the BVC) beyond that layout guide.

Approaches I abandoned:

- letting -layoutSubviews position the tab/grid views. The problem with this approach (which is much cleaner from an API perspective) is that the timing of the layout passes is unpredictable, it it resulted in changes being made that weren't fully animated (for example, subviews would be scaled and positioned without animation, and then the superview would scale with an animation).

- using layout constraints for GridTransitionCell's tab views. This is probably the correct thing to do long-term; mostly this was a decision made under time constraints, but since ultimately animating constraint changes depends on -layoutSubviews being called at the right times, I did have some concerns given the difficulties described above. It's unfortunate that grid_cell.mm is mixing constraint- and frame-based layout, but it is confined to that single file.

Bug: 851460, 850507, 862343
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If6d55f14aa05e705143547b61773fdb34796ad2d
Reviewed-on: https://chromium-review.googlesource.com/1136647
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575590}

Per the bug, add corner rounding and change the scale of the reduced motion animation.

Note that this CL uses 26px corner radius for better visibility given how brief the animation is.

Bug: 851871
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9f2c3b02ce53abed3570f33a09017ee7a9273ed1
Reviewed-on: https://chromium-review.googlesource.com/1138618Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575589}

This CL fixes the problem of the tab grid (the root view controller) being briefly visible when the app launches.

Note that this problem isn't simply a matter of the initial tab view controller (the BVC) being  presented with an animation at launch; even if the presentation isn't animated, the tab grid is visible for several frames as the app launches.

The fix in this CL is to (again) insert the launch image view on top of the tab grid during launch.

This is done inside the TabGridCoordinator. If the launch view is present, the presentation of the tab view controller isn't animated. The launch view is removed the first time a presentation completes, and it is never added again.

There are a few problems with this approach that should be resolved after M69 launches:

 - Futzing around with view hierarchies isn't something a coordinator should do. I'm doing it that way here because it at least keeps things well-contained.

 - Jamming the launch view in to spackle over UIKit glitches is getting kind of old.

Bug: 826288
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I701b550f9eef16452a608b839c9a321b6b7a966a
Reviewed-on: https://chromium-review.googlesource.com/1138329Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575588}

This reverts commit 1e3235b3.

Reason for revert: suspect for breaking webkit_layout_tests on
Mac, e.g. test offset-from-point-complex-scripts.html.

Bug: 864405

Original change's description:
> Add support for mid ligature positions
> 
> Makes XPositionForOffset and CharacterIndexForPosition support
> return results inside a ligature glyph (while still not breaking ZWJs)
> by using a character-based TextBreakIterator inside glyphs.
> 
> Bug: 473476
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I723cc8ba081958ff2d470d3e73ead6cbe327cf60
> Reviewed-on: https://chromium-review.googlesource.com/1085554
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575496}

TBR=eae@chromium.org,kojii@chromium.org,drott@chromium.org,fserb@chromium.org

Change-Id: Id20c3aca9139d65e4187009e7ef7b45f87cceb5e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 473476
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1140073Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575587}

Bug:863767
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ibe182c3bc7acaf9a0519da2eb365e443df460d68

TBR=perezju@chromium.org

Change-Id: Ibe182c3bc7acaf9a0519da2eb365e443df460d68
Reviewed-on: https://chromium-review.googlesource.com/1138407Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575586}

If feature flags has changed drivefs may need a restart before it's able
to serve requests. In this case mounting will fail. Make browser handle
this situation by retrying after some time.

BUG=chromium:845390,chromium:845388

Change-Id: I0d4cdcf0e981b0966a23d91d3dc6fd30a32fb927
Reviewed-on: https://chromium-review.googlesource.com/1139943Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575585}

Bug: 849582
Change-Id: I6e75d9a62b4b58569c2c29b913c0a6a0cab0bf83
Reviewed-on: https://chromium-review.googlesource.com/1139057Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#575584}