- 05 Dec, 2019 40 commits
-
-
Noel Gordon authored
CL:1947603 noted how to remove the .dialog-navigation-list dependency from the directory tree _and_ keep its unittest passing. Thus this CL. There are no integration tests of the FilesApp splitter or FilesApp window resize event handling. Add tests for both, and use them to test the tree "clipped" attribute, since it is active in both files-ng and normal FilesApp after this change. Bug: 992819 Change-Id: Id46cbee77fc39bb227f66fc2850ee09a6fe68df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947620Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721907}
-
Adrienne Walker authored
Currently, QuotaClient is a raw pointer, jointly owned by QuotaManager and AppCacheServiceImpl, with a complicated keep_alive dance and conditional self-destruction. This is just a drive-by cleanup to get rid of "raw new" calls that looked suspicious and to make the refcounting explicit. Once AppCache gets removed, it seems possible to make QuotaClient to be owned fully by QuotaManager as a unique_ptr. Change-Id: I4df4bda44f51666e99880812c49ff76a7635c13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949579 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721906}
-
Noel Gordon authored
Bug: None Change-Id: Ief982eb1150918c8f995f6b26332bc594924b856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950374Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Test is flaky on multiple platforms. It seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894975161591307904/+/steps/sync_integration_tests_on__none__GPU_on_Mac__with_patch__on_Mac-10.13.6/0/logs/Flaky_failure:_SingleClientExtensionsSyncTest.StartWithSomeExtensions__status_SUCCESS_TIMEOUT_/0 TBR=mastiz@chromium.org Bug: 1030556 Change-Id: I334eb74f5561360b1fa868ba580748d5265148f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951276Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#721904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/be9c8b0410e0..e2a516e4d1f2 git log be9c8b0410e0..e2a516e4d1f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 dberris@chromium.org PinpointScheduler: Wire the Execution Engine Created with: gclient setdep -r src/third_party/catapult@e2a516e4d1f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:988912 Tbr: sadrul@google.com Change-Id: I46cc4634c14f8fccf5caa575236171397db58a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721903}
-
Giovanni Ortuño Urquidi authored
Test seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894942310371245376/+/steps/content_browsertests/0/logs/Deterministic_failure:_WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService__status_FAILURE_/0 TBR=guidou@chromium.org Bug: 1031033 Change-Id: I4c9a0856bb58eba535c2d0f9c2052abb52fd98ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951275Reviewed-by:
-
Hitoshi Yoshida authored
Before this CL, ToFlexibleArrayBufferView() expected the given |value| has ArrayBufferView. But in its use cases, all in generated code, we don't check the fact, and instead, check the returned value is empty to throw an exception. FlexibleArrayBufferView var; // No check v8_var->IsArrayBufferView() ToFlexibleArrayBufferView(isolate, v8_var, var); if (var.IsEmpty()) { exception_state.ThrowTypeError(...); } To keep generated code's style, which is consistent with other ToFooBar(), this CL checks the given V8 value is in a correct type, and makes return value empty if it's not. Bug: 1029716 Change-Id: I1e58c998064b90a0a5b09f0e8895c9283a37e45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949826Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#721901}
-
sczs authored
It also enables editing on the SaveCardModal if the flag is enabled and the card will be uploaded. Bug: 1029067 Change-Id: If8dd3c0ab5e2ef9e4b943a7ae3bf2347f2c47130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947766 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#721900}
-
Theodore Olsauskas-Warren authored
Along with the elevation of the Privacy card out of advanced, the toggle for allowing Chrome Sign In is being moved out of Privacy and into the Sync and Google Services section. This toggle is disabled during the Sync setup flow if the user elects to go to settings during Sync setup. Additionally, the "Turn On Sync.." button is disabled when Chrome Sign In is disabled. This removes the possibility of enabling sync before restarting the browser after disabling sign in. Every change in behavior is behind the privacySettingsRedesignEnabled finch flag. Bug: 1014143 Change-Id: I4f2f11598ac22823310623d6bd079ece27bfe3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943174Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#721899}
-
Yuki Shiino authored
CompositeNode supports Python's format-like composition of code nodes. Bug: 839389 Change-Id: Ie7689eb709eecefbb0c2ef4b46b1c59e2abea734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952545Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721898}
-
David Dorwin authored
Add an ICU-based implementation of time_exploded, removing the use of the POSIX implementation and thus the use of fuchsia.deprecatedtimezone. Bug: 985946 Test: base/time/ unit tests Change-Id: I91440ecae48684717b6fdcfe5f7ef66028b079c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949776 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721897}
-
Findit authored
This reverts commit a4d27f51. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 721832 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0ZDI3ZjUxM2ViNDBhODk1MDVmMDQyZDY4NjkzZWQ2NzAyNDAwZDkM Sample Failed Build: https://ci.chromium.org/b/8894942016495385648 Sample Failed Step: browser_tests Original change's description: > Move Audio Service off Service Manager > > All the details around if/when a service instance is started and whether > it's in- or out-of-process have been centralized into the implementation > of a single GetAudioService() helper in Content. > > A few other helpers are added to ease the transition off the Service > Manager, though they aren't necessarily ideal APIs. For example, > client library APIs which once took a Service Manager Connector may now > take a RepeatingCallback to bind a specific type of interface. > > In addition to GetAudioService(), Content provides helpers for > AudioSystem construction and StreamFactory binding from any sequence. > > Because all timeout/lifetime management logic is now generically > supported within Mojo and Content and requires no service implementation > details to get right (and because unit tests launching service processes > is no longer supported outside of Content), all Audio Service test > coverage relevant to lifetime management is deemed superfluous and has > been removed. > > Bug: 977637 > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721832} Change-Id: Ic59416fc7c5f5eda2c3b8b211773f9761d2ea03d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952526 Cr-Commit-Position: refs/heads/master@{#721896}
-
Chase Phillips authored
This CL extends the manifest scope behavior so a server can override the default scope. The default scope for a new AppCache instance is the manifest URL with an empty path. An upcoming change will update the default to be the manifest URL without the manifest filename. If a server wants to support the behavior that a manifest can specify resources outside of that scope, the server can pass a response header in their 200 or 304 response named X-AppCache-Allowed. The value of this header must be a URL path and have a last character equal to a forward slash. Bug: 999001 Change-Id: I0277c5ab0645346c4a7c6d5eec5ea67c9cbeeda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935035 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Meilin Wang authored
This CL: 1. Added a new class AmbientModeState to store states related to this mode. 2. Wired up AssistantManagerServiceImpl to observe the new state change in order to update action module as necessary. Misc: Fixed linter warnings. Bug: b/139698911 Test: run unittests added in this change Change-Id: I4dd078c19cc2ce73a8262fe3cfc0c39308949e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906932 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721894}
-
Jie Jiang authored
Currently RFCOMM is not available on arcvm because we need some operations (listen(), connect(), etc.) on the bluetooth socket in Android, which is not supported by VSockProxy. This change moves such operations into Chrome. See http://ag/9487891 for change in Android. - For RFCOMM listen, we keep the listening socket in Chrome. When a new connection is accepted, we give the new socket by accept() to Android. - For RFCOMM connect, we keep the socket when connection is not established. When connect is ready, we give this socket to Android. - We use mojo interface to wrap the sockets live in Chrome. The following events (e.g., connect() succeeds) are notified via these interfaces. BUG=b:142090057 TEST=cts-tradefed run commandAndExit cts -m CtsBluetoothTestCases; manually wrote some apps, Android on DUT can communicate with my workstation via RFCOMM, both as client and server Change-Id: If366aaeca5297a011bbd9ff6584831afbf2b86ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837329 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721893}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2a6f1d0a4f3..d056ed33f541 Created with: gclient setdep -r src-internal@d056ed33f541 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jbudorick@google.com Change-Id: I5cd75ec89f635fc69044bfb47803208bc955d344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721892}
-
Yutaka Hirano authored
For better understanding of request failures Bug: 1018050, 1009889 Change-Id: I1581672378bff9668cf4066cbad872e16acdab9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950265 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721891}
-
Kuo Jen Wei authored
As the TOT of CCA source will ship with different chrome version branches, we no longer need to check chrome version for compatibility in different chrome version. Bug: b/141518780 Change-Id: I1562dd39f57dd79b7318b136ca6c3e86b4c6396e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952059 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#721890}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/42b3b9c4131a..7ecb9268dfeb git log 42b3b9c4131a..7ecb9268dfeb --date=short --first-parent --format='%ad %ae %s' 2019-12-04 rharrison@chromium.org Merge two calls to InitializeHLSL into one Created with: gclient setdep -r src/third_party/dawn@7ecb9268dfeb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8f182238eaf67582e1b3f2caed721838925e06d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952175Reviewed-by:
-
Chase Phillips authored
This CL adds support for persisting the manifest version and scope in the DB: * Adds the manifest_version and manifest_scope fields to the Caches table via a new database schema version (version 9) * Modifies AppCacheDatabase methods for reading and writing these fields * Updates AppCacheStorageImpl to carry these values into and from a group record * Adds an AppCacheBackfiller to fill in the manifest version and scope fields Bug: 999001 Change-Id: Idbda1618dd8bf4e81de3a7f8a79bafe3fed0959f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935034Reviewed-by:
-
Yutaka Hirano authored
...to investigate a DCHECK failure in ClusterFuzz. Bug: 1027957 Change-Id: I9dbee9026afc93b227a6579552d921077d5aebe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952061 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721887}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ab60e2ade15b..4629de24ad8b git log ab60e2ade15b..4629de24ad8b --date=short --first-parent --format='%ad %ae %s' 2019-12-05 primiano@google.com Delete CONTRIBUTING.md symlink 2019-12-05 primiano@google.com Merge "Improve docs" Created with: gclient setdep -r src/third_party/perfetto@4629de24ad8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iece177bc51c5e8a5830647256e343ba509d267f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952176Reviewed-by:
-
Hayato Ito authored
Follow-up of the review comment: https://crrev.com/c/1906452/6/third_party/blink/renderer/modules/service_worker/service_worker_timeout_timer.h#109 Prefer separate functions, EnqueueNormal(...) and EnqueuePending(...), to just one PushTask(Task) function, so that callers don't have to create a Task on caller sides. This CL also renames ServiceWorkerEventQueue::Task to ServiceWorkerEventQueue::Event, and does necessary changes accordingly. We no longer use a word of *task* in ServiceWorkerEventQueue because using both tasks and events in ServiceWorkerEventQueue is slightly confusing. It would be better to use Event consistently because its meaning is clear in this context. Bug: 965802 Change-Id: I18b133429e4636eef69cfc4e79c33b13be978ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948368 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Eric Willigers authored
InstallableManager now supports webp icons for desktop PWA installs, in addition to png and svg icons. TBR=mmenke@chromium.org Bug: 466958 Change-Id: I47fe3ae5c4d96fabba7dbc2d839d8e299df47355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942904 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#721884}
-
Nicholas Hollingum authored
Based on go/crostini-self-activate, we implement the wiring to allow crostini windows to activate themselves. This involves: - Hooking the surface request up to the shell_surface - Building the exo::Permission framework suggested by oshima@ - Building utilities to grant and revoke permissions - Hooking the shelf app controller up so it can grant and remove permissions. This is a remake of crrev.com/c/1850690 Bug: 899587 Change-Id: Ib9c5af8a876fe190fc72be86b873170186c62c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935771 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#721883}
-
Jiawei Shao authored
This patch is the first one to implement requesting a GPUDevice with a descriptor that indicates the required extensions on this device. With this patch a WGPUDeviceDescriptor is sent from Blink to the GPU process so that we can specify the required extensions when creating the Dawn Device object. In the next patch we will add the callback to receive the device id after the creation of the Dawn Device object in the GPU process. BUG=chromium:996713 Change-Id: If0ce899b17f36fe3f87af497d2e6af1189cc5a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938834 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721882}
-
Hitoshi Yoshida authored
This CL does not prevent to access ditionary members that have not-enabled [RuntimeEnabled] from C++ code. Data conversions between Blink and V8 check the features' status. Bug: 839389 Change-Id: If8986ce837ab92c536d7d27b262e15f220d4d4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947612Reviewed-by:
-
Christopher Lam authored
This CL pulls the opacity settings of cr-toggle ripples into the centralized color style sheet. This makes cr-toggle colors more consistent with cr-radio-button which uses a paper-ripple-opacity of 1 in order to allow the ripple opacity to be specified as part of the ripple color. Bug: 1018654 Change-Id: Idb93737176d4ab2a74b307ae784bd9bf306fc41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935774Reviewed-by:
-
Dominic Farolino authored
Renamed classes: - SharedURLLoaderFactoryInfo => PendingSharedURLLoaderFactory - URLLoaderFactoryBundleInfo => PendingURLLoaderFactoryBundle Renamed variables: - script_loader_factory_info => pending_script_loader_factory - shared_url_loader_info => pending_shared_url_loader_factory - network_factory_info => pending_network_factory - network_loader_factory_info => pending_network_loader_factory - url_loader_factory_info => pending_url_loader_factory - loader_factory_info => pending_loader_factory - fallback_factory_info => pending_fallback_factory - factory_info => pending_factory - subresource_loader_factory_bundle_info => pending_subresource_loader_factory_bundle Renamed files: - cross_thread_shared_url_loader_factory_info.{h,cc} => cross_thread_pending_shared_url_loader_factory.{h,cc} - network_download_url_loader_factory_info.{h,cc} => network_download_pending_url_loader_factory.{h,cc} Bug: 955171 Change-Id: I62f9babca56eb1257ccb6e1a14b28d39b159cb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945987 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#721879}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/738d06da1f6f..2e8ff9ca1328 git log 738d06da1f6f..2e8ff9ca1328 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 kayce@google.com DevTools: Update What's New for Chrome 80 Created with: gclient setdep -r src/third_party/devtools-frontend/src@2e8ff9ca1328 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icecbb7364a5316c0e7a7c651521e742267157929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952488Reviewed-by:
-
Jason Chase authored
Previously, origin trials could only be enabled in secure contexts. This restriction makes sense for new, experimental features. However, for trials to extend the use of deprecated features, this restriction is less useful. See crbug.com/1027546 for details. This CL removes the global restriction to secure contexts. Instead, it is now possible to allow specific trials to be used in insecure contexts. For now, only a single test trial is hard-coded to allow insecure contexts. A follow-up CL will implement configuration for deprecation trials to allow insecure contexts. NOTE: All tokens will now be parsed and validated in insecure contexts. Previously, the insecure context check happened first, and would exit early before token validation. This means extra work is done for regular trial tokens. That can't really be avoided, as the token has to be parsed to get the trial name. Bug: 1027546 Change-Id: Ia37422ade598561909006425464fad20775eb44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932241 Commit-Queue: Jason Chase <chasej@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#721877}
-
Hiroki Sato authored
Sometimes Android sets the focus (via a11y event of VIEW_FOCUSED) to the collection (list/grid). This invokes ChromeVox to read entire content of the collection. This CL adds following logic to handle the situation: 1. If a role of a node is kList or kGrid, CanBeAccessibilityFocused returns false. 2. When a11y event of VIEW_FOCUSED is dispatched, instead of directly assigning event source as a focus, try to find the first focusable node under the event source. element of the node gets ChromeVox focus. Bug: b:130185621 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open PlayStore/Hangouts and open drawer menu. The fist Change-Id: Ic85f05711fbd9cff2e2e074a01daa37c09d71bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942902 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721876}
-
Bartek Nowierski authored
This change adds use counters for counting V8 function calls in detached windows. They aren't emitted the usual way, because the use counter infrastructure doesn't work on detached windows. Instead they're plumbed through instance counters to be emitted via UKM. Bug: 1018156 Change-Id: I2c85604c9a96b9aec50896a74c089cf5eacfa61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925839 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
-
behdad authored
If the reporter in the stage of beginImpl is replaced with a new reporter, that means that Impl frame has caused no damage, and should not be reported as MissedFrame. Bug: chromium:1030304 Change-Id: I248a4dabf848e2ef6fc752c9388f60a6118092d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951651 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#721874}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b198c7757765..1077a87feff3 git log b198c7757765..1077a87feff3 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 tsepez@chromium.org Give UnownedPtr<> a move ctor and move assign operator. Created with: gclient setdep -r src/third_party/pdfium@1077a87feff3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icf3669cb929239b8b30993421a76edb613ae1010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952487Reviewed-by:
-
Takashi Toyoshima authored
Change-Id: I32178c4171544265f375d555a1203947ede5b1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950105Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#721872}
-
Adam Rice authored
Remove the "CompressionStreams" flag and enable CompressionStream and DecompressionStream by default. See the "Intent to Ship" thread at https://groups.google.com/a/chromium.org/d/msg/blink-dev/JmwpHPTu3XM/FQQ1fTwxBAAJ BUG=999091 Change-Id: Ic97407e4391f2d0481aaeba1009c18706f036be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950370Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#721871}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98d6edc69428..f2a6f1d0a4f3 Created with: gclient setdep -r src-internal@f2a6f1d0a4f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1027573,chromium:1030991 Tbr: jbudorick@google.com Change-Id: I43b9e99f70cf5155140d579625ca0be3f8ab8521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952486Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a727d8080716..dee5b5f3cf3f git log a727d8080716..dee5b5f3cf3f --date=short --first-parent --format='%ad %ae %s' 2019-12-05 chrisforbes@google.com Regres: roll deqp forward to current tip of 1.1.6 Created with: gclient setdep -r src/third_party/swiftshader@dee5b5f3cf3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I42c93c2c4f862d948096887c73973b7f16723868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952192Reviewed-by:
-
Miyoung Shin authored
This CL converts KeepAlive mojom interface clients in extension to use BrowserInterfaceBroker, and introduces RegisterBrowserInterfaceBindersForFrame method in ExtensionsBrowserClient class to register the extension interfaces to a binder map for BrowserInterfaceBroker. Bug: 936482 Change-Id: I6e793427ef32138454ae191c8623cabcee9a61f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946188 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721868}
-
