GitLab

Adds a new file to //printing to hold the enums to be included
during the IPC generation. This allows to use them in more than
one generator at the time.

BUG=311308

Review URL: https://codereview.chromium.org/857053002

Cr-Commit-Position: refs/heads/master@{#313540}

This is a clean-up, getting rid of many manual deletes and comments about who owns forms passed around in vectors.

BUG=451018

Review URL: https://codereview.chromium.org/825773003

Cr-Commit-Position: refs/heads/master@{#313539}

This reverts the revert of https://chromiumcodereview.appspot.com/715203004/ by
fixing the build error.

BUG=376014, 376006, 376091

Review URL: https://codereview.chromium.org/868313004

Cr-Commit-Position: refs/heads/master@{#313538}

The major re-factoring for this has been done, this is mostly just
moving the files, with a small addition to ExtensionsBrowserClient.

For extensions/browser/api/networking_private/DEPS:
TBR=jamescook@chromium.org
BUG=363776

Review URL: https://codereview.chromium.org/870163002

Cr-Commit-Position: refs/heads/master@{#313537}

This CL replaces the use of XChangeActivePointerGrab() (of
which there is no XI2 equivalent) with XGrabPointer (of
which there is an XI2 equivalent).

BUG=426380
TEST=None

Review URL: https://codereview.chromium.org/821803002

Cr-Commit-Position: refs/heads/master@{#313536}

Created StatusUploader class to manage the uploading of device status.

Refactored status uploading functionality in cloud policy infrastructure - the
timing and contents of the device upload are now controlled by StatusUploader,
while CloudPolicyClient exposes an API to create the upload job.

BUG=430908

Review URL: https://codereview.chromium.org/845313008

Cr-Commit-Position: refs/heads/master@{#313535}

Remove scrolling action for pages of Top10PageSet.
Measurements that are paired with Top10PageSet are
TabSwitching & PageCycler.  Both of these originally set
action_name_to_run='' which means that they don't expect
RunPageInteraction to run anything.

BUG=418375

Review URL: https://codereview.chromium.org/885493004

Cr-Commit-Position: refs/heads/master@{#313534}

To suppress upcoming changes in text blob bounds calculation.

BUG=451401
R=reed@google.com

Review URL: https://codereview.chromium.org/881323002

Cr-Commit-Position: refs/heads/master@{#313533}

BUG=448626

Review URL: https://codereview.chromium.org/867073002

Cr-Commit-Position: refs/heads/master@{#313532}

Background: ContentVideoView displays fullscreen video in a
VideoViewSurface. Currently, each Android content embedder
(WebView, ContentShell, and ChromeShell) is responsible for
releasing this surface when exiting fullscreen.

Problem: Releasing ContentVideoView from each embedder leads to
code duplication. Worse, this was never done for the WebView:
when it exits fullscreen video playback, AwContents's
exitFullScreen removes the VideoViewSurface which triggers
ContentVideoView's surfaceDestroyed(). surfaceDestroyed()
releases the MediaPlayerAndroid. Releasing the MediaPlayerAndroid
during playback gives a frozen video (see bug).

Solution: For all content embedders on Android, tear down
ContentVideoView, from content-layer (before the embedder
specific "exit fullscreen"-work).

BUG=449152
TEST=For unencrypted video, manually verify that video playback
continues inline when exiting fullscreen (tested in
com.android.browser, ContentShell and ChromeShell). Added
automatic test for VIDEO_HOLE-playback in WebView.

Review URL: https://codereview.chromium.org/845193005

Cr-Commit-Position: refs/heads/master@{#313531}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8b0a05a..c2893c5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/876343006

Cr-Commit-Position: refs/heads/master@{#313530}

This covers some Omnibox stuff, which is probably responsible for the jank in keyboard messages processing and drilling down some of issues.
There are some issues that require advanced investigations that are not included in this CL:
1. PeekMessage, which is probably processing hooks
2. DispatchMessage, maybe, having same issues
3. GetQueueStatus (!!!)
4. DefWndProc

BUG=440919

Review URL: https://codereview.chromium.org/879153002

Cr-Commit-Position: refs/heads/master@{#313529}

First part of the orderfile generating script refactor. The aim here is to make
sure that all scripts parse the object files the same way, using the same
tool. This commit extracts the parsing logic from patch_orderfile.py. It uses nm
from the Android NDK.

BUG=452879

Review URL: https://codereview.chromium.org/884113002

Cr-Commit-Position: refs/heads/master@{#313528}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0d1eda3..fb46751

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/877373002

Cr-Commit-Position: refs/heads/master@{#313527}

BUG=none
NOTRY=true
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/886533002

Cr-Commit-Position: refs/heads/master@{#313526}

This is a relanding of the original CL mentioned below, with
a fix for bug http://crbug.com/448599, where some strange cameras
were listed.

The problem was the filtering out of devices with
V4L2_CAP_VIDEO_OUTPUT_MPLANE capabilities, which is the case for
the strange camera enumerated in the mentioned bug, corresponding
to a V4L2 memory-to-memory  graphics processor.

FI: the enumerated device is called exynos-gsc.m2m and is indeed
defined as having such capability in line [1]

[1] http://lxr.free-electrons.com/source/drivers/media/platform/exynos-gsc/gsc-m2m.c#L286

Original Reland description follows -------------------------------------
Relanding: Linux Video Capture: Add support for multiplanar YUV420 format enumeration.

This is a relanding of the original CL _with the designated initializers
changed by typical struct fields accesors_.

Note: Gcc does not support designated initializers and it seems that
there are still a few such builds around, hence the change.

Original CL description follows -----------------------------------------

multiplanar --> V4L2_CAP_VIDEO_CAPTURE_MPLANE

M420 is an example of I420 triplanar format, used
for testing and to be landed since there must be
at least one multiplanar format for this CL to be
consistent.

Following reviewer's hints, the VCDFLinux code is
refactored internally. Given that, some struct
initializations change from

struct A a = {}    _or_   struct A a; memset(&a, 0, sizeof(a));
a.bla1 = foo1;
a.bla2 = foo2;

to

struct A a = {
  .bla1 = foo1,
  .bla2 = foo2,
};

Which is a very common idiom to initialize structs in
interactions with V4L2 IOCTL. I'm introducing it here and
I'm planning to use it further in VCDLinux CLs down the line.

This CL only adds support for enumerating multiplane
format, while the actual capture will be reviewed in
a later CL (WIP @ http://crrev.com/804473008).

BUG=441836, 448599

Review URL: https://codereview.chromium.org/877193005

Cr-Commit-Position: refs/heads/master@{#313525}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

Rather than binding a large number of callbacks for every device, pass a
single new object DeviceEventDispatcherEvdev to each device.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/869613003

Cr-Commit-Position: refs/heads/master@{#313524}

BUG=None
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/883003002

Cr-Commit-Position: refs/heads/master@{#313523}

Revert of Dump property values for the touch log source (patchset #11 id:200001 of https://codereview.chromium.org/864253002/)

Reason for revert:
Broke the arm-generic-freon builder on Chrome OS:

https://uberchromegw.corp.google.com/i/chromeos/builders/arm-generic_freon%20nightly%20chromium%20PFQ/builds/549/steps/BuildPackages/logs/stdio

See crbug.com/452911 - looks like a printf format specifier is wrong on 32 bit

Original issue's description:
> Dump property values for the touch log source
>
> The CL dumps gesture property values for touch devices that run
> with the CrOS gesture library. The format is designed to be
> backward-compatible with the X11 behaviour.
>
> Contributed by sheckylin@chromium.org
>
> BUG=450159
> TEST=samus ChromeOS build
>
> Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
> Cr-Commit-Position: refs/heads/master@{#313446}

TBR=achuith@chromium.org,spang@chromium.org,alexst@chromium.org,adlr@chromium.org,miletus@chromium.org,sheckylin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450159

Review URL: https://codereview.chromium.org/881353002

Cr-Commit-Position: refs/heads/master@{#313522}

Creating a DriWindow happens before the Compositor associated with
it. On DriWindow creation an IPC is sent to the GPU process to
initialize the window on the GPU side. The Compositor also sends
an IPC to create a surface for the window. Since the same channel
is used when IPC-ing both messages, the order of IPCs should be
maintained. Thus, assume that, on the GPU side, the window (delegate)
is already present when trying to create a surface.

Note the previous implementation was working around an issue during
initialization where the channel wasn't established. The issue was
that the channel in the platform was established late, so the IPCs
in Chrome would be serviced before the IPCs in the Ozone platform.

For clarity, these are the major steps taken at startup when creating
a window:

1) PostTaskOnUI(create GpuProcessHostShim)
2) Create WindowTreeHost
3) Create DriWindow
  a) If channel established PostTaskOnIO(create window on GPU)
4) WindowTreeHost::OnAcceleratedWidget()
5) Create Compositor
6) PostTaskOnUI(create output surface)
7) MessageLoop::Run()
8) Execute task in (1)
  a) Create GpuProcessHostShim
  b) OnChannelEstablished
    i) DriWindow::OnChannelEstablished -> PostTaskOnIO(create window
       on GPU)
9) Execute task in (6) -> PostTaskOnIO(create surface on GPU)

Note, even if the channel isn't up and running in step (8), messages
will be queued internally in GpuProcessHost. Thus the messages in
(8) and (9) will be queued in the correct order.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/883783002

Cr-Commit-Position: refs/heads/master@{#313521}

Previously we tried to refcount the tracking id to slot id mapping.
This broke in some circumstances where the number of press events was
not equal to the number of release events.

This patch switches to marking some touch events such that they don't
modify the mapping, simplifying logic, and fixing a nasty bug.

BUG=439051
TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping

Review URL: https://codereview.chromium.org/785753002

Cr-Commit-Position: refs/heads/master@{#313520}

WorkerTaskRunner manages and uses the WebWorkerRunLoops in a map in |loop_map_|,
and |run_loop_| in ThreadLocalState remain unused. So remove it.

BUG=none
R=avi@chromium.org

Review URL: https://codereview.chromium.org/880213002

Cr-Commit-Position: refs/heads/master@{#313519}

Revert of NaCl: Update revision in DEPS, 945d33419 -> 939a13aa3 (patchset #1 id:1 of https://codereview.chromium.org/881893003/)

Reason for revert:
Caused http://crbug.com/452846

Original issue's description:
> NaCl: Update revision in DEPS, 945d33419 -> 939a13aa3
>
> This pulls in the following Native Client changes:
>
> 939a13a (teravest@chromium.org) Provide an irt_core_lib GN target.
> dbf2af4 (sbc@chromium.org) Remove include of build_config.h from nacl_exception.h
> e205317 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> 7c8a96b (jfb@chromium.org) Update revision for PNaCl
> 3d00a54 (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> 1de8ba8 (mseaborn@chromium.org) Update codereview.settings following the switch from SVN to Git
> 7a6cf46 (jfb@chromium.org) Update revision for PNaCl
> bc28c0b (jvoung@chromium.org) Fix the native_client URL in the PNaCl REV file.
> f8aa9dc (bradnelson@google.com) Adding le32-nacl build of pnacl tools.
> cfda521 (teravest@chromium.org) Explicitly include build_config.h.
> 61b7ba9 (teravest@chromium.org) Output depfile from build_nexe.
> 2d65c23 (jfb@chromium.org) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
> 5f5cd88 (sbc@chromium.org) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
> 1baa204 (jvoung@chromium.org) Remove some more dead code and variables from pnacl/build.sh.
> f116471 (dschuff@chromium.org) Update revision for PNaCl
> 01f3d97 (teravest@chromium.org) Always define product_dir in build_nexe.
> 8a5a846 (mseaborn@chromium.org) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
> c14b58a (mseaborn@chromium.org) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
> c5d8394 (bradnelson@google.com) Change driver bash scripts to work in devenv.
> 490e554 (dschuff@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
> 2a7391a (sbc@chromium.org) Fix several issues with update_pnacl_tool_revisions.py
> fbc3b5c (dschuff@chromium.org) Support filenames with spaces in the PNaCl driver scripts.
> 4f726e8 (sbc@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
> 28a1341 (dschuff@chromium.org) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
> 9f9d773 (sbc@chromium.org) Update GCC revision in tools/REVISIONS
> 29ae54a (jfb@chromium.org) Update revision for PNaCl
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build
>
> Committed: https://crrev.com/4a8dee9ac9fd757f776f76a651d921f347305e82
> Cr-Commit-Position: refs/heads/master@{#313447}

TBR=mseaborn@chromium.org,jfb@chromium.org,bradnelson@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/886513002

Cr-Commit-Position: refs/heads/master@{#313518}

Setting that variable to an empty string is not a supported way of disabling the
sandbox. tools/valgrind/chrome_tests.py is supposed to pass "--no-sandbox" which
takes care of that.

BUG=245376
TBR=jln@chromium.org, timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/880023003

Cr-Commit-Position: refs/heads/master@{#313517}

BUG=449989, 399842
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884753002

Cr-Commit-Position: refs/heads/master@{#313516}

CustomButtonStateChangedDelegate was itnroduced in http://crrev.com/159994, and
its use was removed in http://crrev.com/185369 It hasn't been used since. So
remove the code.

BUG=none
R=tfarina@chromium.org

Review URL: https://codereview.chromium.org/872473004

Cr-Commit-Position: refs/heads/master@{#313515}

This patch needs to land after
https://codereview.chromium.org/872423002/ since the path
to the AppRTC code changes.

BUG=451985

Review URL: https://codereview.chromium.org/864973003

Cr-Commit-Position: refs/heads/master@{#313514}

list -> set, O(n^2) -> O(n).
Timing, without this patch (on a typical trace from a device):
real	1m49.774s
user	1m49.394s
sys	0m0.316s

With:
real	0m5.607s
user	0m5.482s
sys	0m0.120s

BUG=448054

Review URL: https://codereview.chromium.org/873003003

Cr-Commit-Position: refs/heads/master@{#313513}

This CL supports the step 3 described in the design doc:
https://docs.google.com/document/d/1qDGbMlwKOXxCRBlw9IirK8Qmna3JqvnO3Aogkfu9UJQ/edit?usp=sharing

Queued events are flushed out when the worker thread gets ready and
the provider host is notified of the thread id.

BUG=437677
TEST=https://codereview.chromium.org/861743002/

Review URL: https://codereview.chromium.org/855383006

Cr-Commit-Position: refs/heads/master@{#313512}

BUG=452892
NOTRY=True

Review URL: https://codereview.chromium.org/878553006

Cr-Commit-Position: refs/heads/master@{#313511}

BUG=385088

Review URL: https://codereview.chromium.org/882873002

Cr-Commit-Position: refs/heads/master@{#313510}

Fails on a subset of bots.

BUG=371290
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/879303003

Cr-Commit-Position: refs/heads/master@{#313509}

Writes results of running tests to trix instead of local file.

R=vabr@chromium.org
BUG=435249

Review URL: https://codereview.chromium.org/873333002

Cr-Commit-Position: refs/heads/master@{#313508}

"namespace Webkit" does not exist.

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/868353002

Cr-Commit-Position: refs/heads/master@{#313507}

BUG=None
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/871243002

Cr-Commit-Position: refs/heads/master@{#313506}

Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/398c70a..d5d1eac
d5d1eac  Stop calling memmove when unnecessary
482062f  Fix some fragile code that is likely to cause future memory corruption problems.

BUG=450137
R=mark@chromium.org

Review URL: https://codereview.chromium.org/879283002

Cr-Commit-Position: refs/heads/master@{#313505}

This paves the way to allowing logic living elsewhere in Chrome to
specify a value for this param (which will come in a later CL).

Also, cleans up a couple areas of the code, including cleaning up the
unit test for the URL generating function to abstract away the policy
pref code and using a weak pointer instead of base::Unretained() in
a callback.

BUG=452605

Review URL: https://codereview.chromium.org/883803002

Cr-Commit-Position: refs/heads/master@{#313504}

Add a DuplicateFinder and introduce it into the cloud import pipeline.  Note: Deduplication takes place in-place on the source files, which could be slow for MTP devices.  Profiling will be necessary to test this.  The duplicate check returns a simple yes/no answer.  Non-duplicate media is then imported as before.

Destination is now promoted to a top-level concept.  MediaImportHandler has a new function which enables clients to register new import destinations.  Each destination requires a DestinationFactory and an optional DuplicateFinder.  The import destination is selected at import time by its ID.

The Observer pattern on the ImportTask class was tweaked to support auxiliary data being passed with each observer call.  This is to allow richer updates (e.g. an entry-changed update that informs observers when a file was copied, and sends along the source and new destination).

A new importer.TestLogger had to be created and inserted into some tests in order to circumvent the running of the regular RunTimeLogger, which uses functionality that doesn't exist at test time (i.e. chrome.syncFileSystem.onFileStatusChanged)

MockEntry et al. were  augmented to do more "realistic" moves and copies, needed to test the new two-stage import.

Unit tests were cleaned up.

BUG=420680
TEST=browser_test: FileManagerJsTest.MediaImportHandlerTest

Review URL: https://codereview.chromium.org/881463003

Cr-Commit-Position: refs/heads/master@{#313503}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b27ee88..0d1eda3

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/885623003

Cr-Commit-Position: refs/heads/master@{#313502}

Cr-Commit-Position: refs/heads/master@{#313501}