GitLab

R=ericrk@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I03fa2d870efcdd7f63122dd8c3d68826faeb4c0f
Reviewed-on: https://chromium-review.googlesource.com/879921Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531770}

Some printers use rectangular DPI only. Not accounting for this results
in distorted printouts when printing from Chrome. Send rectangular DPI
to Pdfium so that these printers can print correctly.

Bug: 738950
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0b9e90905b7fefc38ca1d73d176d94e8e4a3b727
Reviewed-on: https://chromium-review.googlesource.com/664249Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531769}

Crash on trybot:
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/634970

Bug: 805049
Change-Id: If727e7e6bc7e48dff72a0f8d6ae5791e83502725
Reviewed-on: https://chromium-review.googlesource.com/884208
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531768}

Safe Browsing Download Protection for .RAR files:
This library will be used to unpack any .rar files
downloaded by the user to ensure that they are safe.
This code would execute inside a sandboxed process.

This code is being fuzzed via OSS-Fuzz here:
https://github.com/google/oss-fuzz/tree/master/projects/unrar

Here's the author's permission to use this library
for fuzzing and inclusion in Chrome: http://go/wknlc

Followed the process listed at:
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md

Bug: 750327
Change-Id: Ia6978fcf43f1ba570d6e8dad5daf2903cbdb3834
Reviewed-on: https://chromium-review.googlesource.com/855044
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531767}

urllib has issues with proxies similar to the ones reported in bug 134165
that are not present in urllib2.urlopen(). Namely, it does not perform HTTP
tunneling with proxy servers when fetching HTTPS URLs.

urllib2 does not have a urlretrieve() method though, so we need to do some
additional work ourselves to fetch the desired file (the code was borrowed
from depot_tools' gsutil.py which does soemthing similar).

See https://codereview.chromium.org/133933007 and
https://codereview.chromium.org/2554753005 for other instances of the same
problem.

Bug: 804479
Test: `gclient runhooks' behind my corporate proxy
Change-Id: I272faefd380c2e6000df766e255aa932f7230ddc
Reviewed-on: https://chromium-review.googlesource.com/883362Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531766}

This test has been reported as flaky by the flakiness dashboard so I am
disabling it until it can be investigated.

TBR=dtapuska@chromium.org

BUG=805666

Change-Id: I1e6045bdb5802eeb40a4e89de39a41cdf87feccd
Reviewed-on: https://chromium-review.googlesource.com/884944Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531765}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bcd1365c..50c5a55c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I74150e47d90c533678ea5f612e1769a0bfa2eb2c
Reviewed-on: https://chromium-review.googlesource.com/884012Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531764}

Final cleanup CL in componenets/. If file doesn't use base::WrapUnique,
base/memory/ptr_util.h includes are changed to <memory>.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8752f3bede1d7556538f63e7942501e78f78f411
Reviewed-on: https://chromium-review.googlesource.com/882242Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#531763}

This was mistakenly added during a bulk operation.  It has no diff
from the non-rls version.

BUG=711468
TBR=skobes@chromium.org,bokan@chromium.org
NOTRY=true

Change-Id: Ib3de59015f751869cd0f5efd74d9e4872bb08df3
Reviewed-on: https://chromium-review.googlesource.com/885061
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531762}

We already disable ChromeVox while running chrome --mash. Skipping the
panel creation inside AccessibilityManager allows more browser_tests to
run under --mash, including a bunch of tests that don't need or exercise
ChromeVox. This improves our test coverage of login and policy under
mash and doesn't make our runtime behavior any worse.

Bug: 628655
Test: browser_tests --mash
Change-Id: I634adbe5712be802f02148ff4c631e2110a963f4
Reviewed-on: https://chromium-review.googlesource.com/884837Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531761}

https://chromium.googlesource.com/catapult.git/+log/0e7663c0ec66..e99797e78121

$ git log 0e7663c0e..e99797e78 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 eakuefner [Dashboard] Ignore reference build directory when deploying

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I4dd68d375c2795c50af7bbb8af7eff8aaed38bfe
Reviewed-on: https://chromium-review.googlesource.com/884728
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531760}

This commit:
- breaks ChromeAppListItem's inheritance from AppListItem;
- uses ChromeAppListItem instead of AppListItem in chrome.

Bug: 733662
Change-Id: I9064f778f4a08542556845caa7198cab94631aca
Reviewed-on: https://chromium-review.googlesource.com/854701Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#531759}

In preparation for an upcoming M64 launch. Note, this has implications
for Android Webview, which did not go through a fieldtrial. For
Webview, this only implements part of the experiment: the dispatching
of requests to the worker pool. Handling responses on a worker thread
can be implemented in a followup.

Bug: 786173
Change-Id: I089b64ab5333b4ff3bf60b5ad4c5c1659c65b896
Reviewed-on: https://chromium-review.googlesource.com/884001Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531758}

A previous CL added some code to SandboxUnpacker which resulted in
some lines of a method from bing reached:
https://chromium-review.googlesource.com/c/chromium/src/+/871800

A subsequent change was checked in so instead of reverting the first
change, I am going to remove the unreachable code.

TBR=jcivelli@chromium.org

Change-Id: If37d3641734cf9ab71b04329dbab0e346aa93949
Reviewed-on: https://chromium-review.googlesource.com/884983Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531757}

This reverts commit 9919631e.

Reason for revert: breaking presubmits: https://ci.chromium.org/buildbot/tryserver.chromium.linux/chromium_presubmit/644296

Original change's description:
> Let anyone update the Android profile version
> 
> Including autorollers.
> 
> This also removes an entry for the now-deleted android.ensure file.
> 
> Bug: 803632
> Test: None
> Change-Id: I481b0e2822aee2ac0b6d919aa0ee4a84954f12ed
> Reviewed-on: https://chromium-review.googlesource.com/884233
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: George Burgess <gbiv@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531720}

TBR=nyquist@chromium.org,gbiv@chromium.org

Change-Id: I815260d16013dd8ebf56069e6335409f9e1cd7c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803632
Reviewed-on: https://chromium-review.googlesource.com/884981Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531756}

If ContentVerifyJob receives hashes (ContentVerifyJob::OnHashesReady)
after the content is read (ContentVerifyJob::DoneReading), then it
was possible for DispatchFailureCallback to be called more than once.
This causes a DCHECK failure in DispatchFailureCallback
(DCHECK(!failed_)).

Bail out early in OnHashesReady if call to ContentVerifyJob::BytesRead
leads to a ContentVerifyJob failure.

Note that this isn't harmful in Release builds as
DispatchFailureCallback tests ContentVerifyJob::failure_callback_
before calling the callback, which is reset once it is called.
Nevertheless, this is incorrect behavior and this CL fixes that.


Bug: 804630
Test: See bug description for repro steps.
Change-Id: Icf3a5c8b4c0d01cb20e02de14b11aca4aeff03e5
Reviewed-on: https://chromium-review.googlesource.com/879961Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531755}

The JSON ruleset parsing step when unpacking an extension now happens
in the browser process using the safe JSON parser.

Also several changes from base::Bind to base::BindOnce.

Bug: 804379
Change-Id: Ie133b429a0ae101c368568b4ae73b940b07d1744
Reviewed-on: https://chromium-review.googlesource.com/879352
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531754}

BUG=805488
R=thestig

Change-Id: I577bf4f5682cffced4f7424768545cc467ad6416
Reviewed-on: https://chromium-review.googlesource.com/884942Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531753}

Allow jobs on the majority of the waterfall bots and trybots to target
either one of these configurations, depending on which one has the
most capacity.

TBR=jmadill@chromium.org, geofflang@chromium.org
NOTRY=true

Bug: 711839
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I83dfb0cd1990c134decc1bc10b9db5b8e788f60d
Reviewed-on: https://chromium-review.googlesource.com/882344
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531752}

This patch implements CSSNumericValue.type(), which exposes the type
of a CSSNumericValue in the form of a dictionary.

We changed a lot of tests because we originally couldn't inspect the
type of a CSSNumericValue via JavaScript, so we mainly wrote unit tests.
Now we can directly test the types in web platform tests.

WIP API:
https://github.com/w3c/css-houdini-drafts/pull/546/files

Bug: 803684
Change-Id: Ie86a81c42cab34cd01286a3066be6bc9fda50fce
Reviewed-on: https://chromium-review.googlesource.com/880422Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531751}

I had changed ui::Gpu to not use ScopedAllowSyncCall previously. Remove
ui::Gpu from SyncCallRestrictions friends since it's not needed.

Bug: none
Change-Id: I8e0c80a87970882b83aec8de046e17fdb90e016f
Reviewed-on: https://chromium-review.googlesource.com/883766Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531750}

RendererStartupHelperTest.ExtensionInIncognitoRenderer was crashing on debug
builds occasionally because the incognito context it was using wasn't marked
live. This adds code to ExtensionsTest to initialize the incognito context. This
also necessiated modifying MockExtensionSystemFactory so that a separate
MockExtensionSystem was created for incognito (like in non-testing scenario).

BUG=795888

Change-Id: I2b3d7e4261862e036686648d064867cb154b2694
Reviewed-on: https://chromium-review.googlesource.com/882495Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531749}

Test is failing on Waterfall for Android Stable platform so disabling testDoesntHangOnFragmentNavigation.

Bug: chromedriver:2025
Change-Id: If9c90e5c0a8a4c2b478f5c78593751803299939e
Reviewed-on: https://chromium-review.googlesource.com/884438Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531748}

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2cfffc68b1f9d1fa0149ed70d18fbed9c3ccd1d3
Reviewed-on: https://chromium-review.googlesource.com/883348Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#531747}

Currently attempts to enter overview mode are blocked when there are no
windows in use. Allow entering overview mode in the new ui, and display
a message if there are no windows in use. We still exit overview if
there is one window left and we close it (like android).

For multi-display, all displays will enter overview when F5 is pressed.
Displays with windows will work normally and displays without windows
will show the indicator.

The indicator will not show in splitview overview at the moment because
splitview requires 2 or more windows on the MRU list to activate
splitview overview. Compatibility with splitview will be done in another
CL.

This is hidden behind switch.

Test: ash_unittests WindowSelectorTest.*
Bug: 782320
Change-Id: Ia82338cb285fb394a54d36df0ed5d26089aa2604
Reviewed-on: https://chromium-review.googlesource.com/869111Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531746}

https://chromium-review.googlesource.com/c/chromium/src/+/852978
routes all Tab- and BrowserWindowController requests through a
convenience method that queries the provided window and its
parent. This change broke code that assumed the window controller
search would not include the parent window or any other ancestors.

Bug: 805282
Change-Id: Ib2ac4817b2582836f34b7fc3755b0e324bb49c13
Reviewed-on: https://chromium-review.googlesource.com/884661Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531745}

If a frame has guest view custom elements defined, then any iframes also
need the definition or else a webview in an iframe will not be
initialized. If the iframe contains a script element, a script context
will be created which allows for the definition of the custom element in
the iframe. If there are no script elements, then no script context is
created, so the custom element definition is not available.

We make the ForceMainWorldInitialization setting available so that
extension code can force the creation of a script context for any
subframe of a frame which has access to guest view custom element
definitions.

Bug: 788914
Change-Id: Ibdd7c321b6e67dbe913f3deb2307406102d7b44a
Reviewed-on: https://chromium-review.googlesource.com/828045
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531744}

Fix some bugs in the original implementation for loading APP2s.
Update unittest helpers to APP2, supporting APP via wrapper.

Bug: 70282455
Test: cast_audio_backend_unittests
Change-Id: I3a3866c3feceea2d8cc4887f7e445ac62a50f811
Reviewed-on: https://chromium-review.googlesource.com/879581Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531743}

Change-Id: I4e087b8b1da557d6c85dd8c87b678b1fa62bba5f
Reviewed-on: https://chromium-review.googlesource.com/883624Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#531742}

The extension needs autotestPrivate permission to change the
display settings, like screen resolution and rotation.

BUG=803543
R=rdevlin.cronin@chromium.org

Change-Id: I835fd549730dfa8e7ceaebc96737c4b957f802d5
Reviewed-on: https://chromium-review.googlesource.com/877326Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@google.com>
Cr-Commit-Position: refs/heads/master@{#531741}

BUG=797999

Change-Id: I7545418680181af1c47fb5cd6578299be5f3deba
Reviewed-on: https://chromium-review.googlesource.com/872572
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531740}

Bug: 803571
Test: components_unittests --gtest_filter=*IDN*
Change-Id: I8cc473d0e74208076a2aa17c1869d14bbfaa20ed
Reviewed-on: https://chromium-review.googlesource.com/882006
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531739}

For images not pre-decoded using a task, they are always assumed to be
at-raster and don't count against the cache budget for locking beyond
the duration of the op that uses them. Allowing them to be budgeted
would help canvas use-cases which repeatedly use the same image by
avoiding the lock/unlock churn for every op, since canvas never
performs any pre-decoding.

R=ericrk@chromium.org

Bug: 804325
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia316121af3fcfbe1e87c5750bf92357888c678bb
Reviewed-on: https://chromium-review.googlesource.com/882553Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531738}

There is a race condition where a user makes an insertion handle
and then long-presses some text to make a selection. This can result
in the |INSERTION_HANDLE_CLEARED| coming after the call to
|SelectionPopupControllerImpl#showSelectionMenu()| which resets the
menu position set by |showSelectionMenu()|. This CL fixes that by first
making sure there is no range selection before trying to clear the
insertion handle.

Bug: 773515
Change-Id: I16b1e845b3960420f424dd04d418464a26bc5f1b
Reviewed-on: https://chromium-review.googlesource.com/884508Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531737}

A CastWebViewExtension gets created when hosting these pages, which
handles integration with the extension system

Handlers for the chrome-extension: scheme are installed during startup
allowing URLs to reference pages

Bug: b/70571389
Test: Local build, testing flinging chrome-extension URL
Merge-With: eureka-internal/126605
Change-Id: I5cefca57bb5b8d6bee21a17ef89b602bca5411c2
Reviewed-on: https://chromium-review.googlesource.com/868312
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531736}

Add details about number of resources and type of bitmap in UI resource
memory dump.

BUG=780547

Change-Id: Iaea7854db074a74a2a1340881ae3450756e74525
Reviewed-on: https://chromium-review.googlesource.com/879593
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531735}

StateFullscreen and TabletMode is no longer needed in chrome.

Bug: 733662
Change-Id: Ib25f89745e989042e321c597fe62ded72bc0cffa
Reviewed-on: https://chromium-review.googlesource.com/884376
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531734}

I see sporadic failures going back several days so I am going to
disable this test.

TBR=jbudorick@chromium.org

BUG=804892

Change-Id: I55f9af5935e7eb200c3cf963df2d7ce05dc3b991
Reviewed-on: https://chromium-review.googlesource.com/884392Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531733}

This patch moves binding validation from Persistence/ into Automapping/.

The validation was used in both default mappings and automapping.
Since default mapping is gone, we can safely move it to automapping.

This consolidates all the binding-creation logic in one place,
making it easier to report and manage binding errors.

R=dgozman

Change-Id: Ie969c0b42468cfc863723311bf920510cf587560
Reviewed-on: https://chromium-review.googlesource.com/882486Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531732}

My recent CL
https://chromium-review.googlesource.com/c/chromium/src/+/870744
caused a leak in ExternalProviderImplChromeOSTest as the test shuts down
with some extension installation pending.
Make sure we wait for all extensions to be installed before we exit the
test.

Bug: 805591
Change-Id: I89c1187d9e32ce0ab859689286c6283b0316d602
Reviewed-on: https://chromium-review.googlesource.com/884270Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531731}