GitLab

This CL moves the DoNotTrack header to be set in the NavigationRequest
for frame navigations, and in RenderFrameImpl for sub-resrouces load,
based on whether the containing frame has DNT set.

This is now all done in the content layer. So the browser tests were
also moved to content, leaving in Chrome 2 simple tests that validates
that the Chrome preference is set on the WebContents.

Bug: 808948
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifb57ab8bb9a2bd6231ec0cf93232306738b020dc
Reviewed-on: https://chromium-review.googlesource.com/953077Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541665}

This updates //gin to use base::OnceCallback or base::RepeatingCallback
instead of legacy base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //gin from 8 to 1
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I5c4bb758181c09e2d7b0e2fec5c51a4e1eec24bb
Reviewed-on: https://chromium-review.googlesource.com/952646Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541664}

Turning on root-layer-scrolls caused the number of layers on the
worldjournal story to almost double, causing regressions on many
metrics. The reason for these extra layers is because we were now
compositing iframes where we weren't before.

These iframes have empty sizes: 0x0 but, when RLS is enabled, the
LayoutView computes a non-empty layout overflow rect in
LayoutBlock::ComputeOverflow (due to default margins on an empty page).
The reason this differs based on RLS is because LayoutView has an
overflow clip only when RLS is turned on. Thus, without RLS,
ComputeOverflow doesn't add overflow from the old_client_after_edge and
the LayoutView never gets any overflow. No overflow means DocumentRect
in LocalFrameView::ScrollingReasons() does not exceed the empty
VisibleContentRect size and we return kNotScrollableNoOverflow. With
RLS this method returns kScrollable and we blindly mark it as needing
compositing.

The fix in this CL is to check that the iframe has some size in addition
to being scrollable before we composite it.

Bug: 811438
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iae82d124337088531ef94acac1e7383f08b852b5
Reviewed-on: https://chromium-review.googlesource.com/953332Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541663}

This reverts commit 1ee268df.

Original change's description:
> Revert "Reland "Exclude unused java classes from gvr_common_java aar""
> 
> This reverts commit 03667272.
> 
> Reason for revert: Causing crashes of unknown origin on K https://chromium-swarm.appspot.com/task?id=3c16a11a3d0f5b10&refresh=10&show_raw=1 (occurred with original CL as well)
> 
> Original change's description:
> > Reland "Exclude unused java classes from gvr_common_java aar"
> > 
> > This reverts commit f04d3bde.
> > 
> > Original change's description:
> > > Revert "Exclude unused java classes from gvr_common_java aar"
> > > 
> > > This reverts commit dbc48ca4.
> > > 
> > > Reason for revert: Getting NoClassDefFoundError on Nougat https://chromium-swarm.appspot.com/task?id=3c01bdd86290b710&refresh=10&show_raw=1
> > > 
> > > Original change's description:
> > > > Exclude unused java classes from gvr_common_java aar
> > > > 
> > > > As far as I can tell this filters the rest of the unused java classes.
> > > > 
> > > > Please revert this CL if you see ClassNotFound Exceptions.
> > > > 
> > > > diagnose_bloat summary:
> > > > MonochromePublic.apk_Breakdown (-4,097 bytes)
> > > >     +1,731 bytes Zip Overhead
> > > >         -1 bytes Package metadata size
> > > >     -5,827 bytes Java code size
> > > > MonochromePublic.apk_Specifics
> > > >    -15,137 bytes normalized apk size
> > > >    -11,040 bytes main dex size
> > > > 
> > > > Bug: 944791
> > > > Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4
> > > > Reviewed-on: https://chromium-review.googlesource.com/944791
> > > > Reviewed-by: Brandon Jones <bajones@chromium.org>
> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#540549}
> > > 
> > > TBR=mthiesse@chromium.org,bajones@chromium.org
> > > 
> > > Change-Id: I1b4b8c2d4acaaa9eafde507ceeb32293a164ac2b
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 944791
> > > Reviewed-on: https://chromium-review.googlesource.com/946653
> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#540672}
> > 
> > TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 944791
> > Change-Id: I17e5095e0298d20bdd3876473e673f4ed5f07e5c
> > Reviewed-on: https://chromium-review.googlesource.com/951826
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#541236}
> 
> TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org
> 
> Change-Id: I97a0f25703d4ebf80b357a8f63d4399c1fcfbb3f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 944791
> Reviewed-on: https://chromium-review.googlesource.com/951972
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541247}

TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org

Change-Id: Ia8c899645df903ee40c6cdfe1b0f1d614869df68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944791
Reviewed-on: https://chromium-review.googlesource.com/954183
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541662}

This CL moves the core CORB logic (figuring out if a given response
should be CORB-protected based on 1) response metadata like initiator,
MIME type, CORS headers and 2) sniffing the first bytes of the response)
from //content/common into //services/network.

As part of the move, this CL makes some extra, opportunistic changes:
- Renames the moved files (and the moved class) to match the name agreed
  upon in the explainer
  (s/CrossSiteDocumentClassifier/CrossOriginReadBlocking)
- Also moves the explainer doc to //services/network
- Tweaks the old CrossSiteDocumentMimeType enum so that
  - It is nested in CrossOriginReadBlocking::MimeType
  - The enum values have shorter names

In the long-term, the core CORB logic should only be needed within
services/network.  In the short-term, this logic has the following
consumers:

- content/browser/loader/cross_site_document_resource_handler.cc
  (integrates CORB into the old, pre-network-service,
  ResourceHandler-based world;  this can go away after the network
  service ships)

- content/renderer/loader/site_isolation_stats_gatherer.cc
  (gathers UMA that help decide what responses can be blocked
  by CORB with acceptably low risk of breaking existing websites;
  this can go away after CORB ships)

- WIP(https://crbug.com/792546): services/network/url_loader.cc
  (this will integrate CORB into the new, network-service world).

Bug: 792546
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib8fe412b1f807d23e41700b7f7090cd4b77c1783
Reviewed-on: https://chromium-review.googlesource.com/929446
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541661}

Bug: 819706
Change-Id: I5d9a244871ec06b33babb56eb8bd2453133c3c8b
Reviewed-on: https://chromium-review.googlesource.com/953243
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541660}

LayoutObject::HitTest calls NodeAtPoint multiple times for different
phases. We can avoid calling LayoutBox::NodeAtPoint if the point is
known to be clipped out. This patch extracts this optimization from
LayoutBox::NodeAtPoint and uses it in LayoutBox::HitTest to avoid
several calls to LayoutBox::NodeAtPoint at the expense of making
LayoutObject::HitTest virtual.

HitTest has been renamed HitTestAllPhases to clarify the behavior.

With this, blink_perf.events.hit-test-lots-of-layers improves by 7%.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib1a8a048d636fa63ad31347825660caf69fca1a0
Reviewed-on: https://chromium-review.googlesource.com/953378Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541659}

DelegatedFrameHostAndroid was updated to take a compositor lock when
it attaches to the compositor. This patch adds unit tests verifying
that this behavior works as expected.

Bug: 792120
Change-Id: I0eb783e15663df1f1f9efce01249946aec7678a1
Reviewed-on: https://chromium-review.googlesource.com/952662
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541658}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/57bbe676efe5..670a0ff9f5a1

$ git log 57bbe676e..670a0ff9f --date=short --no-merges --format='%ad %ae %s'
2018-02-21 baileyberro smbprovider: add GetDeleteList protos
2018-03-01 dgreid vm_concierge: Add a command to list VM disk images

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I9abfc78a3d258b061d52d4b66f9fe925ad38ae25
Reviewed-on: https://chromium-review.googlesource.com/953180Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541657}

Bug: 789645
Change-Id: I6c07392942a49c7ce20ece83cdd5284310377559
Reviewed-on: https://chromium-review.googlesource.com/953969
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541656}

Bug: 817127
Change-Id: I30343146b3fe8f84cf04bf7fe68fd330fa12f48c
Reviewed-on: https://chromium-review.googlesource.com/952194
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541655}

Since presenter belongs to UI, let's move it to Ash at this moment,
so that future CLs will be smaller.

Bug: 733662
Change-Id: I30809e34bb96406516fcdcefb27e29a440634bf9
Reviewed-on: https://chromium-review.googlesource.com/953092Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#541654}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: If1a9f377c0179c0b4b9b1f18d870ccccfc221296
Reviewed-on: https://chromium-review.googlesource.com/952328
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541653}

Also use base::StringPiece rather than a std::string reference. It
avoids some unnecessary copies in the substrings.

Bug: 814591
Change-Id: I7a1a0387b09038f7e084b2baf7b67716c729710a
Reviewed-on: https://chromium-review.googlesource.com/953744Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541652}

Migrated builders being removed from console:
* GPU Linux Builder
* Cast Linux
* Linux Builder
* Linux Builder (dbg)
* Linux Tests
* Linux Tests (dbg)(1)
* Mac10.13 Tests (dbg)

Bug: 790061, 790118, 790133, 790138, 790143, 790140, 818393
Change-Id: I77a097b28129870a19c5d21c6fbf99b9c67dde8e
Reviewed-on: https://chromium-review.googlesource.com/954284Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541651}

This CL suggests that the words "test" and "example" be treated as
QUERY regardless of whether whitespace is present (e.g. "test ").

Without this CL something like "test " (with a trailing space) will be
UNKNOWN, which may be treated as a URL or QUERY (it's not explicit --
this CL makes it explicit).

Bug: 818137
Change-Id: Iedaa4e3c06782a9d9131d3e91d3cee87c1dee7ab
Reviewed-on: https://chromium-review.googlesource.com/950235
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541650}

This CL tries to remove test expectations from
LayoutTests/FlagExpectations/site-per-process
if they are already covered by expectations in
LayoutTests/TestExpectations

Bug: 477150, 711468, 788390
Change-Id: I89b0838d7fc3dbdbb536d542baf2d3e5e31b6faf
Reviewed-on: https://chromium-review.googlesource.com/953222
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541649}

Implements the core of the tail processing algorithm for AudioNodes,
but doesn't actually enable it.  Enabling will fill be in a follow-up
CL.

Keep nodes alive when there are no input connections so that the node
has time to flush out any internal memory. When the output of the node
is going to be disabled (because there are no inputs), place the node
on a list, without disabling the output.

The list is processed every rendering quantum to see if the tail time
of node has passed.  If the tail time has not passed, nothing is done;
otherwise, the output is disabled, and the node is removed from the
list.  This allows the node to be collected, if possible.

Bug: 357843
Test: AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html
Change-Id: I895255f856c079dbeed872120ab5c0cb36b8bdb3
Reviewed-on: https://chromium-review.googlesource.com/949762Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541648}

In ash/accelerators/accelerator_controller, we need to query / set the
caps lock state. This is currently done through InputMethodManager.

Under mash, InputMethodManager will not be available from
accelerator_controller, so we'll need to query / set the caps lock state
via Mojo.

We use the existing ImeController::IsCapsLockEnabled() and
ImeController::SetCapsLockFromTray (renamed to SetCapsLockEnabled)
methods.

Bug: 819081
Change-Id: Id4b4337f6cb9268116b4c6bb034ad4004a3a7705
Reviewed-on: https://chromium-review.googlesource.com/950503Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541647}

crbug.com/818086 shows that using control flow guard, ThinLTO, and
RTTI together results in broken binaries. This change disables CFG
when ThinLTO and RTTI are enabled to allow builds to succeed while a
fix for the problem is developed.

R=dpranke,thakis

Bug: 818086
Change-Id: Ia926350dc4193f3a1c87a45b36a8d5dc1dd97c08
Reviewed-on: https://chromium-review.googlesource.com/952666Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541646}

RenderFrameMetadataProvider(RFMP) is not available until calling
RWHI::RequestCompositorFrameSink, that is no observer can be added before
that point, which may not be convenient for all observers. In this patch,
RenderFrameMetadataProvider will be created in RenderWidgetHostImpl
constructor and the ready to receive and send information after calling
RequestCompositorFrameSink.

For Example: RenderWidgetHostViewAura is created and start to observe changes
in RFM before calling RWHI::RequestCompositorFrameSink.

Bug: 716911

Change-Id: Icac9d5ff44a24b2a828bb7946202917f79c93147
Reviewed-on: https://chromium-review.googlesource.com/952200
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541645}

https://webrtc.googlesource.com/src.git/+log/12edf4ce344d..98bb968f7bed

$ git log 12edf4ce3..98bb968f7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2b15c8329fb0542de893ca6a6efb78f623d50581
Reviewed-on: https://chromium-review.googlesource.com/953650Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541644}

https://boringssl.googlesource.com/boringssl/+log/f8058d41147543d6ad9a5ae5d70e7d19198bbe33..a6bfc45b6286e358ba83f7daa769e1e9012cc7bb

BUG=none

Change-Id: I21c45bdad92ecbe9879be5a414c336d490146b9f
Reviewed-on: https://chromium-review.googlesource.com/953649Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541643}

In my recent change to this file:
https://chromium-review.googlesource.com/c/chromium/src/+/951745/5/remoting/host/current_process_stats_agent.cc#35,
I accidentally called the set_working_set_size setter with the PagefileUsage metric.

This CL fixes it to use the set_pagefile_size setter.

Bug: 819289
Change-Id: I3670f955bb484c1eb27d067c72d17a4d745a2446
TBR: sergeyu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/953764Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541642}

https://chromium.googlesource.com/angle/angle.git/+log/e4c5a23b1148..40dba69082bd

$ git log e4c5a23b1..40dba6908 --date=short --no-merges --format='%ad %ae %s'
2018-03-07 jmadill Update copyright notice in the style guide.
2018-03-05 brandon1.jones Add NPOT validation to copyTextureCHROMIUM

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I9c329b16a07a26ac9942446f53357722d18c26ef
Reviewed-on: https://chromium-review.googlesource.com/953653Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#541641}

+ Fix keyboard not showing when interacting between url bar and prompt
javascript dialog
+ Fix keyboard not being hidden when entering tab switcher
+ Add accessibility description when opening tab modal dialogs

Bug: 798893, 812443
Change-Id: I162b4dface23c5af142ffc2054aaf489dcc53647
Reviewed-on: https://chromium-review.googlesource.com/897989
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541640}

BUG=819730

Change-Id: I772f0a960ecc79cc43d0f924448b2c7823755fb6
Reviewed-on: https://chromium-review.googlesource.com/953659Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541639}

Removed 2 tests from the filter:
-RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler
  * Fixed by adding |ScopedIPCSupport| after |InitializeMojo()|.
-RenderThreadImplBrowserTest.ResourceDispatchIPCTasksGoThroughScheduler
  * This test no longer exists.

-- Note: the first test used to crash with log:
[91028:91028:0307/112240.705814:2593896751430:FATAL:scoped_refptr.h(219)] Check failed: ptr_.
#0 0x7f69ce3986ad base::debug::StackTrace::StackTrace()
#1 0x7f69ce396b9c base::debug::StackTrace::StackTrace()
#2 0x7f69ce41ebca logging::LogMessage::~LogMessage()
#3 0x7f69d0131b42 scoped_refptr<>::operator->()
#4 0x7f69d016d49b mojo::edk::NodeController::SendBrokerClientInvitation()
#5 0x7f69d013becf mojo::edk::Core::SendBrokerClientInvitation()
#6 0x7f69d01c06ea mojo::edk::OutgoingBrokerClientInvitation::Send()
#7 0x7f69c9cb0df8 content::internal::ChildProcessLauncherHelper::PostLaunchOnLauncherThread()
#8 0x7f69c9cb08cd content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread()


Bug: 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I18d85b91b5db78087c7e507df3d38da767327e1b
Reviewed-on: https://chromium-review.googlesource.com/953248Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541638}

Standard C++ doesn't allow implicit conversion between function pointers
and void*. MSVC does allow that, so clang-cl also allows it but emits a
-Wmicrosoft-cast warning. We want to enable this warning to make the
compiler behave more similar on different platforms, so add an explicit
cast to void*. (GetProcAddress() returns FARPROC, a function pointer type.)

Bug: 550065
Change-Id: Ia96aaa2ef58a434ef61e7d8d0c6df9b632d6b1c2
Reviewed-on: https://chromium-review.googlesource.com/953743Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541637}

BUG=813163
TBR=jochen@chromium.org

Change-Id: I1fb5565b978fb38b39fb2ddf9f726f9a3c5bd794
Reviewed-on: https://chromium-review.googlesource.com/953591Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541636}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: Ic2218d2ce520b53b6da32947d4def70a72f69c27
Reviewed-on: https://chromium-review.googlesource.com/952707Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541635}

BUG=810917

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5370ff9d3a8cc943e511f8cc5da272d07d47406d
Reviewed-on: https://chromium-review.googlesource.com/953325Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541634}

BUG=chromium:811811
BUG=chromium:811905
BUG=chromium:811815
BUG=chromium:811796
BUG=chromium:811831
BUG=chromium:811789
BUG=chromium:811809
BUG=chromium:811821
BUG=chromium:811869
BUG=chromium:811866
BUG=chromium:811781
BUG=chromium:811799
BUG=chromium:811814
BUG=chromium:811864
BUG=chromium:811835
BUG=chromium:811834

Change-Id: I6019014dd1032a0553f520b1127a2e5041a425e3
Reviewed-on: https://chromium-review.googlesource.com/953256Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541633}

This allows browser_action_test_util_views_mac.mm to be used in the
future for shared code between Mac Views and Aura Views.

BUG=818397

Change-Id: I3c0937216233ffbbe1933ad3cbb423da1010feb2
Reviewed-on: https://chromium-review.googlesource.com/953245Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541632}

iOS swarming arguments doesn't contain isolate args, which are separated
by '--' from the swarming trigger arguments.  Remove the '--' assert in
the script which blocks iOS tasks to use the custom swarming trigger logic.
Other platforms:
<args to swarming.py trigger> -- <args to bot running isolate>

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I49bb5a1c0abf78a5aa775d139f9dc60c60adeb09
Reviewed-on: https://chromium-review.googlesource.com/953251Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541631}

This is temporary, in order to be able to continue running the GLES1
and GLES2 conformance tests on these bots. The tests need to be
migrated to other machines.

Bug: 819751
Change-Id: Idfb9c70fd81cb7891bbc597e541a9bb64f686511
Reviewed-on: https://chromium-review.googlesource.com/953825Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541630}

This reverts commit d6d6b05f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Better support crosh
> 
> - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing.
> - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf.
> 
> Test: chromevox_tests --gtest_filter=Editing*.*. Manually on crosh, by typing into the text field.
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I8a9cf31e8834434ade0960d5e0b3045a664bc7ca
> Reviewed-on: https://chromium-review.googlesource.com/952193
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541378}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I3a3d196e9dfefdaed96fb098c6ecaf8cc5643d82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/954042Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541629}

It should be fine to remove the entire code path within |focusInput|
with |opt_ensureFocus| == true, since the original bug crbug.com/725622
was fixed by reverting another CL. However to be safe, this CL only
affects user pods without password input field.

The cause of the bug might be: when clicking the pod that requires
online sign-in (ie. the pod that does not display a password field),
the focus immediately goes to the GAIA sign-in page, so the pod never
gets the chance to remove the focus listener. When the GAIA page is
closed, the pod is still trying to steal focus. It's observed that the
issue doesn't exist if the GAIA page is not opened.

Bug: 778371
Change-Id: Ib4f39798fa60bc0cf72bbfd67c7fe8e997f7eedb
Reviewed-on: https://chromium-review.googlesource.com/950475Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541628}

BUG=chromium:819050
TEST=None

Change-Id: I821bd35f6a0ce3129f3753b282e120003f5b90a6
Reviewed-on: https://chromium-review.googlesource.com/953826Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541627}

|retransmittable_on_wire_timeout_| is set and there are active requests.

If retransmittable_on_wire_timeout_ is explicitly set, then the following behavior is enabled:
If an ACK is received such that there are no more unacked packets, a short delay timer will start if the connection has active requests (to expire retransmittable_on_wire_timeout_ from the now). When the timer expires, a PING frame will be sent. If a retransmittable packet is sent while the timer is active, the timer is cancelled.
This is intended to only be enabled for Cronet for connection migration.

Merges internal change 187955841

Change-Id: I0517e2768ccdd785f05de484dc2fe77eaaa32ea0
Reviewed-on: https://chromium-review.googlesource.com/953340Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541626}