GitLab

- Adds 3x resources to components/resources/autofill. These missing
  resources where causing the ResourceBundle to load the 1x ones for
  iPhone plus devices which resulted in blurry icons.
- Modifies the 1x and 2x resources for the generic credit card to match
  the 3x one.
- Removes the imagesets from iOS bundle and changes the autofill suggestion
  code to use the resources in the components.

Bug: 763499
Change-Id: I5463bc20c30b884ee4685a3fd2cd28d84625a709
Reviewed-on: https://chromium-review.googlesource.com/660802
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501283}

Using wpt-import in Chromium 8539662e.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1659

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: Ia24d4f19870cb2696c44c4487fde12feb5753c22
Reviewed-on: https://chromium-review.googlesource.com/663397
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501282}

When the user long press an item on the NTP, a context menu is shown.
The omnibox should be unfocused when this context menu is presented.
It is only necessary to specify it on iPad as showing the alert menu
on iPhone automatically unfocus it.

Bug: 763907
Change-Id: I9d1b8bcf94b64867464ba9ff1ab0a49c423f3a47
Reviewed-on: https://chromium-review.googlesource.com/663342Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501281}

Bug: 730365, 762110
Change-Id: I6a7c090385bc595171b82f73ba53635b1623b210
Reviewed-on: https://chromium-review.googlesource.com/634463Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501280}

This reverts commit b50598f3.

Reason for revert: This was just an mksnapshot flake, see:
https://crbug.com/700525 

Cycled already green before revert was in.

Original change's description:
> Revert "Update V8 to version 6.3.113."
> 
> This reverts commit cb14e960.
> 
> Reason for revert: Compile error on Windows: 
>  FAILED: gen/v8/snapshot.cc snapshot_blob.bin 
> C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin
> ==== C stack trace ===============================
> 	v8::internal::CEntryStub::MajorKey [0x01250990+0]
> 	v8::internal::CodeStub::FindCodeInCache [0x010F8D09+25]
> 	v8::internal::CodeStub::GetCode [0x010FAAA9+57]
> 	v8::internal::MacroAssembler::CallRuntime [0x01495804+148]
> 	v8::internal::TypeofDescriptor::TypeofDescriptor [0x014E4DB9+665]
> 	v8::internal::SetupIsolateDelegate::PopulateWithPlaceholders [0x014E53DE+46]
> 	v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x014E5603+19]
> 	v8::internal::SetupIsolateDelegate::SetupBuiltins [0x0149DDD1+17]
> 	v8::internal::Isolate::Init [0x012E1778+4792]
> 	v8::SnapshotCreator::SnapshotCreator [0x01058C26+150]
> 	v8::V8::CreateSnapshotDataBlob [0x0105B181+33]
> 	main [0x01051690+192]
> 	__scrt_common_main_seh [0x015C7EEB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
> 	BaseThreadInitThunk [0x7786338A+18]
> 	RtlInitializeExceptionChain [0x77E69A02+99]
> 	RtlInitializeExceptionChain [0x77E699D5+54]
> 
> Original change's description:
> > Update V8 to version 6.3.113.
> > 
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde
> > 
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> > 
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> > 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> > 
> > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org
> > 
> > Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92
> > Reviewed-on: https://chromium-review.googlesource.com/663297
> > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#501250}
> 
> TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org
> 
> Change-Id: I71255d8fcb1b281550f5f5d43e0671d36cb29c55
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/663599
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501266}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sebsg@chromium.org

Change-Id: I5a4c7f19bc2584cbc3bc72b8983de5ade2f5595e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/663697Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501279}

Added blocked popup content to interactive invocation of blocked popups dialog.

TBR=grt@chromium.org

Bug: 652031
Change-Id: I1c3f4bca0fe682897e0ed98e61957735b0d46320
Reviewed-on: https://chromium-review.googlesource.com/612496Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501278}

https://skia.googlesource.com/skia.git/+log/a8e5744afadd..ff72a0857f4d

$ git log a8e5744af..ff72a0857 --date=short --no-merges --format='%ad %ae %s'
2017-09-12 rmistry Add SK_DEBUG to SkUserConfig.h from upload_to_android.py if "--debug" flag is specified

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I077d2b0f6138211dd030b439dd237d5918ebbebd
Reviewed-on: https://chromium-review.googlesource.com/663558Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501277}

Creates OmniboxPopupMediator and AutocompleteResultsWrapper, moves
logic to these classes form OmniboxPopupMaterialVC.

Bug: 
Change-Id: I753b37f4831d43956a146ac025cf6d166bf46500
Reviewed-on: https://chromium-review.googlesource.com/608242Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501276}

Bug: 764338
Tbr: reveman@chromium.org
Change-Id: I37817bd0b9ac8f8a12b1d2336476741e0e7dd69c
Reviewed-on: https://chromium-review.googlesource.com/663657
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501275}

This change modifies the benchmark's story flow in two ways:
- about:blank will no longer be loaded before pushing the browser to
  the background. Thus making the background measurement more realistic
- the browser will now be restarted between each foreground/background
  pair of stories; this will make each pair stories independent of each
  other, helping to make results more reproducible and less noisy.

Perf sheriffs warning: This is expected to affect memory measurements
for this benchmark.

Bug: 750055
Change-Id: I65ea9431d52f63ee3e7dfccad68a62476018ea99
Reviewed-on: https://chromium-review.googlesource.com/612980
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#501274}

The file thread is no longer used. TaskScheduler should be used for
all file operations.

Bug: 
Change-Id: Iba07dc70a721c2c84cdb7ac00b7d4be057ae83aa
Reviewed-on: https://chromium-review.googlesource.com/660599Reviewed-by: Gene Gutnik <gene@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501273}

This reverts commit a67f5458.

Reason for revert:

Suspecting this CL as cause of consistent failing of AnimationSimTest.CustomPropertyBaseComputedStyle on Linux.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI

builds 1921 to 1929 failed

Log output for the test:

[ RUN      ] AnimationSimTest.CustomPropertyBaseComputedStyle
Received signal 11 SEGV_MAPERR 000000000008
#0 0x00000403655c base::debug::StackTrace::StackTrace()
#1 0x000004036284 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fe54f260330 <unknown>
#3 0x00000252b7a2 WTF::RefCountedBase::Ref()
#4 0x000004fafad7 blink::InterpolationEffect::AddInterpolationsFromKeyframes()
#5 0x000004fb6de5 blink::KeyframeEffectModelBase::EnsureInterpolationEffectPopulated()
#6 0x000004fb635a blink::KeyframeEffectModelBase::Sample()
#7 0x000004fbcf63 blink::KeyframeEffectReadOnly::ApplyEffects()
#8 0x000004fbd3f8 blink::KeyframeEffectReadOnly::UpdateChildrenAndEffects()
#9 0x000004f90916 blink::AnimationEffectReadOnly::UpdateInheritedTime()
#10 0x000004f89f9d blink::Animation::Update()
#11 0x000004f9cff6 blink::DocumentTimeline::ServiceAnimations()
#12 0x000005d9307e blink::PageAnimator::ServiceScriptedAnimations()
#13 0x000005597082 blink::WebViewImpl::BeginFrame()
#14 0x0000030f61a2 blink::SimCompositor::BeginFrame()
#15 0x0000028f2c7f blink::AnimationSimTest_CustomPropertyBaseComputedStyle_Test::TestBody()
#16 0x000003e17584 testing::Test::Run()
#17 0x000003e17e1e testing::TestInfo::Run()
#18 0x000003e18672 testing::TestCase::Run()
#19 0x000003e1db33 testing::internal::UnitTestImpl::RunAllTests()
#20 0x000003e1d7fd testing::UnitTest::Run()
#21 0x0000040fee72 base::TestSuite::Run()
#22 0x00000287d729 (anonymous namespace)::runHelper()
#23 0x00000287e041 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#24 0x000004101c40 base::(anonymous namespace)::LaunchUnitTestsInternal()
#25 0x000004101b09 base::LaunchUnitTests()
#26 0x00000287d69c main
#27 0x7fe549324f45 __libc_start_main
#28 0x00000244e029 <unknown>
  r8: 0000000000000000  r9: 00007ffcd7abb768 r10: 6e65622c656e696c r11: 00007fe54948e2d0
 r12: 00007ffcd7abae40 r13: 00003a23d3438890 r14: 00002f60aeb47718 r15: 00003a23d3438810
  di: 0000000000000010  si: 00007ffcd7abadf8  bp: 00007ffcd7abae30  bx: 0000000000000008
  dx: 0000000000000000  ax: f050afb778fbfd01  cx: f050afb778fbfd01  sp: 00007ffcd7abacd0
  ip: 000000000252b7a2 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000008
[end of stack trace]
Calling _exit(1). Core file will not be generated.

Original change's description:
> Make WTF::PassRefPtr an alias of WTF::RefPtr
> 
> This CL converts WTF::PassRefPtr to an alias of WTF::RefPtr, and removes
> the implementation.
> 
> Bug: 494719
> Change-Id: Ide96ef03dfa69668c1de87891a712bcd46470e13
> Reviewed-on: https://chromium-review.googlesource.com/657786
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501218}

TBR=haraken@chromium.org,tzik@chromium.org

Change-Id: Ida686824debc5967f95055be5d1629bcf5351b3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 494719
Reviewed-on: https://chromium-review.googlesource.com/663600Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501272}

BUG=758711

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Iacfd99301c8924e4126c9684a2da24ef8a415a5a
Reviewed-on: https://chromium-review.googlesource.com/660922Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501271}

No need for ParseShorthand or InQuirksMode.

Bug: None

Change-Id: I739a2f2e244cb21c11fe3a7b79ddcc95a655b4e8
Reviewed-on: https://chromium-review.googlesource.com/660757
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501270}

This reverts commit ab640662.

Reason for revert: ArticleSnippetsTest has failed consistently
on KitKat Tablet Tester since this landed. Specifically the
following tests are failing:
  ArticleSnippetsTest#testDownloadSuggestion__ChromeHomeEnabled
  ArticleSnippetsTest#testSigninPromo__ChromeHomeEnabled
  ArticleSnippetsTest#testSnippetAppearance__ChromeHomeEnabled

Additionally, many other test suites that follow
chrome_public_test_apk started failing when this landed; not
sure if that's related.

Original change's description:
> Render snippets in ArticleSnippetsTest in isolation
> 
> Remove the "snippets" render that shows all cards together, because
> multiple, non-article sections are not realistic in the modern design
> anymore.
> 
> Rebaseline other renders:
> * Use relative timestamp instead of Jan 17, 1970
> * Use only single-card backgrounds for pre-modern cards
> * Update modern card background color after https://crrev.com/497799
> * Update pre-modern text color after https://crrev.com/500684
> 
> Also move card contents in the modern layout except for the rounded
> corners into a RelativeLayout, to avoid a circular dependency between
> the height of the containing layout and the position of the bottom
> corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html).
> 
> Bug: 757735
> Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91
> Reviewed-on: https://chromium-review.googlesource.com/628562
> Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500975}

TBR=bauerb@chromium.org,skyostil@chromium.org,perezju@chromium.org,peconn@chromium.org

Change-Id: Iedb4e042448a8e4c8090d8af5fbdbb6e2f19a6b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757735
Reviewed-on: https://chromium-review.googlesource.com/663382Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: John Mellor <johnme@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501269}

Many websites use 16 pixel favicons. This CL avoids stretching the favicon
and results in a sharper image.

Bug: 763499
Change-Id: I07208084990c22a05261bfce5d6d4b6c16fdfb8d
Reviewed-on: https://chromium-review.googlesource.com/663577Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501268}

This change gets rid of a no-longer-helpful scale operation on the Skia
canvas, in preparation for some rework of how vector icons are drawn.
Some other cleanup is included.

BUG=
R=bshe@chromium.org

Change-Id: I4d709aa9a743e86639ef86627d39d4e2254b5695
Reviewed-on: https://chromium-review.googlesource.com/661019Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501267}

This reverts commit cb14e960.

Reason for revert: Compile error on Windows: 
 FAILED: gen/v8/snapshot.cc snapshot_blob.bin 
C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin
==== C stack trace ===============================
	v8::internal::CEntryStub::MajorKey [0x01250990+0]
	v8::internal::CodeStub::FindCodeInCache [0x010F8D09+25]
	v8::internal::CodeStub::GetCode [0x010FAAA9+57]
	v8::internal::MacroAssembler::CallRuntime [0x01495804+148]
	v8::internal::TypeofDescriptor::TypeofDescriptor [0x014E4DB9+665]
	v8::internal::SetupIsolateDelegate::PopulateWithPlaceholders [0x014E53DE+46]
	v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x014E5603+19]
	v8::internal::SetupIsolateDelegate::SetupBuiltins [0x0149DDD1+17]
	v8::internal::Isolate::Init [0x012E1778+4792]
	v8::SnapshotCreator::SnapshotCreator [0x01058C26+150]
	v8::V8::CreateSnapshotDataBlob [0x0105B181+33]
	main [0x01051690+192]
	__scrt_common_main_seh [0x015C7EEB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x7786338A+18]
	RtlInitializeExceptionChain [0x77E69A02+99]
	RtlInitializeExceptionChain [0x77E699D5+54]

Original change's description:
> Update V8 to version 6.3.113.
> 
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde
> 
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
> 
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> 
> TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org
> 
> Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92
> Reviewed-on: https://chromium-review.googlesource.com/663297
> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501250}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org

Change-Id: I71255d8fcb1b281550f5f5d43e0671d36cb29c55
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/663599Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501266}

This should fix the crashes that we've been seeing on the bots, so those
have been re-enabled as well.

BUG=761060

Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551
Reviewed-on: https://chromium-review.googlesource.com/663219Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501265}

The blocking pool is deprecated.

The only remaining user was the ServiceProcessPrefs' JsonPrefStore,
which now uses TaskScheduler instead.

Bug: 667892
Change-Id: Ic4739018ff111b7886bbc186e50f40408a8d9367
Reviewed-on: https://chromium-review.googlesource.com/660677Reviewed-by: Gene Gutnik <gene@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501264}

This reverts commit abd57f32.

Reason for revert: Will reland similar CL once the FILE thread is also deprecated (we prefer to deprecate all browser threads at once).

Original change's description:
> Remove BrowserThread::FILE_USER_BLOCKING/CACHE/DB.
> 
> These threads are deprecated and no longer used.
> 
> NOPRESUBMIT=true
> 
> Bug: 689520
> Change-Id: I55b05b70626f91c8a71d56642c851bb786dbfcaa
> Reviewed-on: https://chromium-review.googlesource.com/660597
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Francois Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501245}

TBR=jam@chromium.org,fdoray@chromium.org

Change-Id: I4a0605974792092af8780595fcccef5a6dda3d87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 689520
Reviewed-on: https://chromium-review.googlesource.com/663598Reviewed-by: Francois Doray <fdoray@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501263}

When python script run it could already download
google library (i.e. because of Google App Engine).
This library contains wrong google protobuf library.
Therefore we have to reload google library in the script.

Bug: 764314
Change-Id: I26d7ea31988d7b818d8c4c702e1614c7d35c85d5
Reviewed-on: https://chromium-review.googlesource.com/660222
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501262}

This reverts commit 26a9ac5e.

Reason for revert: Another test started failing, the revert seems to have fixed the buffer test flakyness after all


Original change's description:
> Revert "Revert "Run exo tests in parallel""
> 
> This reverts commit b7877027.
> 
> Reason for revert: Test is still flaky after the revert.
> 
> Original change's description:
> > Revert "Run exo tests in parallel"
> > 
> > This reverts commit 245abec2.
> > 
> > Reason for revert: One of the exo tests is failing flakily now. See http://crbug.com/746227
> > 
> > Original change's description:
> > > Run exo tests in parallel
> > > 
> > > BUG=None
> > > TEST=All tests still should pass
> > > 
> > > Change-Id: I8a2cc5598baaa9692a33a79767f93869e5a75b9b
> > > Reviewed-on: https://chromium-review.googlesource.com/657622
> > > Reviewed-by: David Reveman <reveman@chromium.org>
> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#500712}
> > 
> > TBR=reveman@chromium.org,oshima@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: None
> > Change-Id: I6a7d7bfef56b027a0ebf8b914f2967195029840b
> > Reviewed-on: https://chromium-review.googlesource.com/662842
> > Reviewed-by: Ben Wells <benwells@chromium.org>
> > Commit-Queue: Ben Wells <benwells@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#501215}
> 
> TBR=reveman@chromium.org,oshima@chromium.org,benwells@chromium.org
> 
> Change-Id: Ieaf5e740873c52dd9cf593cc139e493ffc7ef3c3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://chromium-review.googlesource.com/663518
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501255}

TBR=reveman@chromium.org,oshima@chromium.org,benwells@chromium.org,sebsg@chromium.org

Change-Id: Ic69a89d448f78ae90794f26a018a50edd65903bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663597Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501261}

The lack of PLATFORM_EXPORT on the forward declaration made the compiler
generate non-exported template instantiations which later caused linker
errors when those methods were missing.

R=drott@chromium.org, mstensho@opera.com

Bug: 764255
Change-Id: I2e03b924185dd7787d8129aa4c3c93716341cdbd
Reviewed-on: https://chromium-review.googlesource.com/663377Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#501260}

Remove

1) In remote_suggestions_scheduler_impl.cc prefs cleaning procedures
for M59.

2) In features.h an obsolete feature definition, which I missed when
removed the feature itself.

Bug: 
Change-Id: I7bdb6cf0c64db96f0a76eed49fe49cd11df00cdc
Reviewed-on: https://chromium-review.googlesource.com/663180Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501259}

This CL adds an instance of CredentialManager to PasswordController:
 * In PasswordController's Init function, it is checked whether the
   feature is enabled, and then (and only then), CredentialManager is
   instantiated and owned by PasswordController. CredentialManager then
   registers a script command callback for "credentials" command prefix.
 * CredentialManager instance owned by PasswordController is destroyed
   in PasswordController::detach(), which is invoked when WebState is
   being destroyed. CredentialManager then removes script command
   callback.

Bug: 435048
Change-Id: Ibad9c09f8c8f0868d940bd0912a861b6120dd1c8
Reviewed-on: https://chromium-review.googlesource.com/652227
Commit-Queue: Tomasz Garbus <tgarbus@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501258}

Change PrintObserver to a WebStateUserData and move creation to
BrowserViewController to remove the need to create it from Tab
and a dependency of model on UI.

Introduce a separate protocol WebStatePrinter implemented by
BrowserViewController to decouple PrintTabHelper from UI.

Bug: 760556
Change-Id: I42ea68e70e84b52ed7c5f705ee01e74e749e09df
Reviewed-on: https://chromium-review.googlesource.com/660122
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501257}

Jumbo builds (where the compiler has more information) noticed that
run_ is unused and emitted a warning.

R=drott@chromium.org

Change-Id: I4a975375cfc772e77dd5e9692c5cdc982a8453c1
Reviewed-on: https://chromium-review.googlesource.com/663179
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501256}

This reverts commit b7877027.

Reason for revert: Test is still flaky after the revert.

Original change's description:
> Revert "Run exo tests in parallel"
> 
> This reverts commit 245abec2.
> 
> Reason for revert: One of the exo tests is failing flakily now. See http://crbug.com/746227
> 
> Original change's description:
> > Run exo tests in parallel
> > 
> > BUG=None
> > TEST=All tests still should pass
> > 
> > Change-Id: I8a2cc5598baaa9692a33a79767f93869e5a75b9b
> > Reviewed-on: https://chromium-review.googlesource.com/657622
> > Reviewed-by: David Reveman <reveman@chromium.org>
> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#500712}
> 
> TBR=reveman@chromium.org,oshima@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: None
> Change-Id: I6a7d7bfef56b027a0ebf8b914f2967195029840b
> Reviewed-on: https://chromium-review.googlesource.com/662842
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Commit-Queue: Ben Wells <benwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501215}

TBR=reveman@chromium.org,oshima@chromium.org,benwells@chromium.org

Change-Id: Ieaf5e740873c52dd9cf593cc139e493ffc7ef3c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/663518Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501255}

Bug: 589943, 517992
Change-Id: Ib27813b4908fa24aed837e65774e0a1ab0c2e94d
Reviewed-on: https://chromium-review.googlesource.com/661857Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501254}

This reverts commit a32e4ca5.

Reason for revert: 

Makes the VideoResourceUpdaterTest.HighBitFrameNoF16 test fail on Linux MSan tests:

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/4137

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/4138


Uninitialized value was stored to memory, Uninitialized value was created by a heap allocation

Original change's description:
> [media]: Replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos.
> 
> LUMINANCE_F16 has following issues:
> 1. GL_LUMINANCE (as well as GL_ALPHA) is deprecated.
> 2. GpuMemoryBuffer cannot support LUMINANCE_F16.
> 3. LUMINANCE_F16 requires cpu int-to-float conversion.
> 
> This CL introduces a media switch "kUseR16Texture" feature to use R16_EXT.
> 
> If we get better power/performance numbers, we can enable R16_EXT
> by default.
> 
> R16_EXT is :
> + intuitive
> + filterable
> + no int to half float CPU conversion
> + GpuMemoryBuffer can support R16_EXT
> 
> Bug: 445071, 624436
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I8e5d63a8ea11ef1bbc67e26f4d74e5c1dfc76eb5
> Reviewed-on: https://chromium-review.googlesource.com/633663
> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501233}

TBR=rijubrata.bhaumik@intel.com,hubbe@chromium.org,dcastagna@chromium.org,piman@chromium.org

Change-Id: If9643b718cca8e44e495018ff5ab934f395b2d71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 445071, 624436
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/663517Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501253}

In a small number of places Blink uses SingleThreadTaskRunners to work
around blink/content boundary. The common practice was to
forward-declare SingleThreadTaskRunner class and pass it as a raw
pointer.

This practice worked given that there were few SingleThreadTaskRunners
and many places holding references to them. But this is changing now —
for the attribution purposes SingleThreadTaskRunners will become
lightweight wrappers containing metadata and are going to be created
on demand, so each consumer probably will hold to its own unique copy
of STTR. That means that raw pointers should not be used and STTR should
be passed around using refptrs.

Given that scoped_refptrs are banned in Blink and the ban should not be lifted,
public/platform/scheduler/ now contains an alias (SingleThreadTaskRunnerRefPtr)
which should be used when STTR is passed around in Blink.

R=haraken@chromium.org,kinuko@chromium.org,jochen@chromium.org
CC=hajimehoshi@chromium.org,japhet@chromium.org
BUG=762453

Change-Id: I34e0b243b774c62a643bc7fd48d0f3938715101e
Reviewed-on: https://chromium-review.googlesource.com/654904Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501252}

This is needed to migrate net::SerialWorker (used early on the IO
thread) from base::WorkerPool to base::TaskScheduler. Initializing
base::TaskScheduler early matches the behavior of the browser
process.

Bug: 
Change-Id: I0e409980228c379ccabadc3e32f0b9255d91a2e0
Reviewed-on: https://chromium-review.googlesource.com/660598Reviewed-by: Gene Gutnik <gene@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501251}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92
Reviewed-on: https://chromium-review.googlesource.com/663297Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501250}

CSS WG has agreed to modify the track sizing algorithm to include
a new step: https://drafts.csswg.org/css-grid/#algo-stretch
We used to do the stretch of the "auto" tracks at the end of
the track sizing algorithm, however this change integrates it
into the algorithm itself as the last step.
See: https://github.com/w3c/csswg-drafts/issues/1150

The patch moves the method
LayoutGrid::ApplyStretchAlignmentToTracksIfNeeded() to
GridTrackSizingAlgorithm::StretchAutoTracksIfNeeded().
And then modifies the grid track sizing algorithm to execute
the new step.

This also modifies the test to check the new expected behavior.

BUG=763386
TEST=external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html

Change-Id: Ieb31e822989ae4655d0e632885215e4a032dd445
Reviewed-on: https://chromium-review.googlesource.com/657578
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#501249}

WorkerPool is being deprecated in favor of TaskScheduler.

NSS calls may acquire the NSS lock or reenter Chrome code via
extension hooks (such as smart card UI). To ensure threads are not
starved or deadlocked, base::ScopedBlockingCall instances
increment the thread pool capacity when too much time is spent
in a scope where an NSS call is made.

Bug: 659191
Change-Id: Iaf088d84521753a3399083047a4e5733d44c472f
Reviewed-on: https://chromium-review.googlesource.com/648218Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501248}

With MDM errors, no error message exists. A default message to invite
the user to tap on the cell should be displayed.

This bug was introduced with:
https://chromereviews.googleplex.com/456347014/patch/40001/50002

BUG=717273

Change-Id: Iec972ca39dbc374a5a1003e5ef78e1927485e5f3
Reviewed-on: https://chromium-review.googlesource.com/652867Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501247}

On systems that use-zoom-for-dsf with HiDPI find bar would shift incorrectly
when obscuring search results due to WebKit returning selection box in
screen coordinates without converting them to display coords.

In order to write a proper test, we'd have to check if find bar still
overlapped the selection box, but there is no way to know where the box is
without somehow using FindReply message, which was sending wrong coordinates.

Bug: 755958
Change-Id: Ifb1c1615aa019c876c3c9488b659b060ca8f8116
Reviewed-on: https://chromium-review.googlesource.com/620652
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501246}

These threads are deprecated and no longer used.

NOPRESUBMIT=true

Bug: 689520
Change-Id: I55b05b70626f91c8a71d56642c851bb786dbfcaa
Reviewed-on: https://chromium-review.googlesource.com/660597Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501245}

Committed Interstitial error page HTML (1/2): attach net_error and error_page_content to ThrottleCheckResult.

Changes NavigationThrottle::ThrottleCheckResult into a struct that holds a net
error and an optional error page content (i.e. HTML + inline JS/CSS). The old
ThrottleCheckResult enum is changed to ThrottleAction and included in the
struct.

TBRing jochen@ for mechanical changes.

TBR=jochen@chromium.org

Bug: 751949
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I2b4836d1be24251704f25b05f0fd0c38bb74c341
Reviewed-on: https://chromium-review.googlesource.com/647656
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501244}