- 14 Jan, 2020 40 commits
-
-
Ali Juma authored
SafeBrowsingDataManager::CanCheckResourceType takes an argument of type content::ResourceType but only the Android-specific override in RemoteSafeBrowsingDatabaseManager uses the value of this argument. This CL forward-declares content::Resource type in database_manager.h. With this change, components/safe_browsing/core/db no longer depends on content/public/common. This is a step towards removing content/ dependencies from components/safe_browsing/core. Change-Id: I8b227a2c04594db8965a3ef1db4008a381a0965d Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995333 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#731600}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1041419 Change-Id: I37d869acfd366097bf4c1b2c2fc84d49f82c3bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998349 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#731599}
-
Kartik Hegde authored
Gather display and graphics related metrics in DeviceStatusCollector so that they can be exposed by the CDM API. BUG=chromium:1017893 TEST=Cherry pick https://crrev.com/c/1779132 and ensure that the values reported match that found on chrome://gpu or task manager (for GPU process memory). Change-Id: Idbc88fddf16b52f342cf92d0a0fe6060b4ee0e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933563 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731598}
-
edchin authored
Rapid blocking of javascript popups can cause a crash as simultaneous snapshots are triggered. Do not take snapshots when consecutive infobars are popup blocking infobars. Bug: 1018285 Change-Id: I46bca7fd8cc1f4d3f43ff28800b37c41a247f7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999084 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731597}
-
Becca Hughes authored
Add a basic Web UI at chrome://media-history for viewing Media History data. At the moment it just shows the row count per table but in the future we will add more. BUG=1024353 Change-Id: Ifb4190ba4266806ae6c07b07c77144c71907e87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988733Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#731596}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=manukh@chromium.org Bug: 1041419 Change-Id: I77d816e1495a2d404919fb2d0c83162df088af0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998306 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731595}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/683dd1d6a863..feb3b6cc6f2b git log 683dd1d6a863..feb3b6cc6f2b --date=short --first-parent --format='%ad %ae %s' 2020-01-14 syoussefi@chromium.org Vulkan: Remove row->col major shader transformation 2020-01-14 jie.a.chen@intel.com Add P010 stream test 2020-01-14 jmadill@chromium.org Invoke the standalone test harness runner. 2020-01-14 jmadill@chromium.org Fix test harness running disabled tests. 2020-01-14 jmadill@chromium.org Fix and improve UWP build. 2020-01-14 syoussefi@chromium.org Vulkan: Add test that exposes sampler refactor bug Created with: gclient setdep -r src/third_party/angle@feb3b6cc6f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033416 Tbr: jonahr@google.com Change-Id: I976aa5a885ba380971e3e9696d0934ac4989d81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731594}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gambard@chromium.org Bug: 1041419 Change-Id: I6f350b5690afb17554d191b71a2e1d51b87734d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998202 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731593}
-
John Budorick authored
Follow-up to crrev.com/c/1994168 Bug: 1039873 Change-Id: I2d86cc07fc2684886313fd454c733a40b9959df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998965Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#731592}
-
Stefan Zager authored
Change-Id: I7a1d9bc15bf04da61bba97f105303639ffd34f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999239 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731591}
-
rajendrant authored
This CL gets the estimated data savings due to SaveData and updates as LiteMode savings. The savings are retrieved from field trial as json. Relanding the revert in https://crrev.com/c/1990989 after renaming the failing test class LazyLoadDisabledBrowserTest, due to some naming clash. TBR=ryansturm@chromium.org Bug: 923551 Change-Id: Idf09151ea69218065b52b83e39eb84a0b7ae6cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996270 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#731590}
-
Alex Newcomer authored
Increase the padding to align the opaque bg with the button. Bug: 1041771 Change-Id: I04c5c89a4694a0d358b2bc5ccf143934ef30242a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001387 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#731589}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kerrnel@chromium.org Bug: 1041419 Change-Id: Ib705be1fc7ef6116a8c385209e07b1d9eb4e2107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998698 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731588}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1041419 Change-Id: I0a0e14d9aa856ed807837915fbd99d38d465b255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998574 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731587}
-
Maxim Novikov authored
This change makes Chromecast keep playing media in background on Android devices, to follow the typical behavior or media apps. apps keep playing in background (e.g., when a user is in the Home screen) Bug: internal b/147370574 Test: Built and installed on Android TV device, verified that Cast audio Change-Id: Ied7ecf4653814573b2511ffb7b419264504e768a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001086 Commit-Queue: Maxim Novikov <csbubbles@chromium.org> Reviewed-by:Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731586}
-
Kurt Horimoto authored
This delegate mocks out the presentation and dismissal callbacks for use in tests. Bug: none Change-Id: If6dd38ca262fb94b29c283d8a85e872d8fcf5457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994148 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#731585}
-
Ali Juma authored
This CL defines a CreateTestTaskEnvironment utility function that can be used to create a TaskEnvironment in tests. This function creates a BrowserTaskEnvironment for content/ clients, and creates a WebTaskEnvironment for ios/. This CL makes tests within components/safe_browsing/core use the new utility function rather than directly constructing a BrowserTaskEnvironmnent. This is a step towards removing dependencies on content/ from components/safe_browsing/core. Bug: 1028755 Change-Id: I7f819f733bcde7121e11f656d53ba4ac08370495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993873 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
Due to some broswer-state related flakiness, the "accept-ch-lifetime.tentative.https.html" test was split into several different files. Also, all mentions of "lifetime" in the tests was removed to keep up to date with the Client Hint spec. Change-Id: I1c06b82d8cbe8bd6e304f5c1fa1d058b100a825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994422Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#731583}
-
kylechar authored
The dep on //components/viz/service is no longer used. Bug: 936425 Change-Id: I22315f95f007a11968a4c800b846864340b0191b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000957Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#731582}
-
Scott Violet authored
This is purely the interface used by SessionTabHelper. Next patch will move SessionTabHelper to components/sessions/content. BUG=1033924 TEST=none Change-Id: I351ec7c46d9c0fc68fec9dfb3ca5c30727abefb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999335 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#731581}
-
Tibor Goldschwendt authored
Previously, we showed an outline. Changed per UX request. Bug: 1040256 Change-Id: I23115e42361634c42bcb7a43e81638af2b88c6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995946 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#731580}
-
Alison Maher authored
Update the wording of forced-colors-mode-printing-02.html to match the expectation of the test. Bug: 970285 Change-Id: I1eda50b8a566bf733cb62fbd1d2c0c02ab14486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994013Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#731579}
-
John Budorick authored
A few tests are surprisingly sensitive to screen size. Bug: 1030919 Change-Id: I2bdf22dc99e6b02041bc10998140bf0c8491e655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998706 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=battre@chromium.org Bug: 1041419 Change-Id: Ie1681cb457450139c09ee8651c002ef475744c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998318 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731577}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kkhorimoto@chromium.org Bug: 1041419 Change-Id: I71c61acd9230f6260aaf72c0755ff6d5394be95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998644 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731576}
-
James Cook authored
I recently added the settings-sync-account-control element to the Chrome OS build: https://chromium-review.googlesource.com/c/chromium/src/+/1978844 The "Clear browsing data" WebUI dialog contains that element. Its Polymer attached() method calls PeopleHandler::GetStoredAccountList which crashes in guest mode because no IdentityManager exists. This didn't crash before because the Polymer element wasn't included in the Chrome OS build, so the DOM element did nothing. Make the C++ handler work in guest mode by returning an empty list. This fixes the crash. Also use a dom-if to remove the settings-sync-account-control from the dialog footer. The Chromium Polymer style guide recommends dom-if when a hidden section contains custom elements. Bug: 1040476 Test: added automated tests Change-Id: Id2f703d0c37784c6525dc9127281530d87231421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999238 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#731575}
-
Etienne Pierre-doray authored
Change-Id: Iab598deb78a0716543b3ed2c1af2f57fd7f0ab81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998972 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#731574}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=juncai@chromium.org Bug: 1041419 Change-Id: I230d849e4c858fa49a7d960658ddc4cbe22a5535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998863 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#731573}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sanfin@chromium.org Bug: 1041419 Change-Id: I1471c223769e8d43ed4c8e93a968371df93d7697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998880 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Archana Simha authored
Added metrics to measure time spent on the extensions page when the checkup tool is present, number of times a user is shown the ntp promo and number of times a user clicks on the ntp promo. Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: I720a5116ea8db2547ce23665446028815a75c22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970839 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731571}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a76ee010877..6e62267bbb42 Created with: gclient setdep -r src-internal@6e62267bbb42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040973 Tbr: jbudorick@google.com Change-Id: I17b5c7a20f1a4c72003ed5e90d80b3d43e7569c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731570}
-
danakj authored
The flag is a browser-side bit matching state in the renderer's InputHandler. Every time we reset the InputHandler we should reset this bit. That also ensures it will be reset when we recreate the RenderWidget due to cross-origin navigations. R=avi@chromium.org Bug: 419087 Change-Id: I0274eecb283e6e7758a831b9eee2bd540f3f7aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995763Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#731569}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2839ae905e7..28f5c8101b20 git log f2839ae905e7..28f5c8101b20 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 khokhlov@google.com Merge "trace_processor: fix debug assertion on Windows" Created with: gclient setdep -r src/third_party/perfetto@28f5c8101b20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I979b96adcb5d58301c07beba5fc45858b08cb41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999959Reviewed-by:
-
Yue Zhang authored
When user switches between light and dark mode, incognito tabs are dumped and then restored. This exposes a missed range check in TabListMediator. When restoring an incognito tab group, the tab is added to TabModel but corresponding PropertyModel is not yet added to TabListModel, which leads to a temporary async. This async is also exposed in other cases where we try to sync TabListModel with TabModel through restoring, e.g. exiting multi-window mode. This CL fixes this issue. Bug: 1034385, 1034921 Change-Id: I3e712070cb3455a38d43cb7dae74adc68ebf65e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970735 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731567}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=stkhapugin@chromium.org Bug: 1041419 Change-Id: If551207bc0b945f223cddd2a6c4ed08fe54b39e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997710 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731566}
-
Ian Kilpatrick authored
This is primarily a refactor. This removes usages of FlexItem::box (if possible), and provides an alterate implementation of: - MarginBoxAscent - ComputeStretchedSize ...when not present. Bug: 845235 Change-Id: Ife8c54fb779de5d2afdcb904ab92acd6c724cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998618 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731565}
-
Jeroen Dhollander authored
When pressing on the keyboard icon to switch from voice input to text mode, the on-screen keyboard was not displayed. This forced the user to tap explicitly on the query input field to show the keyboard. Fixing this exposed a few other problems, including the issue reported in b/134766206, which now became a lot more visible because you could actually see the on-screen keyboard appear and immediately dismiss when the Assistant UI was launched in tablet mode. So this CL also fixes that bug. Note that this only addresses the onscreen keyboard in tablet mode. I opened b/146679393 to fix the related issue in normal mode but with on-screen keyboard enabled through the accessibility settings. Bug: b/146210314, b/134766206 Tests: added many unittests to |ash_unittests --gtest_filter="AssistantPageViewTabletMode.*"| Change-Id: I49da3ca647aa4bde0026f6fa84e582874836be63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972619 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#731564}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9f1e03b61de8..146e16f68fdc git log 9f1e03b61de8..146e16f68fdc --date=short --first-parent --format='%ad %ae %s' 2020-01-14 bclayton@google.com C++14: Use enum class builtin hashing 2020-01-14 bclayton@google.com C++14: Use std::enable_if_t instead of our own Created with: gclient setdep -r src/third_party/swiftshader@146e16f68fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8a993f667404cefb8dc2b462106e88da87e62eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001105Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jbroman@chromium.org Bug: 1041419 Change-Id: I7fc98a8361856747ff71216263d88157da304ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997827 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#731562}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1041419 Change-Id: I56d2b632cd9e44db7c184e96bf119392e421405b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998571 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#731561}
-
