- 09 Oct, 2019 40 commits
-
-
Friedrich Horschig authored
This CL adds the TextView showing the origin for PSL matched credentials if there is one. Colors, height and margins are adjusted accordingly. Screenshots (one for eliding, one for a simple label are in the bugs). Bug: 1011833,1012184 Change-Id: Ie6968579557aafc70e9ed0ce1d2cba90e4e3d193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848389 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704248}
-
Xianzhu Wang authored
1. Switch ScrollbarLayerInterface to ScrollbarLayerBase which is in the layer class inheritance hierarchy, to avoid the need of ScrollingCoordinator::ScrollbarLayerGroup. I think we added ScrollbarLayerInterface when we might have different parent layer class for the different scrollbar layer classes. This is no longer the case. And that won't be the case for crbug.com/1009291. 2. Remove SolidColorScrollbarLayerImpl's is_overlay parameter because it's only for overlay scrollbars in real world. Bug: 1009291 Change-Id: If12422481330b1d778899180c1147d52948fce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845489 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704247}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1092c0bc8b8..955f8fd0477e git log e1092c0bc8b8..955f8fd0477e --date=short --no-merges --format='%ad %ae %s' 2019-10-09 perkj@webrtc.org Add virtual method rtcp::RtcpPacket::SetSenderSsrc 2019-10-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b2d00427..8e1616e4 (703937:704145) 2019-10-09 aleloi@webrtc.org Removing outdated tests. 2019-10-09 peah@webrtc.org AEC3: Send the spectral power estimates for all channels to AecState 2019-10-09 nisse@webrtc.org Delete large up-front allocation in LibvpxVp8Encoder::InitEncode 2019-10-09 gustaf@webrtc.org Run fullband processing at output rate on ARM 2019-10-09 peah@webrtc.org AEC3: Remove redundant class 2019-10-09 eshr@google.com Add Duration field to EventRateCounter 2019-10-09 saza@webrtc.org Delete AecState::EchoPathGain() Created with: gclient setdep -r src/third_party/webrtc@955f8fd0477e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1012256,chromium:b/130016532 Change-Id: Iff2a55dcd7c672360792f55bb79fb7b6173ea188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704246}
-
Aaron Colwell authored
- Adds logic to CPSPI::CanCommitOriginAndURL() to verify opaque origin precursor info and documents exceptional cases that need followup work. - Extended URL origin check and "same origin" checks in CPSPI::CanCommitOriginAndURL() to apply to all URLs instead of just "standard" URLs. - Updated RFHI::CanCommitOriginAndURL() origin check for debug URLs to also apply to opaque origin precursors. - Update DocumentLoader::FillNavigationParamsForErrorPage() to force the error page commit origin to be an opaque origin with precursor info that matches the original document's origin. This ensures that the error page origin will be consistent with the process lock of the process that the error page is displayed in. Bug: 991607 Change-Id: Iec661e29880fcaf8e066bb2f1c3e5e6cf292decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837093 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704245}
-
Brandon Goddard authored
In the network tool, selecting the "Group by Frame" option will group several requests under their parent iframe. When navigating the network data grid using a keyboard, reaching a group frame node with the arrow keys will cause the node to expand and collapse instead of select. This prevents navigation to the children or the rest of the requests under the table. This CL addresses the issue by allowing selection of group frame nodes. Since selection === open the sidepane, the group frame node defaults to displaying the first child request in the sidepane when selected, Similar to how the waterfall column displays Also, Clicking on a group frame node name now selects instead of expanding. The node can be expanded by clicking in the "disclosure" triangle to the left of the name, which is the behavior in the rest of the datagrids in the devtools. Before: https://imgur.com/gMGgTkd After: https://imgur.com/AyMHnba Bug: 1007508 Change-Id: Ibb4063e90aefde96129108e7e44b76cac611741e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823721Reviewed-by:
John Emau <John.Emau@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704244}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd575424..0aff71c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b58fdbd5d6b60ff5417b8f73c8021f5e402fecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850071Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704243}
-
Lily Chen authored
Previously this method was virtual, and the default implementation just did nothing. However this would cause the unique_ptr argument to just be destroyed, and that was causing segfaults in tests which tried to hold onto the pointer to the delegate (and use it to set expected values, etc.), if the CookieStore they were using had the default implementation. This change moves the implementation of SetCookieAccessDelegate from CookieMonster to its base class CookieStore, and stores the delegate in the base class itself, to avoid this problem. Bug: 978172 Change-Id: Iee2c2ee7a5edae9e98266a7c4d38774f5babb3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849114Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704242}
-
Robert Ogden authored
Bug: 1011457 Change-Id: I2ce266270a5189bb3dc4d09de2d193b3d0737209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846042Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#704241}
-
John Budorick authored
https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/8 Bug: 922145 Change-Id: Ibad4b68179f4a8fc63ae3cbfed43411a22ad63a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849192 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704240}
-
Lorne Mitchell authored
Modified Action.title() to only call ls() on the options title property. Previously it would call ls() on the title property of Extension.title(), which already calls ls(). This resulted in a duplicate call. Bug: 941561 Change-Id: Idc8d5da56c2ddd219234beb148d3eddd8fb6edd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838700 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#704239}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d903e9334991..b91063d99c88 Created with: gclient setdep -r src-internal@b91063d99c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I987eca61b32b4b0cffe822d4b7a0a644806debbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849263Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704238}
-
Jakob Gruber authored
V8 will shortly drop this script. Import our own copy in mojo/public/tools/ and use that for mojo's build. The concatenate-files.py script is copied, modulo license header, from V8's tools/ directory. Bug: v8:7624 Change-Id: I07c6a64f061c3957002ca6f2c83c7f93b3ec009d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845764Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704237}
-
zhaoyangli authored
"automation_action.mm" implements autofill automation actions for iOS through earlgrey framework. This change makes it fully EG2 compatible. This is part of autofill automation framework EG2 migration. - Removed unused headers and changed headers for EG2. - Changed web view test util method calls to methods in chrome_matchers and chrome_actions which are EG2 compatible. Bug: 987646, 1003605 Change-Id: Idad2a2fbe68436cccd623c92044b46f0137f32d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847904Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704236}
-
Xianzhu Wang authored
Previously RWHV::SetSize(gfx::Size(800, 600)) at the beginning of a web test didn't work on Mac if the previous test synchronously set renderer window size (which didn't affect browser window size), because the call was a no-op due to the early return in the function when it found that the new size was the same as the old size. This left some inconsistent state caused by the previous synchronous resize persist until we changed the window size to another value. Now to ensure RWHV::SetSize() to reset the previous state, we call it twice, first with a different value, then with the desired value. This reduces number of unexpected flaky tests on mac-rel from about 300 to about 180. Bug: 1011191 Change-Id: I00fe653f5c44639d2a841bb5d4db779be0da6147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845479 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#704235}
-
David Narsiya authored
This is a reland of 78b72848 There was a problem with dependencies when "base/stl_util.h" was included in generated file, so I removed this include and solved problem of generating kAllEnginesLength variable differently. Original change's description: > Added behaviour to generate array of search engines > > All search engines are described in prepopulated_engines.json. In > template_url_prepopulate_data.cc there was an array kAllEngines > consisted of them, created by enumeration. There is a danger of > modifying prepopulated_engines.json without modifying this array. This > changes contain automatical generation of kAllEngines. > > Change-Id: Idc78552372f73b07fc7070fff66c000a30c6a6ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807312 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#701133} Change-Id: I9f68f2c6b408e50041680b6972ccb736aec840b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832272 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#704234}
-
Michael Lippautz authored
The previous implementation of using a trait had the problem of not being able to override already instantiated templates. Rely on a different type "v8::TracedReference" instead that does not come with a destructor. Bug: 995684 Change-Id: Ia6d5ae1964b47e7460f76aa5df154f1b4d0c63d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848011 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#704233}
-
Emil A Eklund authored
Bug: 1011885 Tbr: cbiesinger@chromium.org Change-Id: Id4186d64cef5eac6e4c0868dbe2a30fe3c129ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846568Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704232}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8e7d9d6c2326..ef4c25e71c32 git log 8e7d9d6c2326..ef4c25e71c32 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 geofflang@chromium.org GL: Skip buffer validation for transform feedback buffers. Created with: gclient setdep -r src/third_party/angle@ef4c25e71c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ia4d7515f2a0d21d53007a83f76c7585588f0ab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704231}
-
Toni Barzic authored
Enabling hotseat exposes some rounding errors when calculating expected app list layout half way during drag between peeking/half to full-screen/closed state. To fix this, calculate the expected search box padding using currently reported app list transition progress (which is already checked that is reasonably close to half state values), and gfx::Tween::IntValueBetween, which is also the method used to determine the padding value for the current progress app list progress. BUG=1011920 Change-Id: I9792442aba0953f880308606d2291a98e6aac9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848155 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704230}
-
Sean Kau authored
We do not need the PrintJobHistoryService on the lock screen to support extensions. If we create the PrintJobHistoryService on the lock screen, it creates a CupsPrintJobManager which results in multiple notifications for each print job. Bug: chromium:1011532 Change-Id: I16399186031a334d3b98ceda5ec9ab22f23a7e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842557Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704229}
-
Justin Cohen authored
Workaround for a WKWebView bug where WKNavigations can leak, leaving a permanent pending URL, thus breaking the omnibox. While it is possible for navigations to finish out-of-order, it's an edge case that should be handled gracefully, as last committed will appear in the omnibox instead of the pending URL. Added behind a feature flag as well as histogram to track usage. Bug: 1010765 Change-Id: I6cf2ed4c9ea6302a351f6775ef03d91f093c91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843232Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#704228}
-
Justin Cohen authored
This reverts commit f62ebc4f. Reason for revert: Failing on downstream iPhone bot: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/4972 Original change's description: > Reland "[iOS][MF] Fix search in all passwords" > > This is a reland of b400d6c7 > > The reason for the revert was that the test failing on the slimnav bot. This > is a legacy bot and runs with the feature off. > > After investigating, it turns out it is a bug in Earl Grey where it is waiting > for a view controller to dismiss. > > Since slim-navigation is not related to the failure, this CL disables the > test when slim-navigation is off, and relands the fix. > > Original change's description: > > [iOS][MF] Fix search in all passwords > > > > If the password view controller was presenting something, it will stay > > around. This is fixed and a test is added. > > > > Bug: 1008421 > > Change-Id: I8248cbbf28be94bc4b84c65ccda42129a192db0b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826895 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702358} > > Bug: 1008421 > Change-Id: If336b1cc5b4d6427125921d01b636b0726b860f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844979 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704143} TBR=olivierrobin@chromium.org,javierrobles@chromium.org Change-Id: I94f7b760783984e19eece46c975b3ab3f1219add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849119Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704227}
-
Rohit Rao authored
BUG=934252 Change-Id: Ib7f68a0c9997ad4638cdb884e5099fcca8402a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849995Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704226}
-
Christian Dullweber authored
Show a confirmation step when cookie blocking was enabled for a specific site. Bug: 967668 Change-Id: I09f2ebf71c196d6a7085a18405da9d59f581a183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849853Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704225}
-
John Delaney authored
Adds a use counter for the heavy ad intervention and adds the use counter to the UKM whitelist. This will be used to look at % page loads affected and also whether certain origins are more affected than others. Bug: 985890 Change-Id: I09f0f6b8fd2703b4801b9958d55fcac165658c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846174 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704224}
-
siyua authored
chip is visible. Uploaded screenshot in bug comment 30 Bug: 932818 Change-Id: I7e69019e18e7a217c3757a787bbb7be3810922ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848579Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#704223}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a529449a. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iffc1b84cfe83514bb4e835ae471d88976094ca9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849951Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704222}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/54548626a977..e27a503a0a21 git log 54548626a977..e27a503a0a21 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 kjlubick@google.com [canvaskit] Clean up embedded fonts Created with: gclient setdep -r src/third_party/skia@e27a503a0a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ic5a740097d501e805895c483772d5a3a93dd95af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704221}
-
Robbie Gibson authored
According to the spec, the srcset attribute does not need each URL to have an associated descriptor. Just the URL is valid. srcset is also a valid attribute on a <source> tag, so the data should be inlined there as well. Bug: 1006216 Change-Id: I0f782035dfdbf514423cdd430536ed962340c9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829711 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704220}
-
Connie Wan authored
This addresses #7 and #8 in the attached bug. Here we selectively repaint only the necessary underline because otherwise there can be weird interactions where the dragged tabs appear underneath unassociated group underlines. Bug: 1008438 Change-Id: I63038a958249800a2d3df97d8609b8dfe5963410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846045Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704219}
-
Sammie Quon authored
Dimming is already applied in OnPaint so the filter is not needed, requested by UX. Test: manual Bug: 1012042 Change-Id: I2467e4a927c6786f1289e7417bea8bb05716b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846473 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#704218}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLShadowElement> as new downcast helper 2. Use IsA<HTMLShadowElement>(element) in place of IsHTMLShadowElement(element) Bug: 891908 Change-Id: I9b202b810eae9fe10d9b3f0dd84ef9043ab28088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847699Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704217}
-
John Z Wu authored
This fixes an issue where supportedLanguages becomes stale, which causes translate to be offered with a nil CWVTranslationLanguage. Bug: 1012518 Change-Id: Iaed82b4c539443e38ba5198b0c87ae6bab28c7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848652 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#704216}
-
Peter Boström authored
Adds standard highlight-path generators to MoreButton in unified_volume_view.cc as well as RoundedLabelButton and UserAvatarButton. Bug: chromium:1007546 Change-Id: I9f409bf7bd1058c5e4b1d6f41993bb3c42835dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848653 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704215}
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I2aa0c1df1f4d2ae12c328782d2aa4de63c57161a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845716 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704214}
-
Abhijeet Kandalkar authored
This CL uses DynamicTo<HTMLPortalElement> as new downcast helper Bug: 891908 Change-Id: I42e021335c6167888414d6e190a0974c3f0e13db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847454Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704213}
-
Alexander Nohe authored
Noticed that the stylus tool was not launching android apps due to a permission error with the content provider. Updated the ARC++ container to a more preferred method of launching the Android note taking app. Bug: b/138960936 Change-Id: If9d5e5fbdce610df24bfe94a5c40c160b7f7a347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783221 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704212}
-
Arthur Hemery authored
Some sharding was not properly configured, and shards timed out. Increasing overall sharding to match standard CI bots. Bug: 976218 Change-Id: I8e6c196b5b58e4e5a9a4ed21e6c37d34671158ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849378 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#704211}
-
David Roger authored
Bug: 995720 Change-Id: I40cf6420119e34aa7f2b45460d032a24aee52d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849895Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704210}
-
Raul Tambre authored
This is a reland of 465e6173 gLinux has the html module from python-future, but it's missing unescape(). Switched the import order to import the html module only if importing HTMLParser fails. Original change's description: > tools/metrics/histograms/extract_histograms.py: Python 3 support > > Example error: > Traceback (most recent call last): > File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module> > import extract_histograms > File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module> > import HTMLParser > ModuleNotFoundError: No module named 'HTMLParser' > > Also fixed deprecation warnings: > C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead. > return HTMLParser().unescape(line) > ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead. > self.assertEquals('This is a summary with & and " and \'', > > The changes are backwards compatible. > > Bug: 941669 > Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657 > Auto-Submit: Raul Tambre <raul@tambre.ee> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701265} Bug: 941669 Change-Id: Ib42aa6819103fde6a388765867890589ea4ced82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834001 Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#704209}
-